ddtrace 1.2.0 → 1.4.0

data/lib/datadog/profiling/ext/forking.rb

@@ -5,6 +5,11 @@ module Datadog
     module Ext
       # Monkey patches `Kernel#fork`, adding a `Kernel#at_fork` callback mechanism which is used to restore
       # profiling abilities after the VM forks.
+      #
+      # Known limitations: Does not handle `BasicObject`s that include `Kernel` directly; e.g.
+      # `Class.new(BasicObject) { include(::Kernel); def call; fork { }; end }.new.call`.
+      #
+      # This will be fixed once we moved to hooking into `Process._fork`
       module Forking
         def self.supported?
           Process.respond_to?(:fork)
@@ -13,33 +18,22 @@ module Datadog
         def self.apply!
           return false unless supported?
 
-          modules = [::Process, ::Kernel]
-          # TODO: Ruby < 2.3 doesn't support Binding#receiver.
-          #       Remove "else #eval" clause when Ruby < 2.3 support is dropped.
-          # NOTE: Modifying the "main" object as we do here is (as far as I know) irreversible. During tests, this change
-          #       will stick around even if we otherwise stub `Process` and `Kernel`.
-          modules << (TOPLEVEL_BINDING.respond_to?(:receiver) ? TOPLEVEL_BINDING.receiver : TOPLEVEL_BINDING.eval('self'))
-
-          # Patch top-level binding, Kernel, Process.
-          # NOTE: We could instead do Kernel.module_eval { def fork; ... end }
-          #       however, this method rewrite is more invasive and irreversible.
-          #       It could also have collisions with other libraries that patch.
-          #       Opt to modify the inheritance of each relevant target instead.
-          modules.each do |mod|
-            clazz = if mod.class <= Module
-                      mod.singleton_class
-                    else
-                      mod.class
-                    end
-
-            clazz.prepend(Kernel)
-          end
+          [
+            ::Process.singleton_class, # Process.fork
+            ::Kernel.singleton_class,  # Kernel.fork
+            ::Object,                  # fork without explicit receiver (it's defined as a method in ::Kernel)
+            # Note: Modifying Object as we do here is irreversible. During tests, this
+            # change will stick around even if we otherwise stub `Process` and `Kernel`
+          ].each { |target| target.prepend(Kernel) }
+
+          ::Process.singleton_class.prepend(ProcessDaemonPatch)
         end
 
         # Extensions for kernel
+        #
+        # TODO: Consider hooking into `Process._fork` on Ruby 3.1+ instead, see
+        #       https://github.com/ruby/ruby/pull/5017 and https://bugs.ruby-lang.org/issues/17795
         module Kernel
-          FORK_STAGES = [:prepare, :parent, :child].freeze
-
           def fork
             # If a block is provided, it must be wrapped to trigger callbacks.
             child_block = if block_given?
@@ -52,9 +46,6 @@ module Datadog
                             end
                           end
 
-            # Trigger :prepare callback
-            ddtrace_at_fork_blocks[:prepare].each(&:call) if ddtrace_at_fork_blocks.key?(:prepare)
-
             # Start fork
             # If a block is provided, use the wrapped version.
             result = child_block.nil? ? super : super(&child_block)
@@ -62,22 +53,14 @@ module Datadog
             # Trigger correct callbacks depending on whether we're in the parent or child.
             # If we're in the fork, result = nil: trigger child callbacks.
             # If we're in the parent, result = fork PID: trigger parent callbacks.
-            # rubocop:disable Style/IfInsideElse
-            if result.nil?
-              # Trigger :child callback
-              ddtrace_at_fork_blocks[:child].each(&:call) if ddtrace_at_fork_blocks.key?(:child)
-            else
-              # Trigger :parent callback
-              ddtrace_at_fork_blocks[:parent].each(&:call) if ddtrace_at_fork_blocks.key?(:parent)
-            end
-            # rubocop:enable Style/IfInsideElse
+            ddtrace_at_fork_blocks[:child].each(&:call) if result.nil? && ddtrace_at_fork_blocks.key?(:child)
 
             # Return PID from #fork
             result
           end
 
-          def at_fork(stage = :prepare, &block)
-            raise ArgumentError, 'Bad \'stage\' for ::at_fork' unless FORK_STAGES.include?(stage)
+          def at_fork(stage, &block)
+            raise ArgumentError, 'Bad \'stage\' for ::at_fork' unless stage == :child
 
             ddtrace_at_fork_blocks[stage] = [] unless ddtrace_at_fork_blocks.key?(stage)
             ddtrace_at_fork_blocks[stage] << block
@@ -93,6 +76,22 @@ module Datadog
             # rubocop:enable Style/ClassVars
           end
         end
+
+        # A call to Process.daemon ( https://rubyapi.org/3.1/o/process#method-c-daemon ) forks the current process and
+        # keeps executing code in the child process, killing off the parent, thus effectively replacing it.
+        #
+        # This monkey patch makes the `Kernel#at_fork` mechanism defined above also work in this situation.
+        module ProcessDaemonPatch
+          def daemon(*args)
+            ddtrace_at_fork_blocks = Datadog::Profiling::Ext::Forking::Kernel.ddtrace_at_fork_blocks
+
+            result = super
+
+            ddtrace_at_fork_blocks[:child].each(&:call) if ddtrace_at_fork_blocks.key?(:child)
+
+            result
+          end
+        end
       end
     end
   end

data/lib/datadog/profiling/ext.rb

@@ -9,6 +9,7 @@ module Datadog
       ENV_AGENTLESS = 'DD_PROFILING_AGENTLESS'.freeze
       ENV_ENDPOINT_COLLECTION_ENABLED = 'DD_PROFILING_ENDPOINT_COLLECTION_ENABLED'.freeze
 
+      # TODO: Consider removing this once the Ruby-based pprof encoding is removed and replaced by libdatadog
       module Pprof
         LABEL_KEY_LOCAL_ROOT_SPAN_ID = 'local root span id'.freeze
         LABEL_KEY_SPAN_ID = 'span id'.freeze

data/lib/datadog/profiling/flush.rb

@@ -1,8 +1,5 @@
 # typed: false
 
-require 'datadog/core/environment/identity'
-require 'datadog/core/environment/socket'
-
 module Datadog
   module Profiling
     # Represents a collection of events of a specific type being flushed.

data/lib/datadog/profiling/http_transport.rb

@@ -28,7 +28,7 @@ module Datadog
           upload_timeout_milliseconds: @upload_timeout_milliseconds,
 
           # why "timespec"?
-          # libddprof represents time using POSIX's struct timespec, see
+          # libdatadog represents time using POSIX's struct timespec, see
           # https://www.gnu.org/software/libc/manual/html_node/Time-Types.html
           # aka it represents the seconds part separate from the nanoseconds part
           start_timespec_seconds: flush.start.tv_sec,
@@ -80,8 +80,9 @@ module Datadog
       def validate_agent_settings(agent_settings)
         supported_adapters = [Datadog::Transport::Ext::HTTP::ADAPTER, Datadog::Transport::Ext::UnixSocket::ADAPTER]
         unless supported_adapters.include?(agent_settings.adapter)
-          raise ArgumentError, "Unsupported transport configuration for profiling: Adapter #{agent_settings.adapter} " \
-            ' is not supported'
+          raise ArgumentError,
+            "Unsupported transport configuration for profiling: Adapter #{agent_settings.adapter} " \
+                        ' is not supported'
         end
 
         if agent_settings.deprecated_for_removal_transport_configuration_proc

data/lib/datadog/profiling/old_recorder.rb

@@ -1,7 +1,7 @@
 # typed: true
 
-require 'datadog/profiling/buffer'
-require 'datadog/profiling/encoding/profile'
+require_relative 'buffer'
+require_relative 'encoding/profile'
 
 module Datadog
   module Profiling
@@ -73,11 +73,6 @@ module Datadog
         [start, finish, encoded_pprof]
       end
 
-      # NOTE: Remember that if the recorder is being accessed by multiple threads, this is an inherently racy operation.
-      def empty?
-        @buffers.values.all?(&:empty?)
-      end
-
       # Error when event of an unknown type is used with the OldRecorder
       class UnknownEventError < StandardError
         attr_reader :event_class

data/lib/datadog/profiling/pprof/builder.rb

@@ -2,10 +2,10 @@
 
 # typed: true
 
-require 'datadog/profiling/flush'
-require 'datadog/profiling/pprof/message_set'
-require 'datadog/profiling/pprof/string_table'
-require 'datadog/core/utils/time'
+require_relative '../flush'
+require_relative 'message_set'
+require_relative 'string_table'
+require_relative '../../core/utils/time'
 
 module Datadog
   module Profiling

data/lib/datadog/profiling/pprof/converter.rb

@@ -1,6 +1,6 @@
 # typed: true
 
-require 'datadog/profiling/ext'
+require_relative '../ext'
 
 module Datadog
   module Profiling

data/lib/datadog/profiling/pprof/message_set.rb

@@ -1,6 +1,6 @@
 # typed: true
 
-require 'datadog/core/utils/object_set'
+require_relative '../../core/utils/object_set'
 
 module Datadog
   module Profiling

data/lib/datadog/profiling/pprof/stack_sample.rb

@@ -1,9 +1,9 @@
 # typed: true
 
-require 'datadog/profiling/ext'
-require 'datadog/profiling/events/stack'
-require 'datadog/profiling/pprof/builder'
-require 'datadog/profiling/pprof/converter'
+require_relative '../ext'
+require_relative '../events/stack'
+require_relative 'builder'
+require_relative 'converter'
 
 module Datadog
   module Profiling

data/lib/datadog/profiling/pprof/string_table.rb

@@ -1,6 +1,6 @@
 # typed: strict
 
-require 'datadog/core/utils/string_table'
+require_relative '../../core/utils/string_table'
 
 module Datadog
   module Profiling

data/lib/datadog/profiling/pprof/template.rb

@@ -1,11 +1,11 @@
 # typed: false
 
-require 'datadog/profiling/pprof/payload'
-require 'datadog/profiling/pprof/message_set'
-require 'datadog/profiling/pprof/builder'
+require_relative 'payload'
+require_relative 'message_set'
+require_relative 'builder'
 
-require 'datadog/profiling/events/stack'
-require 'datadog/profiling/pprof/stack_sample'
+require_relative '../events/stack'
+require_relative 'stack_sample'
 
 module Datadog
   module Profiling

data/lib/datadog/profiling/preload.rb

@@ -1,5 +1,5 @@
 # typed: strict
 
-require 'ddtrace'
+require_relative '../../ddtrace'
 
 Datadog::Profiling.start_if_enabled

data/lib/datadog/profiling/scheduler.rb

@@ -1,9 +1,9 @@
 # typed: true
 
-require 'datadog/core/utils/time'
+require_relative '../core/utils/time'
 
-require 'datadog/core/worker'
-require 'datadog/core/workers/polling'
+require_relative '../core/worker'
+require_relative '../core/workers/polling'
 
 module Datadog
   module Profiling
@@ -69,6 +69,7 @@ module Datadog
       def after_fork
         # Clear any existing profiling state.
         # We don't want the child process to report profiling data from its parent.
+        Datadog.logger.debug('Flushing exporter in child process #after_fork and discarding data')
         exporter.flush
       end
 
@@ -82,7 +83,7 @@ module Datadog
       end
 
       def work_pending?
-        !exporter.empty?
+        exporter.can_flush?
       end
 
       private

data/lib/datadog/profiling/stack_recorder.rb

@@ -2,11 +2,22 @@
 
 module Datadog
   module Profiling
-    # Used to wrap a ddprof_ffi_Profile in a Ruby object and expose Ruby-level serialization APIs
+    # Stores stack samples in a native libdatadog data structure and expose Ruby-level serialization APIs
+    # Note that `record_sample` is only accessible from native code.
     # Methods prefixed with _native_ are implemented in `stack_recorder.c`
     class StackRecorder
+      def initialize
+        # This mutex works in addition to the fancy C-level mutexes we have in the native side (see the docs there).
+        # It prevents multiple Ruby threads calling serialize at the same time -- something like
+        # `10.times { Thread.new { stack_recorder.serialize } }`.
+        # This isn't something we expect to happen normally, but because it would break the assumptions of the
+        # C-level mutexes (that there is a single serializer thread), we add it here as an extra safeguard against it
+        # accidentally happening.
+        @no_concurrent_synchronize_mutex = Mutex.new
+      end
+
       def serialize
-        status, result = self.class._native_serialize(self)
+        status, result = @no_concurrent_synchronize_mutex.synchronize { self.class._native_serialize(self) }
 
         if status == :ok
           start, finish, encoded_pprof = result
@@ -23,8 +34,7 @@ module Datadog
         end
       end
 
-      # Used only for Ruby 2.2 and below which don't have the native `rb_time_timespec_new` API
-      # Called from native code
+      # Used only for Ruby 2.2 which doesn't have the native `rb_time_timespec_new` API; called from native code
       def self.ruby_time_from(timespec_seconds, timespec_nanoseconds)
         Time.at(0).utc + timespec_seconds + (timespec_nanoseconds.to_r / 1_000_000_000)
       end

data/lib/datadog/profiling/tag_builder.rb

@@ -1,5 +1,7 @@
 # typed: true
 
+require_relative '../core/utils'
+
 module Datadog
   module Profiling
     # Builds a hash of default plus user tags to be included in a profile
@@ -41,7 +43,10 @@ module Datadog
         tags[FORM_FIELD_TAG_SERVICE] = service if service
         tags[FORM_FIELD_TAG_VERSION] = version if version
 
-        user_tags.merge(tags)
+        # Make sure everything is an utf-8 string, to avoid encoding issues in native code/libddprof/further downstream
+        user_tags.merge(tags).map do |key, value|
+          [Datadog::Core::Utils.utf8_encode(key), Datadog::Core::Utils.utf8_encode(value)]
+        end.to_h
       end
     end
   end

data/lib/datadog/profiling/tasks/setup.rb

@@ -1,7 +1,7 @@
 # typed: false
 
-require 'datadog/core/utils/only_once'
-require 'datadog/profiling/ext/forking'
+require_relative '../../core/utils/only_once'
+require_relative '../ext/forking'
 
 module Datadog
   module Profiling

data/lib/datadog/profiling/trace_identifiers/ddtrace.rb

@@ -2,8 +2,8 @@
 
 # typed: true
 
-require 'datadog/tracing'
-require 'datadog/tracing/metadata/ext'
+require_relative '../../tracing'
+require_relative '../../tracing/metadata/ext'
 
 module Datadog
   module Profiling

data/lib/datadog/profiling/trace_identifiers/helper.rb

@@ -2,7 +2,7 @@
 
 # typed: true
 
-require 'datadog/profiling/trace_identifiers/ddtrace'
+require_relative 'ddtrace'
 
 module Datadog
   module Profiling

data/lib/datadog/profiling/transport/http/api/endpoint.rb

@@ -1,10 +1,10 @@
 # typed: true
 
-require 'datadog/core/utils/compression'
-require 'datadog/core/vendor/multipart-post/multipart/post/composite_read_io'
-require 'datadog/profiling/old_ext'
-require 'datadog/profiling/transport/http/response'
-require 'ddtrace/transport/http/api/endpoint'
+require_relative '../../../../core/utils/compression'
+require_relative '../../../../core/vendor/multipart-post/multipart/post/composite_read_io'
+require_relative '../../../old_ext'
+require_relative '../response'
+require_relative '../../../../../ddtrace/transport/http/api/endpoint'
 
 module Datadog
   module Profiling

data/lib/datadog/profiling/transport/http/api/instance.rb

@@ -1,7 +1,7 @@
 # typed: true
 
-require 'ddtrace/transport/http/api/instance'
-require 'datadog/profiling/transport/http/api/spec'
+require_relative '../../../../../ddtrace/transport/http/api/instance'
+require_relative 'spec'
 
 module Datadog
   module Profiling

data/lib/datadog/profiling/transport/http/api/spec.rb

@@ -1,6 +1,6 @@
 # typed: true
 
-require 'ddtrace/transport/http/api/spec'
+require_relative '../../../../../ddtrace/transport/http/api/spec'
 
 module Datadog
   module Profiling

data/lib/datadog/profiling/transport/http/api.rb

@@ -1,10 +1,10 @@
 # typed: true
 
-require 'ddtrace/transport/http/api/map'
-require 'datadog/profiling/encoding/profile'
-require 'datadog/profiling/transport/http/api/spec'
-require 'datadog/profiling/transport/http/api/instance'
-require 'datadog/profiling/transport/http/api/endpoint'
+require_relative '../../../../ddtrace/transport/http/api/map'
+require_relative '../../encoding/profile'
+require_relative 'api/spec'
+require_relative 'api/instance'
+require_relative 'api/endpoint'
 
 module Datadog
   module Profiling

data/lib/datadog/profiling/transport/http/builder.rb

@@ -1,9 +1,9 @@
 # typed: true
 
-require 'ddtrace/transport/http/builder'
+require_relative '../../../../ddtrace/transport/http/builder'
 
-require 'datadog/profiling/transport/http/api'
-require 'datadog/profiling/transport/http/client'
+require_relative 'api'
+require_relative 'client'
 
 module Datadog
   module Profiling

data/lib/datadog/profiling/transport/http/client.rb

@@ -1,7 +1,7 @@
 # typed: true
 
-require 'ddtrace/transport/http/client'
-require 'ddtrace/transport/request'
+require_relative '../../../../ddtrace/transport/http/client'
+require_relative '../../../../ddtrace/transport/request'
 
 module Datadog
   module Profiling

data/lib/datadog/profiling/transport/http/response.rb

@@ -1,6 +1,6 @@
 # typed: true
 
-require 'ddtrace/transport/http/response'
+require_relative '../../../../ddtrace/transport/http/response'
 
 module Datadog
   module Profiling

data/lib/datadog/profiling/transport/http.rb

@@ -1,17 +1,17 @@
 # typed: true
 
-require 'datadog/core/environment/ext'
-require 'ddtrace/transport/ext'
+require_relative '../../core/environment/ext'
+require_relative '../../../ddtrace/transport/ext'
 
-require 'datadog/core/environment/container'
-require 'datadog/core/environment/variable_helpers'
+require_relative '../../core/environment/container'
+require_relative '../../core/environment/variable_helpers'
 
-require 'datadog/profiling/transport/http/builder'
-require 'datadog/profiling/transport/http/api'
+require_relative 'http/builder'
+require_relative 'http/api'
 
-require 'ddtrace/transport/http/adapters/net'
-require 'ddtrace/transport/http/adapters/test'
-require 'ddtrace/transport/http/adapters/unix_socket'
+require_relative '../../../ddtrace/transport/http/adapters/net'
+require_relative '../../../ddtrace/transport/http/adapters/test'
+require_relative '../../../ddtrace/transport/http/adapters/unix_socket'
 
 module Datadog
   module Profiling
@@ -100,12 +100,18 @@ module Datadog
         end
 
         # Add adapters to registry
-        Datadog::Transport::HTTP::Builder::REGISTRY.set(Datadog::Transport::HTTP::Adapters::Net,
-                                                        Datadog::Transport::Ext::HTTP::ADAPTER)
-        Datadog::Transport::HTTP::Builder::REGISTRY.set(Datadog::Transport::HTTP::Adapters::Test,
-                                                        Datadog::Transport::Ext::Test::ADAPTER)
-        Datadog::Transport::HTTP::Builder::REGISTRY.set(Datadog::Transport::HTTP::Adapters::UnixSocket,
-                                                        Datadog::Transport::Ext::UnixSocket::ADAPTER)
+        Datadog::Transport::HTTP::Builder::REGISTRY.set(
+          Datadog::Transport::HTTP::Adapters::Net,
+          Datadog::Transport::Ext::HTTP::ADAPTER
+        )
+        Datadog::Transport::HTTP::Builder::REGISTRY.set(
+          Datadog::Transport::HTTP::Adapters::Test,
+          Datadog::Transport::Ext::Test::ADAPTER
+        )
+        Datadog::Transport::HTTP::Builder::REGISTRY.set(
+          Datadog::Transport::HTTP::Adapters::UnixSocket,
+          Datadog::Transport::Ext::UnixSocket::ADAPTER
+        )
       end
     end
   end

data/lib/datadog/profiling.rb

@@ -1,8 +1,8 @@
 # typed: true
 
-require 'datadog/core'
-require 'datadog/core/environment/variable_helpers'
-require 'datadog/core/utils/only_once'
+require_relative 'core'
+require_relative 'core/environment/variable_helpers'
+require_relative 'core/utils/only_once'
 
 module Datadog
   # Contains profiler for generating stack profiles, etc.
@@ -132,7 +132,7 @@ module Datadog
 
     private_class_method def self.try_loading_native_library
       begin
-        require 'datadog/profiling/load_native_extension'
+        require_relative 'profiling/load_native_extension'
 
         success =
           defined?(Profiling::NativeExtension) && Profiling::NativeExtension.send(:native_working?)
@@ -145,22 +145,23 @@ module Datadog
     private_class_method def self.load_profiling
       return false unless supported?
 
-      require 'datadog/profiling/ext/forking'
-      require 'datadog/profiling/collectors/code_provenance'
-      require 'datadog/profiling/collectors/cpu_and_wall_time'
-      require 'datadog/profiling/collectors/old_stack'
-      require 'datadog/profiling/collectors/stack'
-      require 'datadog/profiling/stack_recorder'
-      require 'datadog/profiling/old_recorder'
-      require 'datadog/profiling/exporter'
-      require 'datadog/profiling/scheduler'
-      require 'datadog/profiling/tasks/setup'
-      require 'datadog/profiling/profiler'
-      require 'datadog/profiling/native_extension'
-      require 'datadog/profiling/trace_identifiers/helper'
-      require 'datadog/profiling/pprof/pprof_pb'
-      require 'datadog/profiling/tag_builder'
-      require 'datadog/profiling/http_transport'
+      require_relative 'profiling/ext/forking'
+      require_relative 'profiling/collectors/code_provenance'
+      require_relative 'profiling/collectors/cpu_and_wall_time'
+      require_relative 'profiling/collectors/cpu_and_wall_time_worker'
+      require_relative 'profiling/collectors/old_stack'
+      require_relative 'profiling/collectors/stack'
+      require_relative 'profiling/stack_recorder'
+      require_relative 'profiling/old_recorder'
+      require_relative 'profiling/exporter'
+      require_relative 'profiling/scheduler'
+      require_relative 'profiling/tasks/setup'
+      require_relative 'profiling/profiler'
+      require_relative 'profiling/native_extension'
+      require_relative 'profiling/trace_identifiers/helper'
+      require_relative 'profiling/pprof/pprof_pb'
+      require_relative 'profiling/tag_builder'
+      require_relative 'profiling/http_transport'
 
       true
     end

data/lib/datadog/tracing/analytics.rb

@@ -1,6 +1,6 @@
 # typed: true
 
-require 'datadog/tracing/metadata/ext'
+require_relative 'metadata/ext'
 
 module Datadog
   module Tracing

data/lib/datadog/tracing/buffer.rb

@@ -1,10 +1,10 @@
 # typed: true
 
-require 'datadog/core'
-require 'datadog/core/environment/ext'
-require 'datadog/core/buffer/thread_safe'
-require 'datadog/core/buffer/cruby'
-require 'datadog/core/diagnostics/health'
+require_relative '../core'
+require_relative '../core/environment/ext'
+require_relative '../core/buffer/thread_safe'
+require_relative '../core/buffer/cruby'
+require_relative '../core/diagnostics/health'
 
 module Datadog
   module Tracing

data/lib/datadog/tracing/context.rb

@@ -1,6 +1,6 @@
 # typed: true
 
-require 'datadog/core/utils/forking'
+require_relative '../core/utils/forking'
 
 module Datadog
   module Tracing

data/lib/datadog/tracing/context_provider.rb

@@ -1,7 +1,7 @@
 # typed: true
 
-require 'datadog/core/utils/sequence'
-require 'datadog/tracing/context'
+require_relative '../core/utils/sequence'
+require_relative 'context'
 
 module Datadog
   module Tracing