ddtrace 0.29.0 → 0.29.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 31e0fcb8b1ca0ac159f61cad36c76981d613f0ec
-  data.tar.gz: 186e058533c35a80cbc8146967d02bc40f363fe3
+  metadata.gz: b29416bf90ae1197fb95cf7f3d505a6a83098156
+  data.tar.gz: 9eabc9df9b505136aa18780d6dfb4d4b48545766
 SHA512:
-  metadata.gz: ce23a13ce0ff2c5bdfe1581d142cb0b00d328f840ed6d200aa1213b47355ef92bf810ce107063542be68e700f4dd7a8e033db9b21a0f77a2c2e2dc551ff51286
-  data.tar.gz: 8784d7bc918baf0e98424b28d7ab236749a3ce6d528f3b32f139480340a1f2710d4cf8446d3dc4cecd5eca052deec1ef04c9d25009e1ae6976c9a7625827ecea
+  metadata.gz: 1f0b882500d0d548a90b1080fae7edbba1c337e9fe9c9749a9ece3eb9840e65d9f622b608c3a451bafe0905aa4560683e81a5008aa3903854974ead88c0c66aa
+  data.tar.gz: b9b5278d663cf8461e6df66626e4b131ec1b723f4eef2eb2b806a34ed7cc55b3a0b3dd7c09789f9bec2b82da22b56a65b97580407f922cb4955cc6369b1f6dd1

data/CHANGELOG.md

@@ -2,6 +2,16 @@
 
 ## [Unreleased]
 
+## [0.29.1] - 2019-11-26
+
+Release notes: https://github.com/DataDog/dd-trace-rb/releases/tag/v0.29.1
+
+Git diff: https://github.com/DataDog/dd-trace-rb/compare/v0.29.0...v0.29.1
+
+### Fixed
+
+- Priority sampling not activating by default (#868)
+
 ## [0.29.0] - 2019-11-20
 
 Release notes: https://github.com/DataDog/dd-trace-rb/releases/tag/v0.29.0
@@ -971,7 +981,8 @@ Release notes: https://github.com/DataDog/dd-trace-rb/releases/tag/v0.3.1
 
 Git diff: https://github.com/DataDog/dd-trace-rb/compare/v0.3.0...v0.3.1
 
-[Unreleased]: https://github.com/DataDog/dd-trace-rb/compare/v0.29.0...master
+[Unreleased]: https://github.com/DataDog/dd-trace-rb/compare/v0.29.1...master
+[0.29.1]: https://github.com/DataDog/dd-trace-rb/compare/v0.29.0...v0.29.1
 [0.29.0]: https://github.com/DataDog/dd-trace-rb/compare/v0.28.0...v0.29.0
 [0.28.0]: https://github.com/DataDog/dd-trace-rb/compare/v0.27.0...v0.28.0
 [0.27.0]: https://github.com/DataDog/dd-trace-rb/compare/v0.26.0...v0.27.0

data/lib/ddtrace/sampler.rb

@@ -64,56 +64,110 @@ module Datadog
     end
   end
 
-  # \RateByServiceSampler samples different services at different rates
-  class RateByServiceSampler < Sampler
-    DEFAULT_KEY = 'service:,env:'.freeze
+  # Samples at different rates by key.
+  class RateByKeySampler < Sampler
+    attr_reader \
+      :default_key
+
+    def initialize(default_key, default_rate = 1.0, &block)
+      raise ArgumentError, 'No resolver given!' unless block_given?
 
-    def initialize(rate = 1.0, opts = {})
-      @env = opts.fetch(:env, Datadog.tracer.tags[:env])
+      @default_key = default_key
+      @resolver = block
       @mutex = Mutex.new
-      @fallback = RateSampler.new(rate)
-      @sampler = { DEFAULT_KEY => @fallback }
+      @samplers = {}
+
+      set_rate(default_key, default_rate)
+    end
+
+    def resolve(span)
+      @resolver.call(span)
+    end
+
+    def default_sampler
+      @samplers[default_key]
     end
 
     def sample?(span)
-      key = key_for(span)
+      key = resolve(span)
 
       @mutex.synchronize do
-        @sampler.fetch(key, @fallback).sample?(span)
+        @samplers.fetch(key, default_sampler).sample?(span)
       end
     end
 
     def sample!(span)
-      key = key_for(span)
+      key = resolve(span)
 
       @mutex.synchronize do
-        @sampler.fetch(key, @fallback).sample!(span)
+        @samplers.fetch(key, default_sampler).sample!(span)
       end
     end
 
     def sample_rate(span)
-      key = key_for(span)
+      key = resolve(span)
 
       @mutex.synchronize do
-        @sampler.fetch(key, @fallback).sample_rate
+        @samplers.fetch(key, default_sampler).sample_rate
       end
     end
 
-    def update(rate_by_service)
+    def update(key, rate)
       @mutex.synchronize do
-        @sampler.delete_if { |key, _| key != DEFAULT_KEY && !rate_by_service.key?(key) }
+        set_rate(key, rate)
+      end
+    end
 
-        rate_by_service.each do |key, rate|
-          @sampler[key] ||= RateSampler.new(rate)
-          @sampler[key].sample_rate = rate
-        end
+    def update_all(rate_by_key)
+      @mutex.synchronize do
+        rate_by_key.each { |key, rate| set_rate(key, rate) }
+      end
+    end
+
+    def delete(key)
+      @mutex.synchronize do
+        @samplers.delete(key)
+      end
+    end
+
+    def delete_if(&block)
+      @mutex.synchronize do
+        @samplers.delete_if(&block)
       end
     end
 
     private
 
+    def set_rate(key, rate)
+      @samplers[key] ||= RateSampler.new(rate)
+      @samplers[key].sample_rate = rate
+    end
+  end
+
+  # \RateByServiceSampler samples different services at different rates
+  class RateByServiceSampler < RateByKeySampler
+    DEFAULT_KEY = 'service:,env:'.freeze
+
+    def initialize(default_rate = 1.0, options = {})
+      super(DEFAULT_KEY, default_rate, &method(:key_for))
+      @env = options[:env]
+    end
+
+    def update(rate_by_service)
+      # Remove any old services
+      delete_if { |key, _| key != DEFAULT_KEY && !rate_by_service.key?(key) }
+
+      # Update each service rate
+      update_all(rate_by_service)
+    end
+
+    private
+
     def key_for(span)
-      "service:#{span.service},env:#{@env}"
+      # Resolve env dynamically, if Proc is given.
+      env = @env.is_a?(Proc) ? @env.call : @env
+
+      "service:#{span.service},env:#{env}"
     end
   end
 

data/lib/ddtrace/tracer.rb

@@ -120,6 +120,9 @@ module Datadog
 
       @mutex = Mutex.new
       @tags = {}
+
+      # Enable priority sampling by default
+      activate_priority_sampling!(@sampler)
     end
 
     # Updates the current \Tracer instance, so that the tracer can be configured after the
@@ -441,7 +444,10 @@ module Datadog
       @sampler = if base_sampler.is_a?(PrioritySampler)
                    base_sampler
                  else
-                   PrioritySampler.new(base_sampler: base_sampler)
+                   PrioritySampler.new(
+                     base_sampler: base_sampler,
+                     post_sampler: Datadog::RateByServiceSampler.new(1.0, env: proc { tags[:env] })
+                   )
                  end
     end
 

data/lib/ddtrace/version.rb

@@ -2,7 +2,7 @@ module Datadog
   module VERSION
     MAJOR = 0
     MINOR = 29
-    PATCH = 0
+    PATCH = 1
     PRE = nil
 
     STRING = [MAJOR, MINOR, PATCH, PRE].compact.join('.')

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ddtrace
 version: !ruby/object:Gem::Version
-  version: 0.29.0
+  version: 0.29.1
 platform: ruby
 authors:
 - Datadog, Inc.
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-11-20 00:00:00.000000000 Z
+date: 2019-11-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: msgpack