ddr-models 3.0.0.beta.3 → 3.0.0.beta.4

data/spec/jobs/fixity_check_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+
+module Ddr::Jobs
+  RSpec.describe FixityCheck do
+
+    it "should use the :fixity queue" do
+      expect(described_class.queue).to eq(:fixity)
+    end
+
+    describe ".perform" do
+      let!(:obj) { double(fixity_check: nil) }
+      before do
+        allow(ActiveFedora::Base).to receive(:find).with("test:1") { obj }
+      end
+      it "should call `fixity_check` on the object" do
+        expect(obj).to receive(:fixity_check)
+        described_class.perform("test:1")
+      end
+    end
+
+  end
+end

data/spec/jobs/job_spec.rb

@@ -0,0 +1,40 @@
+module Ddr::Jobs
+  RSpec.describe Job do
+
+    before(:all) do
+      class TestJob
+        extend Job
+
+        @queue = :test
+
+        def perform(object_id)
+          puts object_id
+        end
+      end
+    end
+
+    after(:all) do
+      Ddr::Jobs.send(:remove_const, :TestJob)
+    end
+
+    let(:queued) do
+      [{"class"=>"Ddr::Jobs::TestJob", "args"=>["test-1"]},
+       {"class"=>"Ddr::Jobs::OtherJob", "args"=>["test-2"]},
+       {"class"=>"Ddr::Jobs::TestJob", "args"=>["test-3"]},
+      ]
+    end
+
+    before(:each) do
+      allow(Resque).to receive(:size).with(:test) { 3 }
+      allow(Resque).to receive(:peek).with(:test, 0, 3) { queued }
+    end
+
+    describe ".queued_object_ids" do
+      it "returns the list of object_ids for queued jobs of this type" do
+        expect(TestJob.queued_object_ids)
+          .to contain_exactly("test-1", "test-3")
+      end
+    end
+
+  end
+end

data/spec/jobs/update_index_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+
+module Ddr::Jobs
+  RSpec.describe UpdateIndex do
+
+    it "should use the :index queue" do
+      expect(described_class.queue).to eq(:index)
+    end
+
+    describe ".perform" do
+      let!(:obj) { double(update_index: nil) }
+      before do
+        allow(ActiveFedora::Base).to receive(:find).with("test:1") { obj }
+      end
+      it "should call `update_index` on the object" do
+        expect(obj).to receive(:update_index)
+        described_class.perform("test:1")
+      end
+    end
+
+  end
+end

data/spec/managers/derivatives_manager_spec.rb

@@ -28,7 +28,7 @@ module Ddr
         context "all derivatives" do
           context "not multires_image_able" do
             let(:object) { ContentBearing.new }
-            context "content is image" do
+            context "content is an image" do
               let(:file) { fixture_file_upload("imageA.tif", "image/tiff") }
               it "should generate a thumbnail and not a ptif" do
                 expect(object.derivatives).to receive(:generate_derivative).with(Ddr::Derivatives::DERIVATIVES[:thumbnail])
@@ -36,15 +36,7 @@ module Ddr
                 object.derivatives.update_derivatives(:now)
               end
             end
-            # context "content is a PDF" do
-            #   let(:file) { fixture_file_upload("sample.pdf", "application/pdf") }
-            #   it "should generate a thumbnail and not a ptif" do
-            #     expect(object.derivatives).to receive(:generate_derivative).with(Ddr::Derivatives::DERIVATIVES[:thumbnail])
-            #     expect(object.derivatives).to_not receive(:generate_derivative).with(Ddr::Derivatives::DERIVATIVES[:multires_image])
-            #     object.derivatives.update_derivatives(:now)
-            #   end
-            # end
-            context "content is neither an image nor a PDF" do
+            context "content is not an image" do
               let(:file) { fixture_file_upload("sample.docx", "application/vnd.openxmlformats-officedocument.wordprocessingml.document") }
               it "should generate neither a thumbnail nor a ptif" do
                 expect(object.derivatives).to_not receive(:generate_derivative).with(Ddr::Derivatives::DERIVATIVES[:thumbnail])
@@ -85,7 +77,7 @@ module Ddr
             object.derivatives.update_derivatives(:now)
           end
         end
-end
+      end
 
       describe "derivative generation" do
         let(:file) { fixture_file_upload("imageA.tif", "image/tiff") }
@@ -120,6 +112,18 @@ end
         end
       end
 
+      describe "exception during derivative generation" do
+        let(:object) { ContentBearing.create }
+        before do
+          allow(Dir::Tmpname).to receive(:make_tmpname).with('', nil) { 'test-temp-dir' }
+          # simulate raising of exception during derivative generation
+          allow_any_instance_of(Ddr::Managers::DerivativesManager).to receive(:generate_derivative).and_raise(StandardError)
+        end
+        it "should delete the temporary work directory" do
+          expect(File.exist?(File.join(Dir.tmpdir, 'test-temp-dir'))).to be false
+        end
+      end
+
     end
   end
 end

data/spec/models/admin_set_spec.rb

@@ -1,25 +1,43 @@
 module Ddr::Models
-  RSpec.describe AdminSet do
+  RSpec.describe AdminSet, ddr_aux: true do
 
     describe ".call" do
-      subject { described_class.call(obj) }
+      let(:obj) { Item.new }
 
       describe "when the object has an admin set" do
-        let(:obj) { double(admin_set: "dvs") }
-        before do
-          allow(described_class).to receive(:find).with(code: "dvs") do
-            described_class.new("id"=>1, "code"=>"dvs", "title"=>"Data and Visualization Services", "created_at"=>"2015-09-15T16:15:58.514Z", "updated_at"=>"2015-09-15T16:15:58.514Z")
+        before { obj.admin_set = "dvs" }
+        describe "and the admin set code is found" do
+          before {
+            allow(described_class).to receive(:get).with(:find, code: "dvs") {
+              {"id"=>1, "code"=>"dvs", "title"=>"Data and Visualization Services", "created_at"=>"2015-09-15T16:15:58.514Z", "updated_at"=>"2015-09-15T16:15:58.514Z"}
+            }
+          }
+          it "returns an AdminSet instance" do
+            expect(described_class.call(obj)).to be_a(described_class)
+          end
+        end
+        describe "and the admin set is not found" do
+          before {
+            allow(described_class).to receive(:get).with(:find, code: "dvs")
+                                       .and_raise(ActiveResource::ResourceNotFound, "404")
+          }
+          it "raises an exception" do
+            expect { described_class.call(obj) }.to raise_error(Ddr::Models::NotFoundError)
           end
         end
-
-        its(:to_s) { is_expected.to eq("Data and Visualization Services") }
       end
 
       describe "when the object does not have an admin set" do
-        let(:obj) { double(admin_set: nil) }
-        it { is_expected.to be_nil }
+        it "returns nil" do
+          expect(described_class.call(obj)).to be_nil
+        end
       end
     end
 
+    describe "instance methods" do
+      subject { described_class.new("id"=>1, "code"=>"dvs", "title"=>"Data and Visualization Services", "created_at"=>"2015-09-15T16:15:58.514Z", "updated_at"=>"2015-09-15T16:15:58.514Z") }
+      its(:to_s) { is_expected.to eq("Data and Visualization Services") }
+    end
+
   end
 end

data/spec/models/contact_spec.rb

@@ -0,0 +1,42 @@
+module Ddr::Models
+  RSpec.describe Contact, ddr_aux: true do
+
+    describe ".call" do
+      describe "when the slug is found" do
+        before {
+          allow(described_class).to receive(:get).with(:find, slug: "abc") {
+            {"id"=>1, "slug"=>"abc", "name"=>"A, B, and C Services", "short_name"=>"ABCS",
+             "url"=>"http://library.inst.edu/abc", "phone"=>"555-1234", "email"=>"abc@library.inst.edu",
+             "ask"=>"http://library.inst.edu/abc-ask", "created_at"=>"2015-09-15T16:15:58.514Z",
+             "updated_at"=>"2015-09-15T16:15:58.514Z"}
+          }
+        }
+        it "returns a Contact instance" do
+          expect(described_class.call("abc")).to be_a(described_class)
+        end
+      end
+      describe "when the slug is not found" do
+        before {
+          allow(described_class).to receive(:get).with(:find, slug: "abc")
+                                     .and_raise(ActiveResource::ResourceNotFound, "404")
+        }
+        it "raises an exception" do
+          expect { described_class.call("abc") }.to raise_error(Ddr::Models::NotFoundError)
+        end
+      end
+    end
+
+    describe "instance methods" do
+      subject {
+        described_class.new(
+          "id"=>1, "slug"=>"abc", "name"=>"A, B, and C Services", "short_name"=>"ABCS",
+          "url"=>"http://library.inst.edu/abc", "phone"=>"555-1234", "email"=>"abc@library.inst.edu",
+          "ask"=>"http://library.inst.edu/abc-ask", "created_at"=>"2015-09-15T16:15:58.514Z",
+          "updated_at"=>"2015-09-15T16:15:58.514Z"
+        )
+      }
+      its(:to_s) { is_expected.to eq("A, B, and C Services") }
+    end
+
+  end
+end

data/spec/models/effective_license_spec.rb

@@ -6,34 +6,41 @@ module Ddr::Models
     let(:url) { "https://creativecommons.org/licenses/by-nc-nd/4.0/" }
 
     let(:license) { License.new(url: url) }
-    before { allow(License).to receive(:find).with(url: url) { license } }
 
-    let(:obj) { double(id: "test-1", license: nil, parent: nil, admin_policy: nil, admin_policy_id: nil) }
+    let(:obj) { Component.new(pid: "test:1") }
+    let(:parent) { Item.new(pid: "test:2") }
+    let(:admin_policy) { Collection.new(pid: "test:3") }
 
     describe "when the object has a license" do
-      before { allow(obj).to receive(:license) { url } }
+      before do
+        allow(License).to receive(:call).with(obj) { license }
+      end
       it { is_expected.to eq(license) }
     end
 
     describe "when the object does not have a license" do
+      before do
+        allow(License).to receive(:call).with(obj) { nil }
+      end
       describe "and the object has a parent" do
-        let(:parent) { double(id: "test-2", license: nil) }
         before do
           allow(obj).to receive(:parent) { parent }
         end
         describe "and the parent has a license" do
           before do
-            allow(parent).to receive(:license) { url }
+            allow(License).to receive(:call).with(parent) { license }
           end
           it { is_expected.to eq(license) }
         end
         describe "and the parent does not have a license" do
+          before do
+            allow(License).to receive(:call).with(parent) { nil }
+          end
           it { is_expected.to be_nil }
         end
       end
       describe "and the object does not have a parent" do
         describe "and the object has an admin policy" do
-          let(:admin_policy) { double(id: "test-3", license: nil) }
           before { allow(obj).to receive(:admin_policy) { admin_policy } }
           describe "and the admin policy has a different id from the object" do
             before do
@@ -41,11 +48,14 @@ module Ddr::Models
             end
             describe "and the admin policy has a license" do
               before do
-                allow(admin_policy).to receive(:license) { url }
+                allow(License).to receive(:call).with(admin_policy) { license }
               end
               it { is_expected.to eq(license) }
             end
             describe "and the admin policy does not have a license" do
+              before do
+                allow(License).to receive(:call).with(admin_policy) { nil }
+              end
               it { is_expected.to be_nil }
             end
           end

data/spec/models/file_characterization_spec.rb

@@ -0,0 +1,38 @@
+module Ddr::Models
+  RSpec.describe FileCharacterization do
+
+    subject { described_class.new(obj) }
+
+    let(:obj) { FactoryGirl.create(:component) }
+    let(:fits_output) { "<fits/>" }
+
+    before {
+      allow(subject).to receive(:with_content_file).and_yield("/tmp/foobar")
+    }
+
+    describe "when there is an error running FITS" do
+      before {
+        allow(subject).to receive(:run_fits).with("/tmp/foobar").and_raise(FileCharacterization::FITSError)
+      }
+      specify {
+        begin
+          subject.call
+        rescue FileCharacterization::FITSError
+        ensure
+          expect(subject.fits).not_to have_content
+        end
+      }
+    end
+
+    describe "when FITS runs successfully" do
+      before {
+        allow(subject).to receive(:run_fits).with("/tmp/foobar") { fits_output }
+      }
+      specify {
+        subject.call
+        expect(subject.fits.content).to eq(fits_output)
+      }
+    end
+
+  end
+end

data/spec/models/finding_aid_spec.rb

@@ -15,15 +15,32 @@ module Ddr::Models
               findaidstatus="published"
               langencoding="iso639-2b"
               repositoryencoding="iso15511">
-      <eadid url="http://example.com/ead/">ead</eadid>
-      <filedesc>
-         <titlestmt>
-            <titleproper>Guide to the Perplexed
-              <num>00001</num>
-            </titleproper>
-          </titlestmt>
-      </filedesc>
+     <eadid url="http://example.com/ead/">ead</eadid>
+     <filedesc>
+       <titlestmt>
+         <titleproper>Guide to the Perplexed
+           <num>00001</num>
+         </titleproper>
+       </titlestmt>
+     </filedesc>
    </eadheader>
+   <archdesc level="collection">
+     <did>
+       <repository>
+         <corpname>Library of the Perplexed</corpname>
+       </repository>
+       <unittitle>Perplexities</unittitle>
+       <unitid>RL.00327</unitid>
+       <physdesc altrender="whole">
+         <extent altrender="materialtype spaceoccupied">6.5 Linear Feet</extent>
+       </physdesc>
+       <unitdate normal="1876/1953" type="inclusive">1876-1953</unitdate>
+       <abstract>Abstract of Perplexities.</abstract>
+       <physdesc id="aspace_foobar">
+         <extent>4000 Items</extent>
+       </physdesc>
+     </did>
+   </archdesc>
 </ead>
 EOS
     end
@@ -34,6 +51,12 @@ EOS
 
     its(:title) { is_expected.to eq("Guide to the Perplexed") }
     its(:url) { is_expected.to eq("http://example.com/ead/") }
+    its(:repository) { is_expected.to eq("Library of the Perplexed") }
+    its(:collection_date_span) { is_expected.to eq("1876-1953") }
+    its(:collection_number) { is_expected.to eq("RL.00327") }
+    its(:collection_title) { is_expected.to eq("Perplexities") }
+    its(:extent) { is_expected.to eq("6.5 Linear Feet; 4000 Items") }
+    its(:abstract) { is_expected.to eq("Abstract of Perplexities.") }
 
   end
 end

data/spec/models/has_admin_metadata_spec.rb

@@ -178,14 +178,17 @@ module Ddr::Models
 
       describe "contacts" do
         before do
-          allow(YAML).to receive(:load_file) { { 'a' => { 'name' => 'Contact A', 'short_name' => 'A' },
-                                                 'b' => { 'name' => 'Contact B', 'short_name' => 'B' } } }
-          Ddr::Contacts.load_contacts
+          allow(Ddr::Models::Contact).to receive(:get).with(:find, slug: 'xa') do
+            {'id'=>1, 'slug'=>'xa', 'name'=>'Contact A', 'short_name'=>'A'}
+          end
+          allow(Ddr::Models::Contact).to receive(:get).with(:find, slug: 'yb') do
+            {'id'=>1, 'slug'=>'yb', 'name'=>'Contact B', 'short_name'=>'B'}
+          end
         end
         describe "#research_help" do
-          before { subject.research_help_contact = 'b' }
+          before { subject.research_help_contact = 'yb' }
           it "should return the appropriate contact" do
-            expect(subject.research_help.slug).to eq('b')
+            expect(subject.research_help.slug).to eq('yb')
           end
         end
       end

data/spec/models/indexing_spec.rb

@@ -18,6 +18,7 @@ module Ddr::Models
       obj.permanent_url = "http://id.library.duke.edu/ark:/99999/fk4zzz"
       obj.display_format = "Image"
       obj.roles.grant role1, role2, role3, role4
+      obj.aspace_id = "aspace_dccea43034e1b8261e14cf999e86449d"
       obj.fcrepo3_pid = "duke:1"
     end
 
@@ -28,6 +29,7 @@ module Ddr::Models
     its([Indexing::PERMANENT_URL]) { is_expected.to eq("http://id.library.duke.edu/ark:/99999/fk4zzz") }
     its([Indexing::DISPLAY_FORMAT]) { is_expected.to eq("Image") }
     its([Indexing::ACCESS_ROLE]) { is_expected.to eq(obj.roles.to_json) }
+    its([Indexing::ASPACE_ID]) { is_expected.to eq("aspace_dccea43034e1b8261e14cf999e86449d") }
     its([Indexing::POLICY_ROLE]) { is_expected.to contain_exactly(role2.agent, role3.agent, role4.agent) }
     its([Indexing::RESOURCE_ROLE]) { is_expected.to contain_exactly(role1.agent) }
     its([Indexing::FCREPO3_PID]) { is_expected.to eq("duke:1") }

data/spec/models/license_spec.rb

@@ -1,24 +1,45 @@
 module Ddr::Models
-  RSpec.describe License do
+  RSpec.describe License, ddr_aux: true do
 
     describe ".call" do
-      subject { described_class.call(obj) }
-
       describe "when the object has a license URL" do
-        let(:url) { "http://example.com" }
-        let(:obj) { double(id: "test-1", license: url) }
-        before do
-          allow(described_class).to receive(:find).with(url: url) { described_class.new(url: url, title: "A License") }
+        let(:obj) { double(id: "test-1", license: "http://example.com") }
+        describe "and the license is found" do
+          before {
+            allow(described_class).to receive(:get).with(:find, url: "http://example.com") {
+              {"id"=>1, "url"=>"http://example.com", "title"=>"A License"}
+            }
+          }
+          it "returns a License instance" do
+            expect(described_class.call(obj)).to be_a(described_class)
+          end
+          it "sets `object_id` to the object id" do
+            expect(described_class.call(obj).object_id).to eq("test-1")
+          end
+        end
+        describe "and the license is not found" do
+          before {
+            allow(described_class).to receive(:get).with(:find, url: "http://example.com")
+                                       .and_raise(ActiveResource::ResourceNotFound, "404")
+          }
+          it "raises an exception" do
+            expect { described_class.call(obj) }.to raise_error(Ddr::Models::NotFoundError)
+          end
         end
-        its(:pid) { is_expected.to eq("test-1") }
-        its(:to_s) { is_expected.to eq("A License") }
       end
 
       describe "when the object does not have a license" do
         let(:obj) { double(id: "test-1", license: nil) }
-        it { is_expected.to be_nil }
+        it "returns nil" do
+          expect(described_class.call(obj)).to be_nil
+        end
       end
     end
 
+    describe "instance methods" do
+      subject { described_class.new("id"=>1, "url"=>"http://example.com", "title"=>"A License") }
+      its(:to_s) { is_expected.to eq("A License") }
+    end
+
   end
 end