ddr-models 3.0.0.beta.10 → 3.0.0.beta.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: acfc5ee132f67a3bcd39524c3cb2b3b54e6904a3
-  data.tar.gz: 8ee6e1cf1e7cbd8cd023d3ccc851b7eea2950803
+  metadata.gz: b649796b2ae7a3e6d271ae693967c20ffcaf09c6
+  data.tar.gz: a08a5a96113854923916d642994a458f0899edef
 SHA512:
-  metadata.gz: 7e470d2d199991ca2d8f8cdcd0300cc8c9c28f5d5339132c18d5f892ede55197577a030adbcbcf5966edfd3f79d72b2825c4e78216902760f0582337d23a0a90
-  data.tar.gz: 17a7d44df2345a1c740afc6f4f9fb08243858cbb4b9a8bd1a16c8b91c8567b4db633c7a33c661d18bf02b9e148deb3e3a0d7030bda432611b9e9bcca472edae7
+  metadata.gz: 92bf5752a52715353c0c6e8bc88a009e0840a1d23caff13383c10c5bb900600dfdce1e30691ff0f2c9dd02e8756806d407e4e785bc67ee9050a9d09dbb40f554
+  data.tar.gz: 35f6bc9504c3500b54ec397dc0fc904de3c00a0a6226e52f1438d2698c7016a34e73bf3843a2b3c509a9cd0a9bcf86fed83a9e402f88f7974e8c12d27d0335f6

data/app/models/attachment.rb

@@ -11,4 +11,8 @@ class Attachment < Ddr::Models::Base
              predicate: ::RDF::URI("http://projecthydra.org/ns/relations#isAttachedTo"),
              class_name: "ActiveFedora::Base"
 
+  def publishable?
+    false
+  end
+
 end

data/app/models/collection.rb

@@ -54,6 +54,10 @@ class Collection < Ddr::Models::Base
                 scope: Ddr::Auth::Roles::POLICY_SCOPE
   end
 
+  def publishable?
+    true
+  end
+
   private
 
   def set_admin_policy

data/app/models/component.rb

@@ -25,4 +25,8 @@ class Component < Ddr::Models::Base
     collection.id rescue nil
   end
 
+  def publishable?
+    parent.present? && parent.published?
+  end
+
 end

data/app/models/item.rb

@@ -17,4 +17,8 @@ class Item < Ddr::Models::Base
              predicate: ActiveFedora::RDF::Fcrepo::RelsExt.isMemberOfCollection,
              class_name: "Collection"
 
+  def publishable?
+    parent.present? && parent.published?
+  end
+
 end

data/app/models/target.rb

@@ -17,4 +17,8 @@ class Target < Ddr::Models::Base
              predicate: ::RDF::URI("http://www.loc.gov/mix/v20/externalTarget#isExternalTargetFor"),
              class_name: "Collection"
 
+  def publishable?
+    false
+  end
+
 end

data/lib/ddr/auth.rb

@@ -38,6 +38,7 @@ module Ddr
       autoload :DatastreamAbilityDefinitions
       autoload :EventAbilityDefinitions
       autoload :ItemAbilityDefinitions
+      autoload :PublicationAbilityDefinitions
       autoload :RoleBasedAbilityDefinitions
       autoload :SuperuserAbilityDefinitions
     end

data/lib/ddr/auth/ability.rb

@@ -9,7 +9,8 @@ module Ddr
                                    AttachmentAbilityDefinitions,
                                    RoleBasedAbilityDefinitions,
                                    DatastreamAbilityDefinitions,
-                                   EventAbilityDefinitions ]
+                                   EventAbilityDefinitions,
+                                   PublicationAbilityDefinitions ]
 
     end
   end

data/lib/ddr/auth/ability_definitions/publication_ability_definitions.rb

@@ -0,0 +1,16 @@
+module Ddr
+  module Auth
+    class PublicationAbilityDefinitions < AbilityDefinitions
+
+      def call
+        can :publish, Ddr::Models::Base do |obj|
+          !obj.published? && obj.publishable?
+        end
+        can :unpublish, Ddr::Models::Base do |obj|
+          obj.published?
+        end
+      end
+
+    end
+  end
+end

data/lib/ddr/auth/permissions.rb

@@ -7,10 +7,12 @@ module Ddr::Auth
     UPDATE       = :update
     REPLACE      = :replace
     ARRANGE      = :arrange
+    PUBLISH      = :publish
+    UNPUBLISH    = :unpublish
     AUDIT        = :audit
     GRANT        = :grant
 
-    ALL = [ READ, DOWNLOAD, ADD_CHILDREN, UPDATE, REPLACE, ARRANGE, AUDIT, GRANT ]
+    ALL = [ READ, DOWNLOAD, ADD_CHILDREN, UPDATE, REPLACE, ARRANGE, PUBLISH, UNPUBLISH, AUDIT, GRANT ]
 
   end
 end

data/lib/ddr/derivatives/multires_image.rb

@@ -2,7 +2,9 @@ module Ddr::Derivatives
   class MultiresImage < Derivative
 
     def self.generatable?(object)
-      object.can_have_multires_image? && object.has_content? && object.content_type == "image/tiff"
+      object.can_have_multires_image? &&
+          object.has_content? &&
+          (object.content_type == "image/tiff" || object.content_type == "image/jpeg")
     end
 
     def self.has_derivative?(object)
@@ -56,4 +58,4 @@ module Ddr::Derivatives
     end
 
   end
-end
+end

data/lib/ddr/derivatives/thumbnail.rb

@@ -21,8 +21,7 @@ module Ddr::Derivatives
     end
 
     def output_file_name(object)
-      basename = object.content.original_name.present? ? File.basename(object.content.original_name, '.*') : "thumbnail"
-      "#{basename}.#{generator.class.output_extension}"
+      "thumbnail.#{generator.class.output_extension}"
     end
 
     def store(object, output_path)

data/lib/ddr/events/event.rb

@@ -39,6 +39,9 @@ module Ddr
       # Receive message sent by ActiveSupport::Notifications
       def self.call(*args)
         notification = ActiveSupport::Notifications::Event.new(*args)
+        if block_given?
+          yield notification.payload
+        end
         create(notification.payload)
       end
 

data/lib/ddr/events/fixity_check_event.rb

@@ -6,26 +6,15 @@ module Ddr
       include ReindexObjectAfterSave
 
       self.preservation_event_type = :fix
-      self.description = "Validation of datastream checksums"
-
-      DETAIL_PREAMBLE = "Datastream checksum validation results:"
-      DETAIL_TEMPLATE = "%{dsid} ... %{validation}"
+      self.description = "Fixity check of attached files".freeze
 
       # Message sent by ActiveSupport::Notifications
       def self.call(*args)
-        notification = ActiveSupport::Notifications::Event.new(*args)
-        result = notification.payload[:result] # FixityCheck::Result instance
-        detail = [DETAIL_PREAMBLE]
-        result.results.each do |dsid, dsProfile|
-          # validation = dsProfile["dsChecksumValid"] ? VALID : INVALID
-          validation = dsProfile["checksum_valid"] ? VALID : INVALID
-          detail << DETAIL_TEMPLATE % {dsid: dsid, validation: validation}
+        super do |payload|
+          results = payload.delete(:results)
+          payload[:outcome] = results.values.all? ? SUCCESS : FAILURE
+          payload[:detail] = "Fixity check results:\n\n#{results}"
         end
-        create(pid: result.id,
-               event_date_time: notification.time,
-               outcome: result.success ? SUCCESS : FAILURE,
-               detail: detail.join("\n")
-               )
       end
 
       def to_solr

data/lib/ddr/jobs/fixity_check.rb

@@ -6,7 +6,7 @@ module Ddr::Jobs
 
     def self.perform(id)
       obj = ActiveFedora::Base.find(id)
-      obj.fixity_check
+      obj.check_fixity
     end
 
   end

data/lib/ddr/managers/permanent_id_manager.rb

@@ -13,6 +13,7 @@ module Ddr
       PERMANENT_URL_BASE = "http://id.library.duke.edu/"
       ASSIGN_EVENT_SUMMARY = "Permanent ID assignment"
       SOFTWARE = Ezid::Client.version
+      FCREPO3_PID = "fcrepo3.pid"
 
       attr_reader :object
 
@@ -53,8 +54,9 @@ EZID Metadata:
       end
 
       def default_metadata
-        { profile: "dc",
-          export: "no"
+        { :profile => "dc",
+          :export => "no",
+          FCREPO3_PID => object.pid
         }
       end
 

data/lib/ddr/managers/workflow_manager.rb

@@ -9,22 +9,34 @@ module Ddr
         object.workflow_state == PUBLISHED
       end
 
-      def publish
-        object.workflow_state = PUBLISHED
+      def publish!(include_descendants: true)
+        unless published?
+          publish
+          object.save
+        end
+        if include_descendants && object.respond_to?(:children)
+          object.children.each { |child| child.publish!(include_descendants: include_descendants) }
+        end
       end
 
-      def publish!
-        publish
-        object.save
+      def unpublish!
+        if published?
+          unpublish
+          object.save
+        end
+        if object.respond_to?(:children)
+          object.children.each { |child| child.unpublish! }
+        end
       end
 
-      def unpublish
-        object.workflow_state = UNPUBLISHED
+      private
+
+      def publish
+        object.workflow_state = PUBLISHED
       end
 
-      def unpublish!
-        unpublish
-        object.save
+      def unpublish
+        object.workflow_state = UNPUBLISHED
       end
 
     end

data/lib/ddr/models.rb

@@ -39,7 +39,6 @@ module Ddr
     autoload :FileCharacterization
     autoload :FileManagement
     autoload :FindingAid
-    autoload :FixityCheckable
     autoload :Governable
     autoload :HasAdminMetadata
     autoload :HasAttachments

data/lib/ddr/models/base.rb

@@ -6,7 +6,6 @@ module Ddr::Models
     include Governable
     include HasThumbnail
     include EventLoggable
-    include FixityCheckable
     include FileManagement
     include Indexing
     include Hydra::Validations
@@ -116,5 +115,48 @@ module Ddr::Models
       self
     end
 
+    def datastreams_to_validate
+      Deprecation.warn(FixityCheckable, "`datastreams_to_validate` is deprecated." \
+                                        " Use `attached_files_having_content` instead.")
+      attached_files_having_content
+    end
+
+    def attached_files_having_content
+      Hash.new.tap do |h|
+        attached_files.each do |file_id, file|
+          h[file_id] = file if file.has_content?
+        end
+      end
+    end
+
+    def fixity_checks
+      Ddr::Events::FixityCheckEvent.for_object(self)
+    end
+
+    def check_fixity
+      results = attached_files_having_content.each_with_object({}) do |(file_id, file), memo|
+        memo[file_id] = !!file.check_fixity
+      end
+      notify_event(:fixity_check, results: results)
+    end
+    alias_method :fixity_check, :check_fixity
+    deprecation_deprecate :fixity_check
+
+    def last_fixity_check
+      fixity_checks.last
+    end
+
+    def last_fixity_check_on
+      last_fixity_check && last_fixity_check.event_date_time
+    end
+
+    def last_fixity_check_outcome
+      last_fixity_check && last_fixity_check.outcome
+    end
+
+    def publishable?
+      raise NotImplementedError, "Must be implemented by subclasses"
+    end
+
   end
 end

data/lib/ddr/models/file.rb

@@ -44,7 +44,7 @@ module Ddr::Models
     end
 
     def create_date_string
-      dsCreateDate.strftime(STRFTIME_FORMAT) if dsCreateDate
+      create_date.strftime(STRFTIME_FORMAT) if create_date
     end
 
     def content_digest(algorithm)

data/lib/ddr/models/has_admin_metadata.rb

@@ -61,7 +61,7 @@ module Ddr::Models
                predicate: Ddr::Vocab::Asset.workflowState,
                multiple: false
 
-      delegate :publish, :publish!, :unpublish, :unpublish!, :published?, to: :workflow
+      delegate :publish!, :unpublish!, :published?, to: :workflow
 
       after_create :assign_permanent_id!, if: "Ddr::Models.auto_assign_permanent_ids"
       around_destroy :update_permanent_id_on_destroy, if: "permanent_id.present?"

data/lib/ddr/models/version.rb

@@ -1,5 +1,5 @@
 module Ddr
   module Models
-    VERSION = "3.0.0.beta.10"
+    VERSION = "3.0.0.beta.11"
   end
 end

data/spec/auth/ability_spec.rb

@@ -2,7 +2,7 @@ module Ddr::Auth
   RSpec.describe Ability, type: :model, abilities: true do
 
     subject { described_class.new(auth_context) }
-    
+
     let(:auth_context) { FactoryGirl.build(:auth_context) }
 
     describe "aliases" do
@@ -144,6 +144,38 @@ module Ddr::Auth
       end
     end
 
+    describe "publication abilities" do
+      let(:obj) { Ddr::Models::Base.new }
+
+      describe "publish" do
+        describe "when the object is published" do
+          before { allow(obj).to receive(:published?) { true } }
+          it { should_not be_able_to(:publish, obj) }
+        end
+        describe "when the object is not published" do
+          describe "when the object is publishable" do
+            before { allow(obj).to receive(:publishable?) { true } }
+            it { should be_able_to(:publish, obj) }
+          end
+          describe "when the object is not publishable" do
+            before { allow(obj).to receive(:publishable?) { false } }
+            it { should_not be_able_to(:publish, obj) }
+          end
+        end
+      end
+
+      describe "unpublish" do
+        describe "when the object is published" do
+          before { allow(obj).to receive(:published?) { true } }
+          it { should be_able_to(:unpublish, obj) }
+        end
+        describe "when the object is not published" do
+          it { should_not be_able_to(:unpublish, obj) }
+        end
+      end
+
+    end
+
     describe "role based abilities" do
       shared_examples "it has role based abilities" do
         describe "when permissions are cached" do

data/spec/derivatives/multires_image_spec.rb

@@ -21,8 +21,14 @@ module Ddr::Derivatives
             expect(subject.generatable?(object)).to be_truthy
           end
         end
-        context 'content is not a tiff image' do
+        context 'content is a jpeg image' do
           before { allow(object).to receive(:content_type) { 'image/jpeg' } }
+          it "should be generatable" do
+            expect(subject.generatable?(object)).to be_truthy
+          end
+        end
+        context 'content is neither a tiff nor a jpeg image' do
+          before { allow(object).to receive(:content_type) { 'image/gif' } }
           it "should not be generatable" do
             expect(subject.generatable?(object)).to be_falsey
           end
@@ -45,4 +51,4 @@ module Ddr::Derivatives
 
     end
   end
-end
+end

data/spec/jobs/fixity_check_spec.rb

@@ -13,7 +13,7 @@ module Ddr::Jobs
         allow(ActiveFedora::Base).to receive(:find).with("test:1") { obj }
       end
       it "should call `fixity_check` on the object" do
-        expect(obj).to receive(:fixity_check)
+        expect(obj).to receive(:check_fixity)
         described_class.perform("test:1")
       end
     end

data/spec/managers/derivatives_manager_spec.rb

@@ -55,8 +55,16 @@ module Ddr
                 object.derivatives.update_derivatives(:now)
               end
             end
-            context "content is not tiff image" do
+            context "content is a jpeg image" do
               let(:file) { fixture_file_upload("bird.jpg", "image/jpeg") }
+              it "should generate a thumbnail and a ptif" do
+                expect(object.derivatives).to receive(:generate_derivative).with(Ddr::Derivatives::DERIVATIVES[:thumbnail])
+                expect(object.derivatives).to receive(:generate_derivative).with(Ddr::Derivatives::DERIVATIVES[:multires_image])
+                object.derivatives.update_derivatives(:now)
+              end
+            end
+            context "content is neither a tiff nor a jpeg image" do
+              let(:file) { fixture_file_upload("arrow1rightred_e0.gif", "image/gif") }
               it "should generate a thumbnail but not a ptif" do
                 expect(object.derivatives).to receive(:generate_derivative).with(Ddr::Derivatives::DERIVATIVES[:thumbnail])
                 expect(object.derivatives).to_not receive(:generate_derivative).with(Ddr::Derivatives::DERIVATIVES[:multires_image])

data/spec/models/attachment_spec.rb

@@ -5,5 +5,6 @@ RSpec.describe Attachment, type: :model, attachments: true do
   it_behaves_like "a DDR model"
   it_behaves_like "an object that can have content"
   it_behaves_like "a non-collection model"
+  it_behaves_like "an unpublishable object"
 
 end

data/spec/models/collection_spec.rb

@@ -3,6 +3,7 @@ require 'spec_helper'
 RSpec.describe Collection, type: :model do
 
   it_behaves_like "a DDR model"
+  it_behaves_like "a publishable object"
 
   describe "#components_from_solr" do
     subject { Collection.new(id: 'test-1') }

data/spec/models/component_spec.rb

@@ -5,6 +5,7 @@ RSpec.describe Component, type: :model, components: true do
   it_behaves_like "a DDR model"
   it_behaves_like "an object that can have content"
   it_behaves_like "a non-collection model"
+  it_behaves_like "a potentially publishable object"
 
   describe "indexing" do
     subject { FactoryGirl.build(:component) }

data/spec/models/has_admin_metadata_spec.rb

@@ -49,15 +49,29 @@ module Ddr::Models
       end
 
       describe "lifecycle" do
-        let!(:identifier) { Ezid::MockIdentifier.new(id: "ark:/99999/fk4zzz", status: "public") }
+        subject { FactoryGirl.create(:item) }
+        let!(:identifier) {
+          Ezid::MockIdentifier.create(subject.permanent_id_manager.default_metadata)
+        }
         before do
           allow(Ddr::Models).to receive(:auto_assign_permanent_ids) { false }
-          allow(Ezid::Identifier).to receive(:find).with("ark:/99999/fk4zzz") { identifier }
-          subject.permanent_id = "ark:/99999/fk4zzz"
+          allow(Ezid::Identifier).to receive(:find).with(identifier.id) { identifier }
+          subject.permanent_id = identifier.id
           subject.save!
         end
-        it "should update the status of the identifier when the object is destroyed" do
-          expect { subject.destroy }.to change(identifier, :status).from("public").to("unavailable | deleted")
+        describe "identifier creation" do
+          it "sets default metadata" do
+            expect(identifier.profile).to eq("dc")
+            expect(identifier.export).to eq("no")
+            expect(identifier["fcrepo3.pid"]).to eq(subject.pid)
+          end
+        end
+        describe "object destruction" do
+          it "marks the identifier as unavailable" do
+            expect { subject.destroy }
+              .to change(identifier, :status)
+                   .to("unavailable | deleted")
+          end
         end
       end
 
@@ -90,50 +104,57 @@ module Ddr::Models
 
     describe "workflow" do
 
-      subject { FactoryGirl.build(:item) }
+      let(:collection) { FactoryGirl.create(:collection) }
+      let(:item) { FactoryGirl.create(:item) }
+      let(:component) { FactoryGirl.create(:component) }
+      before do
+        item.parent = collection
+        item.save!
+        component.parent = item
+        component.save!
+      end
 
       describe "#published?" do
         context "object is published" do
-          before { allow(subject).to receive(:workflow_state) { Ddr::Managers::WorkflowManager::PUBLISHED } }
+          before { allow(collection).to receive(:workflow_state) { Ddr::Managers::WorkflowManager::PUBLISHED } }
           it "should return true" do
-            expect(subject).to be_published
+            expect(collection).to be_published
           end
         end
         context "object is not published" do
-          before { allow(subject).to receive(:workflow_state) { nil } }
+          before { allow(collection).to receive(:workflow_state) { nil } }
           it "should return false" do
-            expect(subject).not_to be_published
+            expect(collection).not_to be_published
           end
         end
       end
 
-      describe "#publish" do
-        it "should publish the object" do
-          subject.publish
-          expect(subject).to be_published
-        end
-      end
-
       describe "#publish!" do
-        it "should publish and persist the object" do
-          subject.publish!
-          expect(subject.reload).to be_published
+        context "do not include descendants" do
+          it "should publish and persist the object" do
+            collection.publish!(include_descendants: false)
+            expect(collection.reload).to be_published
+            expect(item.reload).not_to be_published
+            expect(component.reload).not_to be_published
+          end
         end
-      end
-
-      describe "#unpublish" do
-        before { subject.publish }
-        it "should unpublish the object" do
-          subject.unpublish
-          expect(subject).not_to be_published
+        context "do include descendants" do
+          it "should publish and persist the object and descendants" do
+            collection.publish!
+            expect(collection.reload).to be_published
+            expect(item.reload).to be_published
+            expect(component.reload).to be_published
+          end
         end
       end
 
       describe "#unpublish!" do
-        before { subject.publish! }
+        before { collection.publish! }
         it "should unpublish and persist the object" do
-          subject.unpublish!
-          expect(subject.reload).not_to be_published
+          collection.unpublish!
+          expect(collection.reload).not_to be_published
+          expect(item.reload).not_to be_published
+          expect(component.reload).not_to be_published
         end
       end
     end

data/spec/models/item_spec.rb

@@ -4,5 +4,6 @@ RSpec.describe Item, type: :model do
 
   it_behaves_like "a DDR model"
   it_behaves_like "a non-collection model"
+  it_behaves_like "a potentially publishable object"
 
 end

data/spec/models/target_spec.rb

@@ -5,5 +5,6 @@ RSpec.describe Target, type: :model, targets: true do
   it_behaves_like "a DDR model"
   it_behaves_like "an object that can have content"
   it_behaves_like "a non-collection model"
+  it_behaves_like "an unpublishable object"
 
 end

data/spec/support/shared_examples_for_fixity_checkable_spec.rb

@@ -1,15 +1,13 @@
 RSpec.shared_examples "a fixity checkable object" do
 
-  let(:object) { described_class.new }
-
   describe "fixity check" do
     before do
-      object.thumbnail.content = '1234567890'
-      object.save(validate: false)
+      subject.thumbnail.content = '1234567890'
+      subject.save(validate: false)
     end
-    it "should be able to perform a fixity check" do
-      expect(Ddr::Actions::FixityCheck.execute(object)).to_not be_nil
+    it "can check fixity" do
+      expect { subject.check_fixity }.to change(subject.fixity_checks, :count).from(0).to(1)
     end
   end
 
-end
+end

data/spec/support/shared_examples_for_publication.rb

@@ -0,0 +1,43 @@
+RSpec.shared_examples 'a publishable object' do
+  describe '#publishable?' do
+    let(:object) { described_class.new }
+    it 'should be publishable' do
+      expect(object.publishable?).to be true
+    end
+  end
+end
+
+RSpec.shared_examples 'an unpublishable object' do
+  describe '#publishable?' do
+    let(:object) { described_class.new }
+    it 'should not be publishable' do
+      expect(object.publishable?).to be false
+    end
+  end
+end
+
+RSpec.shared_examples 'a potentially publishable object' do
+  describe "#publishable?" do
+    let(:object) { described_class.new }
+    context "has parent" do
+      before { allow(object).to receive(:parent) { parent } }
+      context "parent is published" do
+        let(:parent) { double(published?: true) }
+        it "should be publishable" do
+          expect(object.publishable?).to be true
+        end
+      end
+      context "parent is not published" do
+        let(:parent) { double(published?: false) }
+        it "should not be publishable" do
+          expect(object.publishable?).to be false
+        end
+      end
+    end
+    context "does not have parent" do
+      it "should not be publishable" do
+        expect(object.publishable?).to be false
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ddr-models
 version: !ruby/object:Gem::Version
-  version: 3.0.0.beta.10
+  version: 3.0.0.beta.11
 platform: ruby
 authors:
 - Jim Coble
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-12 00:00:00.000000000 Z
+date: 2016-02-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -389,7 +389,6 @@ files:
 - Rakefile
 - app/controllers/users/omniauth_callbacks_controller.rb
 - app/controllers/users/sessions_controller.rb
-- app/helpers/models_helper.rb
 - app/models/.keep
 - app/models/attachment.rb
 - app/models/collection.rb
@@ -420,7 +419,6 @@ files:
 - ddr-models.gemspec
 - lib/ddr-models.rb
 - lib/ddr/actions.rb
-- lib/ddr/actions/fixity_check.rb
 - lib/ddr/actions/virus_check.rb
 - lib/ddr/auth.rb
 - lib/ddr/auth/ability.rb
@@ -432,6 +430,7 @@ files:
 - lib/ddr/auth/ability_definitions/datastream_ability_definitions.rb
 - lib/ddr/auth/ability_definitions/event_ability_definitions.rb
 - lib/ddr/auth/ability_definitions/item_ability_definitions.rb
+- lib/ddr/auth/ability_definitions/publication_ability_definitions.rb
 - lib/ddr/auth/ability_definitions/role_based_ability_definitions.rb
 - lib/ddr/auth/ability_definitions/superuser_ability_definitions.rb
 - lib/ddr/auth/ability_factory.rb
@@ -538,7 +537,6 @@ files:
 - lib/ddr/models/files/fits_xml_file.rb
 - lib/ddr/models/files/structural_metadata_file.rb
 - lib/ddr/models/finding_aid.rb
-- lib/ddr/models/fixity_checkable.rb
 - lib/ddr/models/governable.rb
 - lib/ddr/models/has_admin_metadata.rb
 - lib/ddr/models/has_attachments.rb
@@ -676,7 +674,6 @@ files:
 - spec/fixtures/sample.docx
 - spec/fixtures/sample.pdf
 - spec/fixtures/target.png
-- spec/helpers/models_helper_spec.rb
 - spec/index/fields_spec.rb
 - spec/index/filter_spec.rb
 - spec/index/query_builder_spec.rb
@@ -728,6 +725,7 @@ files:
 - spec/support/shared_examples_for_has_content.rb
 - spec/support/shared_examples_for_indexing.rb
 - spec/support/shared_examples_for_non_collection_models.rb
+- spec/support/shared_examples_for_publication.rb
 - spec/support/shared_examples_for_role_sets.rb
 - spec/support/structural_metadata_helper.rb
 - spec/utils_spec.rb
@@ -850,7 +848,6 @@ test_files:
 - spec/fixtures/sample.docx
 - spec/fixtures/sample.pdf
 - spec/fixtures/target.png
-- spec/helpers/models_helper_spec.rb
 - spec/index/fields_spec.rb
 - spec/index/filter_spec.rb
 - spec/index/query_builder_spec.rb
@@ -902,6 +899,7 @@ test_files:
 - spec/support/shared_examples_for_has_content.rb
 - spec/support/shared_examples_for_indexing.rb
 - spec/support/shared_examples_for_non_collection_models.rb
+- spec/support/shared_examples_for_publication.rb
 - spec/support/shared_examples_for_role_sets.rb
 - spec/support/structural_metadata_helper.rb
 - spec/utils_spec.rb

data/app/helpers/models_helper.rb

@@ -1,7 +0,0 @@
-module ModelsHelper
-
-  def admin_set_full_name(slug)
-    I18n.t("ddr.admin_set.#{slug}")
-  end
-
-end

data/lib/ddr/actions/fixity_check.rb

@@ -1,38 +0,0 @@
-module Ddr
-  module Actions
-    class FixityCheck
-
-      # Return result of fixity check - wrapped by a notifier
-      def self.execute(object)
-        ActiveSupport::Notifications.instrument(Ddr::Notifications::FIXITY_CHECK) do |payload|
-          payload[:result] = _execute(object)
-        end
-      end
-
-      # Return result of fixity check
-      def self._execute(object)
-        Result.new(id: object.id).tap do |r|
-          object.datastreams_to_validate.each do |dsid, ds|
-            # r.success &&= ds.dsChecksumValid
-            # r.results[dsid] = ds.profile
-            checksum_valid = ds.check_fixity
-            r.success &&= checksum_valid
-            r.results[dsid] = { 'checksum_valid' => checksum_valid }
-          end
-        end
-      end
-
-      class Result
-        attr_accessor :id, :success, :results, :checked_at
-
-        def initialize(args={})
-          @id = args[:id]
-          @success = args[:success] || true
-          @results = args[:results] || {}
-          @checked_at = args[:checked_at] || Time.now.utc
-        end
-      end
-
-    end
-  end
-end

data/lib/ddr/models/fixity_checkable.rb

@@ -1,32 +0,0 @@
-module Ddr
-  module Models
-    module FixityCheckable
-
-      def datastreams_to_validate
-        datastreams.select { |dsid, ds| ds.has_content? }
-      end
-
-      def fixity_checks
-        Ddr::Events::FixityCheckEvent.for_object(self)
-      end
-
-      # Returns a Ddr::Actions::FixityCheck::Result for the object
-      def fixity_check
-        Ddr::Actions::FixityCheck.execute(self)
-      end
-
-      def last_fixity_check
-        fixity_checks.last
-      end
-
-      def last_fixity_check_on
-        last_fixity_check && last_fixity_check.event_date_time
-      end
-
-      def last_fixity_check_outcome
-        last_fixity_check && last_fixity_check.outcome
-      end
-
-    end
-  end
-end

data/spec/helpers/models_helper_spec.rb

@@ -1,11 +0,0 @@
-require 'spec_helper'
-
-RSpec.describe ModelsHelper, type: :helper do
-
-  describe 'admin_set_full_name' do
-    it "should call I18n to translate the slug" do
-      expect(I18n).to receive(:t).with('ddr.admin_set.foo')
-      helper.admin_set_full_name('foo')
-    end
-  end
-end