dcu-devise 1.0.7

data/test/models/authenticatable_test.rb

@@ -0,0 +1,180 @@
+require 'test/test_helper'
+require 'digest/sha1'
+
+class AuthenticatableTest < ActiveSupport::TestCase
+
+  def encrypt_password(user, pepper=User.pepper, stretches=User.stretches, encryptor=::Devise::Encryptors::Sha1)
+    encryptor.digest('123456', stretches, user.password_salt, pepper)
+  end
+
+  test 'should respond to password and password confirmation' do
+    user = new_user
+    assert user.respond_to?(:password)
+    assert user.respond_to?(:password_confirmation)
+  end
+
+  test 'should generate encrypted password and salt while setting password' do
+    user = new_user
+    assert_present user.password_salt
+    assert_present user.encrypted_password
+  end
+
+  test 'should not change password salt when updating' do
+    user = create_user
+    salt = user.password_salt
+    user.expects(:password_salt=).never
+    user.save!
+    assert_equal salt, user.password_salt
+  end
+
+  test 'should generate a base64 hash using SecureRandom for password salt' do
+    ActiveSupport::SecureRandom.expects(:base64).with(15).returns('friendly_token')
+    assert_equal 'friendly_token', new_user.password_salt
+  end
+
+  test 'should not generate salt if password is blank' do
+    assert_blank new_user(:password => nil).password_salt
+    assert_blank new_user(:password => '').password_salt
+  end
+
+  test 'should not generate encrypted password if password is blank' do
+    assert_blank new_user(:password => nil).encrypted_password
+    assert_blank new_user(:password => '').encrypted_password
+  end
+
+  test 'should encrypt password again if password has changed' do
+    user = create_user
+    encrypted_password = user.encrypted_password
+    user.password = user.password_confirmation = 'new_password'
+    user.save!
+    assert_not_equal encrypted_password, user.encrypted_password
+  end
+
+  test 'should fallback to sha1 as default encryption' do
+    user = new_user
+    assert_equal encrypt_password(user), user.encrypted_password
+  end
+
+  test 'should fallback to devise pepper default configuration' do
+    begin
+      Devise.pepper = ''
+      user = new_user
+      assert_equal encrypt_password(user), user.encrypted_password
+      assert_not_equal encrypt_password(user, 'another_pepper'), user.encrypted_password
+
+      Devise.pepper = 'new_pepper'
+      user = new_user
+      assert_equal encrypt_password(user, 'new_pepper'), user.encrypted_password
+      assert_not_equal encrypt_password(user, 'another_pepper'), user.encrypted_password
+    ensure
+      Devise.pepper = nil
+    end
+  end
+
+  test 'should fallback to devise stretches default configuration' do
+    swap Devise, :stretches => 1 do
+      user = new_user
+      assert_equal encrypt_password(user, nil, 1), user.encrypted_password
+      assert_not_equal encrypt_password(user, nil, 2), user.encrypted_password
+    end
+  end
+
+  test 'should respect encryptor configuration' do
+    User.instance_variable_set(:@encryptor_class, nil)
+
+    swap Devise, :encryptor => :sha512 do
+      begin
+        user = create_user
+        assert_equal user.encrypted_password, encrypt_password(user, User.pepper, User.stretches, ::Devise::Encryptors::Sha512)
+      ensure
+        User.instance_variable_set(:@encryptor_class, nil)
+      end
+    end
+  end
+
+  test 'should test for a valid password' do
+    user = create_user
+    assert user.valid_password?('123456')
+    assert_not user.valid_password?('654321')
+  end
+
+  test 'should authenticate a valid user with email and password and return it' do
+    user = create_user
+    User.any_instance.stubs(:confirmed?).returns(true)
+    authenticated_user = User.authenticate(:email => user.email, :password => user.password)
+    assert_equal authenticated_user, user
+  end
+
+  test 'should return nil when authenticating an invalid user by email' do
+    user = create_user
+    authenticated_user = User.authenticate(:email => 'another.email@email.com', :password => user.password)
+    assert_nil authenticated_user
+  end
+
+  test 'should return nil when authenticating an invalid user by password' do
+    user = create_user
+    authenticated_user = User.authenticate(:email => user.email, :password => 'another_password')
+    assert_nil authenticated_user
+  end
+
+  test 'should use authentication keys to retrieve users' do
+    swap Devise, :authentication_keys => [:username] do
+      user = create_user
+      assert_nil User.authenticate(:email => user.email, :password => user.password)
+      assert_not_nil User.authenticate(:username => user.username, :password => user.password)
+    end
+  end
+
+  test 'should allow overwriting find for authentication conditions' do
+    admin = Admin.create!(valid_attributes)
+    assert_not_nil Admin.authenticate(:email => admin.email, :password => admin.password)
+  end
+
+  test 'should respond to current password' do
+    assert new_user.respond_to?(:current_password)
+  end
+
+  test 'should update password with valid current password' do
+    user = create_user
+    assert user.update_with_password(:current_password => '123456',
+      :password => 'pass321', :password_confirmation => 'pass321')
+    assert user.reload.valid_password?('pass321')
+  end
+
+  test 'should add an error to current password when it is invalid' do
+    user = create_user
+    assert_not user.update_with_password(:current_password => 'other',
+      :password => 'pass321', :password_confirmation => 'pass321')
+    assert user.reload.valid_password?('123456')
+    assert_match /invalid/, user.errors[:current_password]
+  end
+
+  test 'should add an error to current password when it is blank' do
+    user = create_user
+    assert_not user.update_with_password(:password => 'pass321',
+      :password_confirmation => 'pass321')
+    assert user.reload.valid_password?('123456')
+    assert_match /blank/, user.errors[:current_password]
+  end
+
+  test 'should ignore password and its confirmation if they are blank' do
+    user = create_user
+    assert user.update_with_password(:current_password => '123456', :email => "new@email.com")
+    assert_equal "new@email.com", user.email
+  end
+
+  test 'should not update password with invalid confirmation' do
+    user = create_user
+    assert_not user.update_with_password(:current_password => '123456',
+      :password => 'pass321', :password_confirmation => 'other')
+    assert user.reload.valid_password?('123456')
+  end
+
+  test 'should clean up password fields on failure' do
+    user = create_user
+    assert_not user.update_with_password(:current_password => '123456',
+      :password => 'pass321', :password_confirmation => 'other')
+    assert user.password.blank?
+    assert user.password_confirmation.blank?
+  end
+end

data/test/models/confirmable_test.rb

@@ -0,0 +1,212 @@
+require 'test/test_helper'
+
+class ConfirmableTest < ActiveSupport::TestCase
+
+  def setup
+    setup_mailer
+  end
+
+  test 'should generate confirmation token after creating a record' do
+    assert_nil new_user.confirmation_token
+    assert_not_nil create_user.confirmation_token
+  end
+
+  test 'should never generate the same confirmation token for different users' do
+    confirmation_tokens = []
+    3.times do
+      token = create_user.confirmation_token
+      assert !confirmation_tokens.include?(token)
+      confirmation_tokens << token
+    end
+  end
+
+  test 'should confirm a user by updating confirmed at' do
+    user = create_user
+    assert_nil user.confirmed_at
+    assert user.confirm!
+    assert_not_nil user.confirmed_at
+  end
+
+  test 'should clear confirmation token while confirming a user' do
+    user = create_user
+    assert_present user.confirmation_token
+    user.confirm!
+    assert_nil user.confirmation_token
+  end
+
+  test 'should verify whether a user is confirmed or not' do
+    assert_not new_user.confirmed?
+    user = create_user
+    assert_not user.confirmed?
+    user.confirm!
+    assert user.confirmed?
+  end
+
+  test 'should not confirm a user already confirmed' do
+    user = create_user
+    assert user.confirm!
+    assert_nil user.errors[:email]
+
+    assert_not user.confirm!
+    assert_match /already confirmed/, user.errors[:email]
+  end
+
+  test 'should find and confirm an user automatically' do
+    user = create_user
+    confirmed_user = User.confirm_by_token(user.confirmation_token)
+    assert_equal confirmed_user, user
+    assert user.reload.confirmed?
+  end
+
+  test 'should return a new record with errors when a invalid token is given' do
+    confirmed_user = User.confirm_by_token('invalid_confirmation_token')
+    assert confirmed_user.new_record?
+    assert_match /invalid/, confirmed_user.errors[:confirmation_token]
+  end
+
+  test 'should return a new record with errors when a blank token is given' do
+    confirmed_user = User.confirm_by_token('')
+    assert confirmed_user.new_record?
+    assert_match /blank/, confirmed_user.errors[:confirmation_token]
+  end
+
+  test 'should generate errors for a user email if user is already confirmed' do
+    user = create_user
+    user.confirmed_at = Time.now
+    user.save
+    confirmed_user = User.confirm_by_token(user.confirmation_token)
+    assert confirmed_user.confirmed?
+    assert confirmed_user.errors[:email]
+  end
+
+  test 'should authenticate a confirmed user' do
+    user = create_user
+    user.confirm!
+    authenticated_user = User.authenticate(:email => user.email, :password => user.password)
+    assert_equal authenticated_user, user
+  end
+
+  test 'should send confirmation instructions by email' do
+    assert_email_sent do
+      create_user
+    end
+  end
+
+  test 'should not send confirmation when trying to save an invalid user' do
+    assert_email_not_sent do
+      user = new_user
+      user.stubs(:valid?).returns(false)
+      user.save
+    end
+  end
+
+  test 'should not generate a new token neither send e-mail if skip_confirmation! is invoked' do
+    user = new_user
+    user.skip_confirmation!
+
+    assert_email_not_sent do
+      user.save!
+      assert_nil user.confirmation_token
+      assert_not_nil user.confirmed_at
+    end
+  end
+
+  test 'should find a user to send confirmation instructions' do
+    user = create_user
+    confirmation_user = User.send_confirmation_instructions(:email => user.email)
+    assert_equal confirmation_user, user
+  end
+
+  test 'should return a new user if no email was found' do
+    confirmation_user = User.send_confirmation_instructions(:email => "invalid@email.com")
+    assert confirmation_user.new_record?
+  end
+
+  test 'should add error to new user email if no email was found' do
+    confirmation_user = User.send_confirmation_instructions(:email => "invalid@email.com")
+    assert confirmation_user.errors[:email]
+    assert_equal 'not found', confirmation_user.errors[:email]
+  end
+
+  test 'should send email instructions for the user confirm it\'s email' do
+    user = create_user
+    assert_email_sent do
+      User.send_confirmation_instructions(:email => user.email)
+    end
+  end
+
+  test 'should not resend email instructions if the user change his email' do
+    user = create_user
+    user.email = 'new_test@example.com'
+    assert_email_not_sent do
+      user.save!
+    end
+  end
+
+  test 'should not reset confirmation status or token when updating email' do
+    user = create_user
+    user.confirm!
+    user.email = 'new_test@example.com'
+    user.save!
+
+    user.reload
+    assert user.confirmed?
+    assert_nil user.confirmation_token
+  end
+
+  test 'should not be able to send instructions if the user is already confirmed' do
+    user = create_user
+    user.confirm!
+    assert_not user.resend_confirmation_token
+    assert user.confirmed?
+    assert_equal 'already confirmed', user.errors[:email]
+  end
+
+  test 'confirm time should fallback to devise confirm in default configuration' do
+    swap Devise, :confirm_within => 1.day do
+      user = new_user
+      user.confirmation_sent_at = 2.days.ago
+      assert_not user.active?
+
+      Devise.confirm_within = 3.days
+      assert user.active?
+    end
+  end
+
+  test 'should be active when confirmation sent at is not overpast' do
+    swap Devise, :confirm_within => 5.days do
+      Devise.confirm_within = 5.days
+      user = create_user
+
+      user.confirmation_sent_at = 4.days.ago
+      assert user.active?
+
+      user.confirmation_sent_at = 5.days.ago
+      assert_not user.active?
+    end
+  end
+
+  test 'should be active when already confirmed' do
+    user = create_user
+    assert_not user.confirmed?
+    assert_not user.active?
+
+    user.confirm!
+    assert user.confirmed?
+    assert user.active?
+  end
+
+  test 'should not be active when confirm in is zero' do
+    Devise.confirm_within = 0.days
+    user = create_user
+    user.confirmation_sent_at = Date.today
+    assert_not user.reload.active?
+  end
+
+  test 'should not be active without confirmation' do
+    user = create_user
+    user.confirmation_sent_at = nil
+    user.save
+    assert_not user.reload.active?
+  end
+end

data/test/models/lockable_test.rb

@@ -0,0 +1,202 @@
+require 'test/test_helper'
+
+class LockableTest < ActiveSupport::TestCase
+
+  def setup
+    setup_mailer
+  end
+
+  test "should increment failed attempts on unsuccessful authentication" do
+    user = create_user
+    assert_equal 0, user.failed_attempts
+    authenticated_user = User.authenticate(:email => user.email, :password => "anotherpassword")
+    assert_equal 1, user.reload.failed_attempts
+  end
+
+  test "should lock account base on maximum_attempts" do
+    user = create_user
+    attempts = Devise.maximum_attempts + 1
+    attempts.times { authenticated_user = User.authenticate(:email => user.email, :password => "anotherpassword") }
+    assert user.reload.access_locked?
+  end
+
+  test "should respect maximum attempts configuration" do
+    user = create_user
+    swap Devise, :maximum_attempts => 2 do
+      3.times { authenticated_user = User.authenticate(:email => user.email, :password => "anotherpassword") }
+      assert user.reload.access_locked?
+    end
+  end
+
+  test "should clear failed_attempts on successfull sign in" do
+    user = create_user
+    User.authenticate(:email => user.email, :password => "anotherpassword")
+    assert_equal 1, user.reload.failed_attempts
+    User.authenticate(:email => user.email, :password => "123456")
+    assert_equal 0, user.reload.failed_attempts
+  end
+
+  test "should verify whether a user is locked or not" do
+    user = create_user
+    assert_not user.access_locked?
+    user.lock_access!
+    assert user.access_locked?
+  end
+
+  test "active? should be the opposite of locked?" do
+    user = create_user
+    user.confirm!
+    assert user.active?
+    user.lock_access!
+    assert_not user.active?
+  end
+
+  test "should unlock an user by cleaning locked_at, falied_attempts and unlock_token" do
+    user = create_user
+    user.lock_access!
+    assert_not_nil user.reload.locked_at
+    assert_not_nil user.reload.unlock_token
+
+    user.unlock_access!
+    assert_nil user.reload.locked_at
+    assert_nil user.reload.unlock_token
+    assert 0, user.reload.failed_attempts
+  end
+
+  test "should not lock a locked account" do
+    user = create_user
+    user.lock_access!
+    assert_no_difference "ActionMailer::Base.deliveries.size" do
+      user.lock_access!
+    end
+  end
+
+  test 'should not unlock an unlocked user' do
+    user = create_user
+
+    assert_not user.unlock_access!
+    assert_match /not locked/, user.errors[:email]
+  end
+
+  test "new user should not be locked and should have zero failed_attempts" do
+    assert_not new_user.access_locked?
+    assert_equal 0, create_user.failed_attempts
+  end
+
+  test "should unlock user after unlock_in period" do
+    swap Devise, :unlock_in => 3.hours do
+      user = new_user
+      user.locked_at = 2.hours.ago
+      assert user.access_locked?
+
+      Devise.unlock_in = 1.hour
+      assert_not user.access_locked?
+    end
+  end
+
+  test "should not unlock in 'unlock_in' if :time unlock strategy is not set" do
+    swap Devise, :unlock_strategy => :email do
+      user = new_user
+      user.locked_at = 2.hours.ago
+      assert user.access_locked?
+    end
+  end
+
+  test "should set unlock_token when locking" do
+    user = create_user
+    assert_nil user.unlock_token
+    user.lock_access!
+    assert_not_nil user.unlock_token
+  end
+
+  test "should never generate the same unlock token for different users" do
+    unlock_tokens = []
+    3.times do
+      user = create_user
+      user.lock_access!
+      token = user.unlock_token
+      assert !unlock_tokens.include?(token)
+      unlock_tokens << token
+    end
+  end
+
+  test "should not generate unlock_token when :email is not an unlock strategy" do
+    swap Devise, :unlock_strategy => :time do
+      user = create_user
+      user.lock_access!
+      assert_nil user.unlock_token
+    end
+  end
+
+  test "should send email with unlock instructions when :email is an unlock strategy" do
+    swap Devise, :unlock_strategy => :email do
+      user = create_user
+      assert_email_sent do
+        user.lock_access!
+      end
+    end
+  end
+
+  test "should not send email with unlock instructions when :email is not an unlock strategy" do
+    swap Devise, :unlock_strategy => :time do
+      user = create_user
+      assert_email_not_sent do
+        user.lock_access!
+      end
+    end
+  end
+
+  test 'should find and unlock an user automatically' do
+    user = create_user
+    user.lock_access!
+    locked_user = User.unlock_access_by_token(user.unlock_token)
+    assert_equal locked_user, user
+    assert_not user.reload.access_locked?
+  end
+
+  test 'should return a new record with errors when a invalid token is given' do
+    locked_user = User.unlock_access_by_token('invalid_token')
+    assert locked_user.new_record?
+    assert_match /invalid/, locked_user.errors[:unlock_token]
+  end
+
+  test 'should return a new record with errors when a blank token is given' do
+    locked_user = User.unlock_access_by_token('')
+    assert locked_user.new_record?
+    assert_match /blank/, locked_user.errors[:unlock_token]
+  end
+
+  test 'should authenticate a unlocked user' do
+    user = create_user
+    user.lock_access!
+    user.unlock_access!
+    authenticated_user = User.authenticate(:email => user.email, :password => user.password)
+    assert_equal authenticated_user, user
+  end
+
+  test 'should find a user to send unlock instructions' do
+    user = create_user
+    user.lock_access!
+    unlock_user = User.send_unlock_instructions(:email => user.email)
+    assert_equal unlock_user, user
+  end
+
+  test 'should return a new user if no email was found' do
+    unlock_user = User.send_unlock_instructions(:email => "invalid@email.com")
+    assert unlock_user.new_record?
+  end
+
+  test 'should add error to new user email if no email was found' do
+    unlock_user = User.send_unlock_instructions(:email => "invalid@email.com")
+    assert unlock_user.errors[:email]
+    assert_equal 'not found', unlock_user.errors[:email]
+  end
+
+  test 'should not be able to send instructions if the user is not locked' do
+    user = create_user
+    assert_not user.resend_unlock_token
+    assert_not user.access_locked?
+    assert_equal 'not locked', user.errors[:email]
+  end
+
+end