dcm_dict 0.29.0

data/spec/dcm_dict/refine/internal/hash_refine_internal_spec.rb

@@ -0,0 +1,64 @@
+#
+#  Copyright (C) 2014-2020  Enrico Rivarola
+#
+#  This file is part of DcmDict gem (dcm_dict).
+#
+#  DcmDict is free software: you can redistribute it and/or modify
+#  it under the terms of the GNU General Public License as published by
+#  the Free Software Foundation, either version 3 of the License, or
+#  (at your option) any later version.
+#
+#  DcmDict is distributed in the hope that it will be useful,
+#  but WITHOUT ANY WARRANTY; without even the implied warranty of
+#  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#  GNU General Public License for more details.
+#
+#  You should have received a copy of the GNU General Public License
+#  along with DcmDict.  If not, see <http://www.gnu.org/licenses/>.
+#
+#  This software has neither been tested nor approved for clinical use
+#  or for incorporation in a medical device.
+#  It is the redistributor's or user's responsibility to comply with any
+#  applicable local, state, national or international regulations.
+#
+require 'spec_helper'
+
+describe "Hash internal refinement" do
+  using DcmDict::Refine::Internal::HashRefineInternal
+
+  it "should check for lowercase tag_ps field" do
+    h = {tag_ps: '(fffe,E000)'}
+    h.check_tag_ps!
+    expect(h).to eq({tag_ps: '(FFFE,E000)'})
+  end
+
+  it "should check for missing tag_ps field" do
+    expect{ {tag_ps: ''}.check_tag_ps! }.to raise_error("Missing tag_ps field")
+    expect{ {}.check_tag_ps! }.to raise_error("Missing tag_ps field")
+  end
+
+  context "Placeholders data: no Name or Keyword or VR or VM is specified" do
+    {
+      { tag_ps: '(0018,9445)', tag_name: '', tag_key: '', tag_vr: [], tag_vm: [], tag_note: 'RET - See Note' } => { tag_ps: '(0018,9445)', tag_name: "Placeholder (0018,9445)", tag_key: 'Placeholder_0018_9445', tag_vr: [:UN], tag_vm: ["1"], tag_note: 'RET - See Note'},
+      { tag_ps: '(0018,9445)', tag_name: '', tag_key: '', tag_vm: [], tag_note: 'RET - See Note' } => { tag_ps: '(0018,9445)', tag_name: "Placeholder (0018,9445)", tag_key: 'Placeholder_0018_9445', tag_vr: [:UN], tag_vm: ["1"], tag_note: 'RET - See Note'},
+      { tag_ps: '(0018,9445)', tag_name: '', tag_key: '', tag_vr: [], tag_note: 'RET - See Note' } => { tag_ps: '(0018,9445)', tag_name: "Placeholder (0018,9445)", tag_key: 'Placeholder_0018_9445', tag_vr: [:UN], tag_vm: ["1"], tag_note: 'RET - See Note'},
+      { tag_ps: '(0018,9445)', tag_key: '', tag_vr: [], tag_vm: [], tag_note: 'RET - See Note' } => { tag_ps: '(0018,9445)', tag_name: "Placeholder (0018,9445)", tag_key: 'Placeholder_0018_9445', tag_vr: [:UN], tag_vm: ["1"], tag_note: 'RET - See Note'},
+      { tag_ps: '(0018,9445)', tag_name: '', tag_vr: [], tag_vm: [], tag_note: 'RET - See Note' } => { tag_ps: '(0018,9445)', tag_name: "Placeholder (0018,9445)", tag_key: 'Placeholder_0018_9445', tag_vr: [:UN], tag_vm: ["1"], tag_note: 'RET - See Note'},
+    }.each do |src_data, expected_data|
+      it "should check for placeholder data (#{src_data[:tag_ps].inspect} with keys #{src_data.keys.inspect})" do
+        src_data.check_placeholder_data!
+        expect(src_data).to eq(expected_data)
+      end
+    end
+
+    [
+      { tag_ps: '', tag_name: '', tag_key: '', tag_vr: [], tag_vm: [], tag_note: 'RET - See Note' },
+      { tag_name: '', tag_key: '', tag_vr: [], tag_vm: [], tag_note: 'RET - See Note' }
+    ].each do |data|
+      it "should raise error if :tag_ps field is missing (tag_ps=#{data[:tag_ps].inspect})" do
+        expect{data.check_placeholder_data!}.to raise_error("Missing tag_ps field")
+      end
+    end
+
+  end
+end

data/spec/dcm_dict/refine/internal/string_refine_internal_spec.rb

@@ -0,0 +1,228 @@
+# coding: utf-8
+#
+#  Copyright (C) 2014-2020  Enrico Rivarola
+#
+#  This file is part of DcmDict gem (dcm_dict).
+#
+#  DcmDict is free software: you can redistribute it and/or modify
+#  it under the terms of the GNU General Public License as published by
+#  the Free Software Foundation, either version 3 of the License, or
+#  (at your option) any later version.
+#
+#  DcmDict is distributed in the hope that it will be useful,
+#  but WITHOUT ANY WARRANTY; without even the implied warranty of
+#  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#  GNU General Public License for more details.
+#
+#  You should have received a copy of the GNU General Public License
+#  along with DcmDict.  If not, see <http://www.gnu.org/licenses/>.
+#
+#  This software has neither been tested nor approved for clinical use
+#  or for incorporation in a medical device.
+#  It is the redistributor's or user's responsibility to comply with any
+#  applicable local, state, national or international regulations.
+#
+require 'spec_helper'
+
+describe "String refinement (internal)" do
+
+  using DcmDict::Refine::Internal::StringRefineInternal
+  describe "should remove unwanted space characters" do
+
+    [
+      ["FileSetDescriptorFileID ", "trailing spaces"],
+      ["  FileSetDescriptorFileID", "leading spaces"],
+      ["  FileSetDescriptorFileID  ", "leading and trailing spaces"],
+      ["File​Set​Descriptor​FileID", "zero width spaces"],
+      ["  File​Set​Descriptor​FileID  ", "leading, trailing and zero width spaces"]
+    ].each do |wrong_string, comment|
+      it "for string containing #{comment}" do
+        expect(wrong_string.dcm_unspace).to eq('FileSetDescriptorFileID')
+      end
+    end
+  end
+
+  describe "should convert keyword tag string to symbol object" do
+    [
+      ['DarkCurrentCounts', :dark_current_counts],
+      ['InstanceCreationDate', :instance_creation_date],
+      ['RecognitionCode', :recognition_code],
+      ['CoefficientsSDVN', :coefficients_sdvn],
+      ['OffsetOfReferencedLowerLevelDirectoryEntity', :offset_of_referenced_lower_level_directory_entity],
+      ['FileSetDescriptorFileID', :file_set_descriptor_file_id],
+      ['SOPClassUID', :sop_class_uid],
+      ['RelatedGeneralSOPClassUID', :related_general_sop_class_uid],
+      ['ReferencedSOPClassUIDInFile', :referenced_sop_class_uid_in_file],
+      ['MAUsedInGainCalibration', :ma_used_in_gain_calibration],
+      ['OtherPatientIDsSequence', :other_patient_ids_sequence],
+      ['RelativeXRayExposure', :relative_x_ray_exposure],
+      ['DisplayedZValue', :displayed_z_value],
+      ['PhysicalUnitsXDirection', :physical_units_x_direction],
+      ['XRay3DFrameTypeSequence', :x_ray_3d_frame_type_sequence],
+      ['SOPInstanceUIDOfConcatenationSource',  :sop_instance_uid_of_concatenation_source],
+      ['RowsForNthOrderCoefficients', :rows_for_nth_order_coefficients],
+      ['EquivalentCDADocumentSequence', :equivalent_cda_document_sequence],
+      ['ALineRate', :a_line_rate],
+      ['ThreeDPointCoordinates', :three_d_point_coordinates],
+      ['SourceImageIDs', :source_image_ids],
+      ['ModifyingDeviceID', :modifying_device_id],
+      ['TIDOffset', :tid_offset],
+      ['RT_ROIRelationship', :rt_roi_relationship],
+      ['DVHROIContributionType', :dvh_roi_contribution_type],
+      ['OCTZOffsetCorrection', :oct_z_offset_correction],
+      ['WADORSRetrievalSequence', :wado_rs_retrieval_sequence],
+      ['STOWRSStorageSequence', :stow_rs_storage_sequence],
+      ['CIExyWhitePoint', :ciexy_white_point],
+      ['RGBLUTTransferFunction', :rgb_lut_transfer_function],
+      ['ReferencedVOILUTBoxSequence', :referenced_voi_lut_box_sequence],
+      ['CTDIvolNotificationTrigger', :ctdi_vol_notification_trigger],
+      ['XAXRFFrameCharacteristicsSequence', :xa_xrf_frame_characteristics_sequence],
+      ['XRayTubeCurrentInuA', :x_ray_tube_current_in_ua],
+      ['ExposureTimeInuS', :exposure_time_in_us],
+      ['ExposureInuAs', :exposure_in_uas],
+      ['dBdt', :db_dt]
+    ].each do |str, value|
+      it "from #{str.inspect} to #{value.inspect}" do
+        expect(str.tag_key_to_sym).to eq(value)
+      end
+    end
+  end
+
+  describe "should convert standard string tag" do
+    [
+      ['(0014,3050)', '00143050', [0x0014,0x3050]],
+      ['(0008,0012)', '00080012', [0x0008,0x0012]],
+      ['(FFFE,E00D)', 'FFFEE00D', [0xfffe,0xe00d]]
+    ].each do |str, value_str, value_ary|
+      it "from #{str.inspect} to a numeric string tag as #{value_str.inspect}" do
+        expect(str.to_tag_ndm).to eq(value_str)
+      end
+
+      it "from #{str.inspect} to an array object as #{value_ary.inspect}" do
+        expect(str.to_tag_ary).to eq(value_ary)
+      end
+    end
+  end
+
+  {
+    '(0010,0020)'=> [0x0010,0x0020],
+    '00100020' => [0x0010,0x0020]
+
+  }.each do |src, expected_val|
+    it "should implement to_tag_ary metod" do
+      expect(src.to_tag_ary).to eq(expected_val)
+    end
+  end
+
+  {
+    '(0010,0020)'=> '(0010,0020)',
+    '00100020' => '(0010,0020)'
+
+  }.each do |src, expected_val|
+    it "should implement to_tag_str method" do
+      expect(src.to_tag_str).to eq(expected_val)
+    end
+  end
+
+  {
+    '(0010,0020)'=> [0x0010,0x0020],
+    '00100020' => [0x0010,0x0020]
+
+  }.each do |src, expected_val|
+    it "should implement tag_group_num and tag_element_num method" do
+      expect(src.tag_group_num).to eq(expected_val[0])
+      expect(src.tag_element_num).to eq(expected_val[1])
+    end
+  end
+
+  {
+    '(0010,0020)'=> ['0010','0020'],
+    '00100020' => ['0010','0020'],
+    '(FFFE,E000)'=> ['FFFE','E000'],
+
+  }.each do |src, expected_val|
+    it "should implement tag_group_str and tag_element_str method" do
+      expect(src.tag_group_str).to eq(expected_val[0])
+      expect(src.tag_element_str).to eq(expected_val[1])
+    end
+  end
+
+  [
+    '(0010,00208)',
+    'abracadabra',
+    Time.now.to_s,
+    '(1ffff,123)',
+    '(123,1fff0)'
+  ].each do |src|
+    it "should manage wrong value #{src.inspect}" do
+      expect{src.to_tag_str}.to raise_error(RuntimeError)
+      expect{src.to_tag_ndm}.to raise_error(RuntimeError)
+      expect{src.to_tag_ary}.to raise_error(RuntimeError)
+    end
+  end
+
+  {
+    'SOP Class' => :sop_class,
+    'Transfer Syntax' => :transfer_syntax,
+    'Well-known frame of reference' => :well_known_frame_of_reference,
+    'Well-known SOP Instance' => :well_known_sop_instance,
+    'DICOM UIDs as a Coding Scheme' => :dicom_uids_as_a_coding_scheme,
+    'Coding Scheme' => :coding_scheme,
+    'Query/Retrieve' => :query_retrieve,
+    'LDAP OID' => :ldap_oid
+
+
+  }.each do |src, expected_val|
+    it "should implement uid_type_to_sym method #{src.inspect} > #{expected_val.inspect}" do
+      expect(src.uid_type_to_sym).to eq(expected_val)
+    end
+  end
+
+  {
+    '1.2.3.4.5.6' => true,
+    'not uid string' => false,
+    '0.1.2.3.4' => true,
+    '1.2.3456.789.0.1.2.3' => true,
+    '1.2.3.4.5.6.7.8.9.0.1.2.3.4.5.6.7.8.9.0.1.2.3.4.5.6.7.8.9.0.1.2.3' => false,
+    '1,2.3' => false,
+    '1.2.3.04.5' => false
+  }.each do |string, expected_as_uid|
+    it "should check for UID string #{string.inspect} -> #{expected_as_uid}" do
+      expect(string.uid_value?).to eq(expected_as_uid)
+    end
+  end
+
+  describe "should check for group-length tag" do
+    {
+      "00100020" => false,
+      "(0010,0020)" => false,
+      "00100000" => true,
+      "(0010,0000)" => true,
+      "00000002" => false,
+      "(0000,0002)" => false,
+      "00000000" => true,
+      "(0000,0000)" => true
+    }.each do |tag, value|
+      it "for #{tag.inspect}" do
+        expect(tag.group_length_tag?).to eq(value)
+      end
+    end
+  end
+
+  describe "should check for private-creator tag" do
+    {
+      '00100010' => false,
+      '(0010,0010)' => false,
+      '00110010' => true,
+      '(0011,0010)' => true,
+      '00110110' => false,
+      '(0011,0110)' => false,
+      '00282468' => false,
+      '(0028,2468)' => false
+    }.each do |tag, value|
+      it "for #{tag.inspect}" do
+        expect(tag.private_creator_tag?).to eq(value)
+      end
+    end
+  end
+end

data/spec/dcm_dict/refine/string_refine_spec.rb

@@ -0,0 +1,87 @@
+#
+#  Copyright (C) 2014-2020  Enrico Rivarola
+#
+#  This file is part of DcmDict gem (dcm_dict).
+#
+#  DcmDict is free software: you can redistribute it and/or modify
+#  it under the terms of the GNU General Public License as published by
+#  the Free Software Foundation, either version 3 of the License, or
+#  (at your option) any later version.
+#
+#  DcmDict is distributed in the hope that it will be useful,
+#  but WITHOUT ANY WARRANTY; without even the implied warranty of
+#  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#  GNU General Public License for more details.
+#
+#  You should have received a copy of the GNU General Public License
+#  along with DcmDict.  If not, see <http://www.gnu.org/licenses/>.
+#
+#  This software has neither been tested nor approved for clinical use
+#  or for incorporation in a medical device.
+#  It is the redistributor's or user's responsibility to comply with any
+#  applicable local, state, national or international regulations.
+#
+require 'spec_helper'
+
+describe "String refinement" do
+  using DcmDict::Refine::StringRefine
+  describe "should permit access to single data element dictionary information" do
+
+    include_examples "refinement for standard tag",
+                     ["(0010,1005)", "Patient's Birth Name", "PatientBirthName", "(0010,1005)", "00101005",
+                      '(60XX,0040)', "Overlay Type", "OverlayType", "(6022,0040)", "60220040",
+                      '(0028,1200)', "Gray Lookup Table Data", "GrayLookupTableData", "(0028,1200)", "00281200",
+                      '(0014,3050)', "Dark Current Counts", "DarkCurrentCounts", "(0014,3050)", "00143050",
+                     ],
+                     Proc.new{|tag| tag.inspect}
+
+
+    multi_str_data = { '(6046,0040)' => {
+                         tag_multiple: true,
+                         tag_name: "Overlay Type",
+                         tag_keyword: "OverlayType",
+                         tag_key: "OverlayType",
+                         tag_vr: [:CS], tag_vm: ["1"],
+                         tag: [0x6046, 0x0040], tag_ary: [0x6046, 0x0040],
+                         tag_ps: "(60XX,0040)",
+                         tag_sym: :overlay_type,
+                         tag_ndm: "60460040",
+                         tag_str: "(6046,0040)",
+                         tag_group: 0x6046,
+                         tag_element: 0x0040 } }
+
+    include_examples "refinement for multiple tag",
+                     multi_str_data,
+                     Proc.new {|tag| tag.inspect}
+
+  end
+
+
+  describe "should permit access to single data uid dictionary information" do
+    describe "for regular uids" do
+      [
+        '1.2.840.10008.1.1', "Verification SOP Class",
+        '1.2.840.10008.1.2.1', "Explicit VR Little Endian",
+        '1.2.840.10008.5.1.4.1.2.1.1', "Patient Root Query/Retrieve Information Model - FIND",
+        '1.2.3.4.5.6'
+      ].each do |uid|
+        describe "as #{uid.inspect}" do
+          obj = DcmDict::Dictionary::TheUidDictionary.record_at(uid)
+          DcmDict::Dictionary::UidMethod.each do |method|
+            expr = "#{uid.inspect}.#{method.to_s}"
+            it "with #{expr} > #{obj.send(method).inspect}" do
+              value = eval(expr)
+              expect(value).to eq(obj.send(method))
+            end
+          end
+        end
+      end
+    end
+  end
+
+  include_examples "Raise exception for wrong input",
+                   [ '123g123m' ],
+                   [ 'this string is not an uid' ],
+                   Proc.new {|tag| tag.inspect}
+
+end

data/spec/dcm_dict/refine/symbol_refine_spec.rb

@@ -0,0 +1,41 @@
+#
+#  Copyright (C) 2014-2020  Enrico Rivarola
+#
+#  This file is part of DcmDict gem (dcm_dict).
+#
+#  DcmDict is free software: you can redistribute it and/or modify
+#  it under the terms of the GNU General Public License as published by
+#  the Free Software Foundation, either version 3 of the License, or
+#  (at your option) any later version.
+#
+#  DcmDict is distributed in the hope that it will be useful,
+#  but WITHOUT ANY WARRANTY; without even the implied warranty of
+#  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#  GNU General Public License for more details.
+#
+#  You should have received a copy of the GNU General Public License
+#  along with DcmDict.  If not, see <http://www.gnu.org/licenses/>.
+#
+#  This software has neither been tested nor approved for clinical use
+#  or for incorporation in a medical device.
+#  It is the redistributor's or user's responsibility to comply with any
+#  applicable local, state, national or international regulations.
+#
+require 'spec_helper'
+
+describe "Symbol refinement" do
+  using DcmDict::Refine::SymbolRefine
+  describe "should permit access to single data element dictionary information" do
+
+    include_examples "refinement for standard tag",
+                     [:patient_birth_name, :gray_lookup_table_data, :dark_current_counts],
+                     Proc.new{|tag| tag.inspect}
+
+  end
+
+  include_examples "Raise exception for wrong input",
+                   [ :wrong_data_element ],
+                   [],
+                   Proc.new {|tag| tag.inspect}
+
+end

data/spec/dcm_dict/rubies/rb_ext_spec.rb

@@ -0,0 +1,46 @@
+#
+#  Copyright (C) 2014-2020  Enrico Rivarola
+#
+#  This file is part of DcmDict gem (dcm_dict).
+#
+#  DcmDict is free software: you can redistribute it and/or modify
+#  it under the terms of the GNU General Public License as published by
+#  the Free Software Foundation, either version 3 of the License, or
+#  (at your option) any later version.
+#
+#  DcmDict is distributed in the hope that it will be useful,
+#  but WITHOUT ANY WARRANTY; without even the implied warranty of
+#  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#  GNU General Public License for more details.
+#
+#  You should have received a copy of the GNU General Public License
+#  along with DcmDict.  If not, see <http://www.gnu.org/licenses/>.
+#
+#  This software has neither been tested nor approved for clinical use
+#  or for incorporation in a medical device.
+#  It is the redistributor's or user's responsibility to comply with any
+#  applicable local, state, national or international regulations.
+#
+require 'spec_helper'
+
+describe "Rubies dedicate extension" do
+  it "should check for Fixnum::bit_length method" do
+    {(-2**12-1) => 13,
+     (-2**12)   => 12,
+     (-2**12+1) => 12,
+     -0x101    => 9,
+     -0x100    => 8,
+     -0xff     => 8,
+     -2        => 1,
+     -1        => 0,
+     0         => 0,
+     1         => 1,
+     0xff      => 8,
+     0x100     => 9,
+     (2**12-1) => 12,
+     (2**12)   => 13,
+     (2**12+1) => 13}.each do |num, expected_bit_length|
+      expect(num.bit_length).to eq(expected_bit_length)
+    end
+  end
+end