dcidev_approval 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b89d5bed50149b2067004980c70e15f4a4dd63eb4af17c18bbcb1f9a40fe592e
-  data.tar.gz: 4fd39a2c3f38e2635c40035d4d2dcd07f524e74a742f3ca4018153edab7cb4cb
+  metadata.gz: a68030ef24f3a7e3ef969c1aad28d6f73eb5d3ee51ae483cd6278524b89c5c6b
+  data.tar.gz: 191f42224f68dcb99f5ae3efae7f2ed2967b9405feeba9dee4335367884342d0
 SHA512:
-  metadata.gz: a4f1bf7253a23ed2b65a839d3f572f148430fc561c1eec01496cf83ec05d0f2056310c470bbd56fdd044faefe8c263b8704377ffc9be84c431140f7be24abf0c
-  data.tar.gz: f9d5add77f39eb625a564eddf8c33a6a9977ed2ec3f913fa7712527fe9f051c74bafbbaa5b76e266850b076fb6f95e1a98e50bcedb3d1ff8042553f11b573d7a
+  metadata.gz: 571a57ad5daa96bcb61f36db973c8f35126c70ca6c229128a329273f8aeb3985000de6efeb588bbe4075b3d4a41b3fd118bfca5042bf78b896c651d3ed4c191b
+  data.tar.gz: 889b71359e05516fe125ea4422424e07026ac0df5c5ae5ff1adff09a525c078ea98c3053fd30c7d5f1b900db2cfcbf385b3f9df76c1c952131a9362bd7e1a44a

data/lib/dcidev_approval.rb

@@ -44,7 +44,7 @@ module DcidevApproval
         log = self.activity_logs.where("activity LIKE '%edit%'").limit(1).order(created_at: :desc).try(:first)
       end
       {
-        modified_by: log.present? ? log.try(:agent).try(:name).to_s + " (#{log.try(:agent).try(:username).to_s}[#{log.try(:agent).try(:roles).try(:first).try(:name)}])" : nil,
+        modified_by: log.present? ? log.try(:agent).try(:name).to_s + " (#{log.try(:agent).try(:username).to_s}[#{log.try(:agent).try(:roles).try(:first).try(:name)}])" : "System",
         modified_at: log.present? ? log.try(:created_at) || self.try(:updated_at) || self.try(:created_at) : nil
       }
     end
@@ -66,7 +66,7 @@ module DcidevApproval
       }
     end
 
-    def approve_changes(params, agent, request)
+    def approve_changes
 
       if self.change_status.nil? && %w[waiting rejected].include?(self.status)
         raise self.errors.full_messages.join(", ") unless self.update(status: :approved, data_changes: nil, change_status: nil)
@@ -89,13 +89,13 @@ module DcidevApproval
       end
     end
 
-    def delete_changes(params, agent, request)
+    def delete_changes
       # return unless %w[pending_update pending_delete].include? self.change_status
       raise self.errors.full_messages.join(", ") unless self.update(data_changes: nil, change_status: nil, status: self.status == "waiting" ? :rejected : :approved)
       # ActivityLog.write("Reject changes to #{self.class.to_s}", request, agent, menu, self) if params.log
     end
 
-    def edit_data(params, agent, request, bypass = true, &block)
+    def edit_data(params, agent, bypass = true)
       raise "data still waiting for approval" if self.waiting_approval?
       if bypass
         raise self.errors.full_messages.join(", ") unless self.update_by_params(params, false)
@@ -112,16 +112,16 @@ module DcidevApproval
       yield true
     end
 
-    def approval(params, agent, request)
+    def approval(params)
       if params.status == "approved"
-        self.approve_changes(params, agent, request)
+        self.approve_changes
       elsif params.status == "rejected"
-        self.delete_changes(params, agent, request)
+        self.delete_changes
       end
       yield true
     end
 
-    def delete_data(params, agent, request, bypass = true)
+    def delete_data(agent, bypass = true)
       raise "data still waiting for approval" if self.waiting_approval?
       if bypass || agent.is_admin?
         ActiveRecord::Base.transaction do
@@ -137,7 +137,7 @@ module DcidevApproval
   end
 
   module ClassMethods
-    def create_data(params, agent, request, bypass = true)
+    def create_data(params, agent, bypass = true)
       if bypass
         ActiveRecord::Base.transaction do
           data = params.merge!({ status: :approved })

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dcidev_approval
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Punto Damar P
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-01-24 00:00:00.000000000 Z
+date: 2022-01-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dcidev_active_record
@@ -51,7 +51,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
+rubygems_version: 3.2.3
 signing_key:
 specification_version: 4
 summary: Logic for implementing record changes approval