dboard 1.1.1 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 60c9af8ba57dc09e45ec0f39a2e8394705c4cfadd771f52210578438f4f64219
-  data.tar.gz: d1422616d6c609c49cd32c1a88481ae929391d5d3d937cc81b5abb1e37457a90
+  metadata.gz: 7f55103d286932b6db32979de3f7716857da2ad42b7234681796fd9f814a9e09
+  data.tar.gz: 9ba897eddcbf09741ab43d07eb24d8da35071e7e4137e06c3be3afdf6bceaf46
 SHA512:
-  metadata.gz: '091c5bebede637161ece4d905ec07acb12d018c2d7dde186bb427639edbebe43211393ea6279b9ec212f02cdaff847b9812d21e6f1e1bc98dd9dbf117d0ee33a'
-  data.tar.gz: dcc00cb4d504f0911b19f68c98af3db66e76a4cef444a8efcbb0e1a8daaa2a281da11f12eb3ae132bee5c7b06c09e0e228c17b2ad1ad2af005e47d379d71c5b0
+  metadata.gz: 76034350ee61d117fcc963d8789b20cfdfd308f4c602313e9fd15f2f833e311e2bc7cf517361b409ab58a4ccd4e8589df6985fdeaafc7f5f9c1045ae89002a4c
+  data.tar.gz: 9738a25264c457fb50af8b7d9e7a96f3c8bda68b19fae10b64ce505d6a3b0c30df9bb0521f682847f8bfa76b145ae99879373581b15b934c35ed670aa247fd7a

data/Gemfile

@@ -1,7 +1,11 @@
 source "https://rubygems.org"
 gemspec
 
+gem "net_http_timeout_errors"
+
 group :development, :test do
-  gem "barsoom_utils", github: "barsoom/barsoom_utils"
+  gem "barsoom_utils"
+  gem "rspec"
   gem "rubocop"
+  gem "webmock"
 end

data/dboard.gemspec

@@ -17,10 +17,9 @@ Gem::Specification.new do |s|
   s.files         = `git ls-files`.split("\n")
   s.require_paths = [ "lib" ]
 
+  s.add_dependency "dalli"
   s.add_dependency "httparty"
-  s.add_dependency "rake"
   s.add_dependency "json"
-  s.add_dependency "dalli"
+  s.add_dependency "rake"
   s.add_dependency "sinatra"
-  s.add_development_dependency "rspec", "~> 3.9"
 end

data/lib/api.rb

@@ -3,6 +3,7 @@ require File.expand_path(File.join(File.dirname(__FILE__), "collector.rb"))
 require "digest/md5"
 require "json"
 require "httparty"
+require "net_http_timeout_errors"
 
 module Dboard
   class Api
@@ -11,6 +12,27 @@ module Dboard
 
     class Client
       include HTTParty
+
+      def self.post(...)
+        with_retries { super }
+      end
+
+      private
+
+      private_class_method \
+      def self.with_retries
+        remaining_attempts = 3
+
+        begin
+          remaining_attempts -= 1
+          yield
+        rescue *NetHttpTimeoutErrors.all
+          raise if remaining_attempts == 0
+
+          sleep((ENV["RACK_ENV"] == "test") ? 0 : 5)
+          retry
+        end
+      end
     end
 
     def self.get(params)

data/lib/version.rb

@@ -1,3 +1,3 @@
 module Dboard
-  VERSION = "1.1.1"
+  VERSION = "2.0.0"
 end

data/spec/collector_spec.rb

@@ -1,6 +1,6 @@
 require File.expand_path(File.join(File.dirname(__FILE__), "spec_helper"))
 
-describe Dboard::Collector, "register_source" do
+describe Dboard::Collector, ".register_source" do
   before do
     Dboard::Collector.instance.sources.clear
   end
@@ -48,14 +48,14 @@ describe Dboard::Collector, "update_source" do
     Dboard::Collector.instance.sources.clear
   end
 
-  it "should collect and publish data from sources" do
+  it "collects and publishes data from sources" do
     new_relic = double
     allow(new_relic).to receive(:fetch).and_return({ db: "100%" })
     expect(Dboard::Publisher).to receive(:publish).with(:new_relic, { db: "100%" })
     Dboard::Collector.instance.update_source(:new_relic, new_relic)
   end
 
-  it "should print out debugging info" do
+  it "prints out debugging info" do
     new_relic = double
     allow(new_relic).to receive(:fetch).and_raise(Exception.new("some error"))
     expect(Dboard::Collector.instance).to receive(:puts).twice

data/spec/publisher_spec.rb

@@ -1,12 +1,31 @@
 require File.expand_path(File.join(File.dirname(__FILE__), "spec_helper"))
 
-describe "Publisher", "publish" do
-  it "should send data to the dashboard server" do
+describe "Publisher", ".publish" do
+  it "sends data to the dashboard server" do
     expect(Dboard::Api::Client).to receive(:post).with("/sources/new_relic", body: { data: { db: "80%" }.to_json }, timeout: 10000)
     Dboard::Publisher.publish(:new_relic, { db: "80%" })
   end
 
-  it "should handle and log socket errors" do
+  it "retries network errors" do
+    stub_request(:post, "http://api.example/sources/new_relic").
+      to_timeout.times(2).
+      to_return({ body: "OK!" })
+
+    Dboard::Publisher.publish(:new_relic, {})
+  end
+
+  it "raises network errors if we run out of retries" do
+    stub_request(:post, "http://api.example/sources/new_relic").
+      to_timeout.times(3).
+      to_return({ body: "OK!" })
+
+    expect {
+      Dboard::Publisher.publish(:new_relic, {})
+    }.to raise_error(Net::OpenTimeout)
+  end
+
+  # 2021-12-07: No idea why we've treated this one specially, but keeping it for now.
+  it "logs socket errors if we run out of retries" do
     expect(Dboard::Api::Client).to receive(:post).and_raise(SocketError.new("failed to connect"))
     expect(Dboard::Publisher).to receive(:puts).with("SocketError: failed to connect")
     Dboard::Publisher.publish(:new_relic, {})

data/spec/spec_helper.rb

@@ -1,7 +1,8 @@
 require "rspec"
+require 'webmock/rspec'
 
 ENV["RACK_ENV"] ||= "test"
-ENV["API_URL"] = "http://localhost:20843"
+ENV["API_URL"] = "http://api.example"
 ENV["API_USER"] = "test"
 ENV["API_PASSWORD"] = "test"
 

metadata

@@ -1,17 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: dboard
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 2.0.0
 platform: ruby
 authors:
 - Joakim Kolsjö
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-11-19 00:00:00.000000000 Z
+date: 2021-12-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: httparty
+  name: dalli
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -25,7 +25,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: httparty
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -53,7 +53,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: dalli
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -80,20 +80,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.9'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.9'
 description: Dashboard framework
 email:
 - joakim.kolsjo@gmail.com
@@ -139,7 +125,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.28
+rubygems_version: 3.2.32
 signing_key: 
 specification_version: 4
 summary: Dashboard framework