dbf 2.0.7 → 2.0.8

data/spec/dbf/table_spec.rb

@@ -1,56 +1,60 @@
 require "spec_helper"
 
 describe DBF::Table do
+  let(:dbf_path) { fixture_path('dbase_83.dbf') }
+  let(:memo_path) { fixture_path('dbase_83.dbt') }
+  let(:table) { DBF::Table.new dbf_path }
+
   specify 'foxpro versions' do
     expect(DBF::Table::FOXPRO_VERSIONS.keys.sort).to eq %w(30 31 f5 fb).sort
   end
 
   describe '#initialize' do
-    it 'accepts a DBF filename' do
-      expect { DBF::Table.new "#{DB_PATH}/dbase_83.dbf" }.to_not raise_error
+    describe 'when given a path to an existing dbf file' do
+      it 'does not raise an error' do
+        expect { DBF::Table.new dbf_path }.to_not raise_error
+      end
     end
 
-    it 'accepts a DBF and Memo filename' do
-      expect { DBF::Table.new "#{DB_PATH}/dbase_83.dbf", "#{DB_PATH}/dbase_83.dbt" }.to_not raise_error
+    describe 'when given a path to a non-existent dbf file' do
+      it 'raises a DBF::FileNotFound error' do
+        expect { DBF::Table.new "x" }.to raise_error(DBF::FileNotFoundError, 'file not found: x')
+      end
+    end
+
+    describe 'when given paths to existing dbf and memo files' do
+      it 'does not raise an error' do
+        expect { DBF::Table.new dbf_path, memo_path }.to_not raise_error
+      end
     end
 
     it 'accepts an io-like data object' do
-      data = StringIO.new File.read("#{DB_PATH}/dbase_83.dbf")
+      data = StringIO.new File.read(dbf_path)
       expect { DBF::Table.new data }.to_not raise_error
     end
 
     it 'accepts an io-like data and memo object' do
-      data = StringIO.new File.read("#{DB_PATH}/dbase_83.dbf")
-      memo = StringIO.new File.read("#{DB_PATH}/dbase_83.dbt")
+      data = StringIO.new File.read(dbf_path)
+      memo = StringIO.new File.read(memo_path)
       expect { DBF::Table.new data, memo }.to_not raise_error
     end
   end
 
-  context "when closed" do
-    it "closes the data and memo files" do
-      table = DBF::Table.new "#{DB_PATH}/dbase_83.dbf"
-      table.close
-      expect(table).to be_closed
-    end
-
-    it "closes the data" do
-      table = DBF::Table.new "#{DB_PATH}/dbase_30.dbf"
+  context "#close" do
+    it "closes the io" do
       table.close
-      expect(table).to be_closed
+      expect { table.record(1) }.to raise_error(IOError)
     end
   end
 
   describe "#schema" do
     it "matches the test schema fixture" do
-      table = DBF::Table.new "#{DB_PATH}/dbase_83.dbf"
-      control_schema = File.read("#{DB_PATH}/dbase_83_schema.txt")
+      control_schema = File.read(fixture_path('dbase_83_schema.txt'))
       expect(table.schema).to eq control_schema
     end
   end
 
   describe '#to_csv' do
-    let(:table) { DBF::Table.new "#{DB_PATH}/dbase_83.dbf" }
-
     after do
       FileUtils.rm_f 'test.csv'
     end
@@ -70,30 +74,26 @@ describe DBF::Table do
     describe 'when path param passed' do
       it 'creates a custom csv file' do
         table.to_csv('test.csv')
-        expect(File.exists?('test.csv')).to be_true
+        expect(File.exists?('test.csv')).to be_truthy
       end
     end
   end
 
   describe "#record" do
     it "return nil for deleted records" do
-      table = DBF::Table.new "#{DB_PATH}/dbase_83.dbf"
-      table.stub(:deleted_record?).and_return(true)
+      allow(table).to receive(:deleted_record?).and_return(true)
       expect(table.record(5)).to be_nil
     end
   end
 
   describe "#current_record" do
     it "should return nil for deleted records" do
-      table = DBF::Table.new "#{DB_PATH}/dbase_83.dbf"
-      table.stub(:deleted_record?).and_return(true)
+      allow(table).to receive(:deleted_record?).and_return(true)
       expect(table.record(0)).to be_nil
     end
   end
 
   describe "#find" do
-    let(:table) { DBF::Table.new "#{DB_PATH}/dbase_83.dbf" }
-
     describe "with index" do
       it "returns the correct record" do
         expect(table.find(5)).to eq table.record(5)
@@ -124,7 +124,7 @@ describe DBF::Table do
       end
 
       it "should AND multiple search terms" do
-        expect(table.find(:all, "ID" => 30, "IMAGE" => "graphics/00000001/TBC01.jpg")).to eq []
+        expect(table.find(:all, "ID" => 30, :IMAGE => "graphics/00000001/TBC01.jpg")).to be_empty
       end
 
       it "should match original column names" do
@@ -159,40 +159,39 @@ describe DBF::Table do
     end
   end
 
-  describe "filename" do
-    it 'is dbase_03.dbf' do
-      table = DBF::Table.new "#{DB_PATH}/dbase_03.dbf"
-      expect(table.filename).to eq "dbase_03.dbf"
+  describe "#filename" do
+    it 'returns the filename as a string' do
+      expect(table.filename).to eq "dbase_83.dbf"
     end
   end
 
-  describe 'has_memo_file?' do
+  describe '#has_memo_file?' do
     describe 'without a memo file' do
       it 'is false' do
-        table = DBF::Table.new "#{DB_PATH}/dbase_03.dbf"
-        expect(table.has_memo_file?).to be_false
+        table = DBF::Table.new fixture_path('dbase_03.dbf')
+        expect(table.has_memo_file?).to be_falsey
       end
     end
 
     describe 'with a memo file' do
       it 'is true' do
-        table = DBF::Table.new "#{DB_PATH}/dbase_30.dbf"
-        expect(table.has_memo_file?).to be_true
+        expect(table.has_memo_file?).to be_truthy
       end
     end
   end
 
-  describe 'columns' do
-    let(:table) { DBF::Table.new "#{DB_PATH}/dbase_03.dbf" }
-
-    it 'should have correct size' do
-      expect(table.columns.size).to eq 31
+  describe '#columns' do
+    it 'is an array of Columns' do
+      expect(table.columns).to be_an(Array)
+      expect(table.columns).to_not be_empty
+      expect(table.columns.all? {|c| c.class == DBF::Column::Dbase}).to be_truthy
     end
+  end
 
-    it 'should have correct names' do
-      expect(table.columns.first.name).to eq 'Point_ID'
-      expect(table.columns[29].name).to eq 'Easting'
+  describe '#column_names' do
+    it 'is an array of all column names' do
+      correct_column_names = ["ID", "CATCOUNT", "AGRPCOUNT", "PGRPCOUNT", "ORDER", "CODE", "NAME", "THUMBNAIL", "IMAGE", "PRICE", "COST", "DESC", "WEIGHT", "TAXABLE", "ACTIVE"]
+      expect(table.column_names).to eq correct_column_names
     end
   end
 end
-

data/spec/spec_helper.rb

@@ -1,3 +1,9 @@
+begin
+  require 'codeclimate-test-reporter'
+  CodeClimate::TestReporter.start
+rescue LoadError
+end
+
 require 'dbf'
 require 'rspec'
 
@@ -21,3 +27,7 @@ RSpec.configure do |config|
     end
   end
 end
+
+def fixture_path(filename)
+  "#{DB_PATH}/#{filename}"
+end

metadata

@@ -1,18 +1,20 @@
 --- !ruby/object:Gem::Specification
 name: dbf
 version: !ruby/object:Gem::Version
-  version: 2.0.7
+  version: 2.0.8
+  prerelease: 
 platform: ruby
 authors:
 - Keith Morrison
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-04 00:00:00.000000000 Z
+date: 2015-02-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: fastercsv
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -20,38 +22,11 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: 1.5.4
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: 0.9.2
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: 0.9.2
 description: A small fast library for reading dBase, xBase, Clipper and FoxPro database
   files.
 email: keithm@infused.org
@@ -61,12 +36,15 @@ extensions: []
 extra_rdoc_files:
 - README.md
 - CHANGELOG.md
-- MIT-LICENSE
+- LICENSE
 files:
 - CHANGELOG.md
 - Gemfile
 - Gemfile.lock
-- MIT-LICENSE
+- Gemfile.travis
+- Gemfile.travis18
+- Guardfile
+- LICENSE
 - Rakefile
 - README.md
 - bin/dbf
@@ -82,6 +60,7 @@ files:
 - lib/dbf/memo/dbase4.rb
 - lib/dbf/memo/foxpro.rb
 - lib/dbf/record.rb
+- lib/dbf/schema.rb
 - lib/dbf/table.rb
 - lib/dbf/version.rb
 - lib/dbf.rb
@@ -107,27 +86,28 @@ files:
 homepage: http://github.com/infused/dbf
 licenses:
 - MIT
-metadata: {}
 post_install_message: 
 rdoc_options:
 - --charset=UTF-8
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: 1.3.0
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.1.5
+rubygems_version: 1.8.25
 signing_key: 
-specification_version: 4
+specification_version: 3
 summary: Read xBase files
 test_files:
 - spec/dbf/column_spec.rb

checksums.yaml

@@ -1,7 +0,0 @@
----
-SHA1:
-  metadata.gz: db2859c1e08f0132528dfb86229d326f6cc4be33
-  data.tar.gz: e422586329fe7da39010f33f4a6b3a967b574a60
-SHA512:
-  metadata.gz: 0658b29b53be088f91f99808016854f5ef7e5f66f3d73e3a0b455d312c6a401b9861a27596500ce295b976e0fc908bdf986b111a797a309d76fcca4dcdd4e3d5
-  data.tar.gz: e13115f3e2e3695dbfe833006a47a9ac6a17e015b284d6c03d3b4fdbc4ef4909d0c0e087e96e7d88980bac2aef0941faff2dd73ca9ccc49ecb39898e61acf245