dbee 1.0.0.pre.alpha.2 → 1.0.0.pre.alpha.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fecdbe7976189c6a9b9831e20218d6bca1c194f76db554972ead718cc2a26d36
-  data.tar.gz: 6ebbac4f006d91085cc048803c0f683eafcce313cba70e2de8fa744b4d99f981
+  metadata.gz: b130a54954373ada660f1203488dbf1a8c7f086b7d22f6fdc3a1e5f37cbf5266
+  data.tar.gz: f6d4feef16b9bcf531bddeee8ac7628e95286e3f263c335213daad2cf889bca9
 SHA512:
-  metadata.gz: acf29c44149ff9d77b66c248518e5f6bd2cdc0efd3ba3e8f831042557e63ed9512a163478669d7b5563fcb23c9de14e7afa28cc2b64369d18a35a5b0b5a25dd6
-  data.tar.gz: 489890fdb0c75e76030bb01274c7178f2b132c587b7f19361ace87c7517ed5079003e4c36df4366a6b04c641827c7cb9b411211213c9e45cfffa0c21b2272208
+  metadata.gz: 29a0abfebc532e09f81953ec8a9918887bb6ab0bbb3e50d68e1615df71b2c913af0fb9a063ab38381adbcf614df27c6322f297a16d4a90d6481a1608b02ac31b
+  data.tar.gz: ad4f0531f7bfc44e7d5461f453fecfebccb3afbbfb997d111a154030188d9ce4a4d206fdcb9d466027439a182e7c4fb3127327b104223e615be203bd9775b857

data/lib/dbee/query.rb

@@ -20,10 +20,18 @@ module Dbee
   class Query
     acts_as_hashable
 
+    class NoFieldsError < StandardError; end
+
     attr_reader :fields, :filters, :limit, :sorters
 
-    def initialize(fields: [], filters: [], limit: nil, sorters: [])
-      @fields   = Field.array(fields)
+    def initialize(fields:, filters: [], limit: nil, sorters: [])
+      @fields = Field.array(fields)
+
+      # If no fields were passed into a query then we will have no data to return.
+      # Let's raise a hard error here and let the consumer deal with it since this may
+      # have implications in downstream SQL generators.
+      raise NoFieldsError if @fields.empty?
+
       @filters  = Filters.array(filters)
       @limit    = limit.to_s.empty? ? nil : limit.to_i
       @sorters  = Sorter.array(sorters)

data/lib/dbee/version.rb

@@ -8,5 +8,5 @@
 #
 
 module Dbee
-  VERSION = '1.0.0-alpha.2'
+  VERSION = '1.0.0-alpha.3'
 end

data/spec/dbee/query_spec.rb

@@ -31,6 +31,16 @@ describe Dbee::Query do
     expect(subject).to eq(described_class.make(config))
   end
 
+  describe '#initialize' do
+    it 'should raise an ArgumentError if fields keyword is missing' do
+      expect { described_class.new }.to raise_error(ArgumentError)
+    end
+
+    it 'should raise a NoFieldsError if no fields were passed in' do
+      expect { described_class.new(fields: []) }.to raise_error(Dbee::Query::NoFieldsError)
+    end
+  end
+
   context 'README examples' do
     EXAMPLES = {
       'Get all practices' => {

data/spec/dbee_spec.rb

@@ -14,7 +14,7 @@ describe Dbee do
   describe '#sql' do
     let(:provider) { Dbee::Providers::NullProvider.new }
 
-    let(:query) { {} }
+    let(:query) { { fields: [{ key_path: :a }] } }
 
     it 'accepts a hash as a model and passes a Model instance to provider#sql' do
       model = { name: 'something' }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dbee
 version: !ruby/object:Gem::Version
-  version: 1.0.0.pre.alpha.2
+  version: 1.0.0.pre.alpha.3
 platform: ruby
 authors:
 - Matthew Ruggio