dbee-active_record 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ec33481a6a1eb0dd9ddb60ace985456f5e8d085559d8923607bb252c013498de
-  data.tar.gz: 49fe65ebf0caeb1f0e87482309352ed0e258cfd57c2ab26e2c3867d2c7e4a27a
+  metadata.gz: 75589214484b7918c7ae021e2f1cc2815c44b0fd472e61668197f96acb730031
+  data.tar.gz: a5155b0007182721e669a1930b4f313a28b19935b83b7a0084cbc7c65db07d01
 SHA512:
-  metadata.gz: 44d6130ac9b617fddc0943caeabc65576e5617eac9bad7367757ab8ddff1dc98e3e542b9ec564da20f4d1c3c3e1094b8c4e8e27156e76ddea248d12afb38e570
-  data.tar.gz: 7288cd2c2cbb0ee5e57278aa0d5ec308dc0c3dfeb8fe032cb5a50c5e9c42f2110388fd3933d2a46199fea901fda10509359c422e19d9be9d55e9228e449a292a
+  metadata.gz: 609909bbc0f1baab5d1dd36296ef86d47aac62f6f13e1a22d8bd674dacd22212e26e16d213fea797e31f90b8c90c1e78738596dad6b3c8b6d1da32ad82dbc476
+  data.tar.gz: c4815033dd066cd1c99faa3e0887467ec017400305bf0046041ec5b689d5b6c14b97ab5ec3d01a5c34bc6d88ad2bbe9089573ba6a92ad823b202a58418f445c0

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 1.0.3 (August 27th, 2019)
+
+* Raises MissingConstraintError when trying to join to a table without at least one constraint.
+
 # 1.0.2 (August 26th, 2019)
 
 * Only support Dbee version 1.0.2 and above

data/lib/dbee/providers/active_record_provider/expression_builder.rb

@@ -19,6 +19,8 @@ module Dbee
       class ExpressionBuilder
         extend Forwardable
 
+        class MissingConstraintError < StandardError; end
+
         def_delegators :statement, :to_sql
 
         def initialize(model, table_alias_maker, column_alias_maker)
@@ -127,8 +129,10 @@ module Dbee
 
           on = constraint_maker.make(model.constraints, table, previous_table)
 
+          raise MissingConstraintError, "for: #{name}" unless on
+
           @statement = statement.join(table, ::Arel::Nodes::OuterJoin)
-          @statement = statement.on(on) if on
+          @statement = statement.on(on)
 
           tables[name] = table
         end

data/lib/dbee/providers/active_record_provider/version.rb

@@ -10,7 +10,7 @@
 module Dbee
   module Providers
     class ActiveRecordProvider
-      VERSION = '1.0.2'
+      VERSION = '1.0.3'
     end
   end
 end

data/spec/dbee/providers/active_record_provider_spec.rb

@@ -13,6 +13,35 @@ require 'db_helper'
 describe Dbee::Providers::ActiveRecordProvider do
   let(:models) { yaml_fixture('models.yaml') }
 
+  describe '#sql' do
+    before(:all) do
+      connect_to_db(:sqlite)
+    end
+
+    it 'errors when joining tables with no constraints' do
+      model_hash = {
+        name: :users,
+        models: [
+          { name: :logins }
+        ]
+      }
+
+      query_hash = {
+        fields: [
+          { key_path: 'id' },
+          { key_path: 'logins.id' }
+        ]
+      }
+
+      query = Dbee::Query.make(query_hash)
+      model = Dbee::Model.make(model_hash)
+
+      error_class = Dbee::Providers::ActiveRecordProvider::ExpressionBuilder::MissingConstraintError
+
+      expect { described_class.new.sql(model, query) }.to raise_error(error_class)
+    end
+  end
+
   describe 'Snapshot' do
     context 'Generating SQL' do
       %w[sqlite mysql].each do |dbms|

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dbee-active_record
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - Matthew Ruggio
@@ -19,7 +19,7 @@ dependencies:
         version: 5.2.1
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6'
+        version: '7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -29,7 +29,7 @@ dependencies:
         version: 5.2.1
     - - "<"
       - !ruby/object:Gem::Version
-        version: '6'
+        version: '7'
 - !ruby/object:Gem::Dependency
   name: dbee
   requirement: !ruby/object:Gem::Requirement