dbd 0.0.9 → 0.0.10

data/spec/lib/dbd/helpers/ordered_set_collection/ordered_set_collection_spec.rb

@@ -13,36 +13,36 @@ module Dbd
         o
       end
 
-      describe "create an elements collection" do
-        it "the collection is not an array" do
+      describe 'create an elements collection' do
+        it 'the collection is not an array' do
           # do not derive from Ruby standard classes
           subject.should_not be_a(Array)
         end
       end
 
-      describe "accessor functions" do
-        it "the collection has Enumerable methods" do
+      describe 'accessor functions' do
+        it 'the collection has Enumerable methods' do
           subject.map #should_not raise_exception
           subject.first #should_not raise_exception
         end
 
-        it "<< adds the element" do
+        it '<< adds the element' do
           subject << element_1
           subject.count.should == 1
         end
 
-        it "returns self to allow chaining" do
+        it 'returns self to allow chaining' do
           (subject << element_1).should == subject
         end
 
-        it "other functions (e.g. pop) do not work" do
+        it 'other functions (e.g. pop) do not work' do
           lambda {subject.pop} . should raise_exception NoMethodError
         end
 
-        describe "add_and_return_index returns the index of the inserted element" do
+        describe 'add_and_return_index returns the index of the inserted element' do
 
           let(:internal_collection) do
-            subject.instance_variable_get("@internal_collection")
+            subject.instance_variable_get('@internal_collection')
           end
 
           let(:index) do
@@ -51,26 +51,26 @@ module Dbd
 
           before(:each) { index }
 
-          it "works for 1 element" do
+          it 'works for 1 element' do
             index.should == 0
           end
 
-          it "works for 2 elements" do
+          it 'works for 2 elements' do
             index_2 = described_class.add_and_return_index(element_2, internal_collection)
             index_2.should == 1
           end
         end
 
-        describe "last" do
-          it "returns the last element" do
+        describe 'last' do
+          it 'returns the last element' do
             subject << element_1
             subject << element_2
             subject.last.should == element_2
           end
         end
 
-        describe "size" do
-          it "returns the last element" do
+        describe 'size' do
+          it 'returns the last element' do
             subject << element_1
             subject << element_2
             subject.size.should == 2
@@ -78,8 +78,8 @@ module Dbd
         end
       end
 
-      describe "on empty collection" do
-        it "#last returns nil" do
+      describe 'on empty collection' do
+        it '#last returns nil' do
           subject.last.should be_nil
         end
       end

data/spec/lib/dbd/helpers/uuid/uuid_spec.rb

@@ -3,15 +3,21 @@ require 'spec_helper'
 module Dbd
   module Helpers
     describe UUID do
-      it ".regex" do
-        '12345678-abcd-4567-89ab-0123456789ab'.should match(UUID.regexp)
+      describe '.valid_regex' do
+        it 'matches correct uuid' do
+          '12345678-abcd-4567-89ab-0123456789ab'.should match(UUID.valid_regexp)
+        end
+
+        it 'does not match incorrect uuid' do
+          '012345678-abcd-4567-89ab-0123456789ab'.should_not match(UUID.valid_regexp)
+        end
       end
 
-      it ".new creates a new random UUID" do
-        described_class.new.to_s.should match(UUID.regexp)
+      it '.new creates a new random UUID' do
+        described_class.new.to_s.should match(UUID.valid_regexp)
       end
 
-      it ".new creates a new random UUID with UTF-8 encoding" do
+      it '.new creates a new random UUID with UTF-8 encoding' do
         described_class.new.to_s.encoding.should == Encoding::UTF_8
       end
     end

data/spec/lib/dbd/performance_spec.rb

@@ -2,32 +2,32 @@ require 'spec_helper'
 require 'benchmark'
 
 module Dbd
-  describe "performance" do
+  describe 'performance' do
 
     include Benchmark
 
     # no let because we do not want memoized
     def new_subject
-      Fact.new_subject
+      Fact.factory.new_subject
     end
 
-    let(:provenance_fact_1) { Factories::ProvenanceFact.context(new_subject) }
+    let(:provenance_fact_1) { TestFactories::ProvenanceFact.context(new_subject) }
 
     NUMBER_OF_FACTS = 10_000
 
     describe "#{NUMBER_OF_FACTS} facts" do
-      it "reports and checks the used time" do
+      it 'reports and checks the used time' do
         graph = Graph.new
         graph << provenance_fact_1
         # Rehearsal
         NUMBER_OF_FACTS.times do |counter|
-          data_fact = Factories::Fact.data_fact(provenance_fact_1, new_subject)
+          data_fact = TestFactories::Fact.data_fact(provenance_fact_1, new_subject)
           graph << data_fact
         end
         # Actual
         start = Time.now
         NUMBER_OF_FACTS.times do |counter|
-          data_fact = Factories::Fact.data_fact(provenance_fact_1, new_subject)
+          data_fact = TestFactories::Fact.data_fact(provenance_fact_1, new_subject)
           graph << data_fact
         end
         duration = Time.now - start

data/spec/lib/dbd/provenance_fact/methods_spec.rb

@@ -3,74 +3,74 @@ require 'spec_helper'
 module Dbd
   describe ProvenanceFact do
 
-    let(:subject) { described_class.new_subject }
+    let(:subject) { described_class.factory.new_subject }
 
     let(:provenance_fact_1) do
-      Factories::ProvenanceFact.context(subject)
+      TestFactories::ProvenanceFact.context(subject)
     end
 
     let(:provenance_fact_created) do
-      Factories::ProvenanceFact.created(subject)
+      TestFactories::ProvenanceFact.created(subject)
     end
 
-    describe "short" do
-      it "for a provenance fact shows [ prov ], subj, predicate, object" do
+    describe 'short' do
+      it 'for a provenance fact shows [ prov ], subj, predicate, object' do
         provenance_fact_1.short.should match(/^\[ prov \] : [0-9a-f]{8} : https:\/\/data\.vandenabeel : public$/)
       end
 
-      it "for a provenance fact with non string object also works" do
+      it 'for a provenance fact with non string object also works' do
         provenance_fact_created.short.should match(/^\[ prov \] : [0-9a-f]{8} : dcterms:created          : \d{4}/)
       end
     end
 
-    describe "errors" do
-      it "the factory has no errors" do
+    describe 'errors' do
+      it 'the factory has no errors' do
         provenance_fact_1.errors.should be_empty
       end
 
-      describe "with a provenance_subject" do
+      describe 'with a provenance_subject' do
 
         before(:each) do
           provenance_fact_1.stub(:provenance_subject).and_return(subject)
         end
 
-        it "errors returns an array with 1 error message" do
+        it 'errors returns an array with 1 error message' do
           provenance_fact_1.errors.single.should match(/Provenance subject should not be present in Provenance Fact/)
         end
       end
 
-      describe "without subject" do
+      describe 'without subject' do
 
         before(:each) do
           provenance_fact_1.stub(:subject).and_return(nil)
         end
 
-        it "errors returns an array with an error message" do
+        it 'errors returns an array with an error message' do
           provenance_fact_1.errors.single.should match(/Subject is missing/)
         end
       end
     end
 
-    describe "update_used_provenance_subjects" do
-      it "does nothing for a provenance_fact" do
+    describe 'update_used_provenance_subjects' do
+      it 'does nothing for a provenance_fact' do
         h = {}
         provenance_fact_1.update_used_provenance_subjects(h)
         h.should be_empty
       end
     end
 
-    describe "attributes and values" do
-      it "there are 6 attributes" do
+    describe 'attributes and values' do
+      it 'there are 6 attributes' do
         described_class.attributes.size.should == 6
       end
 
-      it "there are 6 values" do
+      it 'there are 6 values' do
         provenance_fact_1.values.size.should == 6
       end
     end
 
-    describe "provenance_fact?" do
-      it "is true for ProvenanceFact or derived from it" do
+    describe 'provenance_fact?' do
+      it 'is true for ProvenanceFact or derived from it' do
         provenance_fact_1.provenance_fact?.should be_true
       end
     end

data/spec/lib/dbd/provenance_fact/new_spec.rb

@@ -3,47 +3,47 @@ require 'spec_helper'
 module Dbd
   describe ProvenanceFact do
 
-    let(:subject) { described_class.new_subject }
-    let(:id_class) { described_class.new_id.class }
+    let(:subject) { described_class.factory.new_subject }
+    let(:id_class) { described_class.factory.new_id.class }
 
     let(:provenance_fact_1) do
-      Factories::ProvenanceFact.context(subject)
+      TestFactories::ProvenanceFact.context(subject)
     end
 
     let(:provenance_fact_2) do
-      Factories::ProvenanceFact.created_by(subject)
+      TestFactories::ProvenanceFact.created_by(subject)
     end
 
-    describe "#new" do
-      it "has a unique id (new_id.class)" do
+    describe '#new' do
+      it 'has a unique id (new_id.class)' do
         provenance_fact_1.id.should be_a(id_class)
       end
 
-      it "two provenance_facts have different id" do
+      it 'two provenance_facts have different id' do
         provenance_fact_1.id.should_not == provenance_fact_2.id
       end
 
-      it "has nil provenance_subject" do
+      it 'has nil provenance_subject' do
         provenance_fact_1.provenance_subject.should be_nil
       end
 
-      it "has correct subject" do
+      it 'has correct subject' do
         provenance_fact_1.subject.should == subject
       end
 
-      it "has correct predicate" do
-        provenance_fact_1.predicate.should == "https://data.vandenabeele.com/ontologies/provenance#context"
+      it 'has correct predicate' do
+        provenance_fact_1.predicate.should == 'https://data.vandenabeele.com/ontologies/provenance#context'
       end
 
-      it "has correct object" do
-        provenance_fact_1.object.should == "public"
+      it 'has correct object' do
+        provenance_fact_1.object.should == 'public'
       end
 
-      it "raises an ProvenanceError when provenance_subject is present in options hash" do
+      it 'raises an ProvenanceError when provenance_subject is present in options hash' do
         lambda { described_class.new(
-          provenance_subject: described_class.new_subject,
-          predicate: "test",
-          object: "test") } .
+          provenance_subject: subject,
+          predicate: 'test',
+          object: 'test') } .
             should raise_error ProvenanceError
       end
     end

data/spec/lib/dbd/provenance_fact/test_factories_spec.rb

@@ -0,0 +1,24 @@
+require 'spec_helper'
+
+module TestFactories
+  describe ProvenanceFact do
+
+    describe 'TestFactories do not fail' do
+      it 'TestFactories::ProvenanceFact.context is OK' do
+        described_class.context.should_not be_nil
+      end
+
+      it 'TestFactories::ProvenanceFact.created_by is OK' do
+        described_class.created_by.should_not be_nil
+      end
+
+      it 'TestFactories::ProvenanceFact.original_source is OK' do
+        described_class.original_source.should_not be_nil
+      end
+
+      it 'TestFactories::ProvenanceFact.new_subject is OK' do
+        described_class.new_subject.should be_a(ProvenanceFact.new_subject.class)
+      end
+    end
+  end
+end

data/spec/lib/dbd/provenance_resource/provenance_resource_spec.rb

@@ -6,66 +6,66 @@ module Dbd
     let(:provenance_resource) { described_class.new }
     let(:provenance_resource_subject) { provenance_resource.subject }
 
-    describe ".new" do
-      describe "without a subject argument" do
-        it "has created a new subject" do
+    describe '.new' do
+      describe 'without a subject argument' do
+        it 'has created a new subject' do
           provenance_resource.subject.should be_a(described_class.new_subject.class)
         end
       end
 
-      describe "with a subject argument" do
-        it "has stored the resource_subject" do
+      describe 'with a subject argument' do
+        it 'has stored the resource_subject' do
           described_class.new(subject: provenance_resource_subject).subject.
             should == provenance_resource_subject
         end
       end
 
-      describe "with a provenance_subject argument" do
-        it "raises an ProvenanceError" do
+      describe 'with a provenance_subject argument' do
+        it 'raises an ProvenanceError' do
           lambda{ described_class.new(provenance_subject: provenance_resource_subject) }.
             should raise_error(ArgumentError)
         end
       end
     end
 
-    describe "provenance_subject" do
-      it "raises NoMethodError when called" do
+    describe 'provenance_subject' do
+      it 'raises NoMethodError when called' do
         lambda{ provenance_resource.provenance_subject }.should raise_error(NoMethodError)
       end
     end
 
-    describe "Factories::Resource" do
-      it ".provenance_resource works" do
-        Factories::ProvenanceResource.provenance_resource
+    describe 'TestFactories::Resource' do
+      it '.provenance_resource works' do
+        TestFactories::ProvenanceResource.provenance_resource
       end
     end
 
-    describe "the collection" do
+    describe 'the collection' do
 
-      let(:provenance_fact_context) { Factories::ProvenanceFact.context }
-      let(:provenance_fact_context_with_incorrect_subject) { Factories::ProvenanceFact.context(Factories::ProvenanceFact.new_subject) }
-      let(:provenance_fact_context_with_correct_subject) { Factories::ProvenanceFact.context(provenance_resource_subject) }
-      let(:fact_1) { Factories::Fact.fact_1(provenance_resource_subject) }
+      let(:provenance_fact_context) { TestFactories::ProvenanceFact.context }
+      let(:provenance_fact_context_with_incorrect_subject) { TestFactories::ProvenanceFact.context(TestFactories::ProvenanceFact.new_subject) }
+      let(:provenance_fact_context_with_correct_subject) { TestFactories::ProvenanceFact.context(provenance_resource_subject) }
+      let(:fact_1) { TestFactories::Fact.fact_1(provenance_resource_subject) }
 
-      describe "adding provenance facts with << " do
-        it "with correct subject it works" do
+      describe 'adding provenance facts with << ' do
+        it 'with correct subject it works' do
           provenance_resource << provenance_fact_context_with_correct_subject
           provenance_resource.first.subject.should == provenance_resource_subject
         end
 
-        it "with incorrect subject it raises SetOnceError" do
+        it 'with incorrect subject it raises SetOnceError' do
           lambda{ provenance_resource << provenance_fact_context_with_incorrect_subject }.
             should raise_error(RubyPeterV::SetOnceError),
-              "Value of subject was #{provenance_fact_context_with_incorrect_subject.subject}, " \
-              "trying to set it to #{provenance_resource.subject}"
+              'Value of subject was #{provenance_fact_context_with_incorrect_subject.subject}, ' \
+              'trying to set it to #{provenance_resource.subject}'
         end
 
-        it "with nil subject it sets the subject" do
+        it 'with nil subject it sets the subject' do
           provenance_resource << provenance_fact_context
           provenance_resource.first.subject.should == provenance_resource_subject
         end
 
-        it "with nil (=correct) provenance_subject it is a noop" do
+        it 'with nil (=correct) provenance_subject it is a noop' do
           provenance_resource << provenance_fact_context
           provenance_resource.first.provenance_subject.should be_nil
         end

data/spec/lib/dbd/rdf_base/rdf_base_spec.rb

@@ -2,28 +2,28 @@ require 'spec_helper'
 
 module Dbd
   describe RdfBase do
-    it "module exists" do
+    it 'module exists' do
       described_class # should not raise error
     end
 
-    it "The RDF module is loaded" do
+    it 'The RDF module is loaded' do
       RDF # should not raise error
     end
 
-    describe "play with a rdf_graph" do
+    describe 'play with a rdf_graph' do
 
-      let(:rdf_graph) { RDF::Graph.new << [:hi, RDF::DC.title, "Hello, world!"] }
+      let(:rdf_graph) { RDF::Graph.new << [:hi, RDF::DC.title, 'Hello, world!'] }
 
-      it "Create a rdf_graph" do
+      it 'Create a rdf_graph' do
         rdf_graph # should_not raise_error
       end
 
-      it "writing data" do
+      it 'writing data' do
         rdf_graph.dump(:ntriples).chomp.should ==
           '_:hi <http://purl.org/dc/terms/title> "Hello, world!" .'
       end
 
-      it "Reading N-triples" do
+      it 'Reading N-triples' do
         n_triples_string =
           '<http://example.com/test#1> ' +
           '<http://www.w3.org/2000/01/rdf-schema#label> ' +