db_sucker 3.2.0 → 3.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b8074c1cae68f9c791d50bb5494ff86eb51bb840470bd2bf94d72cebbc2822a5
-  data.tar.gz: 8fbfadaf58d757f5bc626e23288c0056ffe4eaf1db470718784ad25c3403db3c
+  metadata.gz: 41ee20b2f776fdf1308842c417e64fff4b5d51178bb50ee91db5215ee6e6d660
+  data.tar.gz: 50999e195fa36291660360afee4e78abd4761a5acabb9ea38bb004e9abb937e0
 SHA512:
-  metadata.gz: 6f5784e1d45ed9878c412de70ba0a1d3a243a38c1c6528c790a9aba1dadfcd74b223792b8060647ecf660e0703bb21da0110421c0581c6984127264129246506
-  data.tar.gz: 4ad5f0a6e3bc1466eb6e92de0d39eab511435fd06510c6e60380f9ac6b3a8eec7cc3458b18dbb73787b290f2949726897fc4feefd2918464cc48db1f4ecb42dd
+  metadata.gz: a743447ba674c4213736395e1a6a7d7f0aed5f2305bef00e4cd1ee7903eb4e458a63a55fad1576de818079d9ea3f13f693f7af4f3519b4d7871b7f9f80301d09
+  data.tar.gz: 6d9c944d4f1b0420d785882b0c60b2c79c8803d9bdec83b801756997dec8db68a01c747a5b37a8a90533071358697ce63b3748675dc796c285c88a1d9449e8d9

data/CHANGELOG.md

@@ -1,3 +1,18 @@
+## 3.2.1
+
+### Updates
+
+* Added means to signal all threads in order to wake them up as they occasionally get stuck for some reason. Press `S` or use `:signal-threads` to execute. Have yet to find the culprint :)
+* Slight UX improvements, silent commands briefly flash the screen, invalid commands ring the bell
+
+### Fixes
+
+* don't warn about orphaned concurrent-ruby threads, debug log trace of remaining threads
+* join killed threads to ensure they are dead
+* minor sshdiag fixes/enhancements
+
+-------------------
+
 ## 3.2.0
 
 ### Updates

data/VERSION

@@ -1 +1 @@
-3.2.0
+3.2.1

data/lib/db_sucker/application.rb

@@ -37,10 +37,17 @@ module DbSucker
             else "Unhandled exception terminated application!"
           end
         ensure
+          $core_runtime_exiting = 1
           app.fire(:core_shutdown)
-          remain = Thread.list.length
-          if remain > 1
-            app.warning "#{remain} threads remain (should be 1)..."
+          remain = app.filtered_threads
+          if remain.length > 1
+            app.error "[WARN] #{remain.length} threads remain (should be 1)..."
+            remain.each do |thr|
+              app.debug "[THR] #{Thread.main == thr ? "MAIN" : "THREAD"}\t#{thr.alive? ? "ALIVE" : "DEAD"}\t#{thr.inspect}", 10
+              thr.backtrace.each do |l|
+                app.debug "[THR]\t#{l}", 20
+              end
+            end
           else
             app.debug "1 thread remains..."
           end

data/lib/db_sucker/application/core.rb

@@ -1,6 +1,12 @@
 module DbSucker
   class Application
     module Core
+      def filtered_threads
+        Thread.list.reject do |thr|
+          thr.backtrace[0]["gems/concurrent-ruby"] rescue false
+        end
+      end
+
       def sandboxed &block
         block.call
       rescue StandardError => ex
@@ -49,20 +55,22 @@ module DbSucker
           end
 
           # worker info
-          f.puts "\n\n#{sklaventreiber.workers.length} workers:\n"
-          sklaventreiber.workers.each do |w|
-            f.puts "#{"[SSH] " if w.sshing} #{w.descriptive} #{w.state}".strip
-          end
-
-          # slot pool
-          f.puts "\n\n#{sklaventreiber.slot_pools.length} slot pools:\n"
-          sklaventreiber.slot_pools.each do |name, pool|
-            f.puts "#{name}: #{pool.slots}"
-            pool.active.each do |thr|
-              f.puts "\tactive\t #{thr} [#{thr[:itype]}]"
+          if sklaventreiber
+            f.puts "\n\n#{sklaventreiber.workers.length} workers:\n"
+            sklaventreiber.workers.each do |w|
+              f.puts "#{"[SSH] " if w.sshing} #{w.descriptive} #{w.state}".strip
             end
-            pool.waiting.each do |wthr, tthr|
-              f.puts "\twaiting\t #{tthr} [#{tthr[:itype]}]"
+
+            # slot pool
+            f.puts "\n\n#{sklaventreiber.slot_pools.length} slot pools:\n"
+            sklaventreiber.slot_pools.each do |name, pool|
+              f.puts "#{name}: #{pool.slots}"
+              pool.active.each do |thr|
+                f.puts "\tactive\t #{thr} [#{thr[:itype]}]"
+              end
+              pool.waiting.each do |wthr, tthr|
+                f.puts "\twaiting\t #{tthr} [#{tthr[:itype]}]"
+              end
             end
           end
         end

data/lib/db_sucker/application/dispatch.rb

@@ -101,7 +101,7 @@ module DbSucker
             i += 1
           end
         end
-        t.kill
+        t.kill.join
         puts "Thread priority: -#{m[1].abs}..+#{m[2].abs}"
       end
 
@@ -112,6 +112,10 @@ module DbSucker
         varstr = ARGV.shift
 
         configful_dispatch(idstr, varstr) do |identifier, ctn, variation, var|
+          unless ctn
+            abort "This test requires a config identifier with an SSH connection!"
+          end
+
           log c("\nPlease wait while we run some tests...\n", :blue)
           _identifier = identifier
           _ctn = ctn
@@ -136,7 +140,7 @@ module DbSucker
             }
             250.times do
               break if monitor.synchronize { stop }
-              c, r = ctn.blocking_channel_result("sleep 60", blocking: false, channel: true, use_sh: true)
+              c, r = ctn.blocking_channel_result("sleep 900", blocking: false, channel: true, use_sh: true)
               monitor.synchronize do
                 channels << c
                 print "+"
@@ -145,6 +149,7 @@ module DbSucker
             end
           ensure
             debug "Stopping sessions (#{channels.length})..."
+            puts # newline for style
             i = 1
             loop do
               break if monitor.synchronize { channels.empty? }
@@ -154,6 +159,7 @@ module DbSucker
               print "-"
               i += 1
             end
+            maxsessions = "#{maxsessions}+" if maxsessions.to_i >= 250
             log c("\n\nSSH MaxSessions: #{c maxsessions, :magenta}", :cyan)
             log "This value determines how many sessions we can multiplex over a single TCP connection."
             log "Currently, DbSucker can only utilize one connection, thus this value defines the maxmium concurrency."
@@ -161,7 +167,7 @@ module DbSucker
             log "  * increase the SSHd `MaxSessions' setting on the remote (if you can)"
             log "  * reduce the amount of workers and/or remote slots"
             log "  * fix the mess that is this tool, visit #{c "https://github.com/2called-chaos/db_sucker", :blue}"
-            t.kill
+            t.kill.join
           end
         end
       rescue Net::SSH::AuthenticationFailed => ex

data/lib/db_sucker/application/sklaven_treiber/worker/io/pv_wrapper.rb

@@ -63,7 +63,7 @@ module DbSucker
               end
               killer.signal.join
             ensure
-              killer.kill
+              killer.kill.join
             end
           end
         end

data/lib/db_sucker/application/window/core.rb

@@ -83,6 +83,10 @@ module DbSucker
           init_pair(Window::COLOR_GRAY, 0, -1)
         end
 
+        def flashbang
+          flash
+        end
+
         def set_cursor visibility
           curs_set(visibility)
         end

data/lib/db_sucker/application/window/keypad.rb

@@ -20,12 +20,14 @@ module DbSucker
             ["T", "create core dump and open in editor"],
             ["q", "quit prompt"],
             ["Q", "same as ctrl-c"],
+            ["S", "signal/wakeup all threads"],
             [":", "main prompt"],
           ],
           main_commands: [
             [["?", %w[h elp]], [], "shows this help"],
             [[%w[q uit]], [], "quit prompt"],
             [["q!", "quit!"], [], "same as ctrl-c"],
+            [["signal-threads"], [], "signal/wakeup all threads"],
             [["kill"], [], "(dirty) interrupts all workers"],
             [["kill!"], [], "(dirty) essentially SIGKILL (no cleanup)"],
             [["dump"], [], "create and open coredump"],
@@ -50,6 +52,7 @@ module DbSucker
               when "?" then show_help
               when "q" then quit_dialog
               when "Q" then $core_runtime_exiting = 1
+              when "S" then signal_threads
               end
             end
           end
@@ -71,6 +74,8 @@ module DbSucker
               when "eval" then args.any? ? _eval(args.join(" ")) : eval_prompt
               when "p", "pause" then pause_workers(args)
               when "r", "resume" then resume_workers(args)
+              when "signal-threads" then signal_threads
+              else app.print("\a")
             end
           end
         end
@@ -125,6 +130,7 @@ module DbSucker
 
         def pause_workers args
           if args[0].is_a?(String)
+            window.flashbang
             _detect_worker(args.join(" "), &:pause)
           else
             prompt!("Usage: :p(ause) <table_name|--all>", color: :yellow)
@@ -133,6 +139,7 @@ module DbSucker
 
         def resume_workers args
           if args[0].is_a?(String)
+            window.flashbang
             _detect_worker(args.join(" "), &:unpause)
           else
             prompt!("Usage: :r(esume) <table_name|--all>", color: :yellow)
@@ -141,6 +148,7 @@ module DbSucker
 
         def cancel_workers args
           if args[0].is_a?(String)
+            window.flashbang
             _detect_worker(args.join(" ")) do |wrk|
               wrk.cancel! "canceled by user"
             end
@@ -150,16 +158,29 @@ module DbSucker
         end
 
         def kill_ssh_poll
-          return if sklaventreiber.workers.select{|w| !w.done? || w.sshing }.any?
-          sklaventreiber.poll.try(:kill)
+          if sklaventreiber.workers.select{|w| !w.done? || w.sshing }.any?
+            app.print("\a")
+            prompt!("Error: cannot kill SSH poll whilst in use", color: :red)
+          else
+            window.flashbang
+            sklaventreiber.poll.try(:kill)
+          end
         end
 
         def kill_workers
+          window.flashbang
           Thread.list.each do |thr|
             thr.raise(Interrupt) if thr[:managed_worker]
           end
         end
 
+        def signal_threads
+          window.flashbang
+          Thread.list.each do |thr|
+            thr.signal if thr.respond_to?(:signal)
+          end
+        end
+
         def kill_app
           exit!
         end
@@ -171,4 +192,3 @@ module DbSucker
     end
   end
 end
-

data/lib/db_sucker/patches/developer.rb

@@ -12,7 +12,7 @@ module DbSucker
             end
             app.debug "IO-stats: {#{iostats * ", "}}"
           end
-          app.dump_core if Thread.list.length > 1
+          app.dump_core if app.filtered_threads.length > 1
           app.debug "RSS: #{app.human_bytes(`ps h -p #{Process.pid} -o rss`.strip.split("\n").last.to_i * 1024)}"
         end
 

data/lib/db_sucker/version.rb

@@ -1,4 +1,4 @@
 module DbSucker
-  VERSION = "3.2.0"
+  VERSION = "3.2.1"
   UPDATE_URL = "https://raw.githubusercontent.com/2called-chaos/db_sucker/master/VERSION"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: db_sucker
 version: !ruby/object:Gem::Version
-  version: 3.2.0
+  version: 3.2.1
 platform: ruby
 authors:
 - Sven Pachnit
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-07-05 00:00:00.000000000 Z
+date: 2021-02-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: curses
@@ -210,8 +210,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.3
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Sucks your remote databases via SSH for local tampering.