db_nazi 0.0.3 → 0.0.4

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: ef96777baa9820f3ac045b8d34c72186caaf3af8
+  data.tar.gz: 717b63040614818304ae8c8633948b1d1e796174
+SHA512:
+  metadata.gz: 5d46ba3ebc5ed79e5cce094797e0bc58c7607be681b031f2c290580992531bf99c6c589f39354ff1cd5ee8e49227b38947e88707608de6269faf07a1cb657c5c
+  data.tar.gz: c6d3435923defc3b29aca0bf0f89a2a4799057d0260024386344cb55f3892c16fda864a3db1f96528f2177d901fb1274361c5828ce1c93bf184eb00227cb7147

data/.gitignore

@@ -1 +1,2 @@
+/.bundle
 /Gemfile.lock

data/.travis.yml

@@ -4,36 +4,35 @@ script: bundle exec rake ci
 rvm: []  # only run the builds in the matrix below
 matrix:
   include:
-    - rvm: 1.9.2
+    - rvm: 1.9.3
       env: DB_NAZI_ADAPTER=sqlite3
-    - rvm: 1.9.2
+    - rvm: 1.9.3
       env: DB_NAZI_ADAPTER=mysql
-    - rvm: 1.9.2
+    - rvm: 1.9.3
       env: DB_NAZI_ADAPTER=mysql2
-    - rvm: 1.9.2
+    - rvm: 1.9.3
       before_script: psql -c 'create database myapp_test;' -U postgres
       env: DB_NAZI_ADAPTER=postgresql
 
-    - rvm: 1.9.3
+    - rvm: 2.1.0
       env: DB_NAZI_ADAPTER=sqlite3
-    - rvm: 1.9.3
+    - rvm: 2.1.0
       env: DB_NAZI_ADAPTER=mysql
-    - rvm: 1.9.3
+    - rvm: 2.1.0
       env: DB_NAZI_ADAPTER=mysql2
-    - rvm: 1.9.3
+    - rvm: 2.1.0
       before_script: psql -c 'create database myapp_test;' -U postgres
       env: DB_NAZI_ADAPTER=postgresql
 
-    - rvm: rbx-19mode
+    - rvm: rbx-2
       env: DB_NAZI_ADAPTER=sqlite3
-    - rvm: rbx-19mode
+    - rvm: rbx-2
       env: DB_NAZI_ADAPTER=mysql
-    - rvm: rbx-19mode
+    - rvm: rbx-2
       env: DB_NAZI_ADAPTER=mysql2
-    - rvm: rbx-19mode
+    - rvm: rbx-2
       before_script: psql -c 'create database myapp_test;' -U postgres
       env: DB_NAZI_ADAPTER=postgresql
 
-    # jruby-1.6.7 has a broken testrb - use head for now
-    - rvm: jruby-head
+    - rvm: jruby-19mode
       env: DB_NAZI_ADAPTER=jdbcmysql

data/CHANGELOG

@@ -1,3 +1,7 @@
+== 0.0.4 2014-02-14
+
+ * Rails 4 compatibility.
+
 == 0.0.3 2012-06-27
 
  * Disable DB Nazi when loading schema.

data/Gemfile

@@ -1,4 +1,7 @@
-source :rubygems
+source 'https://rubygems.org'
+gem 'ritual'
+gem 'minitest', '< 5'
+gem 'temporaries'
 gemspec
 
 case ENV['DB_NAZI_ADAPTER']

data/README.markdown

@@ -1,4 +1,4 @@
-## DB Nazi
+## DB Nazi [![Build Status](https://travis-ci.org/oggy/db_nazi.png)](https://travis-ci.org/oggy/db_nazi)
 
 Encourages good DB practices in Active Record migrations.
 

data/db_nazi.gemspec

@@ -16,8 +16,5 @@ Gem::Specification.new do |gem|
   gem.files         = `git ls-files`.split("\n")
   gem.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
 
-  gem.add_runtime_dependency 'activerecord', '~> 3.2.6'
-  gem.add_development_dependency 'ritual', '~> 0.4.1'
-  gem.add_development_dependency 'minitest', '~> 3.1.0'
-  gem.add_development_dependency 'temporaries', '~> 0.3.0'
+  gem.add_runtime_dependency 'activerecord', '< 5'
 end

data/lib/db_nazi/version.rb

@@ -1,5 +1,5 @@
 module DBNazi
-  VERSION = [0, 0, 3]
+  VERSION = [0, 0, 4]
 
   class << VERSION
     include Comparable

data/test/integration/test_integration.rb

@@ -15,10 +15,6 @@ describe DBNazi do
     Dir.chdir @original_pwd
   end
 
-  before do
-    DBNazi.reset
-  end
-
   it "raises an error when there is a careless migration" do
     create_bad_migration(1)
     run_migrations

data/test/test_helper.rb

@@ -49,8 +49,11 @@ MiniTest::Spec.class_eval do
   end
 
   def self.use_database
-    before { recreate_database }
-    after { drop_database }
+    include Module.new {
+      extend MiniTest::Spec::DSL
+      before { recreate_database }
+      after { drop_database }
+    }
   end
 
   # Migrations use Kernel.puts. Lame. This shuts them up.

data/test/unit/db_nazi/test_abstract_adapter.rb

@@ -9,6 +9,11 @@ describe DBNazi::AbstractAdapter do
   end
 
   describe "#add_column" do
+    it "still adds the column if ok" do
+      connection.add_column 'test_table', 'test_column', :boolean, null: false, default: false
+      connection.column_exists?('test_table', 'test_column', :boolean, null: false, default: false).must_equal true
+    end
+
     describe "when nullability is required" do
       use_attribute_value DBNazi, :require_nullability, true
 
@@ -63,6 +68,11 @@ describe DBNazi::AbstractAdapter do
       connection.add_column 'test_table', 'test_column', :boolean, null: false, default: false
     end
 
+    it "still changes the column if ok" do
+      connection.change_column 'test_table', 'test_column', :boolean, null: true
+      connection.column_exists?('test_table', 'test_column', :boolean, null: true).must_equal true
+    end
+
     describe "when nullability is required" do
       use_attribute_value DBNazi, :require_nullability, true
 
@@ -117,6 +127,11 @@ describe DBNazi::AbstractAdapter do
       connection.add_column 'test_table', 'test_column', :boolean, null: true
     end
 
+    it "still adds the index if ok" do
+      connection.add_index 'test_table', 'test_column', unique: false
+      connection.index_exists?('test_table', 'test_column').must_equal true
+    end
+
     describe "when index uniqueness is required" do
       use_attribute_value DBNazi, :require_index_uniqueness, true
 

data/test/unit/db_nazi/test_migration_proxy.rb

@@ -8,13 +8,7 @@ describe DBNazi::MigrationProxy do
   before do
     @original_pwd = Dir.pwd
     Dir.chdir "#{ROOT}/test/tmp"
-  end
-
-  after do
-    Dir.chdir @original_pwd
-  end
 
-  before do
     @migration_proxy = ActiveRecord::MigrationProxy.new("test_migration", 10, "test_migration.rb", nil)
     @migration_class = Class.new(ActiveRecord::Migration) do
       attr_reader :enabled
@@ -27,6 +21,10 @@ describe DBNazi::MigrationProxy do
     @migration_proxy.singleton_class.send(:define_method, :migration) { migration }
   end
 
+  after do
+    Dir.chdir @original_pwd
+  end
+
   describe "#migrate" do
     it "disables DBNazi when no_nazi is used" do
       @migration_class.no_nazi

data/test/unit/db_nazi/test_table.rb

@@ -12,6 +12,13 @@ describe DBNazi::TableDefinition do
       connection.create_table 'test_table'
     end
 
+    it "still creates the column if ok" do
+      connection.change_table 'test_table', bulk: true do |t|
+        t.column 'test_column', :boolean, null: true
+      end
+      connection.column_exists?('test_table', 'test_column', :boolean, null: true).must_equal true
+    end
+
     describe "when nullability is required" do
       use_attribute_value DBNazi, :require_nullability, true
 
@@ -82,6 +89,13 @@ describe DBNazi::TableDefinition do
       end
     end
 
+    it "still creates the index if ok" do
+      connection.change_table 'test_table', bulk: true do |t|
+        t.index 'test_column', unique: false
+      end
+      connection.index_exists?('test_table', 'test_column', unique: false).must_equal true
+    end
+
     describe "when index uniqueness is required" do
       use_attribute_value DBNazi, :require_index_uniqueness, true
 
@@ -124,6 +138,13 @@ describe DBNazi::TableDefinition do
       end
     end
 
+    it "still changes the column if ok" do
+      connection.change_table 'test_table', bulk: true do |t|
+        t.change 'test_column', :boolean, null: false, default: false
+      end
+      connection.column_exists?('test_table', 'test_column', :boolean, null: false, default: false).must_equal true
+    end
+
     describe "when nullability is required" do
       use_attribute_value DBNazi, :require_nullability, true
 

data/test/unit/db_nazi/test_table_definition.rb

@@ -8,6 +8,13 @@ describe DBNazi::TableDefinition do
   end
 
   describe "#column" do
+    it "still creates the column if ok" do
+      connection.create_table 'test_table' do |t|
+        t.column 'test_column', :boolean, null: true
+      end
+      connection.column_exists?('test_table', 'test_column', :boolean, null: true).must_equal true
+    end
+
     describe "when nullability is required" do
       use_attribute_value DBNazi, :require_nullability, true
 

metadata

@@ -1,80 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: db_nazi
 version: !ruby/object:Gem::Version
-  version: 0.0.3
-  prerelease: 
+  version: 0.0.4
 platform: ruby
 authors:
 - George Ogata
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-06-27 00:00:00.000000000 Z
+date: 2014-02-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "<"
       - !ruby/object:Gem::Version
-        version: 3.2.6
+        version: '5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "<"
       - !ruby/object:Gem::Version
-        version: 3.2.6
-- !ruby/object:Gem::Dependency
-  name: ritual
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 0.4.1
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 0.4.1
-- !ruby/object:Gem::Dependency
-  name: minitest
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 3.1.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 3.1.0
-- !ruby/object:Gem::Dependency
-  name: temporaries
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 0.3.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 0.3.0
+        version: '5'
 description: ''
 email:
 - george.ogata@gmail.com
@@ -82,8 +31,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .travis.yml
+- ".gitignore"
+- ".travis.yml"
 - CHANGELOG
 - Gemfile
 - LICENSE
@@ -111,33 +60,26 @@ files:
 homepage: ''
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -2333184105652215530
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -2333184105652215530
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 2.2.0
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Encourage good DB practices in ActiveRecord migrations.
 test_files:
 - test/database.yml