db_meta 0.12.0 → 0.14.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 72b8b2a1d2345a78bad679153e910c7a092ff004495f03bc9f8fc14518080208
-  data.tar.gz: 9a097fa844e9694e3282cc3ad6e5d05318e6e87bae9194e3a479f66f6c60df5b
+  metadata.gz: 2a8daf933344c242f2d8b50b218bddb5a4cf488a729316ad11c658af6c5cb782
+  data.tar.gz: b20f8d156bdfd1839d52781603a4abb83a099adfa415399acf53308cf887a566
 SHA512:
-  metadata.gz: a1ca4509ecf3583ec46fd1c69ed0edcf17bbe4cceddf8675abf38e7818f00dcc0ecfd99793bf65b2d6ecff13387d27b256491d28cefbd115f2400a5429999ffc
-  data.tar.gz: 6633e673c2deb5079879a21efd98569728ae8811b4525d8bfd75fff9e39d6f52811a68830eb55e09a26f439a6cde3b5227031ee4628a594bc8c86fa3cfa2547d
+  metadata.gz: cdddc2bfff37d407e381f9a642dd586c6ecf728f3db170f9db6e0ffc03d4c999633ee8c840d80fb4c2ced75910e399f8ea063825000c143bd4df87ea725eb863
+  data.tar.gz: 5ff480c88420a57634dc65bdd99dcf418a82bbd978457a42b8fd610c4c6d4896243f6b62fa312536b08efc4b21fc43ee4df90694b55c091a1d14c90d646e70d8

data/.github/workflows/01_test.yml

@@ -0,0 +1,67 @@
+name: 01 - Test
+
+on:
+  push:
+    branches:
+      - "*"
+
+  pull_request:
+    branches:
+      - "*"
+
+  schedule:
+  - cron: 0 2 * * 3,6
+
+  # Allows you to run this workflow manually from the Actions tab
+  workflow_dispatch:
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    env:
+      CC_TEST_REPORTER_ID: ${{ secrets.CC_TEST_REPORTER_ID }}
+      ORACLE_HOME: /opt/instantclient_23_7
+      LD_LIBRARY_PATH: /opt/instantclient_23_7
+      OCI_DIR: /opt/instantclient_23_7
+      NLS_LANG: AMERICAN_AMERICA.AL32UTF8
+
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby: [ '4.0', '3.4', '3.3']
+
+    name: Ruby ${{ matrix.ruby }}
+    steps:
+    - uses: actions/checkout@v6
+
+    - name: Install Oracle instant client
+      run: |
+        mkdir -p /opt && cd /opt
+        curl https://download.oracle.com/otn_software/linux/instantclient/2370000/instantclient-basiclite-linux.x64-23.7.0.25.01.zip --output instantclient.zip
+        curl https://download.oracle.com/otn_software/linux/instantclient/2370000/instantclient-sdk-linux.x64-23.7.0.25.01.zip --output instantclient_sdk.zip
+        curl https://download.oracle.com/otn_software/linux/instantclient/2370000/instantclient-sqlplus-linux.x64-23.7.0.25.01.zip --output instantclient_sqlplus.zip
+        unzip -o instantclient.zip
+        unzip -o instantclient_sdk.zip
+        unzip -o instantclient_sqlplus.zip
+
+    - name: libaio.so.1 fix with symbolic link
+      run: |
+        TARGET="/lib/x86_64-linux-gnu/libaio.so.1"
+        SOURCE="/lib/x86_64-linux-gnu/libaio.so.1t64"
+
+        # Check if the symbolic link already exists
+        if [ ! -e "$TARGET" ]; then
+            sudo ln -s "$SOURCE" "$TARGET"
+        fi
+
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+        bundler: latest
+        bundler-cache: true
+        cache-version: 3
+
+    - name: Run default task
+      run: |
+        bundle exec rake

data/.github/workflows/02_release.yml

@@ -0,0 +1,57 @@
+name: 02 - Release
+
+on:
+  push:
+    tags:
+      - 'v*'
+
+jobs:
+
+  build:
+    runs-on: ubuntu-latest
+    permissions:
+      id-token: write
+      contents: write
+    env:
+      ORACLE_HOME: /opt/instantclient_23_7
+      LD_LIBRARY_PATH: /opt/instantclient_23_7
+      OCI_DIR: /opt/instantclient_23_7
+      NLS_LANG: AMERICAN_AMERICA.AL32UTF8
+
+    steps:
+    - name: Checkout current code
+      uses: actions/checkout@v6
+
+    - name: Install Oracle instant client
+      run: |
+        mkdir -p /opt && cd /opt
+        curl https://download.oracle.com/otn_software/linux/instantclient/2370000/instantclient-basiclite-linux.x64-23.7.0.25.01.zip --output instantclient.zip
+        curl https://download.oracle.com/otn_software/linux/instantclient/2370000/instantclient-sdk-linux.x64-23.7.0.25.01.zip --output instantclient_sdk.zip
+        curl https://download.oracle.com/otn_software/linux/instantclient/2370000/instantclient-sqlplus-linux.x64-23.7.0.25.01.zip --output instantclient_sqlplus.zip
+        unzip -o instantclient.zip
+        unzip -o instantclient_sdk.zip
+        unzip -o instantclient_sqlplus.zip
+
+    - name: libaio.so.1 fix with symbolic link
+      run: |
+        TARGET="/lib/x86_64-linux-gnu/libaio.so.1"
+        SOURCE="/lib/x86_64-linux-gnu/libaio.so.1t64"
+
+        # Check if the symbolic link already exists
+        if [ ! -e "$TARGET" ]; then
+            sudo ln -s "$SOURCE" "$TARGET"
+        fi
+
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: '4.0'
+        bundler: latest
+        bundler-cache: true
+        cache-version: 1
+
+    - name: Build gem
+      run: gem build *.gemspec
+
+    - name: Push to Rubygems
+      uses: rubygems/release-gem@v1

data/.ruby-version

@@ -1 +1 @@
-3.3.6
+4.0.3

data/.tool-versions

@@ -1 +1 @@
-ruby 3.3.6
+ruby 4.0.3

data/CHANGELOG.md

@@ -1,3 +1,36 @@
+## [0.14.0] - 2026-04-28
+
+### Changed
+- Reuse a single OCI8 logical connection per worker thread for the duration of the fetch instead of acquiring/logging off on every type fetch. Drastically reduces session attach/detach traffic against the connection pool, which avoids the per-attach overhead (and the 23c Instant Client byte-leak symptom) on long extracts.
+- Batch-load constraint metadata via two bulk queries against `USER_CONSTRAINTS` and `USER_CONS_COLUMNS` once before the parallel object fetch, and have `Constraint#fetch` read from an in-memory cache. Removes 2-3 round-trips per constraint.
+- Constraints with Oracle-generated `SYS_*` names are now emitted without an explicit `CONSTRAINT <name>` clause, so DDL diffs across instances aren't dominated by name churn. User-given names are preserved.
+- Redundant `SYS_*` NOT NULL CHECK constraints (whose condition is just `"COL" IS NOT NULL`) are filtered out — the column-level NOT NULL in the table DDL already covers them.
+- Fixed `View#fetch` to reuse the acquired connection (previously called `Connection.instance.get` twice, leaking a logical connection per view).
+- Fixed `View#extract` crash when a view has columns without comments (`column.comment.size` on nil).
+- Fixed `Table#fetch` ensure logic (was `rescue` instead of `ensure`).
+- Fixed `Column.all` typo (`loggoff` → cleanup no longer needed).
+
+### Added
+- README troubleshooting section for macOS / Apple Silicon: short tip covering both the 23c OID lookup hang and the `libclntsh` ↔ OpenLDAP symbol-clash, with the shared `tnsnames.ora` + `NAMES.DIRECTORY_PATH=(TNSNAMES, EZCONNECT)` fix and links to the relevant ruby-oci8 / Oracle docs.
+- Significantly expanded test coverage (49 → 125 examples; line coverage 58.94% → ~86%).
+- Added Ruby 4.0 to the supported/tested matrix.
+
+### Removed
+- Dropped Ruby 3.2 from the actively tested matrix (EOL 31 Mar 2026).
+
+## [0.13.1] - 2025-11-09
+
+### Added
+- Trusted Publisher
+
+### Changed
+- Updated development dependencies
+
+## [0.13.0] - 2024-12-25
+
+### Changed
+- Support for Ruy 3.4
+
 ## [0.12.0] - 2024-06-15
 
 ### Changed

data/README.md

@@ -1,14 +1,16 @@
 [![Gem Version](https://badge.fury.io/rb/db_meta.svg)](https://badge.fury.io/rb/db_meta)
-[![Maintainability](https://api.codeclimate.com/v1/badges/ffd17b164da909c5c172/maintainability)](https://codeclimate.com/github/thomis/db_meta/maintainability)
-[![Test Coverage](https://api.codeclimate.com/v1/badges/ffd17b164da909c5c172/test_coverage)](https://codeclimate.com/github/thomis/db_meta/test_coverage)
-[![ci](https://github.com/thomis/db_meta/actions/workflows/ci.yml/badge.svg)](https://github.com/thomis/db_meta/actions/workflows/ci.yml)
+[![01 - Test](https://github.com/thomis/db_meta/actions/workflows/01_test.yml/badge.svg)](https://github.com/thomis/db_meta/actions/workflows/01_test.yml)
+[![02 - Release](https://github.com/thomis/db_meta/actions/workflows/02_release.yml/badge.svg)](https://github.com/thomis/db_meta/actions/workflows/02_release.yml)
 
-# Welcome to db_meta
-Database meta and core data extraction.
+# db_meta
 
-## Is it production ready?
+Extract Oracle schema metadata and core data as SQL DDL files.
 
-Well, I would not say, but I am using it already for my database development work where the gem covers my needs. Be careful and check details. Please create an issue when you think that someting is wrong or missing.
+`db_meta` connects to an Oracle schema and writes out DDL for every object (tables, views, indexes, constraints, packages, sequences, synonyms, grants, …), plus optional `INSERT` scripts for reference/lookup data. The output is a folder of `.sql` files organized by object type — suitable for checking into version control, diffing across environments, or seeding a fresh schema.
+
+## Status
+
+Used in day-to-day database development by the author. It covers the most common Oracle object types but is not exhaustive — exotic features (advanced storage clauses, partitioning details, etc.) may be missing or simplified. Spot-check the output before relying on it for a migration, and please open an issue if you hit something that's wrong or missing.
 
 ## Installation
 via Gemfile
@@ -31,6 +33,13 @@ meta.fetch
 meta.extract
 ```
 
+## Output conventions
+
+A few decisions worth knowing about, especially if you compare extracts across instances:
+
+- **Auto-generated `SYS_*` constraint names are stripped from the output.** Oracle invents names like `SYS_C0012345` for unnamed constraints, and those names differ between instances — making schema diffs noisy. Constraints with a `SYS_*` name are emitted without an explicit `CONSTRAINT <name>` clause; on import, Oracle just generates a fresh name. User-given constraint names are preserved as-is.
+- **Redundant `NOT NULL` CHECK constraints are omitted.** Oracle exposes column-level `NOT NULL` both as a column attribute and as a `SYS_*` CHECK constraint with a body of `"COL" IS NOT NULL`. The column-level form is already in the table DDL, so the duplicate CHECK is filtered out.
+
 ## Supported Databases
 - Oracle
 
@@ -50,9 +59,14 @@ meta.extract
 
 Currently supported and tested ruby versions are:
 
-- 3.3
-- 3.2
-- 3.1
+- 4.0 (EOL 31 Mar 2029)
+- 3.4 (EOL 31 Mar 2028)
+- 3.3 (EOL 31 Mar 2027)
+
+Ruby versions not tested anymore:
+
+- 3.2 (EOL 31 Mar 2026)
+- 3.1 (EOL 31 Mar 2025)
 - 3.0 (EOL 31 Mar 2024)
 - 2.7 (EOL 31 Mar 2023)
 - 2.6 (EOL 31 Mar 2022)
@@ -60,8 +74,61 @@ Currently supported and tested ruby versions are:
 ## Planned Features
 - Storage and tablespace clause
 
+## Troubleshooting (macOS / Apple Silicon)
+
+If `OCI8.new` hangs for ~10s, prints "byte leak" gibberish, or crashes with `ldap_first_entry: Assertion …`, the issue is almost always that the Instant Client is trying to use LDAP/OID for database name resolution. The fix is the same in both cases: tell Oracle to use a local `tnsnames.ora` instead of LDAP. Create `~/opt/oracle/admin/tnsnames.ora` with your DB alias and `~/opt/oracle/admin/sqlnet.ora` containing `NAMES.DIRECTORY_PATH=(TNSNAMES, EZCONNECT)`, then `export TNS_ADMIN=$HOME/opt/oracle/admin`.
+
+For background and the `libclntsh` ↔ OpenLDAP symbol-clash variant (caused by Oracle's bundled LDAP client and Homebrew's OpenLDAP both loading into the same Ruby process), see:
+
+- [ruby-oci8 #32 — OCI8 hangs when switching to LDAP](https://github.com/kubo/ruby-oci8/issues/32)
+- [ruby-oci8 #41 — Assertion failure using LDAP](https://github.com/kubo/ruby-oci8/issues/41)
+- [Oracle Instant Client FAQ](https://www.oracle.com/database/technologies/instant-client/faqs.html)
+
+## Publishing
+
+This project uses [Trusted Publishing](https://guides.rubygems.org/trusted-publishing/) to securely publish gems to RubyGems.org. Trusted Publishing eliminates the need for long-lived API tokens by using OpenID Connect (OIDC) to establish a trusted relationship between GitHub Actions and RubyGems.org.
+
+With Trusted Publishing configured, gem releases are automatically published to RubyGems when the release workflow runs, providing a more secure and streamlined publishing process.
+
 ## Contributing
-...
+
+We welcome contributions to db_meta! Here's how you can help:
+
+1. **Fork the repository** - Create your own fork of the code
+2. **Create a feature branch** - Make your changes in a new git branch:
+   ```
+   git checkout -b my-new-feature
+   ```
+3. **Make your changes** - Write your code and tests
+4. **Run the tests** - Ensure all tests pass:
+   ```
+   bundle exec rake
+   ```
+5. **Commit your changes** - Write clear and meaningful commit messages:
+   ```
+   git commit -am 'Add some feature'
+   ```
+6. **Push to your branch** - Push your changes to GitHub:
+   ```
+   git push origin my-new-feature
+   ```
+7. **Create a Pull Request** - Open a PR from your fork to the main repository
+
+### Guidelines
+
+- Write tests for any new functionality
+- Follow the existing code style and conventions
+- Update documentation as needed
+- Keep commits focused and atomic
+- Write clear commit messages
+
+### Reporting Issues
+
+Found a bug or have a feature request? Please open an issue on GitHub with:
+- A clear title and description
+- Steps to reproduce (for bugs)
+- Expected vs actual behavior
+- Ruby version and environment details
 
 ## License
 db_meta is released under [Apache License, Version 2.0](https://opensource.org/licenses/Apache-2.0)

data/db_meta.gemspec

@@ -18,11 +18,12 @@ Gem::Specification.new do |spec|
   spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency "bundler", "~> 2.3"
+  spec.add_development_dependency "bundler", ">= 2.3"
   spec.add_development_dependency "rake", "~> 13.1"
   spec.add_development_dependency "rspec", "~> 3.13"
   spec.add_development_dependency "standard", "~> 1.34"
   spec.add_development_dependency "simplecov", "~> 0.21"
 
   spec.add_dependency "ruby-oci8", "~> 2.2"
+  spec.add_dependency "logger", "~> 1.6"
 end

data/lib/db_meta/abstract.rb

@@ -20,7 +20,7 @@ module DbMeta
       @include = args[:include]
 
       @objects = []
-      @invalid_objects = Hash.new([])
+      @invalid_objects = Hash.new { |h, key| h[key] = [] }
 
       @base_folder = args[:base_folder] || File.expand_path(File.join(Dir.pwd, "/#{@username}@#{@instance}"))
 

data/lib/db_meta/oracle/connection.rb

@@ -5,6 +5,8 @@ module DbMeta
     class Connection
       include Singleton
 
+      THREAD_KEY = :db_meta_oracle_connection
+
       attr_accessor :username, :password, :database_instance
       attr_reader :pool
       attr_reader :worker
@@ -23,11 +25,22 @@ module DbMeta
           Log.info("Connected to #{@username}@#{@database_instance}")
         end
 
-        # create and return logical connection. It creates physical connection as needed.
-        ::OCI8.new(@username, @password, @pool)
+        # one logical connection per thread - reused across all fetches in that thread
+        Thread.current[THREAD_KEY] ||= ::OCI8.new(@username, @password, @pool)
+      end
+
+      def release_thread_connection
+        connection = Thread.current[THREAD_KEY]
+        return unless connection
+        connection.logoff
+      rescue
+        # connection may already be closed
+      ensure
+        Thread.current[THREAD_KEY] = nil
       end
 
       def disconnect
+        release_thread_connection
         return unless @pool
         @pool.destroy
         Log.info("Logged off from #{@username}@#{@database_instance}")

data/lib/db_meta/oracle/objects.rb

@@ -26,6 +26,9 @@ module DbMeta
       end
 
       def fetch(args = {})
+        # bulk-load metadata that would otherwise drive N round-trips per object
+        Constraint.preload
+
         # fetch details in parallel
         # number of threads = physical connections / 2 to prevent application locking
         worker = (1..Connection.instance.worker / 2).map {
@@ -35,6 +38,8 @@ module DbMeta
               object.fetch
             end
           rescue ThreadError
+          ensure
+            Connection.instance.release_thread_connection
           end
         }
         worker.map(&:join) # wait until all are done
@@ -215,8 +220,6 @@ module DbMeta
         Log.info("Objects: #{items.size}, Object Types: #{types.uniq.size}")
 
         objects
-      ensure
-        connection&.logoff # closes logical connection
       end
     end
   end

data/lib/db_meta/oracle/types/column.rb

@@ -36,8 +36,6 @@ module DbMeta
         cursor.close
 
         columns
-      rescue
-        connection.loggoff
       end
 
       private

data/lib/db_meta/oracle/types/comment.rb

@@ -9,8 +9,6 @@ module DbMeta
         while (row = cursor.fetch)
           @text = row[0]
         end
-      ensure
-        connection.logoff
       end
     end
   end

data/lib/db_meta/oracle/types/constraint.rb

@@ -5,6 +5,72 @@ module DbMeta
 
       attr_reader :constraint_type, :table_name, :search_condition, :referential_constraint, :delete_rule, :columns
 
+      @@cache = {}
+      @@cache_mutex = Mutex.new
+
+      def self.preload(args = {})
+        connection_class = args[:connection_class] || Connection
+        connection = connection_class.instance.get
+
+        meta = {}
+        cursor = connection.exec(
+          "select constraint_name, constraint_type, table_name, search_condition, r_constraint_name, delete_rule " \
+          "from user_constraints"
+        )
+        cursor.fetch_hash do |row|
+          name = row["CONSTRAINT_NAME"]
+          type = translate_constraint_type(row["CONSTRAINT_TYPE"])
+          search_condition = row["SEARCH_CONDITION"]
+
+          # Skip Oracle-generated NOT NULL CHECK constraints. They are already
+          # represented by the column's NOT NULL clause in the table DDL, so
+          # emitting them again is redundant noise that breaks schema diffs.
+          next if redundant_not_null?(name, type, search_condition)
+
+          meta[name] = {
+            constraint_type: type,
+            table_name: row["TABLE_NAME"],
+            search_condition: search_condition,
+            r_constraint_name: row["R_CONSTRAINT_NAME"],
+            delete_rule: row["DELETE_RULE"],
+            columns: []
+          }
+        end
+        cursor.close
+
+        cursor = connection.exec(
+          "select constraint_name, column_name, position " \
+          "from user_cons_columns order by constraint_name, position"
+        )
+        cursor.fetch_hash do |row|
+          entry = meta[row["CONSTRAINT_NAME"]]
+          next unless entry
+          entry[:columns] << row["COLUMN_NAME"]
+        end
+        cursor.close
+
+        @@cache_mutex.synchronize { @@cache = meta }
+      end
+
+      def self.system_generated?(name)
+        name.to_s.start_with?("SYS_")
+      end
+
+      def self.redundant_not_null?(name, type, search_condition)
+        return false unless system_generated?(name) && type == "CHECK"
+        return false if search_condition.nil?
+        # Match patterns like: "COL_NAME" IS NOT NULL  or  COL_NAME IS NOT NULL
+        !!search_condition.match?(/\A\s*"?[A-Z0-9_$#]+"?\s+IS\s+NOT\s+NULL\s*\z/i)
+      end
+
+      def self.cache
+        @@cache
+      end
+
+      def self.reset_cache
+        @@cache_mutex.synchronize { @@cache = {} }
+      end
+
       def initialize(args = {})
         super
 
@@ -13,37 +79,29 @@ module DbMeta
       end
 
       def fetch(args = {})
-        connection = Connection.instance.get
-        cursor = connection.exec("select * from user_constraints where constraint_name = '#{@name}'")
-        cursor.fetch_hash do |item|
-          @constraint_type = translate_constraint_type(item["CONSTRAINT_TYPE"])
-          @extract_type = :merged if @constraint_type == "FOREIGN KEY"
-          @table_name = item["TABLE_NAME"]
-          @search_condition = item["SEARCH_CONDITION"]
-          @delete_rule = item["DELETE_RULE"]
-
-          if @constraint_type == "FOREIGN KEY"
-            constraint = Constraint.new("OBJECT_TYPE" => "CONSTRAINT", "OBJECT_NAME" => item["R_CONSTRAINT_NAME"])
-            constraint.fetch
-            @referential_constraint = constraint
-          end
-        end
-        cursor.close
+        entry = @@cache[@name]
+        return unless entry
 
-        # get affected columns
-        cursor = connection.exec("select * from user_cons_columns where constraint_name = '#{@name}' order by position")
-        cursor.fetch_hash do |item|
-          @columns << item["COLUMN_NAME"]
+        @constraint_type = entry[:constraint_type]
+        @table_name = entry[:table_name]
+        @search_condition = entry[:search_condition]
+        @delete_rule = entry[:delete_rule]
+        @columns = entry[:columns].dup
+        @extract_type = :merged if @constraint_type == "FOREIGN KEY"
+
+        if @constraint_type == "FOREIGN KEY" && entry[:r_constraint_name]
+          @referential_constraint = Constraint.new(
+            "OBJECT_TYPE" => "CONSTRAINT",
+            "OBJECT_NAME" => entry[:r_constraint_name]
+          )
+          @referential_constraint.fetch
         end
-        cursor.close
-      ensure
-        connection.logoff
       end
 
       def extract(args = {})
         buffer = []
         buffer << "ALTER TABLE #{@table_name} ADD ("
-        buffer << "  CONSTRAINT #{@name}"
+        buffer << "  CONSTRAINT #{@name}" unless Constraint.system_generated?(@name)
 
         case @constraint_type
         when "CHECK"
@@ -69,9 +127,7 @@ module DbMeta
         ["PRIMARY KEY", "FOREIGN KEY", "UNIQUE", "CHECK"].index(type)
       end
 
-      private
-
-      def translate_constraint_type(type)
+      def self.translate_constraint_type(type)
         case type
         when "P"
           "PRIMARY KEY"

data/lib/db_meta/oracle/types/database_link.rb

@@ -15,8 +15,6 @@ module DbMeta
           @host = row[2].to_s
         end
         cursor.close
-      ensure
-        connection.logoff
       end
 
       def extract(args = {})

data/lib/db_meta/oracle/types/function.rb

@@ -14,8 +14,6 @@ module DbMeta
           @source << row[0].to_s
         end
         cursor.close
-      ensure
-        connection.logoff
       end
 
       def extract(args = {})

data/lib/db_meta/oracle/types/index.rb

@@ -38,12 +38,10 @@ module DbMeta
           @columns[idx] = row[0] # replace sys_... entry
         end
         cursor.close
-      ensure
-        connection.logoff
       end
 
       def extract(args = {})
-        "CREATE#{(@uniqueness == "UNIQUE") ? " UNIQUE" : nil} INDEX #{@name} ON #{@table_name}(#{@columns.join(", ")});"
+        "CREATE#{" UNIQUE" if @uniqueness == "UNIQUE"} INDEX #{@name} ON #{@table_name}(#{@columns.join(", ")});"
       end
     end
   end

data/lib/db_meta/oracle/types/materialized_view.rb

@@ -33,8 +33,6 @@ module DbMeta
           @comment = item["COMMENTS"]
         end
         cursor.close
-      ensure
-        connection.logoff
       end
 
       def extract(args = {})

data/lib/db_meta/oracle/types/package.rb

@@ -6,22 +6,21 @@ module DbMeta
       attr_reader :header, :body
 
       def fetch
+        connection = Connection.instance.get
+
         @header = ""
-        cursor = Connection.instance.get.exec("select text from user_source where type = 'PACKAGE' and name = '#{@name}' order by line")
+        cursor = connection.exec("select text from user_source where type = 'PACKAGE' and name = '#{@name}' order by line")
         while (row = cursor.fetch)
           @header << row[0].to_s
         end
         cursor.close
 
         @body = ""
-        connection = Connection.instance.get
         cursor = connection.exec("select text from user_source where type = 'PACKAGE BODY' and name = '#{@name}' order by line")
         while (row = cursor.fetch)
           @body << row[0].to_s
         end
         cursor.close
-      ensure
-        connection.logoff
       end
 
       def extract(args = {})

data/lib/db_meta/oracle/types/procedure.rb

@@ -14,8 +14,6 @@ module DbMeta
           @source << row[0].to_s
         end
         cursor.close
-      ensure
-        connection.logoff
       end
 
       def extract(args = {})

data/lib/db_meta/oracle/types/queue.rb

@@ -23,8 +23,6 @@ module DbMeta
           @compatible = row["COMPATIBLE"]
         end
         cursor.close
-      ensure
-        connection.logoff
       end
 
       def extract(args = {})

data/lib/db_meta/oracle/types/sequence.rb

@@ -19,8 +19,6 @@ module DbMeta
           @last_number = row[6].to_i
         end
         cursor.close
-      ensure
-        connection.logoff
       end
 
       def extract(args = {})

data/lib/db_meta/oracle/types/synonym.rb

@@ -21,8 +21,6 @@ module DbMeta
           @db_link = row[2].to_s
         end
         cursor.close
-      ensure
-        connection.logoff
       end
 
       def extract(args = {})

data/lib/db_meta/oracle/types/table.rb

@@ -36,8 +36,6 @@ module DbMeta
           @duration = row[3].to_s
         end
         cursor.close
-      rescue
-        connection.logoff
       end
 
       def extract(args = {})
@@ -54,7 +52,7 @@ module DbMeta
         if @iot_type == "IOT"
           constraint = @constraints.find { |c| c.constraint_type == "PRIMARY KEY" }
           buffer[-1] += ","
-          buffer << "  CONSTRAINT #{constraint.name}"
+          buffer << "  CONSTRAINT #{constraint.name}" unless Constraint.system_generated?(constraint.name)
           buffer << "  PRIMARY KEY (#{constraint.columns.join(", ")})"
           buffer << "  ENABLE VALIDATE"
         end

data/lib/db_meta/oracle/types/table_data_collection.rb

@@ -44,8 +44,6 @@ module DbMeta
         buffer << nil
 
         buffer.join("\n")
-      ensure
-        connection.logoff
       end
 
       def ddl_drop

data/lib/db_meta/oracle/types/trigger.rb

@@ -27,8 +27,6 @@ module DbMeta
         parse_trigger_type
 
         cursor.close
-      ensure
-        connection.logoff
       end
 
       def extract(args = {})

data/lib/db_meta/oracle/types/type.rb

@@ -19,8 +19,6 @@ module DbMeta
           @body << row[0].to_s
         end
         cursor.close
-      ensure
-        connection.logoff
       end
 
       def extract(args = {})

data/lib/db_meta/oracle/types/view.rb

@@ -15,13 +15,11 @@ module DbMeta
 
         @source = ""
         connection = Connection.instance.get
-        cursor = Connection.instance.get.exec("select text from user_views where view_name = '#{@name}'")
+        cursor = connection.exec("select text from user_views where view_name = '#{@name}'")
         while (row = cursor.fetch)
           @source << row[0].to_s
         end
         cursor.close
-      ensure
-        connection.logoff
       end
 
       def extract(args = {})
@@ -47,7 +45,7 @@ module DbMeta
 
         # view column comments
         @columns.each do |column|
-          next if column.comment.size == 0
+          next if column.comment.nil? || column.comment.size == 0
           buffer << "COMMENT ON COLUMN #{@name}.#{column.name} IS '#{column.comment.gsub("'", "''")}';"
         end
 

data/lib/db_meta/version.rb

@@ -1,3 +1,3 @@
 module DbMeta
-  VERSION = "0.12.0"
+  VERSION = "0.14.0"
 end

metadata

@@ -1,27 +1,26 @@
 --- !ruby/object:Gem::Specification
 name: db_meta
 version: !ruby/object:Gem::Version
-  version: 0.12.0
+  version: 0.14.0
 platform: ruby
 authors:
 - Thomi
-autorequire: 
 bindir: exe
 cert_chain: []
-date: 2024-11-22 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '2.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '2.3'
 - !ruby/object:Gem::Dependency
@@ -94,6 +93,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.2'
+- !ruby/object:Gem::Dependency
+  name: logger
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.6'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.6'
 description: Database meta and core data extraction.
 email:
 - thomas.steiner@ikey.ch
@@ -102,8 +115,8 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".github/dependabot.yml"
-- ".github/workflows/cd.yml"
-- ".github/workflows/ci.yml"
+- ".github/workflows/01_test.yml"
+- ".github/workflows/02_release.yml"
 - ".gitignore"
 - ".rspec"
 - ".ruby-version"
@@ -158,7 +171,6 @@ homepage: https://github.com/thomis/db_meta
 licenses:
 - Apache-2.0
 metadata: {}
-post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -173,8 +185,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.22
-signing_key: 
+rubygems_version: 4.0.6
 specification_version: 4
 summary: Database meta and core data extraction
 test_files: []

data/.github/workflows/cd.yml

@@ -1,46 +0,0 @@
-name: cd
-
-on:
-  workflow_dispatch:
-
-jobs:
-
-  build:
-    runs-on: ubuntu-latest
-    env:
-      ORACLE_HOME: /opt/instantclient_21_12
-      LD_LIBRARY_PATH: /opt/instantclient_21_12
-      OCI_DIR: /opt/instantclient_21_12
-      NLS_LANG: AMERICAN_AMERICA.AL32UTF8
-
-    steps:
-    - name: Checkout current code
-      uses: actions/checkout@v4
-
-    - name: Install Oracle instant client
-      run: |
-        mkdir -p /opt && cd /opt
-        curl https://download.oracle.com/otn_software/linux/instantclient/2112000/instantclient-basic-linux.x64-21.12.0.0.0dbru.zip --output instantclient.zip
-        curl https://download.oracle.com/otn_software/linux/instantclient/2112000/instantclient-sdk-linux.x64-21.12.0.0.0dbru.zip --output instantclient_sdk.zip
-        unzip instantclient.zip
-        unzip instantclient_sdk.zip
-
-    - name: Set up Ruby
-      uses: ruby/setup-ruby@v1
-      with:
-        ruby-version: '3.3'
-        bundler: latest
-        bundler-cache: true
-        cache-version: 1
-
-    - name: Push to Rubygems
-      env:
-        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      run: |
-        git config --global user.email "thomas.steiner@ikey.ch"
-        git config --global user.name "thomis"
-        mkdir ~/.gem
-        echo -e "---\n:rubygems_api_key: ${{ secrets.RUBYGEMS_API_KEY }}" > ~/.gem/credentials
-        chmod 600 ~/.gem/credentials
-        bundle exec rake release
-        rm ~/.gem/credentials

data/.github/workflows/ci.yml

@@ -1,65 +0,0 @@
-name: ci
-
-on:
-  push:
-    branches:
-      - "*"
-
-  pull_request:
-    branches:
-      - "*"
-
-  schedule:
-  - cron: 0 2 * * 3,6
-
-  # Allows you to run this workflow manually from the Actions tab
-  workflow_dispatch:
-
-jobs:
-  build:
-    runs-on: ubuntu-latest
-    env:
-      CC_TEST_REPORTER_ID: ${{ secrets.CC_TEST_REPORTER_ID }}
-      ORACLE_HOME: /opt/instantclient_21_12
-      LD_LIBRARY_PATH: /opt/instantclient_21_12
-      OCI_DIR: /opt/instantclient_21_12
-      NLS_LANG: AMERICAN_AMERICA.AL32UTF8
-
-    strategy:
-      fail-fast: false
-      matrix:
-        ruby: [ '3.3', '3.2', '3.1', '3.0']
-
-    name: Ruby ${{ matrix.ruby }}
-    steps:
-    - uses: actions/checkout@v4
-
-    - name: Install Oracle instant client
-      run: |
-        mkdir -p /opt && cd /opt
-        curl https://download.oracle.com/otn_software/linux/instantclient/2112000/instantclient-basic-linux.x64-21.12.0.0.0dbru.zip --output instantclient.zip
-        curl https://download.oracle.com/otn_software/linux/instantclient/2112000/instantclient-sdk-linux.x64-21.12.0.0.0dbru.zip --output instantclient_sdk.zip
-        unzip instantclient.zip
-        unzip instantclient_sdk.zip
-
-    - name: Set up Ruby
-      uses: ruby/setup-ruby@v1
-      with:
-        ruby-version: ${{ matrix.ruby }}
-        bundler: latest
-        bundler-cache: true
-        cache-version: 3
-
-    - name: Code Climate setup test reporter
-      run: |
-        curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
-        chmod +x ./cc-test-reporter
-        ./cc-test-reporter before-build
-
-    - name: Run default task
-      run: |
-        bundle exec rake
-
-    - name: Code Climate publish test coverage
-      run: |
-        ./cc-test-reporter after-build