db_memoize 0.3.6 → 0.3.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a1659eec50470121a2d590b1abef910d5fa5c3888239e75c3249db78f68b87c8
-  data.tar.gz: 79f73004fe585ef2f71d39ba95a16f7b2a98e78a9fad4c8ca110e8db9e928819
+  metadata.gz: 97b2b4cd0624780588e5aaa90b93bf26e5f272246b043e076a282461e036188f
+  data.tar.gz: 8d440f2716fad476dbf95dd94698e77cb90099e9be330ffff599b788d1e2be1c
 SHA512:
-  metadata.gz: d8682fd173bd5fa2e89345a5df03b2fe833f2ce1dcd9b95596a137a08ad6c71b162f01b5707ce8750f44aecdf3128ec93bf3d44c9c24b8629882ffc49260414f
-  data.tar.gz: c5826ed544ce66c21588f210c72fc2825a60fb2c46c03617d46d5ff2d1f6235f8278aa865f99cbd5cb8881e9669a1c22788988dcfb1b02fffe1f0546eabba493
+  metadata.gz: 063a5479a255e730d6fc4c2f9b89fc007484662ca2e852536603f974daa1fa8017d783ac5bfebe776b39096c3a70e7d65b2266c1efc80c75562ecb94d5f6da69
+  data.tar.gz: a52b4f47e0a15e82769e2188467c543580ad45203e42817b3341e24f11413af7719f1122b3255eeb59c05c9733fdad1b9c0949d53495211de6a7f14249da9eb6

data/VERSION

@@ -1 +1 @@
-0.3.6
+0.3.7

data/lib/db_memoize/helpers.rb

@@ -10,11 +10,5 @@ module DbMemoize
 
       records_or_ids.first.is_a?(ActiveRecord::Base) ? records_or_ids.map(&:id) : records_or_ids
     end
-
-    def log(model, method_name, msg)
-      DbMemoize.logger.send(DbMemoize.log_level) do
-        "DbMemoize <#{model.class.name}##{model.id}>##{method_name} - #{msg}"
-      end
-    end
   end
 end

data/lib/db_memoize/model.rb

@@ -8,21 +8,15 @@ module DbMemoize
       memoizable = !changed? && persisted?
       return send("#{method_name}_without_memoize") unless memoizable
 
-      value         = nil
-      cached_value  = find_memoized_value(method_name)
+      memoized_value = find_memoized_value(method_name)
 
-      if cached_value
-        value = cached_value.value
-        Helpers.log(self, method_name, 'cache hit')
+      if memoized_value
+        memoized_value.value
       else
-        time = ::Benchmark.realtime do
-          value = send("#{method_name}_without_memoize")
-          create_memoized_value(method_name, value)
-        end
-        Helpers.log(self, method_name, "cache miss. took #{Kernel.format '%.2f msecs', time * 1_000}")
+        value = send("#{method_name}_without_memoize")
+        create_memoized_value(method_name, value)
+        value
       end
-
-      value
     end
 
     def unmemoize(method_name = :all)
@@ -51,6 +45,7 @@ module DbMemoize
       self.class.transaction do
         ::DbMemoize::Value.fast_create self.class.table_name, id, method_name, value
         @association_cache.delete :memoized_values
+        value
       end
     end
 

data/lib/db_memoize/railtie.rb

@@ -1,9 +1,5 @@
 module DbMemoize
   class Railtie < ::Rails::Railtie
-    initializer 'Rails logger' do
-      DbMemoize.logger = Rails.logger
-    end
-
     rake_tasks do
       load 'tasks/clear.rake'
       load 'tasks/warmup.rake'

data/lib/db_memoize/value.rb

@@ -20,6 +20,7 @@ module DbMemoize
       when false    then self.val_boolean = value
       when true     then self.val_boolean = value
       when nil      then :nop
+      else raise "Unsupported type #{value.class.name.inspect}, for DbMemoize"
       end
     end
 
@@ -43,36 +44,62 @@ module DbMemoize
       SQL
     end
 
-    def self.fast_create(entity_table_name, id, method_name, value)
+    def self.fast_create(entity_table_name, entity_id, method_name, value)
       method_name = method_name.to_s
 
       # clear out old entry (if any). This makes sure that any existing value
       # is cleared out properly.
       SQL.ask "DELETE FROM #{table_name} WHERE(entity_table_name, entity_id, method_name) = ($1, $2, $3)",
-              entity_table_name, id, method_name
-
-      dest_column = case value
-                    when String   then :val_string
-                    when Integer  then :val_integer
-                    when Float    then :val_float
-                    when Time     then :val_time
-                    when false    then :val_boolean
-                    when true     then :val_boolean
-                    when nil      then :val_nil
-                    when Hash     then :val_object
-                    when Array    then :val_object
-                    else
-                      raise "Unsupported value of type #{value.class.name}: #{value.inspect}"
-                    end
-
-      value = JSON.generate(value) if dest_column == :val_object
+              entity_table_name, entity_id, method_name
+
+      column = case value
+               when String   then :val_string
+               when Integer  then :val_integer
+               when Float    then :val_float
+               when Time     then :val_time
+               when false    then :val_boolean
+               when true     then :val_boolean
+               when nil      then :val_nil
+               when Hash     then :val_object
+               when Array    then :val_object
+               else
+                 raise "Unsupported value of type #{value.class.name}: #{value.inspect}"
+               end
+
+      value = JSON.generate(value) if column == :val_object
+
+      # it looks like Simple::SQL somehow drops subsecond resolutions from
+      # time objects. AR does not, though. So, for time values, we use the
+      # ActiveRecord method; for everything else we use Simple::SQL (for
+      # performance reasons: it is 10 times as fast.)
+      if column != :val_time
+        simple_sql_create_value column, entity_table_name: entity_table_name, entity_id: entity_id,
+                                        method_name: method_name, value: value
+      else
+        ar_create_value column, entity_table_name: entity_table_name, entity_id: entity_id,
+                                method_name: method_name, value: value
+      end
+    end
+
+    def self.simple_sql_create_value(column, entity_table_name:, entity_id:, method_name:, value:)
       sql = <<~SQL.freeze
         INSERT INTO #{table_name}
-          (entity_table_name, entity_id, method_name, #{dest_column}, created_at)
+          (entity_table_name, entity_id, method_name, #{column}, created_at)
           VALUES($1,$2,$3,$4,NOW())
       SQL
 
-      SQL.ask sql, entity_table_name, id, method_name, value
+      SQL.ask sql, entity_table_name, entity_id, method_name, value
+    end
+
+    def self.ar_create_value(column, entity_table_name:, entity_id:, method_name:, value:)
+      data = {
+        :entity_table_name => entity_table_name,
+        :entity_id => entity_id,
+        :method_name => method_name,
+        column => value
+      }
+
+      create!(data)
     end
   end
 end

data/lib/db_memoize.rb

@@ -10,15 +10,4 @@ require 'db_memoize/model'
 require 'db_memoize/railtie' if defined?(Rails)
 
 module DbMemoize
-  class << self
-    attr_writer :logger, :log_level
-
-    def logger
-      @logger ||= ::Logger.new(STDOUT)
-    end
-
-    def log_level
-      @log_level ||= :debug
-    end
-  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: db_memoize
 version: !ruby/object:Gem::Version
-  version: 0.3.6
+  version: 0.3.7
 platform: ruby
 authors:
 - johannes-kostas goetzinger
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-10-08 00:00:00.000000000 Z
+date: 2018-10-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: simple-sql