db_memoize 0.3.11 → 0.3.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 863ab8bb61c16da8578b0047d538d40cdcaf2f567555dd97f24b698146066af7
-  data.tar.gz: 1558260290eb7b3b68d821f679642b1589be653eda64bdec4b21a8b2bafbb689
+  metadata.gz: ce34701844a9a089e61d5010352b335795bcfb477d858c60189866012162e4d3
+  data.tar.gz: a2e8c91d767ff7550c6a84f3adcdb61288c60557700ac629f6473e73ce4ed64c
 SHA512:
-  metadata.gz: 4069e4ed8a024353fd7f1cf378af08c32795b1aaaedc365a6091e56c515b662b3c0118e1a8a66c7b32a535c9d209398fbbc8fdb1a91283011732bbd3c41ac5f4
-  data.tar.gz: 031ccecc72875c72509b75134203c0cc5ff1a7ad6cef82cf449eccca8166c31338b98bbb2129404be853e5641fa81bd8586820049dcec6775975a3deab873938
+  metadata.gz: 264acf8b331b10ed97680e1ee56752d2bbf9fa990ff0910c54711dd6d7b70b1e2aaa37c328f85161b38217e91dd1e9564ee86695f1ba5c7a3854e5d3ba1cfbe1
+  data.tar.gz: 58869f58b470ecff3ea1ab33e98ca81e657dce81e86df549e18aa5d2f5a7dabd8047145640c36a1661c187333e64baa2913190eb30d6a50225d9c29e50a97f81

data/VERSION

@@ -1 +1 @@
-0.3.11
+0.3.12

data/lib/db_memoize/migrations.rb

@@ -22,8 +22,7 @@ module DbMemoize
 
           -- entity_id/entity_table_name should have a better chance to be useful, since
           -- there is more variance in entity_ids than there is in entity_table_names.
-          CREATE UNIQUE INDEX IF NOT EXISTS memoized_attributes_idx2
-            ON db_memoize.memoized_values(entity_id, entity_table_name, method_name);
+          DROP INDEX IF EXISTS memoized_attributes_idx2;
         SQL
       end
     end

data/lib/db_memoize/model.rb

@@ -52,6 +52,14 @@ module DbMemoize
     def find_memoized_value(method_name)
       method_name = method_name.to_s
 
+      # In order to prevent database level deadlocks we don't manage any unique
+      # index on memoized values. This can result in duplicate matching memoized
+      # values.
+      #
+      # It is important to always return the freshest value. To make sure this
+      # happens the \a memoized_values association is ordered by its creation
+      # time (via "created_at DESC"), which lets us just return the first matching
+      # entry here.
       memoized_values.detect do |rec|
         rec.method_name == method_name
       end
@@ -124,7 +132,9 @@ module DbMemoize
             rec.memoized_values.delete_all_ordered
           end
 
-          has_many :memoized_values, -> { where(conditions) },
+          # memoized_values for this object. These values must be returned
+          # newest first, see the comment in \a find_memoized_value.
+          has_many :memoized_values, -> { where(conditions).order('created_at DESC') },
                    dependent: :delete_all, class_name: 'DbMemoize::Value', foreign_key: :entity_id
 
         end

data/lib/db_memoize/value.rb

@@ -37,7 +37,7 @@ module DbMemoize
       SQL.ask <<-SQL
         DO $$DECLARE c record;
         BEGIN
-          FOR c IN #{sql} ORDER BY ctid LOOP
+          FOR c IN SELECT * FROM (#{sql}) sq ORDER BY ctid LOOP
             DELETE FROM #{DbMemoize::Value.table_name} WHERE ctid = c.ctid;
           END LOOP;
         END$$;
@@ -57,11 +57,6 @@ module DbMemoize
     def self.fast_create(entity_table_name, entity_id, method_name, value)
       method_name = method_name.to_s
 
-      # clear out old entry (if any). This makes sure that any existing value
-      # is cleared out properly.
-      SQL.ask "DELETE FROM #{table_name} WHERE(entity_table_name, entity_id, method_name) = ($1, $2, $3)",
-              entity_table_name, entity_id, method_name
-
       column = case value
                when String   then :val_string
                when Integer  then :val_integer
@@ -82,15 +77,14 @@ module DbMemoize
       when :val_time    then value = _reformat_time(value)
       end
 
-      other_columns = ALL_COLUMNS - [column]
-      default_updates = other_columns.map { |c| "#{c}=NULL" }
-
+      # We initialize created_at with +statement_timestamp()+ since this
+      # reflects the current time when running the insert, resulting in
+      # increasing timestamps even within the same transaction.
+      #
+      # (This is only relevant for tests, though.)
       sql = <<~SQL.freeze
         INSERT INTO #{table_name}(entity_table_name, entity_id, method_name, #{column}, created_at)
-          VALUES($1,$2,$3,$4,NOW())
-          ON CONFLICT (entity_id, entity_table_name, method_name)
-          DO UPDATE
-            SET #{default_updates.join(', ')}, #{column}=$4, created_at=NOW()
+          VALUES($1,$2,$3,$4,statement_timestamp())
       SQL
 
       SQL.ask sql, entity_table_name, entity_id, method_name, value

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: db_memoize
 version: !ruby/object:Gem::Version
-  version: 0.3.11
+  version: 0.3.12
 platform: ruby
 authors:
 - johannes-kostas goetzinger
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-10-30 00:00:00.000000000 Z
+date: 2018-11-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: simple-sql