db_memoize 0.2.2 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ec9a05ceb15a0252b3e145983035f1192d9252c4
-  data.tar.gz: 53190328b2d6a04e861bc0d4d88dd29aea61ad7c
+  metadata.gz: c30ad0bcaafd71d6b6e819e0d951561c0ccdee50
+  data.tar.gz: 99803b69c67ad890ed66a2648c4cd414e3c0bc2d
 SHA512:
-  metadata.gz: 1da1fe68e2389d0d6a74ac03d38f486fcd249f58142f52e4fa5aa3b683a1905f2dc879bd57f188957519fb3181bcbd2fca2dcd521071e155ed3fda6e20e3cfe4
-  data.tar.gz: f448a8946e63346fe401d763d396994638ced3cf9e25340ea36b40fcc26372654da88e9593bcbf18f596497325f3dc40c5ae4fc7877421a36d7f5b3489f41d0b
+  metadata.gz: bde9f19880b5809dbf35daf2b1664223f9db45033d1cc297a3714c41afbbec98b0099b4e232566c0be1346e78dada3c92b27c607224f5480599efe91de7a644b
+  data.tar.gz: 61aa061f01ba3df008f1b7be39f4e6510daf9f8e4dda38188b0c33deaace4c874cd60d426ea2cb3296ed4717f65635c5e4bdfa5ce9cb25cf47bd44042abaf020

data/README.md

@@ -1,6 +1,8 @@
 # db_memoize
 library to cache (memoize) method return values in database
 
+**Note:** when updating from version 0.1 to 0.2 you need to run a migration on the existing table, see below.
+
 ## Usage in ActiveRecord models:
 
 ### Example Class:
@@ -112,6 +114,38 @@ Note that db_memoize needs Postgres. To set up the database needed to run tests,
     # createdb -O >>yourusername<< db_memoize_test
 
 
+### Updating from 0.1 -> 0.2
+
+You need to run a migration, like the following: 
+
+```
+class FixDbMemoizeTable < ActiveRecord::Migration
+  def up
+    # After updating db_memoize to 0.2 we need to update some structures, depending
+    # on whether or not db_memoize 0.1 or 0.2 was creating the database tables.
+    execute <<-SQL
+    ALTER TABLE memoized_values
+      ALTER COLUMN entity_table_name SET NOT NULL,
+      ALTER COLUMN entity_id SET NOT NULL,
+      ALTER COLUMN method_name SET NOT NULL,
+      ALTER COLUMN created_at SET NOT NULL;
+    DROP INDEX IF EXISTS index_memoized_values_on_entity_table_name_and_entity_id;
+    CREATE INDEX IF NOT EXISTS index_memoized_values_on_entity_id_and_entity_table_name 
+      ON memoized_values(entity_id, entity_table_name);
+    CREATE INDEX IF NOT EXISTS memoized_attributes_idx 
+      ON memoized_values (((arguments_hash IS NULL)))
+    SQL
+  end
+
+  def down
+    execute <<-SQL
+      DROP INDEX memoized_attributes_idx;
+      DROP INDEX index_memoized_values_on_entity_id_and_entity_table_name;
+    SQL
+  end
+end
+```
+
 Have fun!
 
 

data/lib/db_memoize/model.rb

@@ -26,13 +26,7 @@ module DbMemoize
     end
 
     def unmemoize(method_name = :all)
-      if method_name != :all
-        # FIXME: this works, but isn't immediately visible on the record.
-        # See also note in create_memoized_value.
-        memoized_values.where(method_name: method_name).delete_all
-      else
-        memoized_values.clear
-      end
+      self.class.unmemoize id, method_name
     end
 
     #
@@ -96,7 +90,7 @@ module DbMemoize
         }
         conditions[:method_name] = method_name unless method_name == :all
 
-        DbMemoize::Value.where(conditions).delete_all
+        DbMemoize::Value.where(conditions).delete_all_ordered
       end
 
       def memoize_values(records_or_ids, values, *args)
@@ -130,8 +124,23 @@ module DbMemoize
       def create_memoized_values_association
         unless reflect_on_association(:memoized_values)
           conditions = { entity_table_name: table_name }
+
+          # By defining this before_destroy callback we make sure **we** delete all
+          # memoized values before Rails deletes those via `has_many dependent:
+          # This leads to has_many later on not finding any values to be deleted.
+          #
+          # It would be nice if there was a `dependent: :manual/:noop` option.
+          #
+          # **Note:** before_destroy must be called before memoized_values is
+          # set up, to make sure that these things happen in the right order.
+          #
+          before_destroy do |rec|
+            rec.memoized_values.delete_all_ordered
+          end
+
           has_many :memoized_values, -> { where(conditions) },
                    dependent: :delete_all, class_name: 'DbMemoize::Value', foreign_key: :entity_id
+
         end
       end
     end

data/lib/db_memoize/value.rb

@@ -3,5 +3,20 @@ module DbMemoize
     self.table_name = 'memoized_values'
 
     include DbMemoize::Metal
+
+    def self.delete_all_ordered
+      relation = self
+      relation = all unless is_a?(ActiveRecord::Relation)
+
+      sql = relation.select(:ctid).to_sql
+      connection.execute <<-SQL
+        DO $$DECLARE c record;
+        BEGIN
+          FOR c IN #{sql} ORDER BY ctid LOOP
+            DELETE FROM #{DbMemoize::Value.table_name} WHERE ctid = c.ctid;
+          END LOOP;
+        END$$;
+      SQL
+    end
   end
 end

data/lib/db_memoize/version.rb

@@ -1,3 +1,3 @@
 module DbMemoize
-  VERSION = '0.2.2'.freeze
+  VERSION = '0.2.3'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: db_memoize
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors:
 - johannes-kostas goetzinger
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-06-26 00:00:00.000000000 Z
+date: 2017-06-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties