db_leftovers 0.5.4 → 0.6.0

data/README.html

@@ -81,6 +81,16 @@ end
 <pre><code>rake db:leftovers
 </code></pre>
 
+<p>To print messages even about indexes/foreign keys/constraints that haven't changed, you can say:</p>
+
+<pre><code>rake db:leftovers VERBOSE=true
+</code></pre>
+
+<p>or</p>
+
+<pre><code>rake db:leftovers DB_LEFTOVERS_VERBOSE=true
+</code></pre>
+
 <h2>Known Issues</h2>
 
 <ul>
@@ -100,10 +110,6 @@ make an existing index unique, add a column, remove a WHERE clause, or
 anything else, it will notice and drop and re-create the index.
 I'm working on doing the same thing for foreign keys/constraints,
 but it's not done just yet.</p></li>
-<li><p>If your database is mostly up-to-date, then running the Rake task will spam
-you with messages about how this index and that foreign key already exist.
-These should be hidden by default and shown only if you request a higher
-verbosity.</p></li>
 </ul>
 
 <h2>Contributing to db_leftovers</h2>

data/README.md

@@ -78,6 +78,14 @@ db\_leftovers comes with a Rake task named `db:leftovers`. So you can update you
 
     rake db:leftovers
 
+To print messages even about indexes/foreign keys/constraints that haven't changed, you can say:
+
+    rake db:leftovers VERBOSE=true
+
+or
+
+    rake db:leftovers DB_LEFTOVERS_VERBOSE=true
+
 
 Known Issues
 ------------
@@ -100,11 +108,7 @@ Known Issues
   I'm working on doing the same thing for foreign keys/constraints,
   but it's not done just yet.
   
-* If your database is mostly up-to-date, then running the Rake task will spam
-  you with messages about how this index and that foreign key already exist.
-  These should be hidden by default and shown only if you request a higher
-  verbosity.
- 
+
 
 Contributing to db\_leftovers
 -----------------------------

data/VERSION

@@ -1 +1 @@
-0.5.4
+0.6.0

data/db_leftovers.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = "db_leftovers"
-  s.version = "0.5.4"
+  s.version = "0.6.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Paul A. Jungwirth"]

data/lib/db_leftovers/definition.rb

@@ -7,7 +7,7 @@ module DBLeftovers
         :do_foreign_keys => true,
         :do_constraints => true
       }.merge(opts)
-      dsl = DSL.new
+      dsl = DSL.new(:verbose => ENV['DB_LEFTOVERS_VERBOSE'] || false)
       dsl.define(&block)
       dsl.record_indexes        if opts[:do_indexes]
       dsl.record_foreign_keys   if opts[:do_foreign_keys]

data/lib/db_leftovers/dsl.rb

@@ -6,8 +6,10 @@ module DBLeftovers
     STATUS_CHANGED = 'changed'
     STATUS_NEW     = 'new'
 
-    def initialize
+    def initialize(opts={})
+      @verbose = !!opts[:verbose]
       @db = DatabaseInterface.new
+
       @indexes_by_table = {}      # Set from the DSL
       @old_indexes = @db.lookup_all_indexes
       @new_indexes = {}
@@ -51,7 +53,7 @@ module DBLeftovers
           # puts "#{idx.table_name}.[#{idx.column_names.join(',')}]"
           case index_status(idx)
           when STATUS_EXISTS
-            puts "Index already exists: #{idx.index_name} on #{idx.table_name}"
+            puts "Index already exists: #{idx.index_name} on #{idx.table_name}" if @verbose
           when STATUS_CHANGED
             @db.execute_drop_index(idx.table_name, idx.index_name)
             @db.execute_add_index(idx)
@@ -79,7 +81,7 @@ module DBLeftovers
       @foreign_keys_by_table.each do |table_name, fks|
         fks.each do |fk|
           if foreign_key_exists?(fk)
-            puts "Foreign Key already exists: #{fk.constraint_name} on #{fk.from_table}"
+            puts "Foreign Key already exists: #{fk.constraint_name} on #{fk.from_table}" if @verbose
           else
             @db.execute_add_foreign_key(fk)
             puts "Created foreign key: #{fk.constraint_name} on #{fk.from_table}"
@@ -102,7 +104,7 @@ module DBLeftovers
       @constraints_by_table.each do |table_name, chks|
         chks.each do |chk|
           if constraint_exists?(chk)
-            puts "Constraint already exists: #{chk.constraint_name} on #{chk.on_table}"
+            puts "Constraint already exists: #{chk.constraint_name} on #{chk.on_table}" if @verbose
           else
             @db.execute_add_constraint(chk)
             puts "Created CHECK constraint: #{chk.constraint_name} on #{chk.on_table}"

data/lib/tasks/leftovers.rake

@@ -2,6 +2,7 @@ namespace :db do
 
   desc "Set up indexes, foreign keys, and constraints"
   task :leftovers, [] => [:environment] do
+    ENV['DB_LEFTOVERS_VERBOSE'] = ENV['VERBOSE'] || ENV['DB_LEFTOVERS_VERBOSE']
     load File.join(::Rails.root.to_s, 'config', 'db_leftovers.rb')
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: db_leftovers
 version: !ruby/object:Gem::Version
-  version: 0.5.4
+  version: 0.6.0
   prerelease: 
 platform: ruby
 authors:
@@ -139,7 +139,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1286552012513738437
+      hash: -2522100486146355365
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: