db_blaster 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e8d31a519addfa74e6a2ca3c2d41f58b05e2b4551802948b5a4dc0fe20278dca
-  data.tar.gz: 33a1e76574a2b8e70c681beebf544af587ff143252b08d0dd1a8dbc0b3615864
+  metadata.gz: d612afe45176a37521310c9f694cb2d4b0efe1d42406da82f04bf5fca3187b86
+  data.tar.gz: 25aae3fae57025cfcc72d14e192b21950c73baa804b4270c7de2c1377bc09686
 SHA512:
-  metadata.gz: 378969c9223acf49c50a055b566b1f3f2bff3a0b032bbc9e1aebbb64b5031c9d1a2af6c539d55efc7e90a8254d0ca4cf413be762ab41dbdd1fd4e01efd723d33
-  data.tar.gz: afabd1c77490c8c80bdd1d0a49965026ae69a77d727ffe7da475c5683391dafc4cd9f91d7880ecc5c0818a4c5afeacd4403844a198f932c0c4d448b0c53cb2dc
+  metadata.gz: 28412dbbfae7b89fe57afd4e40fd4bc43bfb2c126a5e3fc67e632d776017f07d2f15d7d70da537344e59aa3021bff30131f905305d00c0784ab156a71185efe9
+  data.tar.gz: 49c856817e7c650bb36b5a74b3395fcdcd075439c2831aebe720eeda381fcc5e36fd08fbacdb1a4c5bd2fde2ec86e647a14a9a1975a023cc40e76019665e7bb0

data/config/brakeman.ignore

@@ -3,24 +3,24 @@
     {
       "warning_type": "SQL Injection",
       "warning_code": 0,
-      "fingerprint": "6f4d3da0707c3f5f5c5bf5a002a254fee246210248aafa655cb2f15adfb47aa7",
+      "fingerprint": "3fef6d99f896e29ef9346d81a1557bd3819fbc762b2aa91d44dfa25a5c095485",
       "check_name": "SQL",
       "message": "Possible SQL injection",
       "file": "lib/db_blaster/finder.rb",
-      "line": 38,
+      "line": 39,
       "link": "https://brakemanscanner.org/docs/warning_types/sql_injection/",
-      "code": "ActiveRecord::Base.connection.execute(\"#{select_sql} OFFSET #{offset}\")",
+      "code": "ActiveRecord::Base.connection.execute(\"#{FinderSql.sql_for_source_table(source_table)} OFFSET #{offset}\")",
       "render_path": null,
       "location": {
         "type": "method",
         "class": "DbBlaster::Finder",
         "method": "find_records_in_batches"
       },
-      "user_input": "select_sql",
+      "user_input": "FinderSql.sql_for_source_table(source_table)",
       "confidence": "Medium",
-      "note": "No SQL injection can occur"
+      "note": "no sql injection"
     }
   ],
-  "updated": "2021-08-09 11:03:06 -0600",
+  "updated": "2021-08-11 13:14:00 -0600",
   "brakeman_version": "5.1.1"
 }

data/lib/db_blaster.rb

@@ -11,6 +11,7 @@ require 'db_blaster/source_table_configuration_builder'
 require 'db_blaster/publisher'
 require 'db_blaster/publish_source_table'
 require 'db_blaster/chunker'
+require 'db_blaster/finder_sql'
 require 'db_blaster/finder'
 
 # Top-level module that serves as an entry point

data/lib/db_blaster/finder.rb

@@ -12,7 +12,7 @@ module DbBlaster
       @offset = 0
     end
 
-    delegate :batch_size, :name, :last_published_updated_at, to: :source_table, prefix: true
+    delegate :batch_size, :name, to: :source_table, prefix: true
 
     def self.find(source_table, &block)
       new(source_table, &block).find
@@ -34,6 +34,7 @@ module DbBlaster
     private
 
     def find_records_in_batches
+      select_sql = FinderSql.sql_for_source_table(source_table)
       loop do
         result = ActiveRecord::Base.connection.execute("#{select_sql} OFFSET #{offset}")
         yield(result)
@@ -54,17 +55,5 @@ module DbBlaster
     def invalid_source_table_message
       "source_table.name: '#{source_table_name}' does not exist!"
     end
-
-    def select_sql
-      "SELECT * FROM #{source_table_name} #{where} ORDER BY updated_at ASC LIMIT #{source_table_batch_size}"
-    end
-
-    def where
-      return '' unless source_table_last_published_updated_at
-
-      ActiveRecord::Base.sanitize_sql_for_conditions(
-        ['WHERE updated_at >= :updated_at', { updated_at: source_table_last_published_updated_at.to_s(:db) }]
-      )
-    end
   end
 end

data/lib/db_blaster/finder_sql.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+
+module DbBlaster
+  # Creates the SQL needed to find records for the provided source_table
+  class FinderSql
+    attr_reader :source_table
+
+    def initialize(source_table)
+      @source_table = source_table
+    end
+
+    def self.sql_for_source_table(source_table)
+      new(source_table).select_sql
+    end
+
+    def select_sql
+      "SELECT * FROM #{source_table.name} #{where} ORDER BY updated_at ASC LIMIT #{source_table.batch_size}"
+    end
+
+    def where
+      return '' unless from_updated_at
+
+      ActiveRecord::Base.sanitize_sql_for_conditions(
+        ['WHERE updated_at >= :updated_at', { updated_at: from_updated_at.to_s(:db) }]
+      )
+    end
+
+    def from_updated_at
+      @from_updated_at ||= source_table.last_published_updated_at
+    end
+  end
+end

data/lib/db_blaster/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DbBlaster
-  VERSION = '0.1.0'
+  VERSION = '0.1.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: db_blaster
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Perry Hertler
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-08-09 00:00:00.000000000 Z
+date: 2021-08-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-sdk-sns
@@ -123,6 +123,7 @@ files:
 - lib/db_blaster/configuration.rb
 - lib/db_blaster/engine.rb
 - lib/db_blaster/finder.rb
+- lib/db_blaster/finder_sql.rb
 - lib/db_blaster/one_record_too_large_error.rb
 - lib/db_blaster/publish_source_table.rb
 - lib/db_blaster/publisher.rb