days 0.2.0 → 1.0.0.rc1

data/spec/models/entry_spec.rb

@@ -1,59 +1,129 @@
 require 'spec_helper'
 
 describe Days::Entry do
-  before do
-    described_class.destroy_all
-  end
-
-  after do
-    described_class.destroy_all
-  end
-
   subject do
     described_class.new(title: 'title', body: 'a')
   end
 
+  describe "#render!" do
+    def generate_pipeline(rendered_text)
+      double("pipeline(#{rendered_text.inspect})").tap do |d|
+        allow(d).to receive(:call) do |text|
+          expect(text).to eq 'text'
+          {output: rendered_text}
+        end
+      end
+    end
+
+    let(:pipeline) do
+
+    end
+
+    subject do
+      described_class.new(title: 'title', body: 'text')
+    end
+
+    before do
+      allow(described_class).to receive(:default_pipeline).and_return(generate_pipeline('default'))
+    end
+
+    context "without pipeline, @pipeline" do
+      it "uses default_pipeline" do
+        expect {
+          subject.render!
+        }.to change {
+          subject.rendered
+        }.from(nil).to('default')
+      end
+    end
+
+    context "with @pipeline" do
+      before do
+        subject.pipeline = generate_pipeline('instance')
+      end
+
+      it "uses @pipeline" do
+        expect {
+          subject.render!
+        }.to change {
+          subject.rendered
+        }.from(nil).to('instance')
+      end
+    end
+
+    context "with pipeline" do
+      it "uses passed argument" do
+        expect {
+          subject.render!(pipeline: generate_pipeline('arg'))
+        }.to change {
+          subject.rendered
+        }.from(nil).to('arg')
+      end
+    end
+  end
 
-  describe "rendering" do
+  describe "auto-rendering" do
     subject do
       described_class.new(title: 'title', body: 'a')
     end
 
     before do
-      Redcarpet::Markdown.any_instance.stub(render: "(sun)")
-      subject.save
+      allow(subject).to receive(:render!) do
+        subject.rendered = 'rendered'
+      end
     end
 
-    it { should be_valid }
+    context "normal" do
+      before do
+        subject.save
+      end
+
+      it { is_expected.to be_valid }
 
-    specify do
-      subject.rendered.should == "(sun)"
+      specify do
+        expect(subject.rendered).to eq('rendered')
+      end
+    end
+
+    context "modified body" do
+      before do
+        subject.save!
+        subject.rendered = ''
+        subject.body = 'b'
+        subject.save
+      end
+
+      it { is_expected.to be_valid }
+
+      specify do
+        expect(subject.rendered).to eq('rendered')
+      end
     end
   end
 
   describe "slug" do
     before do
-      String.any_instance.stub(to_url: "slug")
+      allow_any_instance_of(String).to receive_messages(to_url: "slug")
       subject.save
     end
 
-    it { should be_valid }
+    it { is_expected.to be_valid }
 
     it "generates slug"do
-      subject.slug.should == 'slug'
+      expect(subject.slug).to eq('slug')
     end
 
     context "with empty slug" do
       before do
-        String.any_instance.stub(to_url: "slug")
+        allow_any_instance_of(String).to receive_messages(to_url: "slug")
         subject.slug = ""
         subject.save
       end
 
-      it { should be_valid }
+      it { is_expected.to be_valid }
 
       it "generates slug"do
-        subject.slug.should == 'slug'
+        expect(subject.slug).to eq('slug')
       end
     end
   end
@@ -65,59 +135,59 @@ describe Days::Entry do
       end
 
       specify do
-        subject.should_not be_published
+        expect(subject).not_to be_published
       end
 
       specify do
-        subject.should_not be_scheduled
+        expect(subject).not_to be_scheduled
       end
     end
 
     context "when after published_at" do
       before do
         base = Time.now
-        Time.stub(now: base)
+        allow(Time).to receive_messages(now: base)
         subject.published_at = base - 1
       end
 
       specify do
-        subject.should be_published
+        expect(subject).to be_published
       end
 
       specify do
-        subject.should_not be_scheduled
+        expect(subject).not_to be_scheduled
       end
     end
 
     context "when just published_at" do
       before do
         base = Time.now
-        Time.stub(now: base)
+        allow(Time).to receive_messages(now: base)
         subject.published_at = base
       end
 
       specify do
-        subject.should be_published
+        expect(subject).to be_published
       end
 
       specify do
-        subject.should_not be_scheduled
+        expect(subject).not_to be_scheduled
       end
     end
 
     context "when before published_at" do
       before do
         base = Time.now
-        Time.stub(now: base)
+        allow(Time).to receive_messages(now: base)
         subject.published_at = base + 1
       end
 
       specify do
-        subject.should_not be_published
+        expect(subject).not_to be_published
       end
 
       specify do
-        subject.should be_scheduled
+        expect(subject).to be_scheduled
       end
     end
   end
@@ -128,7 +198,7 @@ describe Days::Entry do
       described_class.create(title: 'B', body: 'b', published_at: Time.local(2012,12,30,11,0,0))
       described_class.create(title: 'C', body: 'c', published_at: Time.local(2012,12,30, 9,0,0))
       described_class.create(title: 'D', body: 'd', published_at: Time.local(2013, 1, 1, 9,0,0))
-      Time.stub(now: Time.local(2012,12,30, 14,0,0))
+      allow(Time).to receive_messages(now: Time.local(2012,12,30, 14,0,0))
     end
 
     subject do
@@ -136,26 +206,26 @@ describe Days::Entry do
     end
 
     it "orders by published_at" do
-      subject.map(&:title).should == ['B', 'C']
+      expect(subject.map(&:title)).to eq(['B', 'C'])
     end
 
     it "rejects not published entries" do
-      subject.map(&:title).should_not include('A')
-      subject.map(&:title).should_not include('D')
+      expect(subject.map(&:title)).not_to include('A')
+      expect(subject.map(&:title)).not_to include('D')
     end
 
     context "all published" do
       before do
-        Time.stub(now: Time.local(2013,1,1,14,0,0))
+        allow(Time).to receive_messages(now: Time.local(2013,1,1,14,0,0))
       end
 
       it "orders by published_at" do
-        subject.map(&:title).should == ['D', 'B', 'C']
+        expect(subject.map(&:title)).to eq(['D', 'B', 'C'])
       end
 
       it "rejects not published entries" do
-        subject.map(&:title).should_not include('A')
-        subject.map(&:title).should include('D')
+        expect(subject.map(&:title)).not_to include('A')
+        expect(subject.map(&:title)).to include('D')
       end
     end
   end
@@ -169,7 +239,7 @@ describe Days::Entry do
       end
 
       it "nullifies published_at" do
-        subject.published_at.should be_nil
+        expect(subject.published_at).to be_nil
       end
     end
 
@@ -182,25 +252,25 @@ describe Days::Entry do
 
       context "when published_at is nil" do
         before do
-          Time.stub(now: base)
+          allow(Time).to receive_messages(now: base)
           subject.published_at = nil
           subject.valid?
         end
 
         it "fills published_at" do
-          subject.published_at.should == base
+          expect(subject.published_at).to eq(base)
         end
       end
 
       context "when published_at is not nil" do
         before do
-          Time.stub(now: base + 1)
+          allow(Time).to receive_messages(now: base + 1)
           subject.published_at = base
           subject.valid?
         end
 
         it "keeps published_at" do
-          subject.published_at.should == base
+          expect(subject.published_at).to eq(base)
         end
       end
     end
@@ -218,20 +288,20 @@ describe Days::Entry do
     let(:body) { "a\n\n<!--more-->\n\nb" }
 
     it "deletes after <!--more-->" do
-      subject.short_rendered.should == "<p>a</p>\n\n"
+      expect(subject.short_rendered).to eq("<p>a</p>\n\n")
     end
 
     context "without <!--more--> in body" do
       let(:body) { "a\n\nb" }
 
       it "returns entire rendered body" do
-        subject.short_rendered.should == subject.rendered
+        expect(subject.short_rendered).to eq(subject.rendered)
       end
     end
 
     context "with block" do
       it "replaces by block evaluation result" do
-        subject.short_rendered { "hi!" }.should == "<p>a</p>\n\nhi!"
+        expect(subject.short_rendered { "hi!" }).to eq("<p>a</p>\n\nhi!")
       end
     end
   end

data/spec/shared/admin.rb

@@ -2,7 +2,7 @@ shared_examples "an admin page" do
   before { env.delete 'rack.session' }
 
   it "redirects to /admin/login" do
-    subject.should be_redirect
-    URI.parse(subject.location).path.should == '/admin/login'
+    expect(subject).to be_redirect
+    expect(URI.parse(subject.location).path).to eq('/admin/login')
   end
 end

data/spec/spec_helper.rb

@@ -1,14 +1,15 @@
 ENV["RACK_ENV"] ||= 'test'
+require 'active_record'
+require 'database_rewinder'
 require 'days'
 require 'days/models'
 require 'days/migrator'
 require 'rack/test'
-require 'active_record'
-require 'active_record/fixtures'
-require 'active_support/test_case'
+
 require 'pry'
 
 Days::App.set :environment, :test
+Days::App.set :raise_errors, true
 
 module AppSpecHelper
   include Rack::Test::Methods
@@ -49,10 +50,10 @@ module AppSpecHelper
         ActiveRecord::Base.logger = nil
       end
 
-      before(:each) do
+      before(:example) do |example|
         @renders = []
-        unless self.example.metadata[:render]
-          Days::App.any_instance.stub(:render) do |*args, &block|
+        unless example.metadata[:render]
+          allow_any_instance_of(Days::App).to receive(:render) do |instance, *args, &block|
             @renders << {engine: args[0], data: args[1], options: args[2] || {}, locals: args[3] || {}, ivars: args[4] || {}}
             ""
           end
@@ -90,24 +91,7 @@ module SetupAndTeardown
   end
 end
 
-module FixturesAdapter
-  extend ActiveSupport::Concern
-  include SetupAndTeardown
-  include ActiveRecord::TestFixtures
-
-  included do
-    self.fixture_path = "#{File.dirname(__FILE__)}/fixtures"
-    self.use_transactional_fixtures = false
-    self.use_instantiated_fixtures  = true
-
-    self.fixture_class_names = Hash.new do |h, table_name|
-        h[table_name] = "Days::#{ActiveRecord::Fixtures.find_table_name(table_name)}"
-    end
-  end
-end
-
 RSpec.configure do |config|
-  config.treat_symbols_as_metadata_keys_with_true_values = true
   config.run_all_when_everything_filtered = true
   config.filter_run :focus
   # config.order = 'random'
@@ -119,16 +103,32 @@ RSpec.configure do |config|
   config.before(:suite) do
     Days::App.environment = ENV["RACK_ENV"] || :test
     config.days_config.establish_db_connection()
-    Days::Migrator.start(config.days_config, verbose: true)
     ActiveRecord::Base.configurations = {'test' => Hash[config.days_config.database]}
+
+    Days::Migrator.start(config.days_config, verbose: true)
     ActiveRecord::Base.logger = nil
+
+    DatabaseRewinder.clean_all
   end
 
+  config.after(:each) do
+    DatabaseRewinder.clean
+  end
 
   config.include AppSpecHelper, type: :controller
-  config.include FixturesAdapter
 
   config.tty = true
+
+  config.mock_with :rspec do |mocks|
+    # In RSpec 3, `any_instance` implementation blocks will be yielded the receiving
+    # instance as the first block argument to allow the implementation block to use
+    # the state of the receiver.
+    # In RSpec 2.99, to maintain compatibility with RSpec 3 you need to either set
+    # this config option to `false` OR set this to `true` and update your
+    # `any_instance` implementation blocks to account for the first block argument
+    # being the receiving instance.
+    mocks.yield_receiver_to_any_instance_implementation_blocks = true
+  end
 end
 
 require_relative "./shared/admin"