davinci_pas_test_kit 0.15.1 → 0.15.2

data/lib/davinci_pas_test_kit/cross_suite/generated/v2.2.1/nutrition_order/metadata.yml

@@ -18,6 +18,7 @@
 :must_supports:
   :extensions:
   - :id: NutritionOrder.extension:coverage
+    :slice_name: coverage
     :path: extension
     :url: http://hl7.org/fhir/us/davinci-crd/StructureDefinition/ext-coverage-information
     :modifier_extension: false
@@ -34,6 +35,7 @@
   - :path: oralDiet.type
   - :path: enteralFormula
   - :path: enteralFormula.baseFormulaType
+  :recursive_elements: []
 :mandatory_elements:
 - NutritionOrder.status
 - NutritionOrder.intent

data/lib/davinci_pas_test_kit/cross_suite/generated/v2.2.1/pas_inquiry_request_bundle/metadata.yml

@@ -31,6 +31,8 @@
   - :path: entry.resource
   - :path: entry:Claim.fullUrl
   - :path: entry:Claim.resource
+  :recursive_elements:
+  - link
 :mandatory_elements:
 - Bundle.identifier
 - Bundle.type

data/lib/davinci_pas_test_kit/cross_suite/generated/v2.2.1/pas_inquiry_response_bundle/metadata.yml

@@ -30,6 +30,8 @@
   - :path: entry.resource
   - :path: entry:ClaimResponse.fullUrl
   - :path: entry:ClaimResponse.resource
+  :recursive_elements:
+  - link
 :mandatory_elements:
 - Bundle.type
 - Bundle.timestamp

data/lib/davinci_pas_test_kit/cross_suite/generated/v2.2.1/pas_request_bundle/metadata.yml

@@ -31,6 +31,8 @@
   - :path: entry.resource
   - :path: entry:Claim.fullUrl
   - :path: entry:Claim.resource
+  :recursive_elements:
+  - link
 :mandatory_elements:
 - Bundle.identifier
 - Bundle.type

data/lib/davinci_pas_test_kit/cross_suite/generated/v2.2.1/pas_response_bundle/metadata.yml

@@ -31,6 +31,8 @@
   - :path: entry.resource
   - :path: entry:ClaimResponse.fullUrl
   - :path: entry:ClaimResponse.resource
+  :recursive_elements:
+  - link
 :mandatory_elements:
 - Bundle.identifier
 - Bundle.type

data/lib/davinci_pas_test_kit/cross_suite/generated/v2.2.1/practitioner/metadata.yml

@@ -36,6 +36,7 @@
   - :path: address.state
   - :path: address.postalCode
   - :path: address.country
+  :recursive_elements: []
 :mandatory_elements:
 - Practitioner.identifier
 - Practitioner.name

data/lib/davinci_pas_test_kit/cross_suite/generated/v2.2.1/practitioner_role/metadata.yml

@@ -40,6 +40,7 @@
   - :path: endpoint
     :types:
     - Reference
+  :recursive_elements: []
 :mandatory_elements:
 - PractitionerRole.practitioner
 - PractitionerRole.telecom.system

data/lib/davinci_pas_test_kit/cross_suite/generated/v2.2.1/requestor/metadata.yml

@@ -56,6 +56,7 @@
   - :path: contact
   - :path: contact.name
   - :path: contact.telecom
+  :recursive_elements: []
 :mandatory_elements:
 - Organization.active
 - Organization.name

data/lib/davinci_pas_test_kit/cross_suite/generated/v2.2.1/service_request/metadata.yml

@@ -17,10 +17,12 @@
 :must_supports:
   :extensions:
   - :id: ServiceRequest.extension:serviceCodeEnd
+    :slice_name: serviceCodeEnd
     :path: extension
     :url: http://hl7.org/fhir/us/davinci-pas/StructureDefinition/extension-productOrServiceCodeEnd
     :modifier_extension: false
   - :id: ServiceRequest.extension:coverage
+    :slice_name: coverage
     :path: extension
     :url: http://hl7.org/fhir/us/davinci-crd/StructureDefinition/ext-coverage-information
     :modifier_extension: false
@@ -36,6 +38,7 @@
     :target_profiles:
     - http://hl7.org/fhir/us/davinci-pas/StructureDefinition/profile-beneficiary|2.2.1
   - :path: occurrence[x]
+  :recursive_elements: []
 :mandatory_elements:
 - ServiceRequest.status
 - ServiceRequest.intent

data/lib/davinci_pas_test_kit/cross_suite/generated/v2.2.1/subscriber/metadata.yml

@@ -38,6 +38,7 @@
   - :path: address.postalCode
   - :path: address.country
   - :path: communication.language
+  :recursive_elements: []
 :mandatory_elements:
 - Patient.identifier
 - Patient.identifier.system

data/lib/davinci_pas_test_kit/cross_suite/generated/v2.2.1/task/metadata.yml

@@ -18,14 +18,17 @@
 :must_supports:
   :extensions:
   - :id: Task.input:AttachmentsNeeded.extension:paLineNumber
+    :slice_name: paLineNumber
     :path: input.extension
     :url: http://hl7.org/fhir/us/davinci-pas/StructureDefinition/extension-serviceLineNumber
     :modifier_extension: false
   - :id: Task.input:AttachmentsNeeded.extension:contentModifier
+    :slice_name: contentModifier
     :path: input.extension
     :url: http://hl7.org/fhir/us/davinci-pas/StructureDefinition/extension-contentModifier
     :modifier_extension: false
   - :id: Task.input:QuestionnaireContext.extension:paLineNumber
+    :slice_name: paLineNumber
     :path: input.extension
     :url: http://hl7.org/fhir/us/davinci-pas/StructureDefinition/extension-serviceLineNumber
     :modifier_extension: false
@@ -86,6 +89,7 @@
   - :path: input:AttachmentsNeeded.value[x]
   - :path: input:QuestionnaireContext.type
   - :path: input:QuestionnaireContext.value[x]
+  :recursive_elements: []
 :mandatory_elements:
 - Task.identifier
 - Task.status

data/lib/davinci_pas_test_kit/cross_suite/pas_bundle_validation.rb

@@ -3,10 +3,12 @@
 require_relative '../parameters_helper'
 require_relative 'validation_test'
 require_relative 'pas_constants'
+require_relative 'pas_datatype_constraints'
 
 module DaVinciPASTestKit
   module PasBundleValidation
     include DaVinciPASTestKit::ValidationTest
+    include DaVinciPASTestKit::PasDatatypeConstraints
     include ParametersHelper
 
     US_CORE_VERSION = '6.1.0'
@@ -80,13 +82,13 @@ module DaVinciPASTestKit
       @validation_error_messages ||= []
     end
 
-    def perform_bundle_validation(bundle, operation, type, ig_version)
+    def perform_bundle_validation(bundle, operation, type, ig_version, request_bundle = nil)
       target_profile = PASConstants.bundle_profile_url_for_operation_and_type(operation, type)
       request_type = "#{operation}_#{type}"
       if type == 'request'
         perform_request_validation(bundle, target_profile, ig_version.delete_prefix('v'), request_type)
       else
-        perform_response_validation(bundle, target_profile, ig_version.delete_prefix('v'), request_type)
+        perform_response_validation(bundle, target_profile, ig_version.delete_prefix('v'), request_type, request_bundle)
       end
     end
 
@@ -96,7 +98,7 @@ module DaVinciPASTestKit
     end
 
     def perform_response_validation(response_bundle, profile_url, version, request_type, request_bundle = nil)
-      validate_pa_response_body_structure(response_bundle, request_bundle) if request_type == 'submit'
+      validate_pa_response_body_structure(response_bundle, request_bundle) if request_type.start_with?('submit')
       validate_resources_conformance_against_profile(response_bundle, profile_url, version, request_type)
     end
 
@@ -203,7 +205,7 @@ module DaVinciPASTestKit
     # Validates the response body structure of a Prior Authorization (PA) response.
     #
     # @param pa_response_bundle [FHIR::Bundle] The FHIR bundle representing the PA response.
-    # @param pa_request_bundle [String] The JSON payload of the PA request bundle.
+    # @param pa_request_bundle [FHIR::Bundle, String, nil] The submitted PA request Bundle, either parsed or JSON.
     #
     # This method performs validation of the PA response bundle structure.
     # It follows the PAS IG requirement that the FHIR Bundle generated
@@ -214,7 +216,7 @@ module DaVinciPASTestKit
     # a given combination of content. Resources echoed back from the request are validated
     # to ensure the same fullUrl and resource identifiers as in the
     # request are used.
-    def validate_pa_response_body_structure(pa_response_bundle, _pa_request_bundle)
+    def validate_pa_response_body_structure(pa_response_bundle, pa_request_bundle)
       first_entry = pa_response_bundle.entry.first.resource
       unless first_entry.is_a?(FHIR::ClaimResponse)
         validation_error_messages <<
@@ -224,22 +226,52 @@ module DaVinciPASTestKit
       base_url = extract_base_url(pa_response_bundle.entry.last&.fullUrl)
       check_presence_of_referenced_resources(first_entry, base_url, pa_response_bundle.entry)
 
-      # Testing: When echoing back resources that are the same as were present in the prior authorization request,
-      # the system SHALL ensure that the same fullUrl and resource identifiers are used in the response as appeared
-      # in the request
-      # pa_request_bundle = FHIR.from_contents(pa_request_bundle)
-      # pa_response_bundle.entry.each do |entry|
-      #   res = entry.resource
-      #   request_entry = pa_request_bundle.entry.find do |ent|
-      #     ent.resource.resourceType == res.resourceType && ent.resource.id == res.id
-      #   end
-      #   next unless request_entry.present?
+      validate_echoed_response_resources(pa_response_bundle, pa_request_bundle)
+    end
+
+    def validate_echoed_response_resources(pa_response_bundle, pa_request_bundle)
+      return if pa_request_bundle.blank?
+
+      request_bundle = pa_request_bundle.is_a?(FHIR::Bundle) ? pa_request_bundle : FHIR.from_contents(pa_request_bundle)
+      return unless request_bundle.is_a?(FHIR::Bundle)
+
+      pa_response_bundle.entry.each do |response_entry|
+        response_resource = response_entry.resource
+        next if response_resource.blank?
+
+        request_entry = request_bundle.entry.find do |entry|
+          echoed_resource?(entry, response_entry)
+        end
+        next if request_entry.blank?
+
+        next if echoed_resource_identifiers_match?(request_entry, response_entry)
 
-      #   assert(
-      #     request_entry.fullUrl == entry.fullUrl && request_entry.resource.identifier == res.identifier,
-      #     resource_present_in_pa_request_and_response_msg(res)
-      #   )
-      # end
+        validation_error_messages << resource_present_in_pa_request_and_response_msg(response_resource)
+      end
+    rescue StandardError
+      validation_error_messages << 'Unable to compare PAS request and response Bundle resources for echoed identifiers.'
+    end
+
+    def echoed_resource?(request_entry, response_entry)
+      request_resource = request_entry.resource
+      response_resource = response_entry.resource
+      return false if request_resource.blank? || response_resource.blank?
+      return false unless request_resource.resourceType == response_resource.resourceType
+
+      # True if any identifying field is present on both sides and matches, so we can later report if any
+      # do not have all matching identifiers. Blank fields do not identify echoed resources.
+      (request_entry.fullUrl.present? && request_entry.fullUrl == response_entry.fullUrl) ||
+        (request_resource.id.present? && request_resource.id == response_resource.id) ||
+        (request_resource.identifier.present? && request_resource.identifier == response_resource.identifier)
+    end
+
+    def echoed_resource_identifiers_match?(request_entry, response_entry)
+      request_resource = request_entry.resource
+      response_resource = response_entry.resource
+
+      request_entry.fullUrl == response_entry.fullUrl &&
+        request_resource.id == response_resource.id &&
+        request_resource.identifier == response_resource.identifier
     end
 
     # Profile conformance of Prior Authorization (PA) resources.
@@ -299,27 +331,36 @@ module DaVinciPASTestKit
     end
 
     # Validates bundle resource and each entry in the bundle against its target profiles.
-    # It logs a message for each conformant entry
-    # and collects error messages for non-conformant entries. Asserts that there are no validation errors.
+    # Validation messages are collected per profile rather than logged directly, so a
+    # resource with multiple candidate profiles only reports errors when it fails all of
+    # them. When a profile passes, only that profile's (non-error) messages are logged.
     # @param version [String] The version of the IG.
     def validate_bundle_entries_against_profiles(version)
       bundle_resources_target_profile_map.each do |key, item|
         resource = item[:resource]
         base_profile = FHIR::Definitions.resource_definition(resource.resourceType).url
+        messages_by_profile = {}
 
         success_profile = item[:profile_urls].find do |url|
-          if key == 'bundle'
-            profile_to_validate = profile_url_for_validation(url, base_profile, version)
-            bundle_profile_valid?(resource, profile_to_validate)
-          elsif url == BASE_R4_PROFILE
-            resource_is_valid?(resource:)
-          else
-            profile_to_validate = profile_url_for_validation(url, base_profile, version)
-            resource_is_valid?(resource:, profile_url: profile_to_validate)
-          end
+          profile_messages =
+            if key == 'bundle'
+              collect_bundle_profile_messages(resource, profile_url_for_validation(url, base_profile, version))
+            elsif url == BASE_R4_PROFILE
+              collect_resource_profile_messages(resource)
+            else
+              collect_resource_profile_messages(resource, profile_url_for_validation(url, base_profile, version)) +
+                datatype_constraint_messages(resource, profile_url_without_version(url), version)
+            end
+          messages_by_profile[url] = profile_messages
+          profile_messages.none? { |message| message[:type] == 'error' }
         end
 
-        validation_error_messages << generate_non_conformance_message(item) unless success_profile
+        if success_profile
+          messages.concat(messages_by_profile[success_profile])
+        else
+          messages_by_profile.each_value { |profile_messages| messages.concat(profile_messages) }
+          validation_error_messages << generate_non_conformance_message(item)
+        end
       end
     end
 
@@ -446,19 +487,36 @@ module DaVinciPASTestKit
       end
     end
 
-    # Validates a Bundle resource against a profile, filtering out entry-resource-level issues
-    # that are covered by individual resource validation to avoid duplicate messages.
+    # Validates a resource against a profile without logging, returning the unfiltered
+    # issues as message hashes for the caller to log once profile selection is resolved.
+    # @param resource [FHIR::Model] The resource to validate.
+    # @param profile_url [String, nil] The profile URL (with version) to validate against,
+    #   or nil to validate against the base resource definition.
+    # @return [Array<Hash>] Message hashes for the issues found.
+    def collect_resource_profile_messages(resource, profile_url = nil)
+      response_details = []
+      resource_is_valid?(resource:, profile_url:,
+                         add_messages_to_runnable: false,
+                         validator_response_details: response_details)
+      validator_issues_to_messages(response_details.reject(&:filtered))
+    end
+
+    # Same as collect_resource_profile_messages for a Bundle, additionally dropping
+    # entry-resource-level issues that are covered by individual resource validation
+    # to avoid duplicate messages.
     # @param bundle [FHIR::Bundle] The Bundle resource to validate.
     # @param profile_url [String] The profile URL (with version) to validate against.
-    # @return [Boolean] true if no unfiltered errors remain after removing entry-resource issues.
-    def bundle_profile_valid?(bundle, profile_url)
+    # @return [Array<Hash>] Message hashes for the Bundle-structural issues found.
+    def collect_bundle_profile_messages(bundle, profile_url)
       response_details = []
       resource_is_valid?(resource: bundle, profile_url:,
                          add_messages_to_runnable: false,
                          validator_response_details: response_details)
-      bundle_level_issues = reject_entry_resource_issues(response_details)
-      bundle_level_issues.each { |issue| messages << { type: issue.severity, message: issue.message } }
-      bundle_level_issues.none? { |issue| issue.severity == 'error' }
+      validator_issues_to_messages(reject_entry_resource_issues(response_details))
+    end
+
+    def validator_issues_to_messages(issues)
+      issues.map { |issue| { type: issue.severity, message: issue.message } }
     end
 
     # Rejects validator issues that are already filtered or are located at/below

data/lib/davinci_pas_test_kit/cross_suite/pas_constants.rb

@@ -5,6 +5,7 @@ module DaVinciPASTestKit
     CLAIM_RESPONSE_PROFILE = 'http://hl7.org/fhir/us/davinci-pas/StructureDefinition/profile-claimresponse'.freeze
     CLAIM_INQUIRY_PROFILE = 'http://hl7.org/fhir/us/davinci-pas/StructureDefinition/profile-claim-inquiry'.freeze
     CLAIM_INQUIRY_RESPONSE_PROFILE = 'http://hl7.org/fhir/us/davinci-pas/StructureDefinition/profile-claiminquiryresponse'.freeze
+    DATA_ABSENT_REASON_EXTENSION_URL = 'http://hl7.org/fhir/StructureDefinition/data-absent-reason'.freeze
 
     BUNDLE_PROFILES_FOR_OPERATION_TYPE = {
       submit_request: 'http://hl7.org/fhir/us/davinci-pas/StructureDefinition/profile-pas-request-bundle',
@@ -13,6 +14,11 @@ module DaVinciPASTestKit
       inquire_response: 'http://hl7.org/fhir/us/davinci-pas/StructureDefinition/profile-pas-inquiry-response-bundle'
     }.freeze
 
+    REFERENCE_NUMBER_EXTENSIONS = {
+      authorization_number: 'http://hl7.org/fhir/us/davinci-pas/StructureDefinition/extension-authorizationNumber',
+      administration_reference_number: 'http://hl7.org/fhir/us/davinci-pas/StructureDefinition/extension-administrationReferenceNumber'
+    }.freeze
+
     def self.bundle_profile_url_for_operation_and_type(operation, type)
       BUNDLE_PROFILES_FOR_OPERATION_TYPE[:"#{operation}_#{type}"]
     end

data/lib/davinci_pas_test_kit/cross_suite/pas_datatype_constraints.rb

@@ -0,0 +1,166 @@
+require_relative 'pas_constants'
+
+module DaVinciPASTestKit
+  # Checks for the narrative-only constraints on the PAS Timing and Quantity data type
+  # profiles introduced in v2.2 (prof-1, prof-2, prof-3). These constraints have no
+  # FHIRPath expression in the StructureDefinitions, so the FHIR validator cannot
+  # enforce them and they are verified here instead.
+  # See https://hl7.org/fhir/us/davinci-pas/STU2.2/StructureDefinition-profile-datatype-timing.html
+  # and https://hl7.org/fhir/us/davinci-pas/STU2.2/StructureDefinition-profile-quantity.html
+  module PasDatatypeConstraints
+    PAS_STRUCTURE_DEFINITION_BASE = 'http://hl7.org/fhir/us/davinci-pas/StructureDefinition'.freeze
+
+    TIMING_CALENDAR_PATTERN_EXTENSION_URL = "#{PAS_STRUCTURE_DEFINITION_BASE}/extension-timingcalendarpattern".freeze
+    TIMING_DELIVERY_PATTERN_EXTENSION_URL = "#{PAS_STRUCTURE_DEFINITION_BASE}/extension-timingdeliverypattern".freeze
+    ITEM_AUTHORIZED_DETAIL_EXTENSION_URL = "#{PAS_STRUCTURE_DEFINITION_BASE}/extension-itemAuthorizedDetail".freeze
+
+    # Quantity.code is bound (required) to the X12 673 "quantity qualifier" value set,
+    # which the terminology validator cannot expand. Requiring this system when a code
+    # is present is the machine-checkable part of prof-3.
+    X12_QUANTITY_UNITS_SYSTEM = 'https://codesystem.x12.org/005010/673'.freeze
+
+    # Profiles that apply profile-datatype-timing to elements of their resource.
+    TIMING_CONSTRAINED_PROFILE_URLS = [
+      "#{PAS_STRUCTURE_DEFINITION_BASE}/profile-devicerequest",
+      "#{PAS_STRUCTURE_DEFINITION_BASE}/profile-medicationrequest",
+      "#{PAS_STRUCTURE_DEFINITION_BASE}/profile-servicerequest"
+    ].freeze
+
+    # Profiles that apply profile-quantity to elements of their resource, directly or
+    # inherited from profile-claim-base (Claim.item.quantity) and
+    # profile-claimresponse-base (ClaimResponse.addItem.quantity and the
+    # itemAuthorizedDetail quantity sub-extension).
+    QUANTITY_CONSTRAINED_PROFILE_URLS = [
+      PASConstants::CLAIM_PROFILE_FIRST_SUBMIT,
+      PASConstants::CLAIM_PROFILE,
+      PASConstants::CLAIM_INQUIRY_PROFILE,
+      PASConstants::CLAIM_RESPONSE_PROFILE,
+      PASConstants::CLAIM_INQUIRY_RESPONSE_PROFILE,
+      "#{PAS_STRUCTURE_DEFINITION_BASE}/profile-servicerequest"
+    ].freeze
+
+    # Evaluates the PAS data type profile constraints for a resource against a profile.
+    # @param resource [FHIR::Model] The resource being validated.
+    # @param profile_url [String] The canonical (unversioned) profile URL being validated against.
+    # @param version [String] The IG version.
+    # @return [Array<Hash>] Error message hashes for each constraint violation found.
+    def datatype_constraint_messages(resource, profile_url, version)
+      return [] unless pas_datatype_constraints_enabled?(version)
+
+      constraint_messages = []
+      if TIMING_CONSTRAINED_PROFILE_URLS.include?(profile_url)
+        profiled_timing_elements(resource).each do |timing, location|
+          constraint_messages << timing_prof1_message(resource, timing, location)
+        end
+      end
+      if QUANTITY_CONSTRAINED_PROFILE_URLS.include?(profile_url)
+        profiled_quantity_elements(resource).each do |quantity, location|
+          constraint_messages << quantity_prof2_message(resource, quantity, location)
+          constraint_messages << quantity_prof3_message(resource, quantity, location)
+        end
+      end
+      constraint_messages.compact
+    end
+
+    # The Timing and Quantity data type profiles were introduced in PAS v2.2.
+    def pas_datatype_constraints_enabled?(version)
+      version.to_s.delete_prefix('v').match?(/\A2\.2(\.|\z)/)
+    end
+
+    private
+
+    # Timing instances the PAS profiles constrain, paired with their element locations.
+    def profiled_timing_elements(resource)
+      case resource.resourceType
+      when 'DeviceRequest', 'ServiceRequest'
+        timing = resource.occurrenceTiming
+        timing.present? ? [[timing, "#{resource.resourceType}.occurrenceTiming"]] : []
+      when 'MedicationRequest'
+        Array(resource.dosageInstruction).each_with_index.filter_map do |dosage, index|
+          [dosage.timing, "MedicationRequest.dosageInstruction[#{index}].timing"] if dosage.timing.present?
+        end
+      else
+        []
+      end
+    end
+
+    # Quantity instances the PAS profiles constrain, paired with their element locations.
+    def profiled_quantity_elements(resource)
+      case resource.resourceType
+      when 'Claim'
+        Array(resource.item).each_with_index.filter_map do |item, index|
+          [item.quantity, "Claim.item[#{index}].quantity"] if item.quantity.present?
+        end
+      when 'ClaimResponse'
+        claim_response_quantity_elements(resource)
+      when 'ServiceRequest'
+        quantity = resource.quantityQuantity
+        quantity.present? ? [[quantity, 'ServiceRequest.quantityQuantity']] : []
+      else
+        []
+      end
+    end
+
+    def claim_response_quantity_elements(resource)
+      add_item_quantities = Array(resource.addItem).each_with_index.filter_map do |add_item, index|
+        [add_item.quantity, "ClaimResponse.addItem[#{index}].quantity"] if add_item.quantity.present?
+      end
+
+      authorized_detail_quantities = Array(resource.item).each_with_index.flat_map do |item, index|
+        Array(item.extension)
+          .select { |extension| extension.url == ITEM_AUTHORIZED_DETAIL_EXTENSION_URL }
+          .filter_map do |extension|
+            quantity = Array(extension.extension).find { |sub| sub.url == 'quantity' }&.valueQuantity
+            if quantity.present?
+              [quantity, "ClaimResponse.item[#{index}].extension:authorizedItemDetail.extension:quantity.valueQuantity"]
+            end
+          end
+      end
+
+      add_item_quantities + authorized_detail_quantities
+    end
+
+    # prof-1: Timings SHALL have at least one of: a count, a frequency and period and
+    # periodUnit (with optional frequencyMax and periodMax), a calendarPattern, or a
+    # deliveryPattern.
+    def timing_prof1_message(resource, timing, location)
+      repeat = timing.repeat
+      return if repeat&.count.present?
+      return if repeat&.frequency.present? && repeat.period.present? && repeat.periodUnit.present?
+      return if extension_present?(timing, TIMING_CALENDAR_PATTERN_EXTENSION_URL)
+      return if extension_present?(timing, TIMING_DELIVERY_PATTERN_EXTENSION_URL)
+
+      datatype_constraint_message(resource, location,
+                                  'Timings SHALL have at least one of: a count, a frequency and period and ' \
+                                  'periodUnit (with optional frequencyMax and periodMax), a calendarPattern, ' \
+                                  'or a deliveryPattern (prof-1)')
+    end
+
+    # prof-2: Quantities SHALL have a value and either a unit or a code.
+    def quantity_prof2_message(resource, quantity, location)
+      return if quantity.value.present? && (quantity.unit.present? || quantity.code.present?)
+
+      datatype_constraint_message(resource, location,
+                                  'Quantities SHALL have a value and either a unit or a code (prof-2)')
+    end
+
+    # prof-3: If a quantity code is present, it SHALL use the X12 quantity units.
+    def quantity_prof3_message(resource, quantity, location)
+      return if quantity.code.blank? || quantity.system == X12_QUANTITY_UNITS_SYSTEM
+
+      datatype_constraint_message(resource, location,
+                                  'If a quantity code is present, it SHALL use the X12 quantity units ' \
+                                  "(system #{X12_QUANTITY_UNITS_SYSTEM}) (prof-3)")
+    end
+
+    def extension_present?(element, url)
+      Array(element.extension).any? { |extension| extension.url == url }
+    end
+
+    # Mirrors the "ResourceType/id: location: message" format of validator messages.
+    def datatype_constraint_message(resource, location, description)
+      resource_label = resource.id.present? ? "#{resource.resourceType}/#{resource.id}" : resource.resourceType
+      { type: 'error', message: "#{resource_label}: #{location}: #{description}" }
+    end
+  end
+end

data/lib/davinci_pas_test_kit/cross_suite/response_selection_utils.rb

@@ -32,10 +32,10 @@ module DaVinciPASTestKit
       criteria.is_a?(Hash) ? criteria : {}
     end
 
-    def include_entity?(entity, request_fhir_obj, operation)
+    def include_entity?(entity, request_fhir_obj, request_number)
       criteria = entity_criteria(entity)
       return false if criteria[REQUEST_RANGE_KEY].present? &&
-                      !request_meets_request_range_criteria?(criteria[REQUEST_RANGE_KEY], operation)
+                      !ranges_cover_value?(request_number, criteria[REQUEST_RANGE_KEY].to_s)
       return false if criteria[FHIRPATH_KEY].present? &&
                       !request_meets_inclusion_criteria?(criteria[FHIRPATH_KEY], request_fhir_obj)
 
@@ -55,26 +55,23 @@ module DaVinciPASTestKit
     # Request index-based selection criteria
     # ***********************************************************************
 
-    def request_meets_request_range_criteria?(ranges, operation)
-      ranges_cover_value?(count_previous_successful_requests(operation) + 1, ranges.to_s)
-    end
-
     def count_previous_successful_requests(operation)
       requests_repo = Inferno::Repositories::Requests.new
       previous_requests = requests_repo.requests_for_result(result.id)
       previous_requests.count { |req| req.url.include?(operation) && req.status == 200 }
     end
 
+    # An invalid range comes from tester input, so it is reported as a warning on the
+    # test and treated as unmet rather than raised, leaving the candidate unselected.
     def ranges_cover_value?(value, ranges_string)
       unless /\A(\d+(-\d+)?,)*\d+(-\d+)?\z/.match?(ranges_string)
-        raise ArgumentError,
-              "Invalid range string: #{ranges_string.inspect}"
+        raise ArgumentError, 'expected comma-separated numbers or ranges such as "1-2,4"'
       end
 
       ranges_string.split(',').any? do |part|
         if part.include?('-')
           low, high = part.split('-').map(&:to_i)
-          raise ArgumentError, "Inverted range in: #{part.inspect}" if low > high
+          raise ArgumentError, "#{part.inspect} is inverted" if low > high
 
           (low..high).cover?(value)
         else
@@ -82,7 +79,26 @@ module DaVinciPASTestKit
         end
       end
     rescue ArgumentError => e
-      raise Inferno::Exceptions::TestSuiteImplementationException.new('pas response range criteria', e.message)
+      add_result_warning(
+        "Invalid requestRange criteria #{ranges_string.inspect}. The corresponding Bundle was not selected " \
+        "(#{e.message})."
+      )
+      false
+    end
+
+    # ***********************************************************************
+    # Tester-facing warnings
+    # ***********************************************************************
+
+    # Records a warning on the result of the waiting test, where the tester will see it,
+    # since problems with response selection stem from tester-provided input. The same
+    # input is evaluated for every incoming request, so a warning identical to one the
+    # result already has is not recorded again.
+    def add_result_warning(message)
+      messages_repo = Inferno::Repositories::Messages.new
+      return if messages_repo.messages_for_result(result.id).any? { |existing| existing.message == message }
+
+      messages_repo.create(result_id: result.id, type: 'warning', message:)
     end
   end
 end