davidsons 1.0.1 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 0840c1274babcf9eb57a4ef24f84931ee3693e7a
-  data.tar.gz: 053ab73ab4258594104732a3e943111202da2383
+SHA256:
+  metadata.gz: 9bf429f746003d6265c0b884318f237f1ed19bc1667008112531e56d66adb9a8
+  data.tar.gz: bf631b8a5f09378731ce6473e1a0beb8fb5b1e9e0d3de7f49e8f0692a0330e11
 SHA512:
-  metadata.gz: 445dd946ba77bf28ae1e6bb7b78f7033ad1aa3aeedc1ec5c42d9788be5790aa93bf3aa076d6879c2fd50baf12052d674887f83155550d1859afa9d82317c81cc
-  data.tar.gz: d0ab4bec018a56e335753e9951da13ef6516066d592ee7ad16faa1f47240d074a40db1a8b62907fc6fc37308f91fd1a0c68ea9934207ee34db7b91f653ab485c
+  metadata.gz: b04b1a42bc0bf21365523d7fad7552e021c0ae91214d8c3e842a81b70c2172c3d12a13195e6dc969f78fe36625a91de454cf08ea770cf2fba13d436c47d9d318
+  data.tar.gz: f4d7a8f6050ecb28ab0c1c0b9ee115ddf047bbea44732c30c0a532f8cc26dc9f5e2d29f1762d99e1b507f4ab3ea452288070c38027130cf9941256a6f9e02feb

data/.circleci/config.yml

@@ -0,0 +1,41 @@
+# Ruby CircleCI 2.0 configuration file
+#
+# Check https://circleci.com/docs/2.0/language-ruby/ for more details
+#
+version: 2
+jobs:
+  build:
+    docker:
+      # specify the version you desire here
+       - image: circleci/ruby:2.4.1-node-browsers
+
+    working_directory: ~/repo
+
+    steps:
+      - checkout
+
+      # Download and cache dependencies
+      - restore_cache:
+          keys:
+          - v1-dependencies-{{ checksum "davidsons.gemspec" }}
+          # fallback to using the latest cache if no exact match is found
+          - v1-dependencies-
+
+      - run:
+          name: install dependencies
+          command: |
+            bundle install --jobs=4 --retry=3 --path vendor/bundle
+
+      - save_cache:
+          paths:
+            - ./vendor/bundle
+          key: v1-dependencies-{{ checksum "Gemfile.lock" }}
+
+      # run tests!
+      - run:
+          name: run tests
+          command: |
+            mkdir /tmp/test-results
+            TEST_FILES="$(circleci tests glob "spec/**/*_spec.rb" | circleci tests split --split-by=timings)"
+            
+            bundle exec rspec --format documentation $TEST_FILES

data/.gitignore

@@ -10,3 +10,4 @@
 
 # rspec failure tracking
 .rspec_status
+script/*

data/.ruby-gemset

@@ -0,0 +1 @@
+davidsons

data/.ruby-version

@@ -0,0 +1 @@
+2.3.6

data/lib/davidsons.rb

@@ -1,6 +1,7 @@
 require "davidsons/version"
 
 require 'net/ftp'
+require 'smarter_csv'
 
 require 'davidsons/base'
 require 'davidsons/user'
@@ -25,15 +26,15 @@ module Davidsons
   end
 
   class Configuration
-    attr_accessor :debug
+    attr_accessor :debug_mode
     attr_accessor :ftp_host
     attr_accessor :proxy_url
     attr_accessor :xmlns
 
-    alias debug? debug
+    alias debug_mode? debug_mode
 
     def initialize
-      @debug      ||= false
+      @debug_mode ||= false
       @ftp_host   ||= "ftp.davidsonsinventory.com"
       @proxy_url  ||= "http://172.31.69.148:8888"
       @xmlns      ||= "https://dealernetwork.davidsonsinc.com/"

data/lib/davidsons/base.rb

@@ -6,11 +6,16 @@ module Davidsons
 
       Net::FTP.open(Davidsons.config.ftp_host, options[:username], options[:password]) do |ftp|
         ftp.passive = true
+        ftp.debug_mode = Davidsons.config.debug_mode?
 
         yield ftp
       end
-    rescue Net::FTPPermError
-      raise Davidsons::NotAuthenticated
+    rescue Net::FTPPermError => e
+      if e.to_s.start_with?('530')
+        raise Davidsons::NotAuthenticated
+      else
+        raise e
+      end
     end
 
     protected

data/lib/davidsons/catalog.rb

@@ -1,8 +1,8 @@
 module Davidsons
   class Catalog < Base
 
-    CATALOG_FILENAME  = "davidsons_inventory.csv".freeze
-    CHUNK_SIZE        = 100
+    CATALOG_FILENAME = "davidsons_inventory.csv".freeze
+    CHUNK_SIZE       = 100
 
     def initialize(options = {})
       requires!(options, :username, :password)
@@ -35,16 +35,14 @@ module Davidsons
         chunk.each do |item|
           item.except!(:retail_price, :capacity, :sale_price, :sale_ends)
 
-          item[:mfg_number] = item[:item_identifier]
           item[:msrp].tr!('$', '')
           item[:price].tr!('$', '')
           item[:upc].tr!('#', '')
-          item[:quantity] = item[:quantity].to_i
 
+          item[:mfg_number] = item[:item_identifier]
+          item[:quantity] = item[:quantity].to_i
           item[:features] = map_features(item)
 
-          item.except!(:finish, :barrel_length, :overall_length, :model_series, :sights, :stock)
-
           yield(item)
         end
       end
@@ -54,12 +52,12 @@ module Davidsons
 
     def map_features(item)
       {
-        finish:         item[:finish],
-        barrel_length:  item[:barrel_length],
-        overall_length: item[:overall_length],
-        model_series:   item[:model_series],
-        sights:         item[:sights],
-        stock:          item[:stock]
+        finish:         item.delete(:finish),
+        barrel_length:  item.delete(:barrel_length),
+        overall_length: item.delete(:overall_length),
+        model_series:   item.delete(:model_series),
+        sights:         item.delete(:sights),
+        stock:          item.delete(:stock),
       }
     end
 

data/lib/davidsons/inventory.rb

@@ -64,7 +64,7 @@ module Davidsons
         chunk.each do |item|
           item.except!(:upc_code)
 
-          item[:quantity]   = item[:quantity_nc].to_i + item[:quantity_az].to_i
+          item[:quantity] = item[:quantity_nc].to_i + item[:quantity_az].to_i
 
           item.except!(:quantity_nc, :quantity_az)
 

data/lib/davidsons/order.rb

@@ -4,8 +4,8 @@ require 'pp'
 module Davidsons
   class Order < Base
 
-    TEST_URL  = 'https://dealernetwork.davidsonsinc.com/testapi/orderservice.asmx?WSDL'
-    API_URL   = 'https://dealernetwork.davidsonsinc.com/api/orderservice.asmx?WSDL'
+    TEST_URL = 'https://dealernetwork.davidsonsinc.com/testapi/orderservice.asmx?WSDL'
+    API_URL  = 'https://dealernetwork.davidsonsinc.com/api/orderservice.asmx?WSDL'
 
     attr :client
 
@@ -14,10 +14,11 @@ module Davidsons
 
       @options = options
 
-      settings = Hash.new
-      settings[:wsdl]                     = @options[:test] ? TEST_URL : API_URL
-      settings[:env_namespace]            = 'soap'
-      settings[:proxy]                    = Davidsons.config.proxy_url
+      settings = {
+        wsdl:          @options[:test] ? TEST_URL : API_URL,
+        env_namespace: 'soap',
+        proxy:         Davidsons.config.proxy_url
+      }
 
       if @options[:test]
         settings[:log]              = true
@@ -50,8 +51,8 @@ module Davidsons
 
     def get_order_tracking(order_number)
       request = @client.call(:get_order_tracking, attributes: { xmlns: Davidsons.config.xmlns }, message: { ':request': {
-        'Token'    => @options[:token],
-        'OrderNo'  => order_number
+        'Token'   => @options[:token],
+        'OrderNo' => order_number
       }})
 
       tracking_info = request.body[:get_order_tracking_response][:get_order_tracking_result]

data/lib/davidsons/user.rb

@@ -10,7 +10,9 @@ module Davidsons
     def authenticated?
       connect(@options) { |ftp| ftp.pwd }
       true
-    rescue Davidsons::NotAuthenticated
+    rescue Davidsons::NotAuthenticated => e
+      puts "Davidsons::User#authenticated? => false"
+      puts e
       false
     end
 

data/lib/davidsons/version.rb

@@ -1,3 +1,3 @@
 module Davidsons
-  VERSION = "1.0.1"
+  VERSION = '1.0.3'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: davidsons
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.3
 platform: ruby
 authors:
 - David Knight
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-08-03 00:00:00.000000000 Z
+date: 2018-08-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: savon
@@ -101,8 +101,11 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".circleci/config.yml"
 - ".gitignore"
 - ".rspec"
+- ".ruby-gemset"
+- ".ruby-version"
 - ".travis.yml"
 - Gemfile
 - LICENSE.txt
@@ -138,7 +141,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: Ruby library for Davidson's