datts_right 0.0.26 → 0.0.27

data/Gemfile.lock

@@ -1,9 +1,8 @@
 PATH
   remote: .
   specs:
-    datts_right (0.0.25)
+    datts_right (0.0.26)
       datts_right
-      rails (>= 3.0.0)
 
 GEM
   remote: http://rubygems.org/

data/VERSION

@@ -1 +1 @@
-0.0.26
+0.0.27

data/datts_right.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{datts_right}
-  s.version = "0.0.26"
+  s.version = "0.0.27"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Ramon Tayag"]

data/lib/datts_right/instance_methods.rb

@@ -127,6 +127,16 @@ module DattsRight
         key = key.to_sym
         #puts "add_definition(:#{key}, #{value.inspect}). current definition: #{definition.nil?}"
         if dynamic_attributes_options[:definition]
+          #puts ":definition is true, so let's see if definition[:#{key}] already exists"
+          # Checking definition straight seems to cause a problem. Is this a bug with Rails?
+          # The problem was like this (assuming definition was actually nil):
+          # definition.nil? # false
+          # definition.inspect # nil
+          # definition.class.name # NilClass
+          # 
+          # How in the world can .nil? return false when it was nil??
+          dynamic_attribute_definition.definition ||= {}
+
           if definition[key]
             raise AlreadyDefined, "#{key} is already defined"
           else

data/spec/datts_right/add_definition_spec.rb

@@ -28,4 +28,11 @@ describe DattsRight, ".add_definition(key, value)" do
   it "should raise AttributeKeyRequired if no attr_key is passed" do
     lambda {Page.create.add_definition(nil, {})}.should raise_error(DattsRight::AttributeKeyRequired)
   end
+
+  it "should be able to handle if definition is nil" do
+    c = Category.create
+    c.definition = nil
+    c.save
+    lambda {c.add_definition(:real, :object_type => "string")}.should_not raise_error(NoMethodError)
+  end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: datts_right
 version: !ruby/object:Gem::Version 
-  hash: 43
+  hash: 41
   prerelease: 
   segments: 
   - 0
   - 0
-  - 26
-  version: 0.0.26
+  - 27
+  version: 0.0.27
 platform: ruby
 authors: 
 - Ramon Tayag