datts_right 0.0.11 → 0.0.12

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    datts_right (0.0.10)
+    datts_right (0.0.11)
       datts_right
       rails (>= 3.0.0)
 

data/VERSION

@@ -1 +1 @@
-0.0.11
+0.0.12

data/datts_right.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{datts_right}
-  s.version = "0.0.11"
+  s.version = "0.0.12"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Ramon Tayag"]
@@ -188,6 +188,18 @@ Gem::Specification.new do |s|
       s.add_development_dependency(%q<bundler>, ["~> 1.0.0"])
       s.add_development_dependency(%q<jeweler>, ["~> 1.5.2"])
       s.add_development_dependency(%q<rcov>, [">= 0"])
+      s.add_development_dependency(%q<autotest>, [">= 0"])
+      s.add_development_dependency(%q<sqlite3>, [">= 0"])
+      s.add_development_dependency(%q<rspec>, ["~> 2.3.0"])
+      s.add_development_dependency(%q<bundler>, ["~> 1.0.0"])
+      s.add_development_dependency(%q<jeweler>, ["~> 1.5.2"])
+      s.add_development_dependency(%q<rcov>, [">= 0"])
+      s.add_development_dependency(%q<autotest>, [">= 0"])
+      s.add_development_dependency(%q<sqlite3>, [">= 0"])
+      s.add_development_dependency(%q<rspec>, ["~> 2.3.0"])
+      s.add_development_dependency(%q<bundler>, ["~> 1.0.0"])
+      s.add_development_dependency(%q<jeweler>, ["~> 1.5.2"])
+      s.add_development_dependency(%q<rcov>, [">= 0"])
     else
       s.add_dependency(%q<datts_right>, [">= 0"])
       s.add_dependency(%q<rails>, [">= 3.0.0"])
@@ -324,6 +336,18 @@ Gem::Specification.new do |s|
       s.add_dependency(%q<bundler>, ["~> 1.0.0"])
       s.add_dependency(%q<jeweler>, ["~> 1.5.2"])
       s.add_dependency(%q<rcov>, [">= 0"])
+      s.add_dependency(%q<autotest>, [">= 0"])
+      s.add_dependency(%q<sqlite3>, [">= 0"])
+      s.add_dependency(%q<rspec>, ["~> 2.3.0"])
+      s.add_dependency(%q<bundler>, ["~> 1.0.0"])
+      s.add_dependency(%q<jeweler>, ["~> 1.5.2"])
+      s.add_dependency(%q<rcov>, [">= 0"])
+      s.add_dependency(%q<autotest>, [">= 0"])
+      s.add_dependency(%q<sqlite3>, [">= 0"])
+      s.add_dependency(%q<rspec>, ["~> 2.3.0"])
+      s.add_dependency(%q<bundler>, ["~> 1.0.0"])
+      s.add_dependency(%q<jeweler>, ["~> 1.5.2"])
+      s.add_dependency(%q<rcov>, [">= 0"])
     end
   else
     s.add_dependency(%q<datts_right>, [">= 0"])
@@ -461,6 +485,18 @@ Gem::Specification.new do |s|
     s.add_dependency(%q<bundler>, ["~> 1.0.0"])
     s.add_dependency(%q<jeweler>, ["~> 1.5.2"])
     s.add_dependency(%q<rcov>, [">= 0"])
+    s.add_dependency(%q<autotest>, [">= 0"])
+    s.add_dependency(%q<sqlite3>, [">= 0"])
+    s.add_dependency(%q<rspec>, ["~> 2.3.0"])
+    s.add_dependency(%q<bundler>, ["~> 1.0.0"])
+    s.add_dependency(%q<jeweler>, ["~> 1.5.2"])
+    s.add_dependency(%q<rcov>, [">= 0"])
+    s.add_dependency(%q<autotest>, [">= 0"])
+    s.add_dependency(%q<sqlite3>, [">= 0"])
+    s.add_dependency(%q<rspec>, ["~> 2.3.0"])
+    s.add_dependency(%q<bundler>, ["~> 1.0.0"])
+    s.add_dependency(%q<jeweler>, ["~> 1.5.2"])
+    s.add_dependency(%q<rcov>, [">= 0"])
   end
 end
 

data/lib/datts_right/dynamic_attribute.rb

@@ -9,11 +9,12 @@ class DynamicAttribute < ActiveRecord::Base
 
   def value=(v)
     object_type = self.class.attr_type?(v)
-
-    if self.object_type == object_type # has to be the same kind of object
-      send "#{self.class.attr_column(v)}=", v
-    elsif v.nil?
+    if v.nil?
       send "#{self.object_type}_value=", v
+    elsif object_type == "string" && self.object_type == "text"
+      self.text_value = v
+    else
+      send "#{self.class.attr_column(v)}=", v
     end
   end
 

data/lib/datts_right/instance_methods.rb

@@ -12,11 +12,12 @@ module DattsRight
     end
 
     def remove_dynamic_attribute(name)
+      # Remove from the cache
+      @dynamic_attributes_cache.delete(name.to_sym)
+
+      # Then remove from the db
       dynamic_attribute = dynamic_attributes.find_by_attr_key(name.to_s)
-      if dynamic_attribute
-        @dynamic_attributes_cache.delete(name.to_sym)
-        dynamic_attribute.destroy
-      end
+      dynamic_attribute.destroy if dynamic_attribute
     end
 
     # Give users access to the cache
@@ -51,21 +52,21 @@ module DattsRight
 
     # Like AR::Base#read_attribute
     def read_dynamic_attribute(attr_name)
-      attr_name = attr_name.to_s
+      attr_name = attr_name.to_sym
       if dynamic_attribute?(attr_name)
         #puts "Reading #{attr_name}. The whole cache: #{@dynamic_attributes_cache.inspect}"
-        @dynamic_attributes_cache[attr_name.to_sym].value
+        @dynamic_attributes_cache[attr_name].value
       end
     end
 
     # Like AR::Base#write_attribute
     def write_dynamic_attribute(attr_name, value)
       #puts "attempting to write: #{attr_name} = #{value}"
+      attr_name = attr_name.to_sym
       if dynamic_attribute?(attr_name)
         #puts "#{attr_name} is a dynamic_attribute"
-        attr_name = attr_name.to_s
         #puts "Writing @dynamic_attributes_cache[:#{attr_name}].value = #{value}"
-        dynamic_attribute = @dynamic_attributes_cache[attr_name.to_sym]
+        dynamic_attribute = @dynamic_attributes_cache[attr_name]
         dynamic_attribute.value = value
         #puts "In write_dynamic_attribute. Full cache: #{@dynamic_attributes_cache.inspect}"
         return dynamic_attribute.value
@@ -103,6 +104,35 @@ module DattsRight
       @dynamic_attributes_cache
     end
 
+    def method_missing(method_id, *args, &body)
+      #begin
+        #method_missing_without_dynamic_attributes method_id, *args, &block
+      #rescue NoMethodError => e
+        #attr_name = method_id.to_s.sub(/\=$/, '')
+        #if is_dynamic_attribute?(attr_name)
+          #if method_id.to_s =~ /\=$/
+            #return write_attribute_with_dynamic_attributes(attr_name, args[0])
+          #else
+            #return read_attribute_with_dynamic_attributes(attr_name)
+          #end
+        #end
+        #raise e
+      #end
+      begin
+        super(method_id, *args, &body)
+      rescue NoMethodError => e
+        attr_name = method_id.to_s.sub(/\=$/, '')
+        if dynamic_attribute?(attr_name)
+          #puts "#{attr_name} is a dynamic_attribute"
+          method_id.to_s =~ /\=$/ ? write_dynamic_attribute(attr_name, args[0]) : read_dynamic_attribute(attr_name)
+        #else
+          #super(method_id, *args, &body) # send it to super again, so that any magic activerecord needs to do will still work
+        else
+          raise NoMethodError
+        end
+      end
+    end
+
     alias :add_datt :add_dynamic_attribute
     alias :remove_datt :remove_dynamic_attribute
     alias :read_datt :read_dynamic_attribute

data/spec/datts_right_spec.rb

@@ -414,4 +414,25 @@ describe DattsRight do
       @page.dynamic_attribute_details(:body).value.should == @page.read_datt(:body)
     end
   end
+
+  it "should be able to write short strings into text variables" do
+    @page.add_datt(:body, "text")
+    @page.write_datt(:body, "short")
+    @page.save
+    @page.read_datt(:body).should == "short"
+  end
+
+  it "should write like a normal attribute" do
+    @page.add_datt(:body, "text")
+    @page.body = "dude"
+    @page.save
+    @page.read_datt(:body).should == "dude"
+  end
+
+  it "should read like a normal attribute" do
+    @page.add_datt(:body, "text")
+    @page.body = "dude"
+    @page.save
+    @page.body.should == "dude"
+  end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: datts_right
 version: !ruby/object:Gem::Version 
-  hash: 9
+  hash: 7
   prerelease: 
   segments: 
   - 0
   - 0
-  - 11
-  version: 0.0.11
+  - 12
+  version: 0.0.12
 platform: ruby
 authors: 
 - Ramon Tayag
@@ -2044,6 +2044,186 @@ dependencies:
   name: rcov
   version_requirements: *id135
   prerelease: false
+- !ruby/object:Gem::Dependency 
+  type: :development
+  requirement: &id136 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  name: autotest
+  version_requirements: *id136
+  prerelease: false
+- !ruby/object:Gem::Dependency 
+  type: :development
+  requirement: &id137 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  name: sqlite3
+  version_requirements: *id137
+  prerelease: false
+- !ruby/object:Gem::Dependency 
+  type: :development
+  requirement: &id138 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 2
+        - 3
+        - 0
+        version: 2.3.0
+  name: rspec
+  version_requirements: *id138
+  prerelease: false
+- !ruby/object:Gem::Dependency 
+  type: :development
+  requirement: &id139 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        hash: 23
+        segments: 
+        - 1
+        - 0
+        - 0
+        version: 1.0.0
+  name: bundler
+  version_requirements: *id139
+  prerelease: false
+- !ruby/object:Gem::Dependency 
+  type: :development
+  requirement: &id140 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        hash: 7
+        segments: 
+        - 1
+        - 5
+        - 2
+        version: 1.5.2
+  name: jeweler
+  version_requirements: *id140
+  prerelease: false
+- !ruby/object:Gem::Dependency 
+  type: :development
+  requirement: &id141 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  name: rcov
+  version_requirements: *id141
+  prerelease: false
+- !ruby/object:Gem::Dependency 
+  type: :development
+  requirement: &id142 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  name: autotest
+  version_requirements: *id142
+  prerelease: false
+- !ruby/object:Gem::Dependency 
+  type: :development
+  requirement: &id143 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  name: sqlite3
+  version_requirements: *id143
+  prerelease: false
+- !ruby/object:Gem::Dependency 
+  type: :development
+  requirement: &id144 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 2
+        - 3
+        - 0
+        version: 2.3.0
+  name: rspec
+  version_requirements: *id144
+  prerelease: false
+- !ruby/object:Gem::Dependency 
+  type: :development
+  requirement: &id145 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        hash: 23
+        segments: 
+        - 1
+        - 0
+        - 0
+        version: 1.0.0
+  name: bundler
+  version_requirements: *id145
+  prerelease: false
+- !ruby/object:Gem::Dependency 
+  type: :development
+  requirement: &id146 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        hash: 7
+        segments: 
+        - 1
+        - 5
+        - 2
+        version: 1.5.2
+  name: jeweler
+  version_requirements: *id146
+  prerelease: false
+- !ruby/object:Gem::Dependency 
+  type: :development
+  requirement: &id147 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  name: rcov
+  version_requirements: *id147
+  prerelease: false
 description: Creates a separate table that saves all your dynamic attributes.
 email: ramon@tayag.net
 executables: []