date_parity 0.0.3 → 0.1.0

data/Gemfile

@@ -2,3 +2,5 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in date_parity.gemspec
 gemspec
+
+gem "debugger"

data/README.md

@@ -2,13 +2,13 @@
 
 Date formatting and parsing per request in Rails with parity between date.to\_s.and string.to\_date.
 
-Rails already has some great Date formatting and parsing options available. For example, Date.DATE\_FORMATS makes it easy to configure and reuse common formats for your application. But, other then the :default it require an explicit field.to\_s(:format) to be applied. Additionally, nothing happens automatically when parsing those dates back from user edits. This generally require some explicit steps per field in your model or controller. 
+Rails has some great Date formatting and parsing options available. But, it still requires a lot of helping code to consistently parse and display dates in a particular format . For example, Date.DATE\_FORMATS makes it easy to configure and reuse common formats for your application. But, other then the :default it require an explicit field.to\_s(:format) to be applied. Additionally, nothing happens automatically when parsing those dates back from user edits. This generally require some explicit steps per field in your model or controller. 
 
 Rails also provides the ability to localize your Date formats. But, that requires decisions made for all users in a particular locale.
 
-Often, we need to allow users, companies, organizations, etc. the ability to choose preferred date formats. Both of the Rails standard approaches using Date.DATE\_FORMATS or localization fall short at making that easy. You end up writing a lot helpers around date fields, and code to normalize posted date values. 
+Often, we need to allow users, companies, organizations, etc. the ability to choose preferred date formats. Both of the Rails standard approaches using Date.DATE\_FORMATS or localization fall short at making that easy; especially when parsing user form posted date strings. You end up writing a lot helpers around date fields, and code to normalize posted date values. 
  
-This is where date\_parity helps. It is implemented by setting a `Date.format` string, similar to a per user `Time.zone` in Rails. This can be set per request (i.e. per user) in a controller's before\_filter or around\_filter.
+This is where date\_parity helps. It is implemented by setting a `Date.format` string, similar to a per user `Time.zone` in Rails. This can be set per request (i.e. per user) in a controller's before\_action or around\_action.
 
 For example:
 ```ruby
@@ -51,6 +51,9 @@ date.to_s
 
 ## Installation
 
+Date Parity >= 0.1.0 works with Rails 4.0 onwards.
+Date Parity 0.0.3 works with Rails 3.
+
 Add this line to your application's Gemfile:
 
     gem 'date_parity'
@@ -65,7 +68,7 @@ Or install it yourself as:
 
 ## Usage
 
-In a Rails controller before\_filter:
+In a Rails controller before\_action:
 ```Date.format = '%m/%d/%Y'```
 
 Generally, you will want to set that string based on user preference, as in:
@@ -77,9 +80,9 @@ Then in any view assuming @model\_started\_on is a date field, and Date.format w
 #=> '12/31/2012' 
 ```
 
-And then you get parity when a form with this field is posted. Rails will attempt to convert the posted string value of "12/31/2012" using Date.\_parse, which DateParity overrides and respects your Date.format.  
+And then you get parity when a form with this field is posted. Rails will attempt to convert the posted string value of "12/31/2012" using Date.\parse, which DateParity overrides and respects your Date.format.  
 
-Without the date\_parity gem, @model.start\_on would have ended up nil because "12/31/2012" is an invalid argument for ruby Date.\_parse. However, when date\_parity is included, Date will use the format string set on Date.format to correctly parse "12/31/2012", as December 31, 2012, when Date.format = "%m/%d/%Y". 
+Without the date\_parity gem, @model.start\_on would have ended up nil because "12/31/2012" is an invalid argument for ruby Date.\parse. However, when date\_parity is included, Date will use the format string set on Date.format to correctly parse "12/31/2012", as December 31, 2012, when Date.format = "%m/%d/%Y". 
 
 Note: Rails text\_field form helper uses ```@model.attribute_before_type_cast``` by default.  When using date\_parity on plain text fields, you will probably want to set your value to explicitly use @model.attribute if it exists. Otherwise, you won't see the formatted date field: For example:
 ```ruby 

data/date_parity.gemspec

@@ -11,7 +11,7 @@ Gem::Specification.new do |gem|
   gem.summary       = 'Rails Date formatting and parsing with full parity between date.to_s.and string.to_date per request.'
   gem.homepage      = ""
 
-  gem.add_dependency 'activesupport', '>= 3.2'
+  gem.add_dependency 'activesupport', '>= 4.0.0'
 
   gem.add_development_dependency 'rake'
   gem.add_development_dependency 'minitest'

data/lib/date_parity/core_ext/date.rb

@@ -7,16 +7,16 @@ class Date
       Thread.current[:date_format] = format
     end
 
-    def _parse_with_date_parity_format(string, comp=false)
-      return _parse_without_date_parity_format(string, comp) if string.blank? or Date.format.blank?
+    def parse_with_date_parity_format(string, comp=false)
+      return parse_without_date_parity_format(string, comp) if string.blank? or Date.format.blank?
       # normalize date by first respecting custom date_parity Date.format, 
       # then formatting back to iso/db string for normal _parse call.
-      _parse_without_date_parity_format(Date.strptime(string, Date.format).to_s(:db), comp)
-    rescue
-      _parse_without_date_parity_format(string, comp)
+      parse_without_date_parity_format(Date.strptime(string, Date.format).to_s(:db), comp)
+    #rescue
+      #parse_without_date_parity_format(string, comp)
     end
 
-    alias_method_chain :_parse, :date_parity_format
+    alias_method_chain :parse, :date_parity_format
   end
 
 end

data/lib/date_parity/version.rb

@@ -1,3 +1,3 @@
 module DateParity
-  VERSION = "0.0.3"
+  VERSION = "0.1.0"
 end

data/test/date_parity_test.rb

@@ -1,10 +1,15 @@
 require 'date_parity/test_helper'
+require 'debugger'
 
 class DateParityTest < MiniTest::Unit::TestCase
 
+  def setup
+    # Reset Date.format from previous test
+    Date.format = nil
+  end
+
   def test_date_to_string_respects_format
     date = Date.parse("2012-08-12")
-
     Date.format = "%m/%d/%Y"
     assert_equal "08/12/2012", date.to_s
 
@@ -29,44 +34,56 @@ class DateParityTest < MiniTest::Unit::TestCase
     date_hash = { :year => 2012, :mon => 8, :mday => 12 }
 
     Date.format = "%m/%d/%Y"
-    assert_equal date_hash,  Date._parse("08/12/2012")
+    assert_equal date_hash[:mday],  Date.parse("08/12/2012").mday
+    assert_equal date_hash[:mon],  Date.parse("08/12/2012").mon
+    assert_equal date_hash[:year],  Date.parse("08/12/2012").year
 
     Date.format = "%d/%m/%Y"
-    assert_equal date_hash,  Date._parse("12/08/2012")
+    assert_equal date_hash[:mday],  Date.parse("12/08/2012").mday
+    assert_equal date_hash[:mon],  Date.parse("12/08/2012").mon
+    assert_equal date_hash[:year],  Date.parse("12/08/2012").year
 
     Date.format = '%Y-%m-%d'
-    assert_equal date_hash,  Date._parse("2012-08-12")
+    assert_equal date_hash[:mday],  Date.parse("2012-08-12").mday
+    assert_equal date_hash[:mon],  Date.parse("2012-08-12").mon
+    assert_equal date_hash[:year],  Date.parse("2012-08-12").year
 
     Date.format = '%d.%m.%Y'
-    assert_equal date_hash,  Date._parse("12.08.2012")
+    assert_equal date_hash[:mday],  Date.parse("12.08.2012").mday
+    assert_equal date_hash[:mon],  Date.parse("12.08.2012").mon
+    assert_equal date_hash[:year],  Date.parse("12.08.2012").year
 
     Date.format = '%Y.%m.%d'
-    assert_equal date_hash,  Date._parse("2012.08.12")
+    assert_equal date_hash[:mday],  Date.parse("2012.08.12").mday
+    assert_equal date_hash[:mon],  Date.parse("2012.08.12").mon
+    assert_equal date_hash[:year],  Date.parse("2012.08.12").year
 
     Date.format = '%Y/%m/%d'
-    assert_equal date_hash,  Date._parse("2012/08/12")
+    assert_equal date_hash[:mday],  Date.parse("2012/08/12").mday
+    assert_equal date_hash[:mon],  Date.parse("2012/08/12").mon
+    assert_equal date_hash[:year],  Date.parse("2012/08/12").year
   end
 
   def test_string_to_date_respects_format
     # This works because Rails ActiveSupport provides 
     # string.to_date, which uses Date._parse
     Date.format = "%m/%d/%Y"
-    assert_equal Date.parse("2012-08-12"), "08/12/2012".to_date
+    assert_equal Date.parse_without_date_parity_format("2012-08-12"), "08/12/2012".to_date
 
     Date.format = "%d/%m/%Y"
-    assert_equal Date.parse("2012-08-12"), "12/08/2012".to_date
+    assert_equal Date.parse_without_date_parity_format("2012-08-12"), "12/08/2012".to_date
 
     Date.format = '%Y-%m-%d'
-    assert_equal Date.parse("2012-08-12"), "2012-08-12".to_date
+    assert_equal Date.parse_without_date_parity_format("2012-08-12"), "2012-08-12".to_date
 
     Date.format = '%d.%m.%Y'
-    assert_equal Date.parse("2012-08-12"), "12.08.2012".to_date
+    assert_equal Date.parse_without_date_parity_format("2012-08-12"), "12.08.2012".to_date
 
     Date.format = '%Y.%m.%d'
-    assert_equal Date.parse("2012-08-12"), "2012.08.12".to_date
+    assert_equal Date.parse_without_date_parity_format("2012-08-12"), "2012.08.12".to_date
 
     Date.format = '%Y/%m/%d'
-    assert_equal Date.parse("2012-08-12"), "2012/08/12".to_date
+    assert_equal Date.parse_without_date_parity_format("2012-08-12"), "2012/08/12".to_date
   end
 
   def test_invalid_date_still_raises_argument_error
@@ -80,7 +97,7 @@ class DateParityTest < MiniTest::Unit::TestCase
 
   def full_date_parity
     Date.format = "%m/%d/%Y"
-    date = Date.parse("2012-12-31")
+    date = Date.parse_without_date_parity_format("2012-12-31")
     assert date, date.to_s.to_date
 
     assert "12/31/2012", "12/31/2012".to_date.to_s

metadata

@@ -1,49 +1,64 @@
 --- !ruby/object:Gem::Specification
 name: date_parity
 version: !ruby/object:Gem::Version
-  version: 0.0.3
   prerelease: 
+  version: 0.1.0
 platform: ruby
 authors:
 - Scott Stewart
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-08-14 00:00:00.000000000 Z
+date: 2013-06-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: activesupport
-  requirement: &70323438102960 !ruby/object:Gem::Requirement
-    none: false
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: 4.0.0
+    none: false
+  name: activesupport
   type: :runtime
   prerelease: false
-  version_requirements: *70323438102960
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: &70323438102540 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 4.0.0
     none: false
+- !ruby/object:Gem::Dependency
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+    none: false
+  name: rake
   type: :development
   prerelease: false
-  version_requirements: *70323438102540
-- !ruby/object:Gem::Dependency
-  name: minitest
-  requirement: &70323438102080 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
     none: false
+- !ruby/object:Gem::Dependency
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+    none: false
+  name: minitest
   type: :development
   prerelease: false
-  version_requirements: *70323438102080
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+    none: false
 description: Rails Date formatting and parsing with full parity between date.to_s.and
   string.to_date per request.
 email: scottpstewart@gamil.com
@@ -69,26 +84,20 @@ rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -101513963914939075
-required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
+required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -101513963914939075
+  none: false
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.11
+rubygems_version: 1.8.23
 signing_key: 
 specification_version: 3
 summary: Rails Date formatting and parsing with full parity between date.to_s.and