date_book 0.0.6 → 0.1.0

data/lib/generators/date_book/install/templates/app/models/calendar.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+
+# Calendar model, used by DateBook to store groups of events
 class Calendar < ApplicationRecord
   acts_as_calendar
-end
+end

data/lib/generators/date_book/install/templates/app/models/event.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+
+# Event model, used by DateBook to store events (recurring and not)
 class Event < ApplicationRecord
   acts_as_event
-end
+end

data/lib/generators/date_book/install/templates/app/models/event_occurrence.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+
+# EventOccurrence model, used by DateBook to store times events occur
 class EventOccurrence < ApplicationRecord
   acts_as_event_occurrence
-end
+end

data/lib/generators/date_book/install/templates/app/models/schedule.rb

@@ -1,3 +1,6 @@
+# frozen_string_literal: true
+
+# Schedule model, used by DateBook to store event recurrence rules
 class Schedule < Schedulable::Model::Schedule
   acts_as_schedule
-end
+end

data/spec/abilities/event_spec.rb

@@ -19,7 +19,7 @@ describe 'Abilities on Events', folder: :abilities do
     it { should_not be_able_to(:create, Event) }
   end
   context 'when logged in as regular user' do
-    let(:my_event) { science_fiction_club_event }
+    let(:my_event) { science_fiction_club }
     let(:other_event) { monday_event }
     let(:user) { regular_user }
     subject(:ability) { Ability.new(user) }

data/spec/controllers/date_book/calendars_controller_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 module DateBook
@@ -7,16 +9,22 @@ module DateBook
     include_context 'loaded site'
     include ControllerMacros
 
-    # This should return the minimal set of attributes required to create a valid
-    # Calendar. As you add validations to Calendar, be sure to
-    # adjust the attributes here as well.
-    let(:valid_attributes) {
-      { name: 'Test Calendar', schedule_attributes: { date: 1.hour.ago.to_date, time: 1.hour.ago} }
-    }
+    # This should return the minimal set of attributes required to create a
+    # valid Calendar. As you add validations to Calendar, be sure to adjust the
+    # attributes here as well.
+    let(:valid_attributes) do
+      {
+        name: 'Test Calendar',
+        schedule_attributes: {
+          date: 1.hour.ago.to_date,
+          time: 1.hour.ago
+        }
+      }
+    end
 
-    let(:invalid_attributes) {
+    let(:invalid_attributes) do
       { name: nil, schedule_attributes: nil }
-    }
+    end
 
     describe 'GET #index' do
       before do
@@ -92,7 +100,6 @@ module DateBook
       end
     end
 
-
     describe 'POST #create' do
       describe 'when not logged in' do
         before do
@@ -121,7 +128,7 @@ module DateBook
             login_user regular_user
           end
           it 'results in a new calendar' do
-            expect { post(:create, params: {  calendar: valid_attributes }) }
+            expect { post(:create, params: { calendar: valid_attributes }) }
               .to change { Calendar.count(:id) }.by(1)
           end
         end
@@ -142,8 +149,8 @@ module DateBook
             login_user regular_user
           end
           it 'does not result in a new calendar' do
-            expect { post(:create, params: {  calendar: invalid_attributes }) }
-              .to_not change { Calendar.count(:id) }
+            expect { post(:create, params: { calendar: invalid_attributes }) }
+              .to_not(change { Calendar.count(:id) })
           end
         end
       end
@@ -153,7 +160,13 @@ module DateBook
       describe 'when not logged in' do
         before do
           # Here's where we are *not* logging in
-          put :update, params: { id: 'regular-calendar', calendar: valid_attributes }
+          put(
+            :update,
+            params: {
+              id: 'regular-calendar',
+              calendar: valid_attributes
+            }
+          )
         end
         it_should_behave_like 'a redirect to the home page'
       end
@@ -161,7 +174,13 @@ module DateBook
         describe 'as someone other than the owner' do
           before do
             login_user other_user
-            put :update, params: { id: 'regular-calendar', calendar: valid_attributes }
+            put(
+              :update,
+              params: {
+                id: 'regular-calendar',
+                calendar: valid_attributes
+              }
+            )
           end
           it_should_behave_like 'a 403 Forbidden error'
         end
@@ -169,10 +188,19 @@ module DateBook
           describe 'with valid params' do
             before do
               login_user regular_user
-              put :update, params: { id: 'regular-calendar', calendar: valid_attributes }
+              put(
+                :update,
+                params: {
+                  id: 'regular-calendar',
+                  calendar: valid_attributes
+                }
+              )
             end
             # Note that slug does not change
-            it_should_behave_like 'a redirect to', '/date_book/calendars/regular-calendar'
+            it_should_behave_like(
+              'a redirect to',
+              '/date_book/calendars/regular-calendar'
+            )
 
             describe 'updates @calendar' do
               subject { regular_calendar.reload }
@@ -189,9 +217,10 @@ module DateBook
               login_user regular_user
               put(
                 :update, params: {
-                id: 'regular-calendar',
-                calendar: invalid_attributes
-              })
+                  id: 'regular-calendar',
+                  calendar: invalid_attributes
+                }
+              )
             end
             it_should_behave_like 'a successful page', which_renders: 'edit'
 
@@ -254,6 +283,5 @@ module DateBook
         end
       end
     end
-
   end
 end

data/spec/controllers/date_book/events_controller_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails_helper'
 
 module DateBook
@@ -7,16 +9,19 @@ module DateBook
     include_context 'loaded site'
     include ControllerMacros
 
-    # This should return the minimal set of attributes required to create a valid
-    # Event. As you add validations to Event, be sure to
-    # adjust the attributes here as well.
-    let(:valid_attributes) {
-      { name: 'Test Event', schedule_attributes: { date: 1.hour.ago.to_date, time: 1.hour.ago} }
-    }
+    # This should return the minimal set of attributes required to create a
+    # valid Event. As you add validations to Event, be sure to adjust the
+    # attributes here as well.
+    let(:valid_attributes) do
+      {
+        name: 'Test Event',
+        schedule_attributes: { date: 1.hour.ago.to_date, time: 1.hour.ago }
+      }
+    end
 
-    let(:invalid_attributes) {
+    let(:invalid_attributes) do
       { name: nil, schedule_attributes: nil }
-    }
+    end
 
     describe 'GET #index' do
       describe 'without a query' do
@@ -33,7 +38,10 @@ module DateBook
       end
       describe 'with a query' do
         before do
-          get :index, params: { start: Time.zone.now, calendar_id: 'admin-calendar' }
+          get(
+            :index,
+            params: { start: Time.zone.now, calendar_id: 'admin-calendar' }
+          )
         end
         it_should_behave_like 'a successful page', which_renders: 'index'
 
@@ -47,14 +55,20 @@ module DateBook
 
     describe 'GET #show' do
       before do
-        get :show, params: { id: 'the-work-week', calendar_id: 'admin-calendar' }
+        get(
+          :show,
+          params: { id: 'the-work-week', calendar_id: 'admin-calendar' }
+        )
       end
       it_should_behave_like 'a successful page', which_renders: 'show'
     end
 
     describe 'GET #popover' do
       before do
-        get :popover, params: { id: 'the-work-week', calendar_id: 'admin-calendar' }
+        get(
+          :popover,
+          params: { id: 'the-work-week', calendar_id: 'admin-calendar' }
+        )
       end
       it_should_behave_like 'a successful page', which_renders: 'popover'
     end
@@ -63,14 +77,14 @@ module DateBook
       describe 'when not logged in' do
         before do
           # Here's where we are *not* logging in
-          get :new, params: { calendar_id: 'regular-calendar'}
+          get :new, params: { calendar_id: 'regular-calendar' }
         end
         it_should_behave_like 'a redirect to the home page'
       end
       describe 'when logged in' do
         before do
           login_user regular_user
-          get :new, params: { calendar_id: 'regular-calendar'}
+          get :new, params: { calendar_id: 'regular-calendar' }
         end
         it_should_behave_like 'a successful page', which_renders: 'new'
 
@@ -86,7 +100,10 @@ module DateBook
       describe 'when not logged in' do
         before do
           # Here's where we are *not* logging in
-          get :edit, params: { id: 'the-work-week', calendar_id: 'admin-calendar' }
+          get(
+            :edit,
+            params: { id: 'the-work-week', calendar_id: 'admin-calendar' }
+          )
         end
         it_should_behave_like 'a redirect to the home page'
       end
@@ -94,31 +111,42 @@ module DateBook
         describe 'as someone other than the owner' do
           before do
             login_user regular_user
-            get :edit, params: { id: 'the-work-week', calendar_id: 'admin-calendar' }
+            get(
+              :edit,
+              params: { id: 'the-work-week', calendar_id: 'admin-calendar' }
+            )
           end
           it_should_behave_like 'a 403 Forbidden error'
         end
         describe 'as the owner' do
           before do
             login_user regular_user
-            get :edit, params: { id: 'science-fiction-club', calendar_id: 'regular-calendar' }
+            get(
+              :edit,
+              params: {
+                id: 'science-fiction-club',
+                calendar_id: 'regular-calendar'
+              }
+            )
           end
           it_should_behave_like 'a successful page', which_renders: 'edit'
 
           describe 'loads requested event into @event' do
             subject { assigns(:event) }
-            it { should eq science_fiction_club_event }
+            it { should eq science_fiction_club }
           end
         end
       end
     end
 
-
     describe 'POST #create' do
       describe 'when not logged in' do
         before do
           # Here's where we are *not* logging in
-          post :create, params: { event: valid_attributes, calendar_id: 'regular-calendar' }
+          post(
+            :create,
+            params: { event: valid_attributes, calendar_id: 'regular-calendar' }
+          )
         end
         it_should_behave_like 'a redirect to the home page'
       end
@@ -126,7 +154,13 @@ module DateBook
         describe 'with valid params' do
           before do
             login_user regular_user
-            post :create, params: { event: valid_attributes, calendar_id: 'regular-calendar' }
+            post(
+              :create,
+              params: {
+                event: valid_attributes,
+                calendar_id: 'regular-calendar'
+              }
+            )
           end
           it_should_behave_like(
             'a redirect to',
@@ -142,14 +176,27 @@ module DateBook
             login_user regular_user
           end
           it 'results in a new event' do
-            expect { post(:create, params: { event: valid_attributes, calendar_id: 'regular-calendar' }) }
-              .to change { Event.count(:id) }.by(1)
+            expect do
+              post(
+                :create,
+                params: {
+                  event: valid_attributes,
+                  calendar_id: 'regular-calendar'
+                }
+              )
+            end.to change { Event.count(:id) }.by(1)
           end
         end
         describe 'with invalid params' do
           before do
             login_user regular_user
-            post :create, params: { event: invalid_attributes, calendar_id: 'regular-calendar' }
+            post(
+              :create,
+              params: {
+                event: invalid_attributes,
+                calendar_id: 'regular-calendar'
+              }
+            )
           end
           it_should_behave_like 'a successful page', which_renders: 'new'
 
@@ -163,8 +210,15 @@ module DateBook
             login_user regular_user
           end
           it 'does not result in a new event' do
-            expect { post(:create, params: {  event: invalid_attributes, calendar_id: 'regular-calendar' }) }
-              .to_not change { Event.count(:id) }
+            expect do
+              post(
+                :create,
+                params: {
+                  event: invalid_attributes,
+                  calendar_id: 'regular-calendar'
+                }
+              )
+            end.to_not(change { Event.count(:id) })
           end
         end
       end
@@ -174,7 +228,14 @@ module DateBook
       describe 'when not logged in' do
         before do
           # Here's where we are *not* logging in
-          put :update, params: { id: 'science-fiction-club', event: valid_attributes, calendar_id: 'regular-calendar' }
+          put(
+            :update,
+            params: {
+              id: 'science-fiction-club',
+              event: valid_attributes,
+              calendar_id: 'regular-calendar'
+            }
+          )
         end
         it_should_behave_like 'a redirect to the home page'
       end
@@ -182,7 +243,14 @@ module DateBook
         describe 'as someone other than the owner' do
           before do
             login_user other_user
-            put :update, params: { id: 'science-fiction-club', event: valid_attributes, calendar_id: 'regular-calendar' }
+            put(
+              :update,
+              params: {
+                id: 'science-fiction-club',
+                event: valid_attributes,
+                calendar_id: 'regular-calendar'
+              }
+            )
           end
           it_should_behave_like 'a 403 Forbidden error'
         end
@@ -190,13 +258,24 @@ module DateBook
           describe 'with valid params' do
             before do
               login_user regular_user
-              put :update, params: { id: 'science-fiction-club', event: valid_attributes, calendar_id: 'regular-calendar' }
+              put(
+                :update,
+                params: {
+                  id: 'science-fiction-club',
+                  event: valid_attributes,
+                  calendar_id: 'regular-calendar'
+                }
+              )
             end
             # Note that slug does not change
-            it_should_behave_like 'a redirect to', '/date_book/calendars/regular-calendar/events/science-fiction-club'
+            it_should_behave_like(
+              'a redirect to',
+              '/date_book/calendars/regular-calendar/events/'\
+                'science-fiction-club'
+            )
 
             describe 'updates @event' do
-              subject { science_fiction_club_event.reload }
+              subject { science_fiction_club.reload }
               its(:name) { should eq 'Test Event' }
             end
 
@@ -221,11 +300,11 @@ module DateBook
 
             describe 'loads the given event into @event' do
               subject { assigns(:event) }
-              it { should eq science_fiction_club_event }
+              it { should eq science_fiction_club }
             end
 
             describe 'does not update @event' do
-              subject { science_fiction_club_event.reload }
+              subject { science_fiction_club.reload }
               its(:name) { should eq 'Science Fiction Club' }
             end
 
@@ -242,7 +321,13 @@ module DateBook
       describe 'when not logged in' do
         before do
           # Here's where we are *not* logging in
-          delete :destroy, params: { id: 'science-fiction-club', calendar_id: 'regular-calendar' }
+          delete(
+            :destroy,
+            params: {
+              id: 'science-fiction-club',
+              calendar_id: 'regular-calendar'
+            }
+          )
         end
         it_should_behave_like 'a redirect to the home page'
       end
@@ -250,17 +335,32 @@ module DateBook
         describe 'as someone other than the owner' do
           before do
             login_user other_user
-            delete :destroy, params: { id: 'science-fiction-club', calendar_id: 'regular-calendar' }
+            delete(
+              :destroy,
+              params: {
+                id: 'science-fiction-club',
+                calendar_id: 'regular-calendar'
+              }
+            )
           end
           it_should_behave_like 'a 403 Forbidden error'
         end
         describe 'as the owner' do
           before do
             login_user regular_user
-            delete :destroy, params: { id: 'science-fiction-club', calendar_id: 'regular-calendar' }
+            delete(
+              :destroy,
+              params: {
+                id: 'science-fiction-club',
+                calendar_id: 'regular-calendar'
+              }
+            )
           end
           # Note that slug does not change
-          it_should_behave_like 'a redirect to', '/date_book/calendars/regular-calendar/events'
+          it_should_behave_like(
+            'a redirect to',
+            '/date_book/calendars/regular-calendar/events'
+          )
 
           describe "sets the flash with a notice of the event's removal" do
             subject { flash[:notice] }
@@ -272,12 +372,18 @@ module DateBook
             login_user regular_user
           end
           it 'results one less event' do
-            expect { delete(:destroy, params: { id: 'science-fiction-club', calendar_id: 'regular-calendar' }) }
-              .to change { Event.count(:id) }.by(-1)
+            expect do
+              delete(
+                :destroy,
+                params: {
+                  id: 'science-fiction-club',
+                  calendar_id: 'regular-calendar'
+                }
+              )
+            end.to change { Event.count(:id) }.by(-1)
           end
         end
       end
     end
-
   end
 end