datatrans 2.2.1 → 2.2.2

data/README.markdown

@@ -14,6 +14,8 @@ Set your datatrans credentials in your environment.
       config.environment = :production
     end
 
+If you don't want to use signed requests (disabled in datatrans web console), you must set `config.sign_key` to `false`.
+
 Possible values for the environment: `:production`, `:development`
 
 Web Authorization
@@ -30,36 +32,36 @@ You need to pass at least `amount`, `currency` and `refno` (order number).
       :uppCustomerEmail => 'customer@email.com'
       # feel free to add more upp infos here ...
     })
-    
+
 In your View your show the credit card form with a convenient helper:
 
     = form_tag Datatrans.web_authorize_url do
-    
+
       = text_field_tag :paymentmethod, 'ECA'
       = text_field_tag :cardno
       = text_field_tag :expm
       = text_field_tag :expy
       = text_field_tag :cvv
-    
+
       = hidden_field_tag :successUrl, <your_application_return_url>
       = hidden_field_tag :cancelUrl, <your_application_return_url>
       = hidden_field_tag :errorUrl, <your_application_return_url>
-    
+
       = datatrans_notification_request_hidden_fields(@transaction)
-    
+
       = submit_tag "send"
-      
+
 In this example we use just ECA (Mastercard) as paymentmethod. Feel free to
 provide an appropriate select field to offer more payment methods. Don't forget
 to add `successUrl`, `cancelUrl` and `errorUrl`. We recommend to set them all
 to the same value.
- 
+
 After you submit the request to Datatrans they redirect back to your application.
 Now you can process the transaction like this:
 
     begin
       transaction = Datatrans::Web::Transaction.new(params)
-      
+
       if transaction.authorize
         # transaction was successful, access the following attributes
         # transaction.transaction_id
@@ -67,16 +69,16 @@ Now you can process the transaction like this:
         # transaction.masked_cc
         # transaction.authorization_code
         # ...
-        
+
       else
         # transaction was not successful, accces the error details
         # transaction.error_code, transaction.error_message, transaction.error_detail
-        
-      end 
+
+      end
     rescue Datatrans::InvalidSignatureError => exception
       # the signature was wrong, the request may have been compromised...
     end
-  
+
 XML Transactions
 ================
 
@@ -94,7 +96,7 @@ Authorize
       :expm => 12,
       :expy => 15
     )
-    
+
     if transaction.authorize
       # ok, the transaction is authorized...
       # access same values as in the web authorization (e.g. transaction.transaction_id)
@@ -114,13 +116,13 @@ To capture an authorized transaction you use the following code:
       :currency => 'CHF',
       :transaction_id => 19834324987349723948729834
     )
-    
+
     if transaction.capture
       # ok, the money is yours...
     else
       # transaction.error_code, transaction.error_message, transaction.error_detail
     end
-    
+
 
 Void
 ----
@@ -133,7 +135,7 @@ To make an authorized transaction invalid use void.
       :currency => 'CHF',
       :transaction_id => 19834324987349723948729834
     )
-    
+
     if transaction.void
       # ok, the transaction is not longer valid...
     else
@@ -141,6 +143,14 @@ To make an authorized transaction invalid use void.
     end
 
 
+CHANGELOG
+=========
+
+2.2.2
+-------
+* added ability to skip signing by setting config.sign_key = false
+
+
 Todo
 ====
 
@@ -163,7 +173,7 @@ Contribute
 * Commit, do not mess with rakefile, version, or history.
   (if you want to have your own version, that is fine but bump version in a commit by itself we can ignore when we pull)
 * Send us a pull request. Bonus points for topic branches.
-  
+
 
 Credits
 =======

data/lib/datatrans/common.rb

@@ -2,6 +2,7 @@ require 'openssl'
 
 module Datatrans::Common
   def sign(*fields)
+    return nil unless Datatrans.sign_key
     key = Datatrans.sign_key.split(/([a-f0-9][a-f0-9])/).reject(&:empty?)
     key = key.pack("H*" * key.size)
     OpenSSL::HMAC.hexdigest(OpenSSL::Digest::MD5.new, key, fields.join)

data/lib/datatrans/version.rb

@@ -1,3 +1,3 @@
 module Datatrans
-  VERSION = "2.2.1"
+  VERSION = "2.2.2"
 end

data/lib/datatrans/web/transaction.rb

@@ -3,28 +3,28 @@ require 'active_support/core_ext/hash'
 module Datatrans::Web
   class Transaction
     include Datatrans::Common
-    
+
     attr_accessor :request
     attr_reader :response, :params
-    
+
     def initialize(params)
-      raise 'Please define Datatrans.sign_key!' unless Datatrans.sign_key.present?
+      raise 'Please define Datatrans.sign_key or set it to false!' unless Datatrans.sign_key == false || Datatrans.sign_key.present?
 
       params = params.to_hash
       params.symbolize_keys!
-      params.reverse_merge!({ :reqtype => 'NOA', :useAlias => 'Yes', :hiddenMode => 'Yes' })
+      params.reverse_merge!(:reqtype => 'NOA', :useAlias => 'yes', :hiddenMode => 'yes')
       @params = params
     end
-    
+
     def signature
       sign(Datatrans.merchant_id, params[:amount], params[:currency], params[:refno])
     end
-    
+
     def authorize
       @response = AuthorizeResponse.new(params)
       @response.successful?
     end
-    
+
     def method_missing(method, *args, &block)
       if response.respond_to? method.to_sym
         response.send(method)
@@ -33,7 +33,7 @@ module Datatrans::Web
       end
     end
   end
-  
+
   module ViewHelper
     def datatrans_notification_request_hidden_fields(transaction)
       fields = [
@@ -46,13 +46,13 @@ module Datatrans::Web
         hidden_field_tag(:sign, transaction.signature),
         hidden_field_tag(:refno, transaction.params[:refno]),
       ]
-      
+
       [:uppCustomerName, :uppCustomerEmail].each do |field_name|
         if transaction.params[field_name].present?
           fields << hidden_field_tag(field_name, transaction.params[field_name])
         end
       end
-      
+
       fields.join.html_safe
     end
   end

data/spec/web/authorize_spec.rb

@@ -5,59 +5,59 @@ require 'spec_helper'
 describe Datatrans::Web::Transaction do
   before do
     @successful_response = {
-      :status => "success", 
-      :returnCustomerCountry => "CHE", 
-      :sign => "95f3111123e628eab6469c636e0d3f06", 
-      :aliasCC => "70323122544311173", 
-      :maskedCC => "520000xxxxxx0007", 
-      :responseMessage => "Authorized", 
-      :useAlias => "Yes", 
-      :expm => "12", 
-      :responseCode => "01", 
-      :sign2 => "a9571428be4d9d37b88988656984bfbf", 
-      :testOnly => "yes", 
-      :currency => "CHF", 
-      :amount => "1000", 
-      :hiddenMode => "yes", 
-      :expy => "15", 
-      :merchantId => "1100000000", 
-      :authorizationCode => "521029462", 
-      :uppTransactionId => "110808173520119430", 
-      :refno => "1", 
-      :uppMsgType => "web", 
-      :uppCustomerName => "", 
-      :pmethod => "ECA", 
-      :reqtype => "NOA", 
-      :uppCustomerEmail => "customer@email.com", 
+      :status => "success",
+      :returnCustomerCountry => "CHE",
+      :sign => "95f3111123e628eab6469c636e0d3f06",
+      :aliasCC => "70323122544311173",
+      :maskedCC => "520000xxxxxx0007",
+      :responseMessage => "Authorized",
+      :useAlias => "yes",
+      :expm => "12",
+      :responseCode => "01",
+      :sign2 => "a9571428be4d9d37b88988656984bfbf",
+      :testOnly => "yes",
+      :currency => "CHF",
+      :amount => "1000",
+      :hiddenMode => "yes",
+      :expy => "15",
+      :merchantId => "1100000000",
+      :authorizationCode => "521029462",
+      :uppTransactionId => "110808173520119430",
+      :refno => "1",
+      :uppMsgType => "web",
+      :uppCustomerName => "",
+      :pmethod => "ECA",
+      :reqtype => "NOA",
+      :uppCustomerEmail => "customer@email.com",
       :acqAuthorizationCode => "173520"
     }
-    
+
     @failed_response = {
-      :status => "error", 
-      :returnCustomerCountry => "CHE", 
-      :sign => "95f3123246e628eab6469c636e0d3f06", 
-      :aliasCC => "70323122544311173", 
-      :maskedCC => "520000xxxxxx0007", 
-      :errorMessage => "declined", 
-      :useAlias => "Yes", 
-      :expm => "12", 
-      :errorCode => "1403", 
-      :testOnly => "yes", 
-      :currency => "CHF", 
-      :amount => "1000", 
-      :hiddenMode => "yes", 
-      :expy => "14", 
-      :merchantId => "1100000000", 
-      :errorDetail => "Declined", 
-      :uppTransactionId => "110808173951050102", 
-      :refno => "1", 
-      :uppMsgType => "web", 
-      :uppCustomerName => "", 
-      :pmethod => "ECA", 
-      :reqtype => "NOA", 
+      :status => "error",
+      :returnCustomerCountry => "CHE",
+      :sign => "95f3123246e628eab6469c636e0d3f06",
+      :aliasCC => "70323122544311173",
+      :maskedCC => "520000xxxxxx0007",
+      :errorMessage => "declined",
+      :useAlias => "yes",
+      :expm => "12",
+      :errorCode => "1403",
+      :testOnly => "yes",
+      :currency => "CHF",
+      :amount => "1000",
+      :hiddenMode => "yes",
+      :expy => "14",
+      :merchantId => "1100000000",
+      :errorDetail => "Declined",
+      :uppTransactionId => "110808173951050102",
+      :refno => "1",
+      :uppMsgType => "web",
+      :uppCustomerName => "",
+      :pmethod => "ECA",
+      :reqtype => "NOA",
       :uppCustomerEmail => "customer@email.com"
     }
-    
+
     @valid_params = {
       :refno => 'ABCDEF',
       :amount => 1000,
@@ -66,23 +66,23 @@ describe Datatrans::Web::Transaction do
       # also params from view helper needed
     }
   end
-  
+
   context "rails form helper" do
     before do
       @transaction = Datatrans::Web::Transaction.new(@valid_params)
       @view = ActionView::Base.new
     end
-    
+
     it "should generate valid form field string" do
-      @view.datatrans_notification_request_hidden_fields(@transaction).should == "<input id=\"merchantId\" name=\"merchantId\" type=\"hidden\" value=\"1100000000\" /><input id=\"hiddenMode\" name=\"hiddenMode\" type=\"hidden\" value=\"Yes\" /><input id=\"reqtype\" name=\"reqtype\" type=\"hidden\" value=\"NOA\" /><input id=\"amount\" name=\"amount\" type=\"hidden\" value=\"1000\" /><input id=\"currency\" name=\"currency\" type=\"hidden\" value=\"CHF\" /><input id=\"useAlias\" name=\"useAlias\" type=\"hidden\" value=\"Yes\" /><input id=\"sign\" name=\"sign\" type=\"hidden\" value=\"0402fb3fba8c6fcb40df9b7756e7e637\" /><input id=\"refno\" name=\"refno\" type=\"hidden\" value=\"ABCDEF\" /><input id=\"uppCustomerEmail\" name=\"uppCustomerEmail\" type=\"hidden\" value=\"customer@email.com\" />"
+      @view.datatrans_notification_request_hidden_fields(@transaction).should == "<input id=\"merchantId\" name=\"merchantId\" type=\"hidden\" value=\"1100000000\" /><input id=\"hiddenMode\" name=\"hiddenMode\" type=\"hidden\" value=\"yes\" /><input id=\"reqtype\" name=\"reqtype\" type=\"hidden\" value=\"NOA\" /><input id=\"amount\" name=\"amount\" type=\"hidden\" value=\"1000\" /><input id=\"currency\" name=\"currency\" type=\"hidden\" value=\"CHF\" /><input id=\"useAlias\" name=\"useAlias\" type=\"hidden\" value=\"yes\" /><input id=\"sign\" name=\"sign\" type=\"hidden\" value=\"0402fb3fba8c6fcb40df9b7756e7e637\" /><input id=\"refno\" name=\"refno\" type=\"hidden\" value=\"ABCDEF\" /><input id=\"uppCustomerEmail\" name=\"uppCustomerEmail\" type=\"hidden\" value=\"customer@email.com\" />"
     end
   end
-  
+
   context "successful response" do
     before do
       Datatrans::Web::Transaction::AuthorizeResponse.any_instance.stub(:params).and_return(@successful_response)
     end
-    
+
     context "process" do
       it "handles a valid datatrans authorize response" do
         @transaction = Datatrans::Web::Transaction.new(@valid_params)
@@ -90,7 +90,7 @@ describe Datatrans::Web::Transaction do
       end
     end
   end
-  
+
   context "compromised response" do
     before do
       fake_response = @successful_response
@@ -98,25 +98,25 @@ describe Datatrans::Web::Transaction do
       Datatrans::Web::Transaction::AuthorizeResponse.any_instance.stub(:params).and_return(fake_response)
       @transaction = Datatrans::Web::Transaction.new(@valid_params)
     end
-    
+
     it "raises an exception if sign2 is invalid" do
       expect {
         @transaction.authorize
       }.to raise_error(Datatrans::InvalidSignatureError)
     end
   end
-  
+
   context "failed response" do
     before do
       Datatrans::Web::Transaction::AuthorizeResponse.any_instance.stub(:params).and_return(@failed_response)
       @transaction = Datatrans::Web::Transaction.new(@valid_params)
     end
-  
+
     context "process" do
       it "handles a failed datatrans authorize response" do
         @transaction.authorize.should be_false
       end
-  
+
       it "returns error details" do
         @transaction.authorize
         @transaction.error_code.length.should > 0

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: datatrans
 version: !ruby/object:Gem::Version
-  version: 2.2.1
+  version: 2.2.2
   prerelease: 
 platform: ruby
 authors:
@@ -10,11 +10,12 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-08-26 00:00:00.000000000Z
+date: 2011-10-11 00:00:00.000000000 +02:00
+default_executable: 
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
-  requirement: &2152354120 !ruby/object:Gem::Requirement
+  requirement: &70124632684580 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -22,10 +23,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2152354120
+  version_requirements: *70124632684580
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &2152353620 !ruby/object:Gem::Requirement
+  requirement: &70124632684020 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -33,10 +34,10 @@ dependencies:
         version: 3.0.0
   type: :runtime
   prerelease: false
-  version_requirements: *2152353620
+  version_requirements: *70124632684020
 - !ruby/object:Gem::Dependency
   name: i18n
-  requirement: &2152353200 !ruby/object:Gem::Requirement
+  requirement: &70124632683320 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -44,10 +45,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2152353200
+  version_requirements: *70124632683320
 - !ruby/object:Gem::Dependency
   name: builder
-  requirement: &2152352740 !ruby/object:Gem::Requirement
+  requirement: &70124632682440 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -55,10 +56,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2152352740
+  version_requirements: *70124632682440
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &2152352320 !ruby/object:Gem::Requirement
+  requirement: &70124632681860 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -66,10 +67,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152352320
+  version_requirements: *70124632681860
 - !ruby/object:Gem::Dependency
   name: actionpack
-  requirement: &2152351820 !ruby/object:Gem::Requirement
+  requirement: &70124632681360 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -77,7 +78,7 @@ dependencies:
         version: 3.0.0
   type: :development
   prerelease: false
-  version_requirements: *2152351820
+  version_requirements: *70124632681360
 description: Datatrans Integration for Ruby on Rails
 email:
 - tobias.miesel@simplificator.com
@@ -109,6 +110,7 @@ files:
 - spec/xml/authorize_spec.rb
 - spec/xml/capture_spec.rb
 - spec/xml/void_spec.rb
+has_rdoc: true
 homepage: ''
 licenses: []
 post_install_message: 
@@ -129,7 +131,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: datatrans
-rubygems_version: 1.7.2
+rubygems_version: 1.6.2
 signing_key: 
 specification_version: 3
 summary: Datatrans Integration for Ruby on Rails