datasketches 0.2.0 → 0.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e62d3e98b646fb074ae5bccf506a3ec9659bfde99d98721e2e3d7377ea68a3ce
-  data.tar.gz: ef7a1d11de9801e0d40d0071a46f695555a026a54c8e31d23624c01045faafe6
+  metadata.gz: 897dbc30f97ce17f0415630b6347a0092dac05196b0ef61e80939410d65cdf17
+  data.tar.gz: 61302f9cadde8a8badc97b455eb5c32d913c3b1fea8ed571e2da93a29e65afa9
 SHA512:
-  metadata.gz: 8808ddf87374a66de48f0434f22b8813cd0170d40ce1dc518a480235f6bd359322fb1e354e224355911f5569a32dce99457515dfd6a8a591223ea6a1e834dfb8
-  data.tar.gz: 5fdeee4c5b69a495d90242e2a3e6157fbca0931bebeb77ba025840c15f14e571c9a672b527082324b2e72e17ae6e0d301b7978cf21be6ae77766cd1b4f18c3d0
+  metadata.gz: 4d541ba7f96a86f3f8de44f069f6e39d51ba6f28fa5d8c8d1d99a8434a95c5fe1a26470e6b062f348808fe5c0a444134d0dc96385437b4cb946c4a92044a2a5c
+  data.tar.gz: bc1bdacb7cbe69f9bb1382fd2ac7019bec04baf444dc963d63a594e989fd201d9eb9aadd0e463ac4efef8f7ba53915a594d8fb00f74ae295674b9024269a0406

data/CHANGELOG.md

@@ -1,3 +1,19 @@
+## 0.2.4 (2021-12-28)
+
+- Updated DataSketches to 3.3.0
+
+## 0.2.3 (2021-09-29)
+
+- Updated DataSketches to 3.2.0
+
+## 0.2.2 (2021-07-17)
+
+- Updated DataSketches to 3.1.0
+
+## 0.2.1 (2021-05-23)
+
+- Improved performance
+
 ## 0.2.0 (2021-05-17)
 
 - Updated DataSketches to 3.0.0

data/LICENSE

@@ -284,11 +284,48 @@ APPENDIX B: Additional licenses relevant to this product.
     ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
     DEALINGS IN THE SOFTWARE.
     -------------------------------------------------------------
-    Code Locations
+    Code Locations:
       * https://github.com/apache/datasketches-cpp/blob/master/common/test/catch.hpp
     that is adapted from the above.
 
 
+    =============================================================
+    BSD License
+    =============================================================
+    Original source code:
+       https://github.com/pybind/pybind11/blob/master/LICENSE
+
+    Copyright (c) 2016 Wenzel Jakob <wenzel.jakob@epfl.ch>, All rights reserved.
+
+    Redistribution and use in source and binary forms, with or without
+    modification, are permitted provided that the following conditions are met:
+
+    1. Redistributions of source code must retain the above copyright notice, this
+       list of conditions and the following disclaimer.
+
+    2. Redistributions in binary form must reproduce the above copyright notice,
+       this list of conditions and the following disclaimer in the documentation
+       and/or other materials provided with the distribution.
+
+    3. Neither the name of the copyright holder nor the names of its contributors
+       may be used to endorse or promote products derived from this software
+       without specific prior written permission.
+
+    THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
+    ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+    WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+    DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+    FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+    DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+    SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+    CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+    OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+    OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+    -------------------------------------------------------------
+    Code Locations:
+    Found only in the convenience binaries distributed from PyPI, which rely
+    on pybind11 code during compilation.
+
 
     =============================================================
     Public Domain
@@ -297,7 +334,7 @@ APPENDIX B: Additional licenses relevant to this product.
        https://github.com/aappleby/smhasher/blob/master/src/MurmurHash3.cpp
        Placed in the Public Domain by Austin Appleby
 
-    Code Locations
+    Code Locations:
       common/include/MurmurHash3.h
     that is adapted from the above.
     -------------------------------------------------------------
@@ -305,6 +342,6 @@ APPENDIX B: Additional licenses relevant to this product.
       * https://graphics.stanford.edu/~seander/bithacks.html
       * Placed in the Public Domain by Sean Eron Anderson
 
-    Code Locations
+    Code Locations:
       * common/include/ceiling_power_of_2.hpp
     that is adapted from the above.

data/NOTICE

@@ -1,5 +1,5 @@
 Apache DataSketches-cpp
-Copyright 2020 The Apache Software Foundation
+Copyright 2020-2021 The Apache Software Foundation
 
 Copyright 2015-2018 Yahoo
 Copyright 2019 Verizon Media

data/README.md

@@ -1,8 +1,8 @@
-# DataSketches
+# DataSketches Ruby
 
 [DataSketches](https://datasketches.apache.org/) - sketch data structures - for Ruby
 
-[![Build Status](https://github.com/ankane/datasketches/workflows/build/badge.svg?branch=master)](https://github.com/ankane/datasketches/actions)
+[![Build Status](https://github.com/ankane/datasketches-ruby/workflows/build/badge.svg?branch=master)](https://github.com/ankane/datasketches-ruby/actions)
 
 ## Installation
 
@@ -292,22 +292,22 @@ This library is modeled after the DataSketches [Python API](https://github.com/a
 
 ## History
 
-View the [changelog](https://github.com/ankane/datasketches/blob/master/CHANGELOG.md)
+View the [changelog](https://github.com/ankane/datasketches-ruby/blob/master/CHANGELOG.md)
 
 ## Contributing
 
 Everyone is encouraged to help improve this project. Here are a few ways you can help:
 
-- [Report bugs](https://github.com/ankane/datasketches/issues)
-- Fix bugs and [submit pull requests](https://github.com/ankane/datasketches/pulls)
+- [Report bugs](https://github.com/ankane/datasketches-ruby/issues)
+- Fix bugs and [submit pull requests](https://github.com/ankane/datasketches-ruby/pulls)
 - Write, clarify, or fix documentation
 - Suggest or add new features
 
 To get started with development:
 
 ```sh
-git clone --recursive https://github.com/ankane/datasketches.git
-cd datasketches
+git clone --recursive https://github.com/ankane/datasketches-ruby.git
+cd datasketches-ruby
 bundle install
 bundle exec rake compile
 bundle exec rake test

data/ext/datasketches/extconf.rb

@@ -1,6 +1,6 @@
 require "mkmf-rice"
 
-$CXXFLAGS += " -std=c++17"
+$CXXFLAGS += " -std=c++17 $(optflags)"
 
 ext = File.expand_path(".", __dir__)
 datasketches = File.expand_path("../../vendor/datasketches-cpp", __dir__)

data/ext/datasketches/theta_wrapper.cpp

@@ -20,10 +20,26 @@ using Rice::Arg;
 
 void init_theta(Rice::Module& m) {
   Rice::define_class_under<theta_sketch>(m, "ThetaSketch")
-    .define_method("empty?", &theta_sketch::is_empty)
-    .define_method("estimate", &theta_sketch::get_estimate)
-    .define_method("lower_bound", &theta_sketch::get_lower_bound)
-    .define_method("upper_bound", &theta_sketch::get_upper_bound);
+    .define_method(
+      "empty?",
+      [](theta_sketch& self) {
+        return self.is_empty();
+      })
+    .define_method(
+      "estimate",
+      [](theta_sketch& self) {
+        return self.get_estimate();
+      })
+    .define_method(
+      "lower_bound",
+      [](theta_sketch& self, uint8_t num_std_devs) {
+        return self.get_lower_bound(num_std_devs);
+      })
+    .define_method(
+      "upper_bound",
+      [](theta_sketch& self, uint8_t num_std_devs) {
+        return self.get_upper_bound(num_std_devs);
+      });
 
   Rice::define_class_under<compact_theta_sketch, theta_sketch>(m, "CompactThetaSketch")
     .define_singleton_function(

data/lib/datasketches/version.rb

@@ -1,3 +1,3 @@
 module DataSketches
-  VERSION = "0.2.0"
+  VERSION = "0.2.4"
 end

data/vendor/datasketches-cpp/CMakeLists.txt

@@ -17,7 +17,7 @@
 
 cmake_minimum_required(VERSION 3.12.0)
 project(DataSketches
-        VERSION 0.12.0
+        VERSION 3.2.0
         LANGUAGES CXX)
 
 include(GNUInstallDirs)
@@ -35,6 +35,8 @@ set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS ON)
 #set(CMAKE_VERBOSE_MAKEFILE ON)
 set(CMAKE_MACOSX_RPATH ON)
 
+set(CMAKE_CXX_STANDARD 11)
+
 # enable compiler warnings globally
 # derived from https://foonathan.net/blog/2018/10/17/cmake-warnings.html
 # and https://arne-mertz.de/2018/07/cmake-properties-options/
@@ -70,6 +72,13 @@ if(COVERAGE AND CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang")
   add_link_options(--coverage)
 endif()
 
+option(SANITIZE "Run sanitization checks (g++/clang only)" OFF)
+if(SANITIZE AND CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang")
+  add_compile_options(-fsanitize=${SANITIZE})
+  add_link_options(-fsanitize=${SANITIZE})
+endif()
+
+
 # set default build type to Release
 # Derived from: https://blog.kitware.com/cmake-and-the-default-build-type/
 set(default_build_type "Release")
@@ -117,11 +126,30 @@ endif()
 
 # # Installation
 install(TARGETS datasketches
-  EXPORT ${PROJCT_NAME}
+  EXPORT ${PROJECT_NAME}
   PUBLIC_HEADER DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/DataSketches
   INCLUDES DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/DataSketches
 )
 
+# Packaging
+include(CMakePackageConfigHelpers)
+write_basic_package_version_file(
+    "${CMAKE_CURRENT_BINARY_DIR}/DataSketchesConfigVersion.cmake"
+    VERSION ${PROJECT_VERSION}
+    COMPATIBILITY SameMajorVersion
+)
+configure_package_config_file(
+    cmake/DataSketchesConfig.cmake.in
+    "${CMAKE_CURRENT_BINARY_DIR}/DataSketchesConfig.cmake"
+    INSTALL_DESTINATION lib/DataSketches/cmake
+    PATH_VARS CMAKE_INSTALL_INCLUDEDIR
+)
+install(EXPORT ${PROJECT_NAME} DESTINATION lib/DataSketches/cmake)
+install(FILES "${CMAKE_CURRENT_BINARY_DIR}/DataSketchesConfigVersion.cmake"
+              "${CMAKE_CURRENT_BINARY_DIR}/DataSketchesConfig.cmake"
+        DESTINATION lib/DataSketches/cmake)
+
+
 #set(CPACK_PROJECT_NAME ${PROJECT_NAME})
 #set(CPACK_PROJECT_VERSION ${PROJECT_VERSION})
-#include(CPack)
+include(CPack)

data/vendor/datasketches-cpp/LICENSE

@@ -284,11 +284,48 @@ APPENDIX B: Additional licenses relevant to this product.
     ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
     DEALINGS IN THE SOFTWARE.
     -------------------------------------------------------------
-    Code Locations
+    Code Locations:
       * https://github.com/apache/datasketches-cpp/blob/master/common/test/catch.hpp
     that is adapted from the above.
 
 
+    =============================================================
+    BSD License
+    =============================================================
+    Original source code:
+       https://github.com/pybind/pybind11/blob/master/LICENSE
+
+    Copyright (c) 2016 Wenzel Jakob <wenzel.jakob@epfl.ch>, All rights reserved.
+
+    Redistribution and use in source and binary forms, with or without
+    modification, are permitted provided that the following conditions are met:
+
+    1. Redistributions of source code must retain the above copyright notice, this
+       list of conditions and the following disclaimer.
+
+    2. Redistributions in binary form must reproduce the above copyright notice,
+       this list of conditions and the following disclaimer in the documentation
+       and/or other materials provided with the distribution.
+
+    3. Neither the name of the copyright holder nor the names of its contributors
+       may be used to endorse or promote products derived from this software
+       without specific prior written permission.
+
+    THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
+    ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+    WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+    DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+    FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+    DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+    SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+    CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+    OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+    OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+    -------------------------------------------------------------
+    Code Locations:
+    Found only in the convenience binaries distributed from PyPI, which rely
+    on pybind11 code during compilation.
+
 
     =============================================================
     Public Domain
@@ -297,7 +334,7 @@ APPENDIX B: Additional licenses relevant to this product.
        https://github.com/aappleby/smhasher/blob/master/src/MurmurHash3.cpp
        Placed in the Public Domain by Austin Appleby
     
-    Code Locations
+    Code Locations:
       common/include/MurmurHash3.h
     that is adapted from the above.
     -------------------------------------------------------------
@@ -305,7 +342,7 @@ APPENDIX B: Additional licenses relevant to this product.
       * https://graphics.stanford.edu/~seander/bithacks.html
       * Placed in the Public Domain by Sean Eron Anderson
       
-    Code Locations
+    Code Locations:
       * common/include/ceiling_power_of_2.hpp
     that is adapted from the above.
   

data/vendor/datasketches-cpp/MANIFEST.in

@@ -9,11 +9,14 @@ global-exclude .git*
 
 recursive-include python/pybind11 *
 
+graft cmake
 graft common
 graft cpc
 graft fi
 graft hll
 graft kll
+graft req
 graft theta
+graft tuple
 graft sampling
 graft python

data/vendor/datasketches-cpp/NOTICE

@@ -1,5 +1,5 @@
 Apache DataSketches-cpp
-Copyright 2020 The Apache Software Foundation
+Copyright 2020-2021 The Apache Software Foundation
 
 Copyright 2015-2018 Yahoo
 Copyright 2019 Verizon Media

data/vendor/datasketches-cpp/README.md

@@ -25,18 +25,85 @@ Installing the latest cmake on OSX: brew install cmake
 Building and running unit tests using cmake for OSX and Linux:
 
 ```
-	$ cd build
-	$ cmake ..
-	$ make
-	$ make test
+    $ cmake -S . -B build/Release -DCMAKE_BUILD_TYPE=Release
+    $ cmake --build build/Release -t all test
 ```
 
 Building and running unit tests using cmake for Windows from the command line:
 
 ```
-	$ cd build
-	$ cmake ..
-	$ cd ..
-	$ cmake --build build --config Release
-	$ cmake --build build --config Release --target RUN_TESTS
+    $ cd build
+    $ cmake ..
+    $ cd ..
+    $ cmake --build build --config Release
+    $ cmake --build build --config Release --target RUN_TESTS
 ```
+
+To install a local distribution (OSX and Linux), use the following command. The
+CMAKE_INSTALL_PREFIX variable controls the destination. If not specified, it 
+defaults to installing in /usr (/usr/include, /usr/lib, etc). In the command below,
+the installation will be in /tmp/install/DataSketches (/tmp/install/DataSketches/include,
+/tmp/install/DataSketches/lib, etc)
+
+```
+    $ cmake -S . -B build/Release -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/tmp/install/DataSketches
+    $ cmake --build build/Release -t install
+```
+
+To generate an installable package using cmake's built in cpack packaging tool,
+use the following command. The type of packaging is controlled by the CPACK_GENERATOR
+variable (semi-colon separated list). Cmake usually supports packaging types such as RPM,
+DEB, STGZ, TGZ, TZ, ZIP, etc.
+
+```
+    $ cmake3 -S . -B build/Release -DCMAKE_BUILD_TYPE=Release -DCPACK_GENERATOR="RPM;STGZ;TGZ" 
+    $ cmake3 --build build/Release -t package
+```
+
+The DataSketches project can be included in other projects' CMakeLists.txt files in one of two ways.
+If DataSketches has been installed on the host (using an RPM, DEB, "make install" into /usr/local, or some 
+way, then CMake's `find_package` command can be used like this:
+
+```
+    find_package(DataSketches 3.2 REQUIRED)
+    target_link_library(my_dependent_target PUBLIC ${DATASKETCHES_LIB})
+```
+
+When used with find_package, DataSketches exports several variables, including
+
+   - `DATASKETCHES_VERSION`: The version number of the datasketches package that was imported.
+   - `DATASKETCHES_INCLUDE_DIR`: The directory that should be added to access DataSketches include files.
+   Because cmake automatically includes the interface directories for included target libraries when
+   using `target_link_library`, under normal circumstances there will be no need to include this directly.
+   - `DATASKETCHES_LIB`: The name of the DataSketches target to include as a dependency. Projects pulling
+   in DataSketches should reference this with `target_link_library` in order to set up all the correct dependencies 
+   and include paths.
+
+If you don't have DataSketches installed locally, dependent projects can pull it directly
+from GitHub using CMake's `ExternalProject` module. The code would look something like this:
+
+```
+    cmake_policy(SET CMP0097 NEW)
+    include(ExternalProject)
+    ExternalProject_Add(datasketches
+        GIT_REPOSITORY https://github.com/apache/datasketches-cpp.git
+        GIT_TAG 3.2.0
+        GIT_SHALLOW true
+        GIT_SUBMODULES ""
+        INSTALL_DIR /tmp/datasketches-prefix
+        CMAKE_ARGS -DBUILD_TESTS=OFF -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} -DCMAKE_INSTALL_PREFIX=/tmp/datasketches-prefix
+
+        # Override the install command to add DESTDIR
+        # This is necessary to work around an oddity in the RPM (but not other) package
+        # generation, as CMake otherwise picks up the Datasketch files when building
+        # an RPM for a dependent package. (RPM scans the directory for files in addition to installing
+        # those files referenced in an "install" rule in the cmake file)
+        INSTALL_COMMAND env DESTDIR= ${CMAKE_COMMAND} --build . --target install
+    )
+    ExternalProject_Get_property(datasketches INSTALL_DIR)
+    set(datasketches_INSTALL_DIR ${INSTALL_DIR})
+    message("Source dir of datasketches = ${datasketches_INSTALL_DIR}")
+    target_include_directories(my_dependent_target 
+                                PRIVATE ${datasketches_INSTALL_DIR}/include/DataSketches)
+    add_dependencies(my_dependent_target datasketches)
+```

data/vendor/datasketches-cpp/cmake/DataSketchesConfig.cmake.in

@@ -0,0 +1,10 @@
+set(DATASKETCHES_VERSION "@PROJECT_VERSION@")
+
+@PACKAGE_INIT@
+
+include("${CMAKE_CURRENT_LIST_DIR}/DataSketches.cmake")
+
+set_and_check(DATASKETCHES_INCLUDE_DIR "@PACKAGE_CMAKE_INSTALL_INCLUDEDIR@/DataSketches")
+set(DATASKETCHES_LIB "datasketches")
+
+check_required_components("@PROJECT_NAME@")

data/vendor/datasketches-cpp/common/CMakeLists.txt

@@ -29,17 +29,18 @@ target_include_directories(common
 
 target_compile_features(common INTERFACE cxx_std_11)
 
-target_sources(common
-  INTERFACE
-    ${CMAKE_CURRENT_SOURCE_DIR}/include/common_defs.hpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/include/memory_operations.hpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/include/MurmurHash3.h
-    ${CMAKE_CURRENT_SOURCE_DIR}/include/serde.hpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/include/count_zeros.hpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/include/inv_pow2_table.hpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/include/binomial_bounds.hpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/include/conditional_back_inserter.hpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/include/conditional_forward.hpp
-    ${CMAKE_CURRENT_SOURCE_DIR}/include/ceiling_power_of_2.hpp
-)
+install(TARGETS common EXPORT ${PROJECT_NAME})
 
+install(FILES 
+			include/common_defs.hpp
+			include/memory_operations.hpp
+			include/MurmurHash3.h
+			include/serde.hpp
+			include/count_zeros.hpp
+			include/inv_pow2_table.hpp
+			include/binomial_bounds.hpp
+			include/conditional_back_inserter.hpp
+			include/conditional_forward.hpp
+			include/ceiling_power_of_2.hpp
+			include/bounds_binomial_proportions.hpp
+  DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}/DataSketches")

data/vendor/datasketches-cpp/common/include/MurmurHash3.h

@@ -16,6 +16,8 @@
 #ifndef _MURMURHASH3_H_
 #define _MURMURHASH3_H_
 
+#include <cstring>
+
 //-----------------------------------------------------------------------------
 // Platform-specific functions and macros
 
@@ -76,9 +78,11 @@ typedef struct {
 // Block read - if your platform needs to do endian-swapping or can only
 // handle aligned reads, do the conversion here
 
-FORCE_INLINE uint64_t getblock64 ( const uint64_t * p, int i )
+FORCE_INLINE uint64_t getblock64 ( const uint64_t * p, size_t i )
 {
-  return p[i];
+  uint64_t res;
+  memcpy(&res, p + i, sizeof(res));
+  return res;
 }
 
 //-----------------------------------------------------------------------------
@@ -95,7 +99,7 @@ FORCE_INLINE uint64_t fmix64 ( uint64_t k )
   return k;
 }
 
-FORCE_INLINE void MurmurHash3_x64_128(const void* key, int lenBytes, uint64_t seed, HashState& out) {
+FORCE_INLINE void MurmurHash3_x64_128(const void* key, size_t lenBytes, uint64_t seed, HashState& out) {
   static const uint64_t c1 = BIG_CONSTANT(0x87c37b91114253d5);
   static const uint64_t c2 = BIG_CONSTANT(0x4cf5ad432745937f);
 
@@ -106,13 +110,13 @@ FORCE_INLINE void MurmurHash3_x64_128(const void* key, int lenBytes, uint64_t se
 
   // Number of full 128-bit blocks of 16 bytes.
   // Possible exclusion of a remainder of up to 15 bytes.
-  const int nblocks = lenBytes >> 4; // bytes / 16 
+  const size_t nblocks = lenBytes >> 4; // bytes / 16 
 
   // Process the 128-bit blocks (the body) into the hash
   const uint64_t* blocks = (const uint64_t*)(data);
-  for (int i = 0; i < nblocks; ++i) { // 16 bytes per block
-    uint64_t k1 = getblock64(blocks,i*2+0);
-    uint64_t k2 = getblock64(blocks,i*2+1);
+  for (size_t i = 0; i < nblocks; ++i) { // 16 bytes per block
+    uint64_t k1 = getblock64(blocks, i * 2 + 0);
+    uint64_t k2 = getblock64(blocks, i * 2 + 1);
 
     k1 *= c1; k1  = ROTL64(k1,31); k1 *= c2; out.h1 ^= k1;
     out.h1 = ROTL64(out.h1,27);

data/vendor/datasketches-cpp/common/include/binomial_bounds.hpp

@@ -381,7 +381,7 @@ private:
   // The following computes an approximation to the lower bound of a Frequentist
   // confidence interval based on the tails of the Binomial distribution.
   static double compute_approx_binomial_lower_bound(unsigned long long num_samples, double theta, unsigned num_std_devs) {
-    if (theta == 1) return num_samples;
+    if (theta == 1) return static_cast<double>(num_samples);
     if (num_samples == 0) return 0;
     if (num_samples == 1) {
       const double delta = delta_of_num_std_devs[num_std_devs];
@@ -395,24 +395,24 @@ private:
     }
     // at this point we know 2 <= num_samples <= 120
     if (theta > (1 - 1e-5)) { // empirically-determined threshold
-      return num_samples;
+      return static_cast<double>(num_samples);
     }
     if (theta < (num_samples / 360.0)) { // empirically-determined threshold
       // here we use the Gaussian approximation, but with a modified num_std_devs
-      const unsigned index = 3 * num_samples + (num_std_devs - 1);
+      const unsigned index = 3 * static_cast<unsigned>(num_samples) + (num_std_devs - 1);
       const double raw_lb = cont_classic_lb(num_samples, theta, lb_equiv_table[index]);
       return raw_lb - 0.5; // fake round down
     }
     // This is the most difficult range to approximate; we will compute an "exact" LB.
     // We know that est <= 360, so specialNStar() shouldn't be ridiculously slow.
     const double delta = delta_of_num_std_devs[num_std_devs];
-    return special_n_star(num_samples, theta, delta); // no need to round
+    return static_cast<double>(special_n_star(num_samples, theta, delta)); // no need to round
   }
 
   // The following computes an approximation to the upper bound of a Frequentist
   // confidence interval based on the tails of the Binomial distribution.
   static double compute_approx_binomial_upper_bound(unsigned long long num_samples, double theta, unsigned num_std_devs) {
-    if (theta == 1) return num_samples;
+    if (theta == 1) return static_cast<double>(num_samples);
     if (num_samples == 0) {
       const double delta = delta_of_num_std_devs[num_std_devs];
       const double raw_ub = std::log(delta) / std::log(1 - theta);
@@ -425,18 +425,18 @@ private:
     }
     // at this point we know 2 <= num_samples <= 120
     if (theta > (1 - 1e-5)) { // empirically-determined threshold
-      return num_samples + 1;
+      return static_cast<double>(num_samples + 1);
     }
     if (theta < (num_samples / 360.0)) { // empirically-determined threshold
       // here we use the Gaussian approximation, but with a modified num_std_devs
-      const unsigned index = 3 * num_samples + (num_std_devs - 1);
+      const unsigned index = 3 * static_cast<unsigned>(num_samples) + (num_std_devs - 1);
       const double raw_ub = cont_classic_ub(num_samples, theta, ub_equiv_table[index]);
       return raw_ub + 0.5; // fake round up
     }
     // This is the most difficult range to approximate; we will compute an "exact" UB.
     // We know that est <= 360, so specialNPrimeF() shouldn't be ridiculously slow.
     const double delta = delta_of_num_std_devs[num_std_devs];
-    return special_n_prime_f(num_samples, theta, delta); // no need to round
+    return static_cast<double>(special_n_prime_f(num_samples, theta, delta)); // no need to round
   }
 
   static void check_theta(double theta) {