datarockets-style 0.9.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: e242588724f25da2f7b419cdaa056a5bfaf6124f
-  data.tar.gz: 8f9a0dee26834329998c453b204be71e8f9de398
+SHA256:
+  metadata.gz: 16590c13f8a15d26842216bb4c0b411c9431a177b7d81b32b9e7a074257b4cf5
+  data.tar.gz: 440e87351bf3e6900d114650fede11f1ab68b2ba5f1d72fe6e599758fec6f346
 SHA512:
-  metadata.gz: 2b304b6c5bf560780de884e8cbc0fbe4e9b6fbe8760284561e5b5548c281bc34122a6750c987de5a467d56ac99396f3c03ccd7e496ca5c3bd8d6d7a29f3ced32
-  data.tar.gz: d7f847d65457edf80911a60f205697f53c410d3a59364a12899e6e1e9151d6294a7d78ae7b98006da726c44f3f69234a4e647889efc74fe08c0afcca7faef19d
+  metadata.gz: be32cf2f4da3c94b9e532bfd0e0a2f0d416200ebc5d2992fdb3ff223b9b9603dd4f78ff198640c4500964cda5f82b93b5484694c909371d53bea2cd185356c0a
+  data.tar.gz: b0120bd764544c9fe6458b981f3b5174d96eaed7980ea29b8ca4b73065b8794225ab832478ee0c7666a1b4ae13908e17d403f30351c80fdd9ec17a4ef6247d49

data/.gitignore

@@ -4,3 +4,7 @@
 /_yardoc/
 /pkg/
 /tmp/
+
+.byebug_history
+.idea
+Gemfile.lock

data/CHANGELOG.md

@@ -2,7 +2,74 @@
 
 The format is described in [Contributing notes](CONTRIBUTING.md#changelog-entry-format).
 
-## master (unreleased)
+## master
+
+## 1.2.0
+
+### Added
+
+* [#219](https://github.com/datarockets/datarockets-style/issues/219) Add `RSpec/PreferBeforeOverSetup` cop. ([@paydaylight][])
+
+### Changed
+
+* [#233](https://github.com/datarockets/datarockets-style/issues/233) Setup `EnforcedStyleForMultiline` for `Style/TrailingCommaInArguments` and `Style/TrailingCommaInArrayLiteral` rules. ([@paydaylight][])
+* [#124](https://github.com/datarockets/datarockets-style/issues/124) Move gem dependencies to `./datarockets-style.gemspec` and drop `Gemfile.lock` tracking. ([@paydaylight][])
+* [#253](https://github.com/datarockets/datarockets-style/issues/253) Update rubocop to `1.10`. ([@paydaylight][])
+* [#124](https://github.com/datarockets/datarockets-style/issues/124) Update rubocop-rails to `2.9`. ([@paydaylight][])
+
+### Fixed
+
+* [#251](https://github.com/datarockets/datarockets-style/issues/251) Update documentation to match `1.1.0` release changes. ([@paydaylight][])
+
+## 1.1.0 (2021-02-09)
+
+### Changed
+
+* Setup `EnforcedStyleForMultiline` for `Style/TrailingCommaInHashLiteral` rule. ([@r.dubrovsky][])
+* Update rubocop to `1.9.1`. ([@paydaylight][])
+* Update rubocop-rails requirement to `>= 2.8.0, < 2.10.0`. ([@paydaylight][])
+* Update rubocop-rspec to `2.2.0`. ([@paydaylight][])
+* Change `Datarockets::Style` module to `DatarocketsStyle`. ([@paydaylight][])
+
+### Fixed
+
+* [#177](https://github.com/datarockets/datarockets-style/issues/177) set `Layout/MultilineOperationIndentation` to indented ([@paydaylight][])
+
+## 1.0.0 (2020-11-10)
+
+### Changed
+
+* Update rubocop to `1.2.0`.
+* Update rubocop-rails to `2.8.1`.
+* Update rubocop-rspec tp `2.0.0`.
+
+## 0.11.0 (2020-11-07)
+
+### Changed
+
+* Update rubocop to '0.93.1'. ([@r.dubrovsky][])
+  * Enable new cops `Lint/BinaryOperatorWithIdenticalOperands`, `Lint/DuplicateRescueException`, `Lint/EmptyConditionalBody`, `Lint/FloatComparison`, `Lint/MissingSuper
+`, `Lint/OutOfRangeRegexpRef`, `Lint/SelfAssignment`, `Lint/TopLevelReturnWithArgument`, `Lint/UnreachableLoop`, `Style/ExplicitBlockArgument`, `Style/GlobalStdStream`, `Style/OptionalBooleanParameter`, `Style/SingleArgumentDig`, `Style/SoleNestedConditional` and `Style/StringConcatenation` in version `0.89`.
+  * Allow to add all new lints automatically.
+  * Add auto-correctable count notification.
+  * Fix tests
+* Update rubocop-rails to `2.7.1`.
+* Update rubocop-rspec tp `1.43.2`.
+  * Disable `RSpec/MultipleMemoizedHelpers` cop.
+
+## 0.10.0 (2020-07-17)
+
+### Changed
+
+* Update rubocop to `0.88.0`. ([@r.dubrovsky][])
+  * Enable new cops `Lint/MixedRegexpCaptureTypes`, `Style/RedundantRegexpCharacterClass` and `Style/RedundantRegexpEscape`. Cops were added in version `0.85`.
+  * Enable new cop `Style/RedundantFetchBlock`. Cop was added in version `0.86`.
+  * Enable new cops `Style/AccessorGrouping`, `Style/BisectedAttrAccessor` and `Style/RedundantAssignment`. Cops were added in version `0.87`.
+  * Enable new cops `Lint/DuplicateElsifCondition`, `Style/ArrayCoercion`, `Style/CaseLikeIf`, `Style/HashAsLastArrayItem`, `Style/HashLikeCase` and `Style/RedundantFileExtensionInRequire`. Cops were added in version `0.88`.
+* Update rubocop-rails to `2.6.0`.
+* Update rubocop-rspec to `1.42.0`.
+
+* Setup `no_braces` rule for `Style/HashAsLastArrayItem` cop which added in the rubocop version `0.88`.
 
 ## 0.9.0 (2020-05-27)
 
@@ -10,7 +77,7 @@ The format is described in [Contributing notes](CONTRIBUTING.md#changelog-entry-
 
 * **(Breaking)** Drop support for Ruby 2.3. ([@r.dubrovsky][])
 
-* Update rubocop to '0.84.0'. ([@r.dubrovsky][])
+* Update rubocop to `0.84.0`. ([@r.dubrovsky][])
   * Enable new cops `Lint/RaiseException` and `Lint/StructNewOverride`. Cops were added in version `0.81`.
   * Enable new cops `Layout/SpaceAroundMethodCallOperator` and `Style/ExponentialNotation`. Cops were added in version `0.82`.
   * Enable new cops `Layout/EmptyLinesAroundAttributeAccessor` and `Style/SlicingWithRange`. Cops were added in version `0.83`.
@@ -171,4 +238,4 @@ The format is described in [Contributing notes](CONTRIBUTING.md#changelog-entry-
 [@v.kuzmik]: https://github.com/TheBlackArroVV/
 [@a.branzeanu]: https://github.com/texpert
 [@nikitasakov]: https://github.com/nikitasakov
-
+[@paydaylight]: https://github.com/paydaylight

data/Gemfile

@@ -3,7 +3,3 @@ source "https://rubygems.org"
 git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 
 gemspec
-
-gem "pry-byebug"
-gem "rake", "~> 13.0"
-gem "rspec", "~> 3.7"

data/README.md

@@ -10,14 +10,14 @@ Add this line to your application's Gemfile:
 
 ```ruby
 group :test, :development do
-  gem 'datarockets-style'
+  gem 'datarockets-style', '~> 1.1.0'
 end
 ```
 
 Or, for a Ruby library, add this to your gemspec:
 
 ```ruby
-spec.add_development_dependency 'datarockets-style'
+spec.add_development_dependency 'datarockets-style', '~> 1.1.0'
 ```
 
 And then execute:
@@ -108,28 +108,28 @@ Result of the formatter is compatible with rubocop config or rubocop todo file.
 For running that cop, just print in your command like
 
 ```bash
-$ bundle exec rubocop -f TodoListFormatter -r datarockets/style
+$ bundle exec rubocop -f TodoListFormatter -r datarockets_style
 Inspecting 10 files
 ...CC.CC..
 10 files inspected, 7 offenses detected
 
 Layout/IndentationConsistency:
   Exclude:
-    - 'spec/datarockets/style/formatter/todo_list_formatter_spec.rb' # 1
+    - 'spec/datarockets_style/formatter/todo_list_formatter_spec.rb' # 1
 
 Naming/MemoizedInstanceVariableName:
   Exclude:
-    - 'lib/datarockets/style/formatter/todo_list_formatter/report_summary.rb' # 1
+    - 'lib/datarockets_style/formatter/todo_list_formatter/report_summary.rb' # 1
 
 RSpec/ExampleLength:
   Exclude:
-    - 'spec/datarockets/style/formatter/todo_list_formatter/report_summary_spec.rb' # 1
-    - 'spec/datarockets/style/formatter/todo_list_formatter_spec.rb' # 2
+    - 'spec/datarockets_style/formatter/todo_list_formatter/report_summary_spec.rb' # 1
+    - 'spec/datarockets_style/formatter/todo_list_formatter_spec.rb' # 2
 
 Style/Documentation:
   Exclude:
-    - 'lib/datarockets/style/formatter/todo_list_formatter/report_summary.rb' # 1
-    - 'lib/datarockets/style/formatter/todo_list_formatter.rb' # 1
+    - 'lib/datarockets_style/formatter/todo_list_formatter/report_summary.rb' # 1
+    - 'lib/datarockets_style/formatter/todo_list_formatter.rb' # 1
 ```
 
 #### Autocorrection
@@ -137,24 +137,24 @@ Style/Documentation:
 If you run the formatter with autocorrection options, the formatter skip corrected cop and does not include it to the result.
 
 ```bash
-$ bundle exec rubocop -f TodoListFormatter -r datarockets/style -a
+$ bundle exec rubocop -f TodoListFormatter -r datarockets_style -a
 Inspecting 10 files
 ...CC.CC..
 10 files inspected, 7 offenses detected, 1 offenses corrected
 
 Naming/MemoizedInstanceVariableName:
   Exclude:
-    - 'lib/datarockets/style/formatter/todo_list_formatter/report_summary.rb' # 1
+    - 'lib/datarockets_style/formatter/todo_list_formatter/report_summary.rb' # 1
 
 RSpec/ExampleLength:
   Exclude:
-    - 'spec/datarockets/style/formatter/todo_list_formatter/report_summary_spec.rb' # 1
-    - 'spec/datarockets/style/formatter/todo_list_formatter_spec.rb' # 2
+    - 'spec/datarockets_style/formatter/todo_list_formatter/report_summary_spec.rb' # 1
+    - 'spec/datarockets_style/formatter/todo_list_formatter_spec.rb' # 2
 
 Style/Documentation:
   Exclude:
-    - 'lib/datarockets/style/formatter/todo_list_formatter/report_summary.rb' # 1
-    - 'lib/datarockets/style/formatter/todo_list_formatter.rb' # 1
+    - 'lib/datarockets_style/formatter/todo_list_formatter/report_summary.rb' # 1
+    - 'lib/datarockets_style/formatter/todo_list_formatter.rb' # 1
 ```
 
 ## Non-goals of RuboCop
@@ -178,4 +178,4 @@ The gem is available as open source under the terms of the [MIT License](https:/
 
 ## Code of Conduct
 
-Everyone interacting in the Datarockets::Style project’s codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](CODE_OF_CONDUCT.md).
+Everyone interacting in the DatarocketsStyle project’s codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](CODE_OF_CONDUCT.md).

data/RELEASING.md

@@ -15,3 +15,19 @@ gem push *built_file*
 * Announce the new release,
    making sure to say "thank you" to the contributors
    who helped shape this version!
+
+## Versioning stragety
+
+As versioning strategy, we're using SemVer: `MAJOR.MINOR.PATCH`
+
+A `MAJOR` version must be incremented if there are any backward-incompatible breaking changes included in a release. This has the benefit of making it easy for anyone to quickly identify if a new version will work differently than a previous one.
+
+Usually, we'll increment it on updating major versions of rubocop dependencies. Ideally, it should be synchronized with the major verion of `rubocop`.
+
+The `MINOR` version must be incremented if backward-compatible functionality is introduced. In the strictest sense, this means you should be able to upgrade to a new minor version without experiencing any breaking changes.
+
+Usually, we'll increment it on changing the list of cops, updating minor versions of dependencies.
+
+The `PATCH` version is meant for backward-compatible bug fixes. You should expect no new functionality with a new patch version, only improvements.
+
+Usually, we'll use it for updating patch versions of dependencies or fixing bugs of the last version. Changed rules of cops in most cases should be added to minor version.

data/bin/console

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 
 require "bundler/setup"
-require "datarockets/style"
+require "datarockets_style"
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.

data/config/base.yml

@@ -1,4 +1,7 @@
-require: datarockets/style
+require: datarockets_style
+
+AllCops:
+  NewCops: enable
 
 Bundler/DuplicatedGem:
   Enabled: true
@@ -47,6 +50,9 @@ Layout/FirstHashElementIndentation:
 Layout/MultilineMethodCallIndentation:
   EnforcedStyle: indented
 
+Layout/MultilineOperationIndentation:
+  EnforcedStyle: indented
+
 Layout/SpaceAroundMethodCallOperator:
   Enabled: true
 
@@ -54,33 +60,91 @@ Layout/SpaceInsideHashLiteralBraces:
   EnforcedStyle: no_space
   EnforcedStyleForEmptyBraces: no_space
 
+Lint/BinaryOperatorWithIdenticalOperands:
+  Enabled: true
+
 Lint/DeprecatedOpenSSLConstant:
   Enabled: true
 
+Lint/DuplicateElsifCondition:
+  Enabled: true
+
+Lint/DuplicateRescueException:
+  Enabled: true
+
+Lint/EmptyConditionalBody:
+  Enabled: true
+
+Lint/FloatComparison:
+  Enabled: true
+
+Lint/MissingSuper:
+  Enabled: true
+
+Lint/MixedRegexpCaptureTypes:
+  Enabled: true
+
+Lint/OutOfRangeRegexpRef:
+  Enabled: true
+
 Lint/RaiseException:
   Enabled: true
 
+Lint/SelfAssignment:
+  Enabled: true
+
 Lint/StructNewOverride:
   Enabled: true
 
+Lint/TopLevelReturnWithArgument:
+  Enabled: true
+
+Lint/UnreachableLoop:
+  Enabled: true
+
 Naming/MemoizedInstanceVariableName:
   EnforcedStyleForLeadingUnderscores: required
 
 Naming/RescuedExceptionsVariableName:
   PreferredName: error
 
+Style/AccessorGrouping:
+  Enabled: true
+
+Style/ArrayCoercion:
+  Enabled: true
+
+Style/BisectedAttrAccessor:
+  Enabled: true
+
+Style/CaseLikeIf:
+  Enabled: true
+
 Style/ClassAndModuleChildren:
   EnforcedStyle: nested
 
 Style/EmptyMethod:
   EnforcedStyle: expanded
 
+Style/ExplicitBlockArgument:
+  Enabled: true
+
 Style/ExponentialNotation:
   Enabled: true
 
+Style/GlobalStdStream:
+  Enabled: true
+
+Style/HashAsLastArrayItem:
+  Enabled: true
+  EnforcedStyle: no_braces
+
 Style/HashEachMethods:
   Enabled: true
 
+Style/HashLikeCase:
+   Enabled: true
+
 Style/HashTransformKeys:
   Enabled: true
 
@@ -93,8 +157,44 @@ Style/FrozenStringLiteralComment:
 Style/NestedInterpolation:
   Enabled: true
 
+Style/OptionalBooleanParameter:
+  Enabled: true
+
+Style/RedundantAssignment:
+  Enabled: true
+
+Style/RedundantFetchBlock:
+  Enabled: true
+
+Style/RedundantFileExtensionInRequire:
+  Enabled: true
+
+Style/RedundantRegexpCharacterClass:
+  Enabled: true
+
+Style/RedundantRegexpEscape:
+  Enabled: true
+
+Style/SingleArgumentDig:
+  Enabled: true
+
 Style/SlicingWithRange:
   Enabled: true
 
+Style/SoleNestedConditional:
+  Enabled: true
+
+Style/StringConcatenation:
+  Enabled: true
+
 Style/StringLiterals:
   EnforcedStyle: double_quotes
+
+Style/TrailingCommaInArguments:
+  EnforcedStyleForMultiline: comma
+
+Style/TrailingCommaInArrayLiteral:
+  EnforcedStyleForMultiline: comma
+
+Style/TrailingCommaInHashLiteral:
+  EnforcedStyleForMultiline: comma

data/config/rails.yml

@@ -1,5 +1,7 @@
 require: rubocop-rails
 
+inherit_from: base.yml
+
 AllCops:
   Exclude:
     - "db/**/*"
@@ -12,8 +14,6 @@ AllCops:
     - "config.ru"
     - "Rakefile"
 
-inherit_from: base.yml
-
 Style/Documentation:
   Enabled: true
   Exclude:

data/config/rspec.yml

@@ -31,5 +31,11 @@ RSpec/LetSetup:
 RSpec/MessageSpies:
   EnforcedStyle: have_received
 
+RSpec/MultipleMemoizedHelpers:
+  Enabled: false
+
 RSpec/NestedGroups:
   Enabled: false
+
+RSpec/PreferBeforeOverSetup:
+  Enabled: true

data/datarockets-style.gemspec

@@ -1,10 +1,10 @@
 lib = File.expand_path("lib", __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require "datarockets/style/version"
+require "datarockets_style/version"
 
 Gem::Specification.new do |spec|
   spec.name          = "datarockets-style"
-  spec.version       = Datarockets::Style::VERSION
+  spec.version       = DatarocketsStyle::VERSION
   spec.authors       = ["Roman Dubrovsky"]
   spec.email         = ["r.dubrovsky@datarockets.com"]
 
@@ -30,7 +30,11 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "rubocop", "~> 0.84"
-  spec.add_dependency "rubocop-rails", "~> 2.5.2"
-  spec.add_dependency "rubocop-rspec", "~> 1.39"
+  spec.add_dependency "rubocop", "~> 1.10"
+  spec.add_dependency "rubocop-rails", "~> 2.9"
+  spec.add_dependency "rubocop-rspec", "~> 2.0"
+
+  spec.add_development_dependency "pry-byebug"
+  spec.add_development_dependency "rake", "~> 13.0"
+  spec.add_development_dependency "rspec", "~> 3.10"
 end