datarockets-style 0.8.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: f2fd6f40031f396d111c19513fa8e0af187c19ce
-  data.tar.gz: ed7157fb4be39d3c0d62bd3f57cd03fcacf04c12
+SHA256:
+  metadata.gz: 13302183c2bb2361f4069f312d84b44569bdac9bd3e012868cf6845357d1754f
+  data.tar.gz: 6d8c66f18353e28136e855a7cf3a0ee1933c4103f68fc1cb0a602d8dcaa5190a
 SHA512:
-  metadata.gz: 7c357e907de9be6791e57a7917597b4d25007e47dadebef87af8d4a2677bf93f39d21217da4710d4aef2efc55834839ff3b26249a24ae3f2eb9c66beca41770c
-  data.tar.gz: e07b9b1d21dc783acf09448ab43a4a78abd8235ec0b03bdfca8ba104aea53650492c873df493f85cf5a64e84b4820e8f5fe57663fde956ec41e5a7a7a5c52343
+  metadata.gz: c17ff90118be39c8b0b078aea534e4a650e4c5dcb3dbccbda0cca6394c7372a97530b50112e76691155237b9944efd26d54fab5f7ef3437d20470c535f1f720b
+  data.tar.gz: 4ddba3d32c03980657729a5b46d7d186fe589ddff67a4d4743bf377180c58bd3d2e0de59451286b28accfa12384852c96a59cf1a150efe611a9d9d361e3cc870

data/.github/ISSUE_TEMPLATE/update-dependencies.md

@@ -14,3 +14,4 @@ To-Do list:
 - [ ] update dependencies to the latest version
 - [ ] investigate how it changes and affect our current styles and cops
 - [ ] check the required ruby version
+- [ ] enable pending cops

data/.gitignore

@@ -4,3 +4,5 @@
 /_yardoc/
 /pkg/
 /tmp/
+
+.byebug_history

data/.rubocop.yml

@@ -7,7 +7,7 @@ inherit_mode:
     - Exclude
 
 AllCops:
-  TargetRubyVersion: 2.3
+  TargetRubyVersion: 2.4
 
 # for checking cops with interpolation
 Lint/InterpolationCheck:

data/CHANGELOG.md

@@ -2,7 +2,65 @@
 
 The format is described in [Contributing notes](CONTRIBUTING.md#changelog-entry-format).
 
-## master (unreleased)
+## master
+
+## 1.0.0 (2020-11-10)
+
+### Changed
+
+* Update rubocop to `1.2.0`.
+* Update rubocop-rails to `2.8.1`.
+* Update rubocop-rspec tp `2.0.0`.
+
+## 0.11.0 (2020-11-07)
+
+### Changed
+
+* Update rubocop to '0.93.1'. ([@r.dubrovsky][])
+  * Enable new cops `Lint/BinaryOperatorWithIdenticalOperands`, `Lint/DuplicateRescueException`, `Lint/EmptyConditionalBody`, `Lint/FloatComparison`, `Lint/MissingSuper
+`, `Lint/OutOfRangeRegexpRef`, `Lint/SelfAssignment`, `Lint/TopLevelReturnWithArgument`, `Lint/UnreachableLoop`, `Style/ExplicitBlockArgument`, `Style/GlobalStdStream`, `Style/OptionalBooleanParameter`, `Style/SingleArgumentDig`, `Style/SoleNestedConditional` and `Style/StringConcatenation` in version `0.89`.
+  * Allow to add all new lints automatically.
+  * Add auto-correctable count notification.
+  * Fix tests
+* Update rubocop-rails to `2.7.1`.
+* Update rubocop-rspec tp `1.43.2`.
+  * Disable `RSpec/MultipleMemoizedHelpers` cop.
+
+## 0.10.0 (2020-07-17)
+
+### Changed
+
+* Update rubocop to `0.88.0`. ([@r.dubrovsky][])
+  * Enable new cops `Lint/MixedRegexpCaptureTypes`, `Style/RedundantRegexpCharacterClass` and `Style/RedundantRegexpEscape`. Cops were added in version `0.85`.
+  * Enable new cop `Style/RedundantFetchBlock`. Cop was added in version `0.86`.
+  * Enable new cops `Style/AccessorGrouping`, `Style/BisectedAttrAccessor` and `Style/RedundantAssignment`. Cops were added in version `0.87`.
+  * Enable new cops `Lint/DuplicateElsifCondition`, `Style/ArrayCoercion`, `Style/CaseLikeIf`, `Style/HashAsLastArrayItem`, `Style/HashLikeCase` and `Style/RedundantFileExtensionInRequire`. Cops were added in version `0.88`.
+* Update rubocop-rails to `2.6.0`.
+* Update rubocop-rspec to `1.42.0`.
+
+* Setup `no_braces` rule for `Style/HashAsLastArrayItem` cop which added in the rubocop version `0.88`.
+
+## 0.9.0 (2020-05-27)
+
+### Changed
+
+* **(Breaking)** Drop support for Ruby 2.3. ([@r.dubrovsky][])
+
+* Update rubocop to `0.84.0`. ([@r.dubrovsky][])
+  * Enable new cops `Lint/RaiseException` and `Lint/StructNewOverride`. Cops were added in version `0.81`.
+  * Enable new cops `Layout/SpaceAroundMethodCallOperator` and `Style/ExponentialNotation`. Cops were added in version `0.82`.
+  * Enable new cops `Layout/EmptyLinesAroundAttributeAccessor` and `Style/SlicingWithRange`. Cops were added in version `0.83`.
+  * Enable new cop `Lint/DeprecatedOpenSSLConstant`. Cop was added in version `0.84`.
+
+* Update rubocop-rails to `2.5.2`.
+* Update rubocop-rspec to `1.39`.
+* Update `activesupport` for fixing security issues.
+
+## 0.8.1 (2020-03-02)
+
+### Changed
+
+* Update rubocop to `0.80.1`.
 
 ## 0.8.0 (2020-02-20)
 

data/Gemfile

@@ -6,4 +6,4 @@ gemspec
 
 gem "pry-byebug"
 gem "rake", "~> 13.0"
-gem "rspec", "~> 3.7"
+gem "rspec", "~> 3.10"

data/Gemfile.lock

@@ -1,61 +1,80 @@
 PATH
   remote: .
   specs:
-    datarockets-style (0.8.0)
-      rubocop (~> 0.80)
-      rubocop-rails (~> 2.4)
-      rubocop-rspec (~> 1.38)
+    datarockets-style (1.0.0)
+      rubocop (>= 1.2, < 2.0)
+      rubocop-rails (>= 2.8.0, < 2.9.0)
+      rubocop-rspec (~> 2.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    ast (2.4.0)
-    byebug (11.0.1)
+    activesupport (6.0.3.4)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (>= 0.7, < 2)
+      minitest (~> 5.1)
+      tzinfo (~> 1.1)
+      zeitwerk (~> 2.2, >= 2.2.2)
+    ast (2.4.1)
+    byebug (11.1.3)
     coderay (1.1.2)
-    diff-lcs (1.3)
-    jaro_winkler (1.5.4)
-    method_source (0.9.2)
-    parallel (1.19.1)
-    parser (2.7.0.2)
-      ast (~> 2.4.0)
-    pry (0.12.2)
-      coderay (~> 1.1.0)
-      method_source (~> 0.9.0)
-    pry-byebug (3.7.0)
+    concurrent-ruby (1.1.7)
+    diff-lcs (1.4.4)
+    i18n (1.8.5)
+      concurrent-ruby (~> 1.0)
+    method_source (1.0.0)
+    minitest (5.14.2)
+    parallel (1.20.0)
+    parser (2.7.2.0)
+      ast (~> 2.4.1)
+    pry (0.13.1)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
+    pry-byebug (3.9.0)
       byebug (~> 11.0)
-      pry (~> 0.10)
-    rack (2.2.2)
+      pry (~> 0.13.0)
+    rack (2.2.3)
     rainbow (3.0.0)
     rake (13.0.1)
+    regexp_parser (1.8.2)
     rexml (3.2.4)
-    rspec (3.9.0)
-      rspec-core (~> 3.9.0)
-      rspec-expectations (~> 3.9.0)
-      rspec-mocks (~> 3.9.0)
-    rspec-core (3.9.0)
-      rspec-support (~> 3.9.0)
-    rspec-expectations (3.9.0)
+    rspec (3.10.0)
+      rspec-core (~> 3.10.0)
+      rspec-expectations (~> 3.10.0)
+      rspec-mocks (~> 3.10.0)
+    rspec-core (3.10.0)
+      rspec-support (~> 3.10.0)
+    rspec-expectations (3.10.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.9.0)
-    rspec-mocks (3.9.0)
+      rspec-support (~> 3.10.0)
+    rspec-mocks (3.10.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.9.0)
-    rspec-support (3.9.0)
-    rubocop (0.80.0)
-      jaro_winkler (~> 1.5.1)
+      rspec-support (~> 3.10.0)
+    rspec-support (3.10.0)
+    rubocop (1.2.0)
       parallel (~> 1.10)
-      parser (>= 2.7.0.1)
+      parser (>= 2.7.1.5)
       rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8)
       rexml
+      rubocop-ast (>= 1.0.1)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 1.7)
-    rubocop-rails (2.4.2)
+      unicode-display_width (>= 1.4.0, < 2.0)
+    rubocop-ast (1.1.1)
+      parser (>= 2.7.1.5)
+    rubocop-rails (2.8.1)
+      activesupport (>= 4.2.0)
       rack (>= 1.1)
-      rubocop (>= 0.72.0)
-    rubocop-rspec (1.38.1)
-      rubocop (>= 0.68.1)
+      rubocop (>= 0.87.0)
+    rubocop-rspec (2.0.0)
+      rubocop (~> 1.0)
+      rubocop-ast (>= 1.1.0)
     ruby-progressbar (1.10.1)
-    unicode-display_width (1.6.1)
+    thread_safe (0.3.6)
+    tzinfo (1.2.8)
+      thread_safe (~> 0.1)
+    unicode-display_width (1.7.0)
+    zeitwerk (2.4.1)
 
 PLATFORMS
   ruby
@@ -64,7 +83,7 @@ DEPENDENCIES
   datarockets-style!
   pry-byebug
   rake (~> 13.0)
-  rspec (~> 3.7)
+  rspec (~> 3.10)
 
 BUNDLED WITH
-   1.16.3
+   2.1.4

data/README.md

@@ -10,14 +10,14 @@ Add this line to your application's Gemfile:
 
 ```ruby
 group :test, :development do
-  gem 'datarockets-style'
+  gem 'datarockets-style', '~> 1.0.0'
 end
 ```
 
 Or, for a Ruby library, add this to your gemspec:
 
 ```ruby
-spec.add_development_dependency 'datarockets-style'
+spec.add_development_dependency 'datarockets-style', '~> 1.0.0'
 ```
 
 And then execute:

data/RELEASING.md

@@ -15,3 +15,19 @@ gem push *built_file*
 * Announce the new release,
    making sure to say "thank you" to the contributors
    who helped shape this version!
+
+## Versioning stragety
+
+As versioning strategy, we're using SemVer: `MAJOR.MINOR.PATCH`
+
+A `MAJOR` version must be incremented if there are any backward-incompatible breaking changes included in a release. This has the benefit of making it easy for anyone to quickly identify if a new version will work differently than a previous one.
+
+Usually, we'll increment it on updating major versions of rubocop dependencies. Ideally, it should be synchronized with the major verion of `rubocop`.
+
+The `MINOR` version must be incremented if backward-compatible functionality is introduced. In the strictest sense, this means you should be able to upgrade to a new minor version without experiencing any breaking changes.
+
+Usually, we'll increment it on changing the list of cops, updating minor versions of dependencies.
+
+The `PATCH` version is meant for backward-compatible bug fixes. You should expect no new functionality with a new patch version, only improvements.
+
+Usually, we'll use it for updating patch versions of dependencies or fixing bugs of the last version. Changed rules of cops in most cases should be added to minor version.

data/config/base.yml

@@ -1,5 +1,8 @@
 require: datarockets/style
 
+AllCops:
+  NewCops: enable
+
 Bundler/DuplicatedGem:
   Enabled: true
 
@@ -29,6 +32,9 @@ Layout/ParameterAlignment:
   EnforcedStyle: with_fixed_indentation
   IndentationWidth: 2
 
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
+
 Layout/EndAlignment:
   EnforcedStyleAlignWith: variable
 
@@ -44,25 +50,98 @@ Layout/FirstHashElementIndentation:
 Layout/MultilineMethodCallIndentation:
   EnforcedStyle: indented
 
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+
 Layout/SpaceInsideHashLiteralBraces:
   EnforcedStyle: no_space
   EnforcedStyleForEmptyBraces: no_space
 
+Lint/BinaryOperatorWithIdenticalOperands:
+  Enabled: true
+
+Lint/DeprecatedOpenSSLConstant:
+  Enabled: true
+
+Lint/DuplicateElsifCondition:
+  Enabled: true
+
+Lint/DuplicateRescueException:
+  Enabled: true
+
+Lint/EmptyConditionalBody:
+  Enabled: true
+
+Lint/FloatComparison:
+  Enabled: true
+
+Lint/MissingSuper:
+  Enabled: true
+
+Lint/MixedRegexpCaptureTypes:
+  Enabled: true
+
+Lint/OutOfRangeRegexpRef:
+  Enabled: true
+
+Lint/RaiseException:
+  Enabled: true
+
+Lint/SelfAssignment:
+  Enabled: true
+
+Lint/StructNewOverride:
+  Enabled: true
+
+Lint/TopLevelReturnWithArgument:
+  Enabled: true
+
+Lint/UnreachableLoop:
+  Enabled: true
+
 Naming/MemoizedInstanceVariableName:
   EnforcedStyleForLeadingUnderscores: required
 
 Naming/RescuedExceptionsVariableName:
   PreferredName: error
 
+Style/AccessorGrouping:
+  Enabled: true
+
+Style/ArrayCoercion:
+  Enabled: true
+
+Style/BisectedAttrAccessor:
+  Enabled: true
+
+Style/CaseLikeIf:
+  Enabled: true
+
 Style/ClassAndModuleChildren:
   EnforcedStyle: nested
 
 Style/EmptyMethod:
   EnforcedStyle: expanded
 
+Style/ExplicitBlockArgument:
+  Enabled: true
+
+Style/ExponentialNotation:
+  Enabled: true
+
+Style/GlobalStdStream:
+  Enabled: true
+
+Style/HashAsLastArrayItem:
+  Enabled: true
+  EnforcedStyle: no_braces
+
 Style/HashEachMethods:
   Enabled: true
 
+Style/HashLikeCase:
+   Enabled: true
+
 Style/HashTransformKeys:
   Enabled: true
 
@@ -75,5 +154,35 @@ Style/FrozenStringLiteralComment:
 Style/NestedInterpolation:
   Enabled: true
 
+Style/OptionalBooleanParameter:
+  Enabled: true
+
+Style/RedundantAssignment:
+  Enabled: true
+
+Style/RedundantFetchBlock:
+  Enabled: true
+
+Style/RedundantFileExtensionInRequire:
+  Enabled: true
+
+Style/RedundantRegexpCharacterClass:
+  Enabled: true
+
+Style/RedundantRegexpEscape:
+  Enabled: true
+
+Style/SingleArgumentDig:
+  Enabled: true
+
+Style/SlicingWithRange:
+  Enabled: true
+
+Style/SoleNestedConditional:
+  Enabled: true
+
+Style/StringConcatenation:
+  Enabled: true
+
 Style/StringLiterals:
   EnforcedStyle: double_quotes

data/config/rails.yml

@@ -1,5 +1,7 @@
 require: rubocop-rails
 
+inherit_from: base.yml
+
 AllCops:
   Exclude:
     - "db/**/*"
@@ -12,8 +14,6 @@ AllCops:
     - "config.ru"
     - "Rakefile"
 
-inherit_from: base.yml
-
 Style/Documentation:
   Enabled: true
   Exclude:

data/config/rspec.yml

@@ -31,5 +31,8 @@ RSpec/LetSetup:
 RSpec/MessageSpies:
   EnforcedStyle: have_received
 
+RSpec/MultipleMemoizedHelpers:
+  Enabled: false
+
 RSpec/NestedGroups:
   Enabled: false

data/datarockets-style.gemspec

@@ -12,7 +12,7 @@ Gem::Specification.new do |spec|
   spec.homepage      = "https://github.com/datarockets/datarockets-style"
   spec.license       = "MIT"
 
-  spec.required_ruby_version = ">= 2.3.0"
+  spec.required_ruby_version = ">= 2.4.0"
 
   # Prevent pushing this gem to RubyGems.org. To allow pushes either set the 'allowed_push_host'
   # to allow pushing to a single host or delete this section to allow pushing to any host.
@@ -30,7 +30,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "rubocop", "~> 0.80"
-  spec.add_dependency "rubocop-rails", "~> 2.4"
-  spec.add_dependency "rubocop-rspec", "~> 1.38"
+  spec.add_dependency "rubocop", ">= 1.2  ", "< 2.0"
+  spec.add_dependency "rubocop-rails", ">= 2.8.0", "< 2.9.0"
+  spec.add_dependency "rubocop-rspec", "~> 2.0"
 end

data/doc/STYLE_GUIDE_RSPEC.md

@@ -15,6 +15,10 @@ This style guide recommends best practices for writing a clear Rspec tests and e
   So there are not any limits for deep or nested groups.
   <sup>[[link](#rspec-nested-groups)]</sup>
 
+* <a name="rspec-let-count"></a>
+  We're not limiting a number of `let` blocks in describe and context blocks.
+  <sup>[[link](#rspec-let-count)]</sup>
+
 * <a name="rspec-subject"></a>
   Each subject should be named, and we should not use `subject` in our test cases.
   Prefer to use `is_expected` that `expect(subject_name)` for small tests.

data/lib/datarockets/style/formatter/todo_list_formatter.rb

@@ -42,7 +42,8 @@ class TodoListFormatter < RuboCop::Formatter::ProgressFormatter
   def finished(inspected_files)
     report_summary(inspected_files.length,
       @total_offense_count,
-      @total_correction_count)
+      @total_correction_count,
+      @total_correctable_count)
     output.puts
 
     Datarockets::Style::Formatter::TodoListFormatter::ReportSummary.new(offense_list).call(output)

data/lib/datarockets/style/formatter/todo_list_formatter/report_summary.rb

@@ -13,9 +13,9 @@ module Datarockets
         class ReportSummary
           attr_reader :offense_list
 
-          FileGroup = Struct.new(:file, :count) do
+          FileGroup = Struct.new(:file, :offenses_count) do
             def print(output)
-              output.puts "    - '#{file}' # #{count}"
+              output.puts "    - '#{file}' # #{offenses_count}"
             end
           end
 
@@ -27,7 +27,7 @@ module Datarockets
             end
 
             def print(output)
-              output.puts(cop_name + ":")
+              output.puts("#{cop_name}:")
               output.puts("  Exclude:")
               file_groups.sort_by(&:file).each do |file_group|
                 file_group.print(output)

data/lib/datarockets/style/version.rb

@@ -1,5 +1,5 @@
 module Datarockets
   module Style
-    VERSION = "0.8.0".freeze
+    VERSION = "1.0.0".freeze
   end
 end

metadata

@@ -1,57 +1,69 @@
 --- !ruby/object:Gem::Specification
 name: datarockets-style
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Roman Dubrovsky
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-02-20 00:00:00.000000000 Z
+date: 2020-11-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '1.2'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0.80'
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '1.2'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0.80'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.8.0
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '2.4'
+        version: 2.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.8.0
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '2.4'
+        version: 2.9.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.38'
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.38'
+        version: '2.0'
 description: 
 email:
 - r.dubrovsky@datarockets.com
@@ -106,15 +118,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.3.0
+      version: 2.4.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Datarockets style guides and shared style configs