datadog 2.44.0 → 2.45.0

data/ext/datadog_profiling_native_extension/collectors_gc_profiling_helper.c

@@ -53,8 +53,6 @@ void gc_profiling_init(void) {
   shady_sym     = ID2SYM(rb_intern_const("shady"));
   force_sym     = ID2SYM(rb_intern_const("force"));
   oldmalloc_sym = ID2SYM(rb_intern_const("oldmalloc"));
-  state_sym     = ID2SYM(rb_intern_const("state"));
-  none_sym      = ID2SYM(rb_intern_const("none"));
 }
 
 bool gc_profiling_has_major_gc_finished(void) {

data/ext/datadog_profiling_native_extension/collectors_idle_sampling_helper.c

@@ -22,12 +22,12 @@
 typedef enum { ACTION_WAIT, ACTION_RUN, ACTION_STOP } action;
 
 // Contains state for a single CpuAndWallTimeWorker instance
-typedef struct {
+struct idle_sampling_loop_state {
   pthread_mutex_t wakeup_mutex;
   pthread_cond_t wakeup;
   action requested_action;
   void (*run_action_function)(void);
-} idle_sampling_loop_state;
+};
 
 static VALUE _native_new(VALUE klass);
 static void reset_state(idle_sampling_loop_state *state);
@@ -39,7 +39,7 @@ static void *run_idle_sampling_loop(void *state_ptr);
 static void interrupt_idle_sampling_loop(void *state_ptr);
 static VALUE _native_reset(DDTRACE_UNUSED VALUE self, VALUE self_instance);
 static VALUE _native_idle_sampling_helper_request_action(DDTRACE_UNUSED VALUE self, VALUE self_instance);
-static void *request_testing_action(void *self_instance_ptr);
+static void *request_testing_action(void *state_ptr);
 static void grab_gvl_and_run_testing_action(void);
 static void *run_testing_action(DDTRACE_UNUSED void *unused);
 
@@ -215,15 +215,14 @@ static VALUE _native_stop(DDTRACE_UNUSED VALUE self, VALUE self_instance) {
   return Qtrue;
 }
 
-// Assumption: Function gets called without the global VM lock
-void idle_sampling_helper_request_action(VALUE self_instance, void (*run_action_function)(void)) {
+idle_sampling_loop_state *idle_sampling_helper_get_state(VALUE self_instance) {
   idle_sampling_loop_state *state;
-  if (!rb_typeddata_is_kind_of(self_instance, &idle_sampling_helper_typed_data)) {
-    grab_gvl_and_raise(rb_eTypeError, "Wrong argument for idle_sampling_helper_request_action");
-  }
-  // This should never fail when the above check passes
   TypedData_Get_Struct(self_instance, idle_sampling_loop_state, &idle_sampling_helper_typed_data, state);
+  return state;
+}
 
+// Called without the GVL, so we access native state directly: touching the Ruby self_instance is unsafe during GC compaction.
+void idle_sampling_helper_request_action(idle_sampling_loop_state *state, void (*run_action_function)(void)) {
   ENFORCE_SUCCESS_NO_GVL(pthread_mutex_lock(&state->wakeup_mutex));
   if (state->requested_action == ACTION_WAIT) {
     state->requested_action = ACTION_RUN;
@@ -238,13 +237,14 @@ void idle_sampling_helper_request_action(VALUE self_instance, void (*run_action_
 // Because the idle_sampling_helper_request_action is built to be called without the global VM lock, here we release it
 // to be able to call that API.
 static VALUE _native_idle_sampling_helper_request_action(DDTRACE_UNUSED VALUE self, VALUE self_instance) {
-  rb_thread_call_without_gvl(request_testing_action, (void *) self_instance, NULL, NULL);
+  idle_sampling_loop_state *state = idle_sampling_helper_get_state(self_instance);
+  rb_thread_call_without_gvl(request_testing_action, state, NULL, NULL);
+  RB_GC_GUARD(self_instance);
   return Qtrue;
 }
 
-static void *request_testing_action(void *self_instance_ptr) {
-  VALUE self_instance = (VALUE) self_instance_ptr;
-  idle_sampling_helper_request_action(self_instance, grab_gvl_and_run_testing_action);
+static void *request_testing_action(void *state_ptr) {
+  idle_sampling_helper_request_action(state_ptr, grab_gvl_and_run_testing_action);
   return NULL;
 }
 

data/ext/datadog_profiling_native_extension/collectors_idle_sampling_helper.h

@@ -1,3 +1,7 @@
 #pragma once
 
-void idle_sampling_helper_request_action(VALUE self_instance, void (*run_action_function)(void));
+typedef struct idle_sampling_loop_state idle_sampling_loop_state;
+
+// Must be called with the GVL held; keep self_instance alive while using the returned pointer.
+idle_sampling_loop_state *idle_sampling_helper_get_state(VALUE self_instance);
+void idle_sampling_helper_request_action(idle_sampling_loop_state *state, void (*run_action_function)(void));

data/ext/datadog_profiling_native_extension/collectors_stack.c

@@ -641,6 +641,7 @@ void record_placeholder_stack(
   );
 }
 
+// Also called from a signal handler or during GC; check callers' safety requirements before changing this function.
 bool prepare_sample_thread(VALUE thread, sampling_buffer *buffer) {
   // While the signal handler checks if there's GC going on, it's actually possible for `sampling_buffer_mark` to
   // still run outside of GC (see comments on that function) and thus we guard for it here.