datadog 2.43.0 → 2.45.0

data/lib/datadog/tracing/otel_thread_context.rb

@@ -9,24 +9,89 @@ module Datadog
     # https://github.com/open-telemetry/opentelemetry-specification/blob/main/oteps/profiles/4947-thread-ctx.md
     #
     # Native functions are implemented in ext/libdatadog_api/otel_thread_context.c
-    module OTelThreadContext
-      class << self
-        def supported?
-          Datadog::Core::LIBDATADOG_API_FAILURE.nil? && _native_supported?
+    class OTelThreadContext
+      UNKNOWN_LOCAL_ROOT_SPAN_ID = 0
+
+      def self.build(tracing_settings)
+        return unless tracing_settings.otel_thread_context_enabled
+
+        instance = new
+        instance if instance.supported? && instance._native_enable
+      end
+
+      def initialize
+        @span_before_start = proc do |event_span_op, event_trace_op|
+          set(
+            trace_id: event_trace_op.id,
+            span_id: event_span_op.id,
+            local_root_span_id: event_trace_op.send(:root_span).id
+          )
         end
 
-        def enable!
-          return false unless supported?
+        @span_finished = proc do |_event_span_op, event_trace_op|
+          next if event_trace_op.finished?
 
-          _native_enable
+          update_from_trace_op(event_trace_op)
         end
+      end
 
-        def set(trace_id:, span_id:, local_root_span_id:)
-          _native_set(trace_id, span_id, local_root_span_id)
+      private_class_method :new
+
+      def subscribe_to_tracer_events!(events)
+        events.span_before_start.subscribe(&@span_before_start)
+        events.span_finished.subscribe(&@span_finished)
+      end
+
+      def set(trace_id:, span_id:, local_root_span_id:)
+        # OTel requires trace-id and span-id to be either both set or both unset.
+        # Zeroes can be used to indicate that no trace and span are active.
+        # https://github.com/open-telemetry/opentelemetry-specification/blob/v1.61.0/oteps/profiles/4947-thread-ctx.md?plain=1#L116C144-L116C189
+        return clear if trace_id.zero? || span_id.zero?
+
+        _native_set(trace_id, span_id, local_root_span_id)
+      end
+
+      def after_fork
+        clear
+      end
+
+      def clear
+        _native_clear
+      rescue => e
+        Datadog.logger.debug do
+          "Error clearing OTel thread context: #{e.class}: #{e.message}"
         end
 
-        def clear
-          _native_clear
+        false
+      end
+
+      def supported?
+        Datadog::Core::LIBDATADOG_API_FAILURE.nil? && _native_supported?
+      end
+
+      def update_from_trace_op(trace_op)
+        active_span = trace_op.active_span
+
+        if active_span
+          # Internally created active span
+          set(
+            trace_id: trace_op.id,
+            span_id: active_span.id,
+            local_root_span_id: trace_op.send(:root_span).id
+          )
+        elsif trace_op.parent_span_id && trace_op.parent_span_id != 0
+          # Active distributed trace context, before first local trace is created
+          set(
+            trace_id: trace_op.id,
+            span_id: trace_op.parent_span_id,
+            local_root_span_id: UNKNOWN_LOCAL_ROOT_SPAN_ID
+          )
+        else
+          clear
+        end
+      rescue => e
+        Datadog.logger.debug do
+          "Error updating OTel thread context: #{e.class}: #{e.message}"
         end
       end
     end

data/lib/datadog/tracing/tracer.rb

@@ -52,10 +52,11 @@ module Datadog
         # rubocop:disable Style/KeywordParametersOrder
         # https://github.com/rubocop/rubocop/issues/13933
         trace_flush: Flush::Finished.new,
-        context_provider: DefaultContextProvider.new,
+        context_provider: nil,
         default_service: Core::Environment::Ext::FALLBACK_SERVICE_NAME,
         enabled: true,
         logger: Datadog.logger,
+        otel_thread_context: nil,
         sampler: Sampling::PrioritySampler.new(
           base_sampler: Sampling::AllSampler.new,
           post_sampler: Sampling::RuleSampler.new
@@ -71,11 +72,16 @@ module Datadog
         @default_service = default_service
         @enabled = enabled
         @logger = logger
-        @provider = context_provider
         @sampler = sampler
         @span_sampler = span_sampler
         @tags = tags
         @writer = writer
+
+        @otel_thread_context = otel_thread_context
+
+        @provider = context_provider || DefaultContextProvider.new(
+          otel_thread_context: otel_thread_context
+        )
       end
 
       # Return a {Datadog::Tracing::SpanOperation span_op} and {Datadog::Tracing::TraceOperation trace_op}
@@ -341,6 +347,10 @@ module Datadog
         # rubocop:enable Lint/UselessMethodDefinition
       end
 
+      def after_fork
+        @otel_thread_context&.after_fork
+      end
+
       # Shorthand that calls the `shutdown!` method of a registered worker.
       # It's useful to ensure that the Trace Buffer is properly flushed before
       # shutting down the application.
@@ -352,6 +362,7 @@ module Datadog
       #
       #   tracer.shutdown!
       def shutdown!
+        @otel_thread_context&.clear
         return unless @enabled
 
         @writer&.stop
@@ -445,6 +456,8 @@ module Datadog
             reconsider_trace_sampling_on_resource(event_trace_op)
           end
         end
+
+        @otel_thread_context&.subscribe_to_tracer_events!(events)
       end
 
       # Creates a new TraceOperation, with events bounds to this Tracer instance.

data/lib/datadog/tracing/transport/native.rb

@@ -47,10 +47,10 @@ module Datadog
           include Statistics
           include SpanEventsNegotiation
 
-          attr_reader :logger
+          attr_reader :logger, :url
 
           # @param agent_settings [Datadog::Core::Configuration::AgentSettingsResolver::AgentSettings]
-          #   Agent connection settings (provides +#url+).
+          #   Agent connection settings, including the request timeout.
           # @param logger [Logger]
           def initialize(agent_settings:, logger:)
             unless Native.supported?
@@ -67,7 +67,7 @@ module Datadog
             # this is held across the fork through the matching completion hook.
             @fork_mutex = Mutex.new
 
-            url = agent_settings.url
+            @url = agent_settings.url
             tracer_version = tracer_version_string
             language = Core::Environment::Ext::LANG
             language_version = Core::Environment::Ext::LANG_VERSION
@@ -83,6 +83,7 @@ module Datadog
 
             exporter = Native::TraceExporter._native_new(
               url: url,
+              timeout_milliseconds: agent_settings.timeout_seconds * 1000,
               tracer_version: tracer_version,
               language: language,
               language_version: language_version,
@@ -90,7 +91,8 @@ module Datadog
               hostname: hostname,
               env: env,
               service: service,
-              version: version
+              version: version,
+              client_computed_stats: !Datadog.configuration.apm.tracing.enabled
             )
             @exporter = exporter
 
@@ -215,25 +217,24 @@ module Datadog
           # native exporter so its runtime can shut down. Idempotent: safe to
           # call multiple times and safe to call after the finalizer has run.
           def close
-            fork_hooks = @send_mutex.synchronize do
-              hooks = @fork_hooks
-              return if hooks.nil?
-
-              @fork_hooks = nil
-              @exporter = nil
-              hooks
-            end
-
-            fork_hooks.each do |stage, block|
-              Core::Utils::AtForkMonkeyPatch.remove_at_fork(stage, block)
+            @fork_mutex.synchronize do
+              @send_mutex.synchronize do
+                hooks = @fork_hooks
+                return if hooks.nil?
+
+                begin
+                  @exporter&._native_close
+                ensure
+                  @fork_hooks = nil
+                  @exporter = nil
+                  hooks.each do |stage, block|
+                    Core::Utils::AtForkMonkeyPatch.remove_at_fork(stage, block)
+                  end
+                  ObjectSpace.undefine_finalizer(self)
+                end
+              end
             end
 
-            # The finalizer only exists to deregister the hooks for a transport
-            # dropped without #close. We have just done that, so remove it;
-            # otherwise its closed-over hook blocks keep the exporter alive until
-            # this transport is itself collected.
-            ObjectSpace.undefine_finalizer(self)
-
             nil
           end
 
@@ -264,7 +265,7 @@ module Datadog
             return [] if traces.empty?
 
             # Apply trace-level tags to root spans (same as the HTTP transport)
-            traces.each { |trace| TraceFormatter.format!(trace) }
+            traces.each { |trace| TraceFormatter.format!(trace, transport: "native") }
 
             # Build the Array<Array<Span>> structure expected by the C extension.
             # Each trace segment becomes one inner array (one trace chunk).

data/lib/datadog/tracing/transport/trace_formatter.rb

@@ -19,8 +19,8 @@ module Datadog
           :first_span,
           :trace
 
-        def self.format!(trace)
-          new(trace).format!
+        def self.format!(trace, transport: nil)
+          new(trace).format!(transport: transport)
         end
 
         def initialize(trace)
@@ -32,7 +32,7 @@ module Datadog
         end
 
         # Modifies a trace so suitable for transport
-        def format!
+        def format!(transport: nil)
           return unless trace
           return trace unless root_span
 
@@ -65,10 +65,13 @@ module Datadog
 
           if first_span
             tag_process_tags!
+            tag_sdk_otlp_export!
             tag_git_repository_url!
             tag_git_commit_sha!
           end
 
+          root_span.set_tag("_dd.tracing.transport", transport) if transport && !partial?
+
           trace
         end
 
@@ -237,6 +240,13 @@ module Datadog
           )
         end
 
+        # TODO: Revisit when OTLP trace export support lands. The OTLP path sets
+        # `_dd.sdk.otlp_export: "true"` on the OTLP resource, so this tag must not
+        # also be set to "false" on the first span of a chunk exported over OTLP.
+        def tag_sdk_otlp_export!
+          first_span.set_tag(Tracing::Metadata::Ext::TAG_SDK_OTLP_EXPORT, "false")
+        end
+
         private
 
         def partial?

data/lib/datadog/tracing/transport/traces.rb

@@ -100,7 +100,7 @@ module Datadog
 
           def encode_trace(encoder, trace, logger:, native_events_supported:)
             # Format the trace for transport
-            TraceFormatter.format!(trace)
+            TraceFormatter.format!(trace, transport: "ruby")
 
             # Make the trace serializable
             serializable_trace = SerializableTrace.new(trace, native_events_supported: native_events_supported)

data/lib/datadog/version.rb

@@ -3,7 +3,7 @@
 module Datadog
   module VERSION
     MAJOR = 2
-    MINOR = 43
+    MINOR = 45
     PATCH = 0
     PRE = nil
     BUILD = nil

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: datadog
 version: !ruby/object:Gem::Version
-  version: 2.43.0
+  version: 2.45.0
 platform: ruby
 authors:
 - Datadog, Inc.
@@ -63,14 +63,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 40.0.0.2.0
+        version: 45.0.0.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 40.0.0.2.0
+        version: 45.0.0.1.0
 - !ruby/object:Gem::Dependency
   name: logger
   requirement: !ruby/object:Gem::Requirement
@@ -190,7 +190,6 @@ files:
 - ext/libdatadog_extconf_helpers.rb
 - lib/datadog.rb
 - lib/datadog/ai_guard.rb
-- lib/datadog/ai_guard/api_client.rb
 - lib/datadog/ai_guard/autoload.rb
 - lib/datadog/ai_guard/component.rb
 - lib/datadog/ai_guard/configuration.rb
@@ -204,16 +203,26 @@ files:
 - lib/datadog/ai_guard/contrib/rails/patcher.rb
 - lib/datadog/ai_guard/contrib/ruby_llm/chat_instrumentation.rb
 - lib/datadog/ai_guard/contrib/ruby_llm/integration.rb
+- lib/datadog/ai_guard/contrib/ruby_llm/message_adapter.rb
 - lib/datadog/ai_guard/contrib/ruby_llm/patcher.rb
+- lib/datadog/ai_guard/contrib/ruby_llm/redaction_change_set.rb
 - lib/datadog/ai_guard/evaluation.rb
-- lib/datadog/ai_guard/evaluation/content_builder.rb
+- lib/datadog/ai_guard/evaluation/client.rb
 - lib/datadog/ai_guard/evaluation/content_part.rb
 - lib/datadog/ai_guard/evaluation/message.rb
+- lib/datadog/ai_guard/evaluation/message_builder.rb
 - lib/datadog/ai_guard/evaluation/no_op_result.rb
+- lib/datadog/ai_guard/evaluation/outcome.rb
 - lib/datadog/ai_guard/evaluation/request.rb
+- lib/datadog/ai_guard/evaluation/response.rb
 - lib/datadog/ai_guard/evaluation/result.rb
 - lib/datadog/ai_guard/evaluation/tool_call.rb
 - lib/datadog/ai_guard/ext.rb
+- lib/datadog/ai_guard/http_client.rb
+- lib/datadog/ai_guard/metrics/telemetry.rb
+- lib/datadog/ai_guard/redaction.rb
+- lib/datadog/ai_guard/redaction/replacements.rb
+- lib/datadog/ai_guard/redaction/result.rb
 - lib/datadog/appsec.rb
 - lib/datadog/appsec/actions_handler.rb
 - lib/datadog/appsec/actions_handler/serializable_backtrace.rb
@@ -577,8 +586,15 @@ files:
 - lib/datadog/kit/identity.rb
 - lib/datadog/kit/tracing/method_tracer.rb
 - lib/datadog/open_feature.rb
+- lib/datadog/open_feature/agentless/configuration_source.rb
+- lib/datadog/open_feature/agentless/parser.rb
+- lib/datadog/open_feature/agentless/response.rb
+- lib/datadog/open_feature/agentless/transport.rb
 - lib/datadog/open_feature/component.rb
 - lib/datadog/open_feature/configuration.rb
+- lib/datadog/open_feature/configuration/agentless_endpoint.rb
+- lib/datadog/open_feature/configuration/source.rb
+- lib/datadog/open_feature/configuration/source/resolution.rb
 - lib/datadog/open_feature/evaluation_engine.rb
 - lib/datadog/open_feature/exposures/batch_builder.rb
 - lib/datadog/open_feature/exposures/buffer.rb
@@ -1174,8 +1190,8 @@ licenses:
 - Apache-2.0
 metadata:
   allowed_push_host: https://rubygems.org
-  changelog_uri: https://github.com/DataDog/dd-trace-rb/blob/v2.43.0/CHANGELOG.md
-  source_code_uri: https://github.com/DataDog/dd-trace-rb/tree/v2.43.0
+  changelog_uri: https://github.com/DataDog/dd-trace-rb/blob/v2.45.0/CHANGELOG.md
+  source_code_uri: https://github.com/DataDog/dd-trace-rb/tree/v2.45.0
 post_install_message: 'JRuby support in the datadog gem is deprecated. Details: https://dtdg.co/jruby-deprecation'
 rdoc_options: []
 require_paths:

data/lib/datadog/ai_guard/evaluation/content_builder.rb

@@ -1,31 +0,0 @@
-# frozen_string_literal: true
-
-module Datadog
-  module AIGuard
-    module Evaluation
-      # Builder for collecting content parts inside a message block.
-      #
-      # Used via the block form of {Datadog::AIGuard.message}:
-      #
-      #   Datadog::AIGuard.message(role: :user) do |m|
-      #     m.text("What's in this image?")
-      #     m.image_url("https://example.com/img.png")
-      #   end
-      class ContentBuilder
-        attr_reader :parts
-
-        def initialize
-          @parts = []
-        end
-
-        def text(text)
-          @parts << ContentPart::Text.new(text)
-        end
-
-        def image_url(url)
-          @parts << ContentPart::ImageURL.new(url)
-        end
-      end
-    end
-  end
-end