datadog-notifications 0.6.2 → 0.6.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 38a9e7c3163df4e1427b18ea7216e1b014d7bd3ba51a1aa0ff133de1990a6227
-  data.tar.gz: 0e1f66f6fea54e0934dd85d3e0ac351070ebd7652c6e0577e55aee10b887c067
+  metadata.gz: 0fe55c10d1c135748c2a818187431d0f316a8cf0192cefdf7ab45d6245e6add9
+  data.tar.gz: f9449725f5768bb0e75eb02363f12eda4235e474d7fb00e6f7cc4c2b54c599d2
 SHA512:
-  metadata.gz: 5362759bfa74f7cc6878861099b77eca4e933221f1f7eec74bff99a40551a21ed1bc5366895d1896ff79cc048d3e3fe00001a6fea20587b7ef4483caf45b220b
-  data.tar.gz: b58dc570f252838b4ad991345652218cd9026d3d78a70ef25d1dfca91577836267a054bbe56b42d45fb2ddb07c269ba10f369e28431fa899a6453db7abdfbe0d
+  metadata.gz: e649e3040acec1a88eb92075b555ed4ba7c2c7533544ba2c4da01d41627dcd570bede8315c1759018351803eca2b9f00e84b95533ebb5d6412f7ada6705dac3d
+  data.tar.gz: 1077d3018207521015a4f4c5025c032b84405377d43a789a27b1153154eafac83e955abc75a5d4cb558073242caed193e3a018ae8251058ce88379a5c7e078ec

data/.github/workflows/ruby.yml

@@ -0,0 +1,21 @@
+name: Ruby
+
+on:
+  push:
+    branches: [main]
+  pull_request:
+    branches: [main]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby-version: ["2.6", "2.7", "3.0"]
+    steps:
+      - uses: actions/checkout@v2
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+          bundler-cache: true
+      - run: bundle exec rake

data/.rubocop.yml

@@ -1,8 +1,12 @@
-inherit_from:
-  - https://gitlab.com/bsm/misc/raw/master/rubocop/default.yml
+inherit_gem:
+  rubocop-bsm:
+    - default.yml
+inherit_mode:
+  merge:
+    - Exclude
 
 AllCops:
-  TargetRubyVersion: "2.5"
+  TargetRubyVersion: "2.6"
 
 Naming/FileName:
   Exclude:

data/Gemfile.lock

@@ -1,100 +1,133 @@
 PATH
   remote: .
   specs:
-    datadog-notifications (0.6.2)
+    datadog-notifications (0.6.7)
       activesupport
-      dogstatsd-ruby (>= 4.2, < 5.0)
+      dogstatsd-ruby (>= 4.8, < 5.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activemodel (6.0.2.1)
-      activesupport (= 6.0.2.1)
-    activerecord (6.0.2.1)
-      activemodel (= 6.0.2.1)
-      activesupport (= 6.0.2.1)
-    activesupport (6.0.2.1)
+    activejob (6.1.3)
+      activesupport (= 6.1.3)
+      globalid (>= 0.3.6)
+    activemodel (6.1.3)
+      activesupport (= 6.1.3)
+    activerecord (6.1.3)
+      activemodel (= 6.1.3)
+      activesupport (= 6.1.3)
+    activesupport (6.1.3)
       concurrent-ruby (~> 1.0, >= 1.0.2)
-      i18n (>= 0.7, < 2)
-      minitest (~> 5.1)
-      tzinfo (~> 1.1)
-      zeitwerk (~> 2.2)
-    ast (2.4.0)
-    axiom-types (0.1.1)
-      descendants_tracker (~> 0.0.4)
-      ice_nine (~> 0.11.0)
-      thread_safe (~> 0.3, >= 0.3.1)
+      i18n (>= 1.6, < 2)
+      minitest (>= 5.1)
+      tzinfo (~> 2.0)
+      zeitwerk (~> 2.3)
+    ast (2.4.2)
     builder (3.2.4)
-    coercible (1.0.0)
-      descendants_tracker (~> 0.0.1)
-    concurrent-ruby (1.1.5)
-    descendants_tracker (0.0.4)
-      thread_safe (~> 0.3, >= 0.3.1)
-    diff-lcs (1.3)
-    dogstatsd-ruby (4.5.0)
-    equalizer (0.0.11)
-    grape (1.2.5)
+    concurrent-ruby (1.1.8)
+    diff-lcs (1.4.4)
+    dogstatsd-ruby (4.8.3)
+    dry-configurable (0.12.1)
+      concurrent-ruby (~> 1.0)
+      dry-core (~> 0.5, >= 0.5.0)
+    dry-container (0.7.2)
+      concurrent-ruby (~> 1.0)
+      dry-configurable (~> 0.1, >= 0.1.3)
+    dry-core (0.5.0)
+      concurrent-ruby (~> 1.0)
+    dry-inflector (0.2.0)
+    dry-logic (1.1.0)
+      concurrent-ruby (~> 1.0)
+      dry-core (~> 0.5, >= 0.5)
+    dry-types (1.5.1)
+      concurrent-ruby (~> 1.0)
+      dry-container (~> 0.3)
+      dry-core (~> 0.5, >= 0.5)
+      dry-inflector (~> 0.1, >= 0.1.2)
+      dry-logic (~> 1.0, >= 1.0.2)
+    globalid (0.4.2)
+      activesupport (>= 4.2.0)
+    grape (1.5.2)
       activesupport
       builder
+      dry-types (>= 1.1)
       mustermann-grape (~> 1.0.0)
       rack (>= 1.3.0)
       rack-accept
-      virtus (>= 1.0.0)
-    i18n (1.7.0)
+    i18n (1.8.9)
       concurrent-ruby (~> 1.0)
-    ice_nine (0.11.2)
-    jaro_winkler (1.5.4)
-    minitest (5.13.0)
-    mustermann (1.0.3)
-    mustermann-grape (1.0.0)
-      mustermann (~> 1.0.0)
-    parallel (1.19.1)
-    parser (2.7.0.1)
-      ast (~> 2.4.0)
-    rack (2.0.8)
+    minitest (5.14.4)
+    mustermann (1.1.1)
+      ruby2_keywords (~> 0.0.1)
+    mustermann-grape (1.0.1)
+      mustermann (>= 1.0.0)
+    parallel (1.20.1)
+    parser (3.0.0.0)
+      ast (~> 2.4.1)
+    rack (2.2.3)
     rack-accept (0.4.5)
       rack (>= 0.4)
     rack-test (1.1.0)
       rack (>= 1.0, < 3)
     rainbow (3.0.0)
-    rake (13.0.1)
-    rspec (3.9.0)
-      rspec-core (~> 3.9.0)
-      rspec-expectations (~> 3.9.0)
-      rspec-mocks (~> 3.9.0)
-    rspec-core (3.9.1)
-      rspec-support (~> 3.9.1)
-    rspec-expectations (3.9.0)
+    rake (13.0.3)
+    regexp_parser (2.1.1)
+    rexml (3.2.5)
+    rspec (3.10.0)
+      rspec-core (~> 3.10.0)
+      rspec-expectations (~> 3.10.0)
+      rspec-mocks (~> 3.10.0)
+    rspec-core (3.10.1)
+      rspec-support (~> 3.10.0)
+    rspec-expectations (3.10.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.9.0)
-    rspec-mocks (3.9.1)
+      rspec-support (~> 3.10.0)
+    rspec-mocks (3.10.2)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.9.0)
-    rspec-support (3.9.2)
-    rubocop (0.78.0)
-      jaro_winkler (~> 1.5.1)
+      rspec-support (~> 3.10.0)
+    rspec-support (3.10.2)
+    rubocop (1.11.0)
       parallel (~> 1.10)
-      parser (>= 2.6)
+      parser (>= 3.0.0.0)
       rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8, < 3.0)
+      rexml
+      rubocop-ast (>= 1.2.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 1.7)
-    ruby-progressbar (1.10.1)
+      unicode-display_width (>= 1.4.0, < 3.0)
+    rubocop-ast (1.4.1)
+      parser (>= 2.7.1.5)
+    rubocop-bsm (0.5.4)
+      rubocop (~> 1.0)
+      rubocop-performance
+      rubocop-rails
+      rubocop-rake
+      rubocop-rspec
+    rubocop-performance (1.10.1)
+      rubocop (>= 0.90.0, < 2.0)
+      rubocop-ast (>= 0.4.0)
+    rubocop-rails (2.9.1)
+      activesupport (>= 4.2.0)
+      rack (>= 1.1)
+      rubocop (>= 0.90.0, < 2.0)
+    rubocop-rake (0.5.1)
+      rubocop
+    rubocop-rspec (2.2.0)
+      rubocop (~> 1.0)
+      rubocop-ast (>= 1.1.0)
+    ruby-progressbar (1.11.0)
+    ruby2_keywords (0.0.4)
     sqlite3 (1.4.2)
-    thread_safe (0.3.6)
-    tzinfo (1.2.6)
-      thread_safe (~> 0.1)
-    unicode-display_width (1.6.0)
-    virtus (1.0.5)
-      axiom-types (~> 0.1)
-      coercible (~> 1.0)
-      descendants_tracker (~> 0.0, >= 0.0.3)
-      equalizer (~> 0.0, >= 0.0.9)
-    zeitwerk (2.2.2)
+    tzinfo (2.0.4)
+      concurrent-ruby (~> 1.0)
+    unicode-display_width (2.0.0)
+    zeitwerk (2.4.2)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
+  activejob
   activerecord
   bundler
   datadog-notifications!
@@ -102,8 +135,8 @@ DEPENDENCIES
   rack-test
   rake
   rspec
-  rubocop
+  rubocop-bsm
   sqlite3
 
 BUNDLED WITH
-   2.1.2
+   2.2.16

data/datadog-notifications.gemspec

@@ -14,17 +14,18 @@ Gem::Specification.new do |s|
   s.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
   s.test_files    = s.files.grep(%r{^(spec)/})
   s.require_paths = ['lib']
-  s.required_ruby_version = '>= 2.5'
+  s.required_ruby_version = '>= 2.6'
 
   s.add_runtime_dependency 'activesupport'
-  s.add_runtime_dependency 'dogstatsd-ruby', '>= 4.2', '< 5.0'
+  s.add_runtime_dependency 'dogstatsd-ruby', '>= 4.8', '< 5.0'
 
+  s.add_development_dependency 'activejob'
   s.add_development_dependency 'activerecord'
   s.add_development_dependency 'bundler'
   s.add_development_dependency 'grape', '>= 1.0.2'
   s.add_development_dependency 'rack-test'
   s.add_development_dependency 'rake'
   s.add_development_dependency 'rspec'
-  s.add_development_dependency 'rubocop'
+  s.add_development_dependency 'rubocop-bsm'
   s.add_development_dependency 'sqlite3'
 end

data/lib/datadog/notifications/config.rb

@@ -14,22 +14,21 @@ module Datadog
       end
 
       # Use a plugin
-      def use(klass, opts={})
-        @plugins.push klass.new(opts)
+      def use(klass, **opts)
+        @plugins.push klass.new(**opts)
       end
 
       protected
 
       def connect!
         env = ENV['RAILS_ENV'] || ENV['RACK_ENV']
-        tags.push("env:#{env}")       if env && tags.none? {|t| t =~ /^env\:/ }
+        tags.push("env:#{env}")       if env && tags.none? {|t| t =~ /^env:/ }
 
         enable_hostname = hostname && hostname != 'false'
-        tags.push("host:#{hostname}") if enable_hostname && tags.none? {|t| t =~ /^host\:/ }
+        tags.push("host:#{hostname}") if enable_hostname && tags.none? {|t| t =~ /^host:/ }
 
         reporter.new statsd_host, statsd_port, namespace: namespace, tags: tags, socket_path: socket_path
       end
-
     end
   end
 end

data/lib/datadog/notifications/plugins/action_controller.rb

@@ -1,16 +1,15 @@
 module Datadog::Notifications::Plugins
   class ActionController < Base
-
     attr_reader :metric_name
 
     # Options:
     #
     # *<tt>:metric_name</tt> - the metric name, defaults to "rails.request"
     # *<tt>:tags</tt> - additional tags
-    def initialize(opts={})
+    def initialize(metric_name: 'rails.request', **opts)
       super
-      @metric_name = opts[:metric_name] || 'rails.request'
 
+      @metric_name = metric_name
       Datadog::Notifications.subscribe 'process_action.action_controller' do |reporter, event|
         record reporter, event
       end
@@ -34,6 +33,5 @@ module Datadog::Notifications::Plugins
         reporter.timing "#{metric_name}.time.view", payload[:view_runtime], tags: tags
       end
     end
-
   end
 end

data/lib/datadog/notifications/plugins/active_job.rb

@@ -1,16 +1,15 @@
 module Datadog::Notifications::Plugins
   class ActiveJob < Base
-
     attr_reader :metric_name
 
     # Options:
     #
     # *<tt>:metric_name</tt> - the metric name, defaults to "activejob.perform"
     # *<tt>:tags</tt>        - additional tags
-    def initialize(opts={})
+    def initialize(metric_name: 'activejob.perform', **opts)
       super
-      @metric_name = opts[:metric_name] || 'activejob.perform'
 
+      @metric_name = metric_name
       Datadog::Notifications.subscribe 'perform.active_job' do |reporter, event|
         record reporter, event
       end
@@ -19,15 +18,15 @@ module Datadog::Notifications::Plugins
     private
 
     def record(reporter, event)
-      job  = event.payload[:job]
-      name = job.class.name.sub(/Job$/, '').underscore
-      tags = self.tags + %W[job:#{name} queue:#{job.queue_name}]
+      job   = event.payload[:job]
+      name  = job.class.name.sub(/Job$/, '').underscore
+      queue = job.queue_name.tr(':', '_')
+      tags  = self.tags + %W[job:#{name} queue:#{queue}]
 
       reporter.batch do
         reporter.increment metric_name, tags: tags
         reporter.timing "#{metric_name}.time", event.duration, tags: tags
       end
     end
-
   end
 end

data/lib/datadog/notifications/plugins/active_record.rb

@@ -1,6 +1,5 @@
 module Datadog::Notifications::Plugins
   class ActiveRecord < Base
-
     attr_reader :metric_name
 
     # Options:
@@ -9,9 +8,10 @@ module Datadog::Notifications::Plugins
     # *<tt>:include_schema</tt>   - record schema queries, off by default
     # *<tt>:include_generic</tt>  - record general (nameless) queries, off by default
     # *<tt>:tags</tt>             - additional tags
-    def initialize(opts={})
+    def initialize(metric_name: 'activerecord.sql', **opts)
       super
-      @metric_name     = opts[:metric_name] || 'activerecord.sql'
+
+      @metric_name     = metric_name
       @include_schema  = opts[:include_schema] == true
       @include_generic = opts[:include_generic] == true
       @include_raw     = opts[:include_raw] == true
@@ -38,6 +38,5 @@ module Datadog::Notifications::Plugins
         reporter.timing "#{metric_name}.time", event.duration, tags: tags
       end
     end
-
   end
 end

data/lib/datadog/notifications/plugins/base.rb

@@ -5,9 +5,8 @@ module Datadog::Notifications::Plugins
     # Options:
     #
     # *<tt>:tags</tt> - additional tags
-    def initialize(opts={})
-      @tags = opts[:tags] || []
+    def initialize(tags: [], **_opts)
+      @tags = tags
     end
-
   end
 end

data/lib/datadog/notifications/plugins/grape.rb

@@ -1,5 +1,6 @@
 module Datadog::Notifications::Plugins
   class Grape < Base
+    DEFAULT_EXCEPTION_HANDLER = ->(e) { Grape.exception_status(e) }
 
     def self.exception_status(err)
       err.respond_to?(:status) ? err.status : 500
@@ -12,10 +13,11 @@ module Datadog::Notifications::Plugins
     # *<tt>:metric_name</tt> - the metric name, defaults to "grape.request"
     # *<tt>:exception_handler</tt> - a custom exception handler proc which accepts an exception object and returns a status
     # *<tt>:tags</tt> - additional tags
-    def initialize(opts={})
+    def initialize(metric_name: 'grape.request', exception_handler: DEFAULT_EXCEPTION_HANDLER, **opts)
       super
-      @metric_name = opts[:metric_name] || 'grape.request'
-      @exception_handler = opts[:exception_handler] || ->(e) { self.class.exception_status(e) }
+
+      @metric_name = metric_name
+      @exception_handler = exception_handler
 
       Datadog::Notifications.subscribe 'endpoint_run.grape' do |reporter, event|
         record reporter, event
@@ -33,7 +35,7 @@ module Datadog::Notifications::Plugins
       status = exception_handler.call(payload[:exception_object]) if payload[:exception_object]
 
       path = extract_path(endpoint)
-      path.gsub!(%r{[^\w\/\-]+}, '_')
+      path.gsub!(%r{[^\w/\-]+}, '_')
 
       tags = self.tags + %W[method:#{method} status:#{status}]
       tags.push "path:#{path}" if path
@@ -47,18 +49,17 @@ module Datadog::Notifications::Plugins
 
     def extract_path(endpoint)
       route = begin
-                endpoint.route
-              rescue NoMethodError
-                nil
-              end
+        endpoint.route
+      rescue NoMethodError
+        nil
+      end
       return endpoint.request.path unless route
 
       path = endpoint.route.path.dup
-      path.sub!(/\(\.\:format\)$/, '')
+      path.sub!(/\(\.:format\)$/, '')
       path.sub!(':version/', '') if endpoint.version
-      path.gsub!(/:(\w+)/) {|m| m[1..-1].upcase }
+      path.gsub!(/:(\w+)/) {|m| m[1..].upcase }
       path
     end
-
   end
 end

data/lib/datadog/notifications/plugins/grpc.rb

@@ -1,6 +1,5 @@
 module Datadog::Notifications::Plugins
   class GRPC < Base
-
     # Options:
     #
     # *<tt>:metric_name</tt> - the metric name, defaults to 'grpc.request'
@@ -10,10 +9,10 @@ module Datadog::Notifications::Plugins
     # Notification payload should have :service (service name, string) and :action (service action/method name, string) keys.
     #
     # Compatible instrumentation is implemented in grpcx gem: https://github.com/bsm/grpcx (>= 0.2.0)
-    def initialize(opts={})
+    def initialize(metric_name: 'grpc.request', **opts)
       super
-      @metric_name = opts[:metric_name] || 'grpc.request'
 
+      @metric_name = metric_name
       Datadog::Notifications.subscribe 'process_action.grpc' do |reporter, event|
         record reporter, event
       end
@@ -34,6 +33,5 @@ module Datadog::Notifications::Plugins
         reporter.timing "#{@metric_name}.time", event.duration, tags: tags
       end
     end
-
   end
 end

data/lib/datadog/notifications/version.rb

@@ -1,5 +1,5 @@
 module Datadog
   class Notifications
-    VERSION = '0.6.2'.freeze
+    VERSION = '0.6.7'.freeze
   end
 end

data/spec/datadog/notifications/config_spec.rb

@@ -1,8 +1,7 @@
 require 'spec_helper'
 
 describe Datadog::Notifications::Config do
-
-  it 'should be connect!' do
+  it 'is connect!' do
     subject.reporter = Mock::Reporter
     subject.hostname = 'test.host'
     subject.tags = ['custom:tag']
@@ -13,7 +12,7 @@ describe Datadog::Notifications::Config do
   end
 
   RSpec.shared_examples 'host tag is not picked up' do |hostname|
-    it 'should not pick up the host tag' do
+    it 'does not pick up the host tag' do
       subject.reporter = Mock::Reporter
       subject.hostname = hostname
       subject.tags = ['custom:tag']
@@ -27,10 +26,9 @@ describe Datadog::Notifications::Config do
   include_examples 'host tag is not picked up', false
   include_examples 'host tag is not picked up', 'false'
 
-  it 'should instantiate plugins on use' do
+  it 'instantiates plugins on use' do
     subject.use Datadog::Notifications::Plugins::ActionController
     expect(subject.plugins.size).to eq(1)
     expect(subject.plugins.first).to be_instance_of(Datadog::Notifications::Plugins::ActionController)
   end
-
 end

data/spec/datadog/notifications/plugins/active_job_spec.rb

@@ -0,0 +1,11 @@
+require 'spec_helper'
+
+describe Datadog::Notifications::Plugins::ActiveJob do
+  it 'sanitizes tags' do
+    NoopJob.perform_now
+    expect(buffered).to eq [
+      'activejob.perform:1|c|#custom:tag,env:test,host:test.host,job:noop,queue:test_queue',
+      'activejob.perform.time:333|ms|#custom:tag,env:test,host:test.host,job:noop,queue:test_queue',
+    ]
+  end
+end

data/spec/datadog/notifications/plugins/active_record_spec.rb

@@ -1,8 +1,7 @@
 require 'spec_helper'
 
 describe Datadog::Notifications::Plugins::ActiveRecord do
-
-  it 'should send an increment and timing event for each query' do
+  it 'sends an increment and timing event for each query' do
     Post.all.to_a
     expect(buffered).to eq [
       'activerecord.sql:1|c|#custom:tag,env:test,host:test.host,query:post.load',
@@ -10,12 +9,11 @@ describe Datadog::Notifications::Plugins::ActiveRecord do
     ]
   end
 
-  it 'should support custom queries' do
+  it 'supports custom queries' do
     Post.find_by_sql('SELECT * FROM posts LIMIT 1').to_a
     expect(buffered).to eq [
       'activerecord.sql:1|c|#custom:tag,env:test,host:test.host,query:post.load',
       'activerecord.sql.time:333|ms|#custom:tag,env:test,host:test.host,query:post.load',
     ]
   end
-
 end

data/spec/datadog/notifications/plugins/grape_spec.rb

@@ -14,7 +14,6 @@ describe Datadog::Notifications::Plugins::Grape do
     end
 
     Class.new(Grape::API) do
-
       rescue_from unauthorized do |_e|
         error!({ message: 'unauthorized', error: '401 Unauthorized' }, 401)
       end
@@ -37,7 +36,7 @@ describe Datadog::Notifications::Plugins::Grape do
     end
   end
 
-  it 'should send an increment and timing event for each request' do
+  it 'sends an increment and timing event for each request' do
     get '/echo/1/1234'
     expect(last_response.status).to eq(200)
     expect(last_response.body).to eq('1 1234')
@@ -48,7 +47,7 @@ describe Datadog::Notifications::Plugins::Grape do
     ])
   end
 
-  it 'should support namespaces and versioning' do
+  it 'supports namespaces and versioning' do
     get '/api/v1/sub/versioned.txt'
     expect(last_response.status).to eq(200)
     expect(last_response.body).to eq('OK')
@@ -59,7 +58,7 @@ describe Datadog::Notifications::Plugins::Grape do
     ])
   end
 
-  it 'should support deep nesting' do
+  it 'supports deep nesting' do
     get '/sub/secure/resource'
     expect(last_response.status).to eq(403)
     expect(last_response.body).to eq('forbidden')
@@ -70,7 +69,7 @@ describe Datadog::Notifications::Plugins::Grape do
     ])
   end
 
-  it 'should handle rescued errors' do
+  it 'handles rescued errors' do
     get '/rescued'
     expect(last_response.status).to eq(401)
 
@@ -80,7 +79,7 @@ describe Datadog::Notifications::Plugins::Grape do
     ])
   end
 
-  it 'should handle invalid method' do
+  it 'handles invalid method' do
     post '/rescued'
 
     expect(last_response.status).to eq(405)
@@ -90,11 +89,10 @@ describe Datadog::Notifications::Plugins::Grape do
     ])
   end
 
-  it 'should not report paths on 404s' do
+  it 'does not report paths on 404s' do
     get '/sub/missing'
     expect(last_response.status).to eq(404)
 
     expect(buffered).to eq([])
   end
-
 end

data/spec/datadog/notifications_spec.rb

@@ -1,8 +1,8 @@
 require 'spec_helper'
 
 describe Datadog::Notifications do
-
   subject { described_class.instance }
+
   after   { ActiveSupport::Notifications.unsubscribe(subscription) }
 
   let!(:subscription) do
@@ -18,16 +18,15 @@ describe Datadog::Notifications do
     end
   end
 
-  it 'should have a reporter' do
+  it 'has a reporter' do
     expect(subject.send(:reporter)).to be_instance_of(Mock::Reporter)
   end
 
-  it 'should subscribe and report' do
+  it 'subscribes and report' do
     Mock::Instrumentable.new(method: 'GET').perform
     expect(buffered).to eq([
       'web.render:1|c|#custom:tag,env:test,host:test.host,status:200,method:GET',
       'web.render.time:333|ms|#custom:tag,env:test,host:test.host,status:200,method:GET',
     ])
   end
-
 end

data/spec/spec_helper.rb

@@ -6,6 +6,7 @@ require 'rspec'
 require 'rack/test'
 require 'grape'
 require 'active_record'
+require 'active_job'
 require 'sqlite3'
 
 ### Active-record test preparation
@@ -18,12 +19,20 @@ end
 class Post < ActiveRecord::Base
 end
 
+### Active-job test preparation
+
+ActiveJob::Base.queue_adapter = :inline
+class NoopJob < ActiveJob::Base
+  self.queue_name = 'test:queue'
+  def perform; end
+end
+
 ### Mocks
 
 module Mock
   class Reporter < Datadog::Notifications::Reporter
-    def timing(stat, _millis, opts={})
-      super(stat, 333, opts)
+    def timing(stat, _millis, **opts)
+      super(stat, 333, **opts)
     end
 
     def send_stat(message)
@@ -36,7 +45,7 @@ module Mock
   end
 
   class Instrumentable
-    def initialize(opts={})
+    def initialize(**opts)
       @opts = opts
     end
 
@@ -70,14 +79,15 @@ Datadog::Notifications.configure do |c|
   c.tags     = ['custom:tag']
 
   c.use Datadog::Notifications::Plugins::ActiveRecord
+  c.use Datadog::Notifications::Plugins::ActiveJob
   c.use Datadog::Notifications::Plugins::Grape,
-    tags: ['more:tags'],
-    metric_name: 'api.request',
-    exception_handler: lambda {|e|
-      if e.message.include?('unauthorized')
-        401
-      else
-        Datadog::Notifications::Plugins::Grape.exception_status(e)
-      end
-    }
+        tags: ['more:tags'],
+        metric_name: 'api.request',
+        exception_handler: lambda {|e|
+          if e.message.include?('unauthorized')
+            401
+          else
+            Datadog::Notifications::Plugins::Grape.exception_status(e)
+          end
+        }
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: datadog-notifications
 version: !ruby/object:Gem::Version
-  version: 0.6.2
+  version: 0.6.7
 platform: ruby
 authors:
 - Dimitrij Denissenko
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-02 00:00:00.000000000 Z
+date: 2021-07-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -30,7 +30,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '4.8'
     - - "<"
       - !ruby/object:Gem::Version
         version: '5.0'
@@ -40,10 +40,24 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '4.8'
     - - "<"
       - !ruby/object:Gem::Version
         version: '5.0'
+- !ruby/object:Gem::Dependency
+  name: activejob
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
@@ -129,7 +143,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: rubocop-bsm
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -164,10 +178,9 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".editorconfig"
+- ".github/workflows/ruby.yml"
 - ".gitignore"
-- ".rake_tasks~"
 - ".rubocop.yml"
-- ".travis.yml"
 - Gemfile
 - Gemfile.lock
 - MIT-LICENCE
@@ -187,6 +200,7 @@ files:
 - lib/datadog/notifications/reporter.rb
 - lib/datadog/notifications/version.rb
 - spec/datadog/notifications/config_spec.rb
+- spec/datadog/notifications/plugins/active_job_spec.rb
 - spec/datadog/notifications/plugins/active_record_spec.rb
 - spec/datadog/notifications/plugins/grape_spec.rb
 - spec/datadog/notifications_spec.rb
@@ -202,19 +216,20 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.5'
+      version: '2.6'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
+rubygems_version: 3.2.15
 signing_key: 
 specification_version: 4
 summary: Generic ActiveSupport::Notifications Datadog handler
 test_files:
 - spec/datadog/notifications/config_spec.rb
+- spec/datadog/notifications/plugins/active_job_spec.rb
 - spec/datadog/notifications/plugins/active_record_spec.rb
 - spec/datadog/notifications/plugins/grape_spec.rb
 - spec/datadog/notifications_spec.rb

data/.rake_tasks~

@@ -1,9 +0,0 @@
-build
-clean
-clobber
-install
-install:local
-release[remote]
-rubocop
-rubocop:auto_correct
-spec

data/.travis.yml

@@ -1,8 +0,0 @@
-cache: bundler
-language: ruby
-before_install:
-  - gem install bundler
-rvm:
-  - 2.7
-  - 2.6
-  - 2.5