datadog-notifications 0.4.6 → 0.4.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 69c40e89aa06bcf6fd1b0f04cbf0dd21cc481e29
-  data.tar.gz: 67577d7cab57a349dd0c9baeadffcf84306495a4
+  metadata.gz: 1ceb379035ce65c48cb6d992e1a0294da716fbcc
+  data.tar.gz: 79930ea901deedc8d5087a58d636a2f10e00b2df
 SHA512:
-  metadata.gz: '025799052026b754667d0a964406e88150e4ce1a8db4c5c26cfc267a0f163b243416fb71b9e858b0376db6768001433d098c3ef1c44368a430662c529ff198b0'
-  data.tar.gz: 05ec7ea5b5e0d42d61a1e32804d76ef3fa0659dd0d614e2974872ea1e53fb050d26e162537261d9c2a6796cec633340207571246927381d06658be029210f756
+  metadata.gz: ed1ec2c0bc244a56c0af5796a61f2363206c1b74fc3bf590d8c3ef9bdcbacdbd08d71ca1693c32fb9234287f749d7afdacc64b30a3db97b2b757475f49f1a3cf
+  data.tar.gz: c0a76f2f10812c86984ec37e173cc66d5c0c432a7bc006f473cd3469f2519c71c5206b9821f194363f740c295acd5411ffe9a10627db3968ab70e05bff807c85

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    datadog-notifications (0.4.6)
+    datadog-notifications (0.4.7)
       activesupport
       dogstatsd-ruby (~> 3.0.0)
 

data/lib/datadog/notifications/config.rb

@@ -20,7 +20,9 @@ module Datadog
       def connect!
         env = ENV['RAILS_ENV'] || ENV['RACK_ENV']
         tags.push("env:#{env}")       if env && tags.none? {|t| t =~ /^env\:/ }
-        tags.push("host:#{hostname}") if tags.none? {|t| t =~ /^host\:/ }
+
+        enable_hostname = hostname && hostname != 'false'
+        tags.push("host:#{hostname}") if enable_hostname && tags.none? {|t| t =~ /^host\:/ }
 
         reporter.new statsd_host, statsd_port, namespace: namespace, tags: tags
       end

data/lib/datadog/notifications/version.rb

@@ -1,5 +1,5 @@
 module Datadog
   class Notifications
-    VERSION = "0.4.6"
+    VERSION = "0.4.7"
   end
 end

data/spec/datadog/notifications/config_spec.rb

@@ -12,6 +12,21 @@ describe Datadog::Notifications::Config do
     expect(subject.tags).to eq(["custom:tag", "env:test", "host:test.host"])
   end
 
+  RSpec.shared_examples 'host tag is not picked up' do |hostname|
+    it 'should not pick up the host tag' do
+      subject.reporter = Mock::Reporter
+      subject.hostname = hostname
+      subject.tags = ["custom:tag"]
+
+      client = subject.send(:connect!)
+      expect(client).to be_instance_of(Mock::Reporter)
+      expect(subject.tags).to eq(["custom:tag", "env:test"])
+    end
+  end
+
+  include_examples 'host tag is not picked up', false
+  include_examples 'host tag is not picked up', 'false'
+
   it 'should instantiate plugins on use' do
     subject.use Datadog::Notifications::Plugins::ActionController
     expect(subject.plugins.size).to eq(1)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: datadog-notifications
 version: !ruby/object:Gem::Version
-  version: 0.4.6
+  version: 0.4.7
 platform: ruby
 authors:
 - Dimitrij Denissenko