datadog-ci 1.23.2 → 1.23.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 660ce0996ea0998e1074ca1f3671b00b74659b31520486c0fec7f850cf619c40
-  data.tar.gz: b3fa584967668ee53d4f66b9c4963236b1fbe58367f4833bf1436064a5112773
+  metadata.gz: a911ce98b1577d684374a00e8efd9ecbcf34fac28f24bb543411dbb762163d8c
+  data.tar.gz: 93c277bf2fc40ccdede20e48102eb6b1c1721336d80b62e60c9a191b807f8754
 SHA512:
-  metadata.gz: 8c99eab8f2b7f6367627746f94cb1338e77000791f89a96767f23572c43d13d96384b7f9b85c494d64bbef34dbbc0659123b31df14976a1de973075ce7bcb657
-  data.tar.gz: 5eab6749fe723823f6bcade1f946e9669924b3299219b7a9e67c1db1b8ac12483ffb910aedbd4be145839dd7a17ac0527d95ec36358cd2f2cee82387b6d136b9
+  metadata.gz: eb8fef68d0b4e9e6dc02aa76c603b98e854b09ef47913c30c986d4e397e9b48c79ec14d5ebb9dd1e48db0737def7d73f7e33aefbb35039441e65b4005884051a
+  data.tar.gz: 072aa07eb4af30102c588a54c75398634e1b409cd1698a087b8e0cb030bc6bb6c5bd8b98ba2c57716e8d819b61ace6ed9ed4ea39a5eda0e1accedc0e232a1eaf

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 ## [Unreleased]
 
+## [1.23.3] - 2025-11-19
+
+### Fixed
+
+* Fix nil error for test discovery component by introducing NullObject pattern for all components of Datadog Test Optimization ([#430][])
+
 ## [1.23.2] - 2025-11-18
 
 ### Added
@@ -548,7 +554,8 @@ Currently test suite level visibility is not used by our instrumentation: it wil
 
 - Ruby versions < 2.7 no longer supported ([#8][])
 
-[Unreleased]: https://github.com/DataDog/datadog-ci-rb/compare/v1.23.2...main
+[Unreleased]: https://github.com/DataDog/datadog-ci-rb/compare/v1.23.3...main
+[1.23.3]: https://github.com/DataDog/datadog-ci-rb/compare/v1.23.2...v1.23.3
 [1.23.2]: https://github.com/DataDog/datadog-ci-rb/compare/v1.23.1...v1.23.2
 [1.23.1]: https://github.com/DataDog/datadog-ci-rb/compare/v1.23.0...v1.23.1
 [1.23.0]: https://github.com/DataDog/datadog-ci-rb/compare/v1.22.1...v1.23.0
@@ -778,4 +785,5 @@ Currently test suite level visibility is not used by our instrumentation: it wil
 [#414]: https://github.com/DataDog/datadog-ci-rb/issues/414
 [#416]: https://github.com/DataDog/datadog-ci-rb/issues/416
 [#418]: https://github.com/DataDog/datadog-ci-rb/issues/418
-[#425]: https://github.com/DataDog/datadog-ci-rb/issues/425
+[#425]: https://github.com/DataDog/datadog-ci-rb/issues/425
+[#430]: https://github.com/DataDog/datadog-ci-rb/issues/430

data/lib/datadog/ci/configuration/components.rb

@@ -5,18 +5,22 @@ require "datadog/core/telemetry/ext"
 require_relative "../ext/settings"
 require_relative "../git/tree_uploader"
 require_relative "../impacted_tests_detection/component"
+require_relative "../impacted_tests_detection/null_component"
 require_relative "../logs/component"
 require_relative "../logs/transport"
+require_relative "../remote/null_component"
 require_relative "../remote/component"
 require_relative "../remote/library_settings_client"
 require_relative "../test_management/component"
 require_relative "../test_management/null_component"
 require_relative "../test_management/tests_properties"
+require_relative "../test_optimisation/null_component"
 require_relative "../test_optimisation/component"
 require_relative "../test_optimisation/coverage/transport"
 require_relative "../test_retries/component"
 require_relative "../test_retries/null_component"
 require_relative "../test_discovery/component"
+require_relative "../test_discovery/null_component"
 require_relative "../test_visibility/component"
 require_relative "../test_visibility/flush"
 require_relative "../test_visibility/known_tests"
@@ -41,14 +45,14 @@ module Datadog
           :test_management, :agentless_logs_submission, :impacted_tests_detection, :test_discovery
 
         def initialize(settings)
-          @test_optimisation = nil
+          @test_optimisation = TestOptimisation::NullComponent.new
           @test_visibility = TestVisibility::NullComponent.new
           @git_tree_upload_worker = DummyWorker.new
-          @ci_remote = nil
+          @ci_remote = Remote::NullComponent.new
           @test_retries = TestRetries::NullComponent.new
           @test_management = TestManagement::NullComponent.new
-          @impacted_tests_detection = nil
-          @test_discovery = nil
+          @impacted_tests_detection = ImpactedTestsDetection::NullComponent.new
+          @test_discovery = TestDiscovery::NullComponent.new
 
           # Activate CI mode if enabled
           if settings.ci.enabled

data/lib/datadog/ci/contrib/rspec/runner.rb

@@ -18,8 +18,10 @@ module Datadog
             def run_specs(*args)
               return super unless datadog_configuration[:enabled]
 
-              if test_discovery_component.enabled?
-                discover_tests
+              discovery_component = test_discovery_component
+
+              if discovery_component&.enabled?
+                discover_tests(discovery_component)
 
                 # don't run the tests, we just needed to discover them and now we can return
                 return
@@ -74,15 +76,15 @@ module Datadog
               Datadog.send(:components).test_discovery
             end
 
-            def discover_tests
-              test_discovery_component.start
+            def discover_tests(component)
+              component.start
 
               examples = ::RSpec.world.all_examples
 
               examples.each do |example|
                 next if example.metadata[:skip]
 
-                test_discovery_component.record_test(
+                component.record_test(
                   name: example.datadog_test_name,
                   suite: example.datadog_test_suite_name,
                   parameters: example.datadog_test_parameters,
@@ -91,7 +93,7 @@ module Datadog
                 )
               end
 
-              test_discovery_component.finish
+              component.finish
             end
           end
         end

data/lib/datadog/ci/impacted_tests_detection/null_component.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+module Datadog
+  module CI
+    module ImpactedTestsDetection
+      # Null object used when impacted tests detection is unavailable
+      class NullComponent
+        def configure(_library_settings = nil, _test_session = nil)
+        end
+
+        def enabled?
+          false
+        end
+
+        def modified?(_test_span)
+          false
+        end
+
+        def tag_modified_test(_test_span)
+        end
+      end
+    end
+  end
+end

data/lib/datadog/ci/remote/null_component.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+module Datadog
+  module CI
+    module Remote
+      # No-op implementation used when remote configuration is disabled.
+      class NullComponent
+        def configure(_test_session)
+        end
+      end
+    end
+  end
+end

data/lib/datadog/ci/test_discovery/null_component.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+
+module Datadog
+  module CI
+    module TestDiscovery
+      # Null object used when test discovery component is unavailable
+      class NullComponent
+        def configure(_library_settings = nil, _test_session = nil)
+        end
+
+        def disable_features_for_test_discovery!(_settings = nil)
+        end
+
+        def start
+        end
+
+        def finish
+        end
+
+        def record_test(name:, suite:, module_name:, parameters:, source_file:)
+        end
+
+        def shutdown!
+        end
+
+        def enabled?
+          false
+        end
+      end
+    end
+  end
+end

data/lib/datadog/ci/test_optimisation/null_component.rb

@@ -0,0 +1,66 @@
+# frozen_string_literal: true
+
+require "set"
+
+module Datadog
+  module CI
+    module TestOptimisation
+      # No-op implementation used when test optimisation is disabled.
+      class NullComponent
+        attr_reader :enabled, :skippable_tests_fetch_error, :test_skipping_enabled,
+          :code_coverage_enabled, :skippable_tests, :correlation_id
+
+        def initialize
+          @enabled = false
+          @test_skipping_enabled = false
+          @code_coverage_enabled = false
+          @skippable_tests_fetch_error = nil
+          @skippable_tests = Set.new
+          @correlation_id = nil
+        end
+
+        def configure(_remote_configuration = nil, _test_session = nil)
+        end
+
+        def enabled?
+          false
+        end
+
+        def skipping_tests?
+          false
+        end
+
+        def code_coverage?
+          false
+        end
+
+        def start_coverage(_test)
+        end
+
+        def stop_coverage(_test)
+          nil
+        end
+
+        def mark_if_skippable(_test)
+        end
+
+        def skippable?(_datadog_test_id)
+          false
+        end
+
+        def on_test_finished(_test, _context)
+        end
+
+        def write_test_session_tags(_test_session, _skipped_tests_count)
+        end
+
+        def skippable_tests_count
+          0
+        end
+
+        def shutdown!
+        end
+      end
+    end
+  end
+end

data/lib/datadog/ci/version.rb

@@ -5,7 +5,7 @@ module Datadog
     module VERSION
       MAJOR = 1
       MINOR = 23
-      PATCH = 2
+      PATCH = 3
       PRE = nil
       BUILD = nil
       # PRE and BUILD above are modified for dev gems during gem build GHA workflow
@@ -22,7 +22,7 @@ module Datadog
       # To allow testing with the next unreleased version of Ruby, the version check is performed
       # as `< #{MAXIMUM_RUBY_VERSION}`, meaning prereleases of MAXIMUM_RUBY_VERSION are allowed
       # but not stable MAXIMUM_RUBY_VERSION releases.
-      MAXIMUM_RUBY_VERSION = "3.5"
+      MAXIMUM_RUBY_VERSION = "4.0"
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: datadog-ci
 version: !ruby/object:Gem::Version
-  version: 1.23.2
+  version: 1.23.3
 platform: ruby
 authors:
 - Datadog, Inc.
@@ -211,6 +211,7 @@ files:
 - lib/datadog/ci/git/upload_packfile.rb
 - lib/datadog/ci/git/user.rb
 - lib/datadog/ci/impacted_tests_detection/component.rb
+- lib/datadog/ci/impacted_tests_detection/null_component.rb
 - lib/datadog/ci/logs/component.rb
 - lib/datadog/ci/logs/transport.rb
 - lib/datadog/ci/readonly_test_module.rb
@@ -218,10 +219,12 @@ files:
 - lib/datadog/ci/remote/component.rb
 - lib/datadog/ci/remote/library_settings.rb
 - lib/datadog/ci/remote/library_settings_client.rb
+- lib/datadog/ci/remote/null_component.rb
 - lib/datadog/ci/remote/slow_test_retries.rb
 - lib/datadog/ci/span.rb
 - lib/datadog/ci/test.rb
 - lib/datadog/ci/test_discovery/component.rb
+- lib/datadog/ci/test_discovery/null_component.rb
 - lib/datadog/ci/test_management/component.rb
 - lib/datadog/ci/test_management/null_component.rb
 - lib/datadog/ci/test_management/tests_properties.rb
@@ -230,6 +233,7 @@ files:
 - lib/datadog/ci/test_optimisation/coverage/ddcov.rb
 - lib/datadog/ci/test_optimisation/coverage/event.rb
 - lib/datadog/ci/test_optimisation/coverage/transport.rb
+- lib/datadog/ci/test_optimisation/null_component.rb
 - lib/datadog/ci/test_optimisation/skippable.rb
 - lib/datadog/ci/test_optimisation/skippable_percentage/base.rb
 - lib/datadog/ci/test_optimisation/skippable_percentage/calculator.rb
@@ -311,7 +315,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 2.7.0
   - - "<"
     - !ruby/object:Gem::Version
-      version: '3.5'
+      version: '4.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="