datacatalog 0.2.4 → 0.3.0

data/spec/base_spec.rb

@@ -1,129 +1,129 @@
-require File.dirname(__FILE__) + '/spec_helper'
-include DataCatalog
-
-describe Base do
-
-  before do
-    setup_api
-  end
-
-  describe ".base_uri=" do
-    it "should set and normalize the base URI" do
-      setup_api
-      DataCatalog.base_uri = 'host.com'
-      DataCatalog.base_uri.should == 'http://host.com'
-    end
-    
-    it "should set the base URI to the default if it's not explicitly defined" do
-      DataCatalog.base_uri = ''
-      DataCatalog.base_uri.should == 'http://api.nationaldatacatalog.com'
-      Base.base_uri.should == 'http://api.nationaldatacatalog.com'
-    end
-  end
-
-  describe ".check_status" do
-    it "should return nil on 200 OK" do
-      response = HTTParty::Response.new(nil, '{"foo":"bar"}', 200, 'OK', {})
-      Base.check_status(response).should be_nil
-    end
-    
-    it "should raise BadRequest on 400 Bad Request" do
-      response = HTTParty::Response.new(nil, '[]', 400, 'Bad Request', {})
-      executing do
-        Base.check_status(response)
-      end.should raise_error(BadRequest)
-    end
-  
-    it "should raise Unauthorized on 401 Unauthorized" do
-      response = HTTParty::Response.new(nil, '', 401, 'Unauthorized', {})
-      executing do
-        Base.check_status(response)
-      end.should raise_error(Unauthorized)
-    end
-  
-    it "should raise NotFound on 404 Not Found" do
-      response = HTTParty::Response.new(nil, '[]', 404, 'Not Found', {})
-      executing do
-        Base.check_status(response)
-      end.should raise_error(NotFound)
-    end
-    
-    it "should raise InternalServerError on 500 Internal Server Error" do
-      response = HTTParty::Response.new(nil, '', 500, 'Internal Server Error', {})
-      executing do
-        Base.check_status(response)
-      end.should raise_error(InternalServerError)
-    end
-  end
-
-  describe ".error" do
-    it "should return an 'Unable to parse:' message when body is blank" do
-      response = HTTParty::Response.new(nil, '', 404, 'Not Found', {})
-      Base.error(response).should == %(Unable to parse: "")
-    end
-    
-    it "should return 'Response was empty' when body is an empty JSON object" do
-      response = HTTParty::Response.new(nil, '{}', 404, 'Not Found', {})
-      Base.error(response).should == "Response was empty"
-    end
-    
-    it "should return 'Response was empty' when body is an empty array" do
-      response = HTTParty::Response.new(nil, '[]', 404, 'Not Found', {})
-      Base.error(response).should == "Response was empty"
-    end
-    
-    it "should return the contents of the errors hash when it exists" do
-      errors = '{"errors":["bad_error"]}'
-      response = HTTParty::Response.new(nil, errors, 400, 'Bad Request', {})
-      Base.error(response).should == '["bad_error"]'
-    end
-    
-    it "should return the contents of the response body when no errors hash exists" do
-      errors = '{"foo":["bar"]}'
-      response = HTTParty::Response.new(nil, errors, 400, 'Bad Request', {})
-      Base.error(response).should == '{"foo":["bar"]}'
-    end
-  end
-
-  describe ".many" do
-    it "should create an object from a filled array" do
-      array = Base.many([
-        {
-          :name  => "Carl Malamud",
-          :email => "no-spam-carl@media.org"
-        },
-        {
-          :name  => "Ellen Miller",
-          :email => "no-spam-ellen@sunlightfoundation.com"
-        }
-      ])
-      array.map do |item|
-        item.should be_an_instance_of(Base)
-      end
-      array.map(&:name).should == ["Carl Malamud", "Ellen Miller"]
-    end    
-  end
-
-  describe ".one" do
-    it "should create an object from a filled hash" do
-      hash = Base.one({
-        :name  => "John Smith",
-        :email => "john@email.com"
-      })
-      hash.should be_an_instance_of(Base)
-      hash.name.should == "John Smith"
-      hash.email.should == "john@email.com"
-    end
-    
-    it "should return nil from an empty hash" do
-      hash = Base.one({})
-      hash.should be_nil
-    end
-    
-    it "should return nil from nil" do
-      hash = Base.one(nil)
-      hash.should be_nil
-    end
-  end
-
-end
+require File.dirname(__FILE__) + '/spec_helper'
+include DataCatalog
+
+describe Base do
+
+  before do
+    setup_api
+  end
+
+  describe ".base_uri=" do
+    it "should set and normalize the base URI" do
+      setup_api
+      DataCatalog.base_uri = 'host.com'
+      DataCatalog.base_uri.should == 'http://host.com'
+    end
+    
+    it "should set the base URI to the default if it's not explicitly defined" do
+      DataCatalog.base_uri = ''
+      DataCatalog.base_uri.should == 'http://api.nationaldatacatalog.com'
+      Base.base_uri.should == 'http://api.nationaldatacatalog.com'
+    end
+  end
+
+  describe ".check_status" do
+    it "should return nil on 200 OK" do
+      response = HTTParty::Response.new(nil, '{"foo":"bar"}', 200, 'OK', {})
+      Base.check_status(response).should be_nil
+    end
+    
+    it "should raise BadRequest on 400 Bad Request" do
+      response = HTTParty::Response.new(nil, '[]', 400, 'Bad Request', {})
+      executing do
+        Base.check_status(response)
+      end.should raise_error(BadRequest)
+    end
+  
+    it "should raise Unauthorized on 401 Unauthorized" do
+      response = HTTParty::Response.new(nil, '', 401, 'Unauthorized', {})
+      executing do
+        Base.check_status(response)
+      end.should raise_error(Unauthorized)
+    end
+  
+    it "should raise NotFound on 404 Not Found" do
+      response = HTTParty::Response.new(nil, '[]', 404, 'Not Found', {})
+      executing do
+        Base.check_status(response)
+      end.should raise_error(NotFound)
+    end
+    
+    it "should raise InternalServerError on 500 Internal Server Error" do
+      response = HTTParty::Response.new(nil, '', 500, 'Internal Server Error', {})
+      executing do
+        Base.check_status(response)
+      end.should raise_error(InternalServerError)
+    end
+  end
+
+  describe ".error" do
+    it "should return an 'Unable to parse:' message when body is blank" do
+      response = HTTParty::Response.new(nil, '', 404, 'Not Found', {})
+      Base.error(response).should == %(Unable to parse: "")
+    end
+    
+    it "should return 'Response was empty' when body is an empty JSON object" do
+      response = HTTParty::Response.new(nil, '{}', 404, 'Not Found', {})
+      Base.error(response).should == "Response was empty"
+    end
+    
+    it "should return 'Response was empty' when body is an empty array" do
+      response = HTTParty::Response.new(nil, '[]', 404, 'Not Found', {})
+      Base.error(response).should == "Response was empty"
+    end
+    
+    it "should return the contents of the errors hash when it exists" do
+      errors = '{"errors":["bad_error"]}'
+      response = HTTParty::Response.new(nil, errors, 400, 'Bad Request', {})
+      Base.error(response).should == '["bad_error"]'
+    end
+    
+    it "should return the contents of the response body when no errors hash exists" do
+      errors = '{"foo":["bar"]}'
+      response = HTTParty::Response.new(nil, errors, 400, 'Bad Request', {})
+      Base.error(response).should == '{"foo":["bar"]}'
+    end
+  end
+
+  describe ".many" do
+    it "should create an object from a filled array" do
+      array = Base.many([
+        {
+          :name  => "Carl Malamud",
+          :email => "no-spam-carl@media.org"
+        },
+        {
+          :name  => "Ellen Miller",
+          :email => "no-spam-ellen@sunlightfoundation.com"
+        }
+      ])
+      array.map do |item|
+        item.should be_an_instance_of(Base)
+      end
+      array.map(&:name).should == ["Carl Malamud", "Ellen Miller"]
+    end    
+  end
+
+  describe ".one" do
+    it "should create an object from a filled hash" do
+      hash = Base.one({
+        :name  => "John Smith",
+        :email => "john@email.com"
+      })
+      hash.should be_an_instance_of(Base)
+      hash.name.should == "John Smith"
+      hash.email.should == "john@email.com"
+    end
+    
+    it "should return nil from an empty hash" do
+      hash = Base.one({})
+      hash.should be_nil
+    end
+    
+    it "should return nil from nil" do
+      hash = Base.one(nil)
+      hash.should be_nil
+    end
+  end
+
+end

data/spec/datacatalog_spec.rb

@@ -1,36 +1,36 @@
-require File.dirname(__FILE__) + '/spec_helper'
-include DataCatalog
-
-describe DataCatalog do
-
-  describe "module accessors" do
-    it "should access the API Key" do
-      DataCatalog.api_key = "4159179f32ff8fefd2c6d48b7e675e7736bf1357"
-      DataCatalog.api_key.should == "4159179f32ff8fefd2c6d48b7e675e7736bf1357"
-    end
-
-    it "should access the base URI" do
-      DataCatalog.base_uri = 'http://somehost.com'
-      DataCatalog.base_uri.should == 'http://somehost.com'
-    end
-  end
-
-  describe ".with_key" do
-    it "should set the API key within the block" do
-      regular_key = '4159179f32ff8fefd2c6d48b7e675e7736bf1357'
-      DataCatalog.api_key = regular_key
-      temporary_key = '0000123400001234000012340000123400001234'
-      DataCatalog.with_key(temporary_key) do
-        DataCatalog.api_key.should == temporary_key
-      end
-      DataCatalog.api_key.should == regular_key
-    end
-    
-    it "should return the last value in the block" do
-      DataCatalog.with_key("0000444400004444") do
-        42
-      end.should == 42
-    end
-  end
-
-end
+require File.dirname(__FILE__) + '/spec_helper'
+include DataCatalog
+
+describe DataCatalog do
+
+  describe "module accessors" do
+    it "should access the API Key" do
+      DataCatalog.api_key = "4159179f32ff8fefd2c6d48b7e675e7736bf1357"
+      DataCatalog.api_key.should == "4159179f32ff8fefd2c6d48b7e675e7736bf1357"
+    end
+
+    it "should access the base URI" do
+      DataCatalog.base_uri = 'http://somehost.com'
+      DataCatalog.base_uri.should == 'http://somehost.com'
+    end
+  end
+
+  describe ".with_key" do
+    it "should set the API key within the block" do
+      regular_key = '4159179f32ff8fefd2c6d48b7e675e7736bf1357'
+      DataCatalog.api_key = regular_key
+      temporary_key = '0000123400001234000012340000123400001234'
+      DataCatalog.with_key(temporary_key) do
+        DataCatalog.api_key.should == temporary_key
+      end
+      DataCatalog.api_key.should == regular_key
+    end
+    
+    it "should return the last value in the block" do
+      DataCatalog.with_key("0000444400004444") do
+        42
+      end.should == 42
+    end
+  end
+
+end

data/spec/source_spec.rb

@@ -1,162 +1,162 @@
-require File.dirname(__FILE__) + '/spec_helper'
-include DataCatalog
-
-module SourceHelpers
-  def create_source(params={})
-    valid_params = {
-      :title => "Some FCC Data",
-      :url   => "http://fcc.gov/somedata.csv"
-    }
-    Source.create(valid_params.merge(params))
-  end
-
-  def create_3_sources
-    %w(FCC NASA DOE).each do |name|
-      Source.create({
-        :title => "#{name} Data",
-        :url   => "http://#{name.downcase}.gov/data.xml"
-      })
-    end
-  end
-end
-
-describe Source do
-  include SourceHelpers
-
-  before do
-    setup_api
-    clean_slate
-  end
-
-  describe ".all" do
-    before do
-      create_3_sources
-      @sources = Source.all
-    end
-  
-    it "should return an enumeration of sources" do
-      @sources.each do |source|
-        source.should be_an_instance_of(Source)
-      end
-    end
-  
-    it "should return correct titles" do
-      expected = ["FCC Data", "NASA Data", "DOE Data"]
-      @sources.map(&:title).sort.should == expected.sort
-    end
-  end
-
-  describe ".all with conditions" do
-    before do
-      create_3_sources
-      @sources = Source.all(:title => "NASA Data")
-    end
-    
-    it "should return an enumeration of sources" do
-      @sources.each do |source|
-        source.should be_an_instance_of(Source)
-      end
-    end
-    
-    it "should return correct titles" do
-      expected = ["NASA Data"]
-      @sources.map(&:title).sort.should == expected.sort
-    end
-  end
-
-  describe ".create" do
-    it "should create a new source from basic params" do
-      source = create_source
-      source.should be_an_instance_of(Source)
-      source.url.should == "http://fcc.gov/somedata.csv"
-    end
-    
-    it "should create a new source from custom params" do
-      source = create_source({ :custom => {
-        "0" => {
-          :label       => "License",
-          :description => "License",
-          :type        => "string",
-          :value       => "Public Domain"
-        }
-      }})
-      source.should be_an_instance_of(Source)
-      source.url.should == "http://fcc.gov/somedata.csv"
-      source.custom.should == {
-        "0" => {
-          "label"       => "License",
-          "description" => "License",
-          "type"        => "string",
-          "value"       => "Public Domain"
-        }
-      }
-    end
-  end
-  
-  describe ".first" do
-    before do
-      create_3_sources
-    end
-  
-    it "should return a source" do
-      source = Source.first(:title => "NASA Data")
-      source.should be_an_instance_of(Source)
-      source.title.should == "NASA Data"
-    end
-    
-    it "should return nil if nothing found" do
-      source = Source.first(:title => "UFO Data")
-      source.should be_nil
-    end
-  end
-  
-  describe ".get" do
-    before do
-      @source = create_source
-    end
-  
-    it "should return a source" do
-      source = Source.get(@source.id)
-      source.should be_an_instance_of(Source)
-      source.title.should == "Some FCC Data"
-    end
-    
-    it "should raise NotFound if no source exists" do
-      executing do
-        Source.get(mangle(@source.id))
-      end.should raise_error(NotFound)
-    end
-  end
-  
-  describe ".update" do
-    before do
-      @source = create_source
-    end
-  
-    it "should update an existing source from valid params" do
-      source = Source.update(@source.id, {
-        :url => "http://fec.gov/newdata.csv"
-      })
-      source.should be_an_instance_of(Source)
-      source.url.should == "http://fec.gov/newdata.csv"
-    end
-  end
-  
-  describe ".destroy" do
-    before do
-      @source = create_source
-    end
-  
-    it "should destroy an existing source" do
-      result = Source.destroy(@source.id)
-      result.should be_true
-    end
-    
-    it "should raise NotFound when attempting to destroy non-existing source" do
-      executing do
-        Source.destroy(mangle(@source.id))
-      end.should raise_error(NotFound)
-    end
-  end
-
-end
+require File.dirname(__FILE__) + '/spec_helper'
+include DataCatalog
+
+module SourceHelpers
+  def create_source(params={})
+    valid_params = {
+      :title => "Some FCC Data",
+      :url   => "http://fcc.gov/somedata.csv"
+    }
+    Source.create(valid_params.merge(params))
+  end
+
+  def create_3_sources
+    %w(FCC NASA DOE).each do |name|
+      Source.create({
+        :title => "#{name} Data",
+        :url   => "http://#{name.downcase}.gov/data.xml"
+      })
+    end
+  end
+end
+
+describe Source do
+  include SourceHelpers
+
+  before do
+    setup_api
+    clean_slate
+  end
+
+  describe ".all" do
+    before do
+      create_3_sources
+      @sources = Source.all
+    end
+  
+    it "should return an enumeration of sources" do
+      @sources.each do |source|
+        source.should be_an_instance_of(Source)
+      end
+    end
+  
+    it "should return correct titles" do
+      expected = ["FCC Data", "NASA Data", "DOE Data"]
+      @sources.map(&:title).sort.should == expected.sort
+    end
+  end
+
+  describe ".all with conditions" do
+    before do
+      create_3_sources
+      @sources = Source.all(:title => "NASA Data")
+    end
+    
+    it "should return an enumeration of sources" do
+      @sources.each do |source|
+        source.should be_an_instance_of(Source)
+      end
+    end
+    
+    it "should return correct titles" do
+      expected = ["NASA Data"]
+      @sources.map(&:title).sort.should == expected.sort
+    end
+  end
+
+  describe ".create" do
+    it "should create a new source from basic params" do
+      source = create_source
+      source.should be_an_instance_of(Source)
+      source.url.should == "http://fcc.gov/somedata.csv"
+    end
+    
+    it "should create a new source from custom params" do
+      source = create_source({ :custom => {
+        "0" => {
+          :label       => "License",
+          :description => "License",
+          :type        => "string",
+          :value       => "Public Domain"
+        }
+      }})
+      source.should be_an_instance_of(Source)
+      source.url.should == "http://fcc.gov/somedata.csv"
+      source.custom.should == {
+        "0" => {
+          "label"       => "License",
+          "description" => "License",
+          "type"        => "string",
+          "value"       => "Public Domain"
+        }
+      }
+    end
+  end
+  
+  describe ".first" do
+    before do
+      create_3_sources
+    end
+  
+    it "should return a source" do
+      source = Source.first(:title => "NASA Data")
+      source.should be_an_instance_of(Source)
+      source.title.should == "NASA Data"
+    end
+    
+    it "should return nil if nothing found" do
+      source = Source.first(:title => "UFO Data")
+      source.should be_nil
+    end
+  end
+  
+  describe ".get" do
+    before do
+      @source = create_source
+    end
+  
+    it "should return a source" do
+      source = Source.get(@source.id)
+      source.should be_an_instance_of(Source)
+      source.title.should == "Some FCC Data"
+    end
+    
+    it "should raise NotFound if no source exists" do
+      executing do
+        Source.get(mangle(@source.id))
+      end.should raise_error(NotFound)
+    end
+  end
+  
+  describe ".update" do
+    before do
+      @source = create_source
+    end
+  
+    it "should update an existing source from valid params" do
+      source = Source.update(@source.id, {
+        :url => "http://fec.gov/newdata.csv"
+      })
+      source.should be_an_instance_of(Source)
+      source.url.should == "http://fec.gov/newdata.csv"
+    end
+  end
+  
+  describe ".destroy" do
+    before do
+      @source = create_source
+    end
+  
+    it "should destroy an existing source" do
+      result = Source.destroy(@source.id)
+      result.should be_true
+    end
+    
+    it "should raise NotFound when attempting to destroy non-existing source" do
+      executing do
+        Source.destroy(mangle(@source.id))
+      end.should raise_error(NotFound)
+    end
+  end
+
+end