database_consistency 3.1.0 → 3.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c8a45e3403f929db1a3524719b0f955b06ac32c922136f5ee930d2eb2b70bdd0
-  data.tar.gz: cc864d1567c17eb3e546321c2d4a1448e2bfc02aec6b4ae25dc7a4f5e6eb5f50
+  metadata.gz: dd7ba14920b79a253aa4c1b603f4dde0478780f0a0a0b4342eb6a928b153545e
+  data.tar.gz: f655cf5cff2f43b0bef8986fa9617c7891b484f375e34289aaa585b3541f21cb
 SHA512:
-  metadata.gz: 25ef86b694af8d420c054b6e1a900803d1c577a5091470d274ca54c9880786a620379ccbdcab408c2f697d94878a53e94bd175e395e77d040c6c245105b2a141
-  data.tar.gz: 4cd6ea61d0a4243260b754677d1268d5fb4b207f3d0428c4af2db5d485b6dc8202cd9725aaa96696cd36497e0aaea130ea4a3c8a3fa06675f14b74be678bde84
+  metadata.gz: 3f52bb80a9d738cd62d4385027069b46ea1fd6c8f99fc8aeb161d0d5e75dff8e6004fe61abc0f76497d7dee9e7247ba0cd066018d1920ee23063b928363c25a4
+  data.tar.gz: 796243796d3e50f1aaa5dd750523be44c1db2c8736cf97720921435026b60283be024253e9972a7f2cedc2ed63ba0bdde3e991dcefb1bb88fe91c9a85a20c282

data/lib/database_consistency/checkers/association_checkers/missing_index_checker.rb

@@ -16,11 +16,13 @@ module DatabaseConsistency
       #  - association isn't a `HasOne` or `HasMany`
       #  - association has `through` option
       #  - associated class doesn't exist
+      #  - associated class's table doesn't exist
       def preconditions
         %i[
           has_one
           has_many
-        ].include?(association.macro) && association.through_reflection.nil? && association.klass
+        ].include?(association.macro) && association.through_reflection.nil? &&
+          association.klass.table_exists?
       rescue StandardError
         false
       end
@@ -39,7 +41,7 @@ module DatabaseConsistency
       end
 
       def check_unique_has_one
-        if unique_index
+        if unique_index || primary_key_columns.sort == association_keys
           report_template(:ok)
         else
           report_template(:fail, error_slug: :has_one_missing_unique_index)
@@ -47,7 +49,7 @@ module DatabaseConsistency
       end
 
       def check_remaining
-        if index
+        if index || primary_key_columns.first(association_keys.size).sort == association_keys
           report_template(:ok)
         else
           report_template(:fail, error_slug: :association_missing_index)
@@ -85,6 +87,13 @@ module DatabaseConsistency
         end
       end
 
+      # The primary key is an implicit unique index, so it covers the association as well.
+      def primary_key_columns
+        @primary_key_columns ||= Array(
+          association.klass.connection_pool.with_connection { |conn| conn.primary_key(association.klass.table_name) }
+        ).map(&:to_s)
+      end
+
       def association_keys
         @association_keys ||= [association.foreign_key, association.type].compact.map(&:to_s).sort
       end

data/lib/database_consistency/helper.rb

@@ -66,7 +66,11 @@ module DatabaseConsistency
     def project_klass?(klass)
       return true unless Module.respond_to?(:const_source_location) && defined?(Bundler)
 
-      !Module.const_source_location(klass.to_s).first.to_s.include?(Bundler.bundle_path.to_s)
+      source_path = Module.const_source_location(klass.to_s).first.to_s
+      bundle_path = Bundler.bundle_path
+      bundle_paths = [bundle_path]
+      bundle_paths << bundle_path.realpath if bundle_path.exist?
+      bundle_paths.none? { |path| source_path.include?(path.to_s) }
     rescue NameError
       false
     end

data/lib/database_consistency/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DatabaseConsistency
-  VERSION = '3.1.0'
+  VERSION = '3.1.1'
 end

data/lib/database_consistency/writers/simple/missing_foreign_key_cascade.rb

@@ -7,15 +7,22 @@ module DatabaseConsistency
         private
 
         def template
-          'should have a foreign key with on_delete: :%<cascade_option>s in the database'
+          'should have a foreign key %<cascade_option>s in the database'
         end
 
         def attributes
           {
-            cascade_option: report.cascade_option
+            cascade_option: cascade_option_text
           }
         end
 
+        # nil stands for a foreign key without an on_delete option
+        def cascade_option_text
+          options = report.cascade_option.compact.map { |option| "with on_delete: :#{option}" }
+          options << 'without on_delete' if report.cascade_option.include?(nil)
+          options.join(' or ')
+        end
+
         def unique_attributes
           {
             foreign_table: report.foreign_table,

data/lib/database_consistency/writers/simple_writer.rb

@@ -31,7 +31,7 @@ module DatabaseConsistency
         klass =
           if report.error_slug
             begin
-              "DatabaseConsistency::Writers::Simple::#{report.error_slug.to_s.classify}".constantize
+              "DatabaseConsistency::Writers::Simple::#{report.error_slug.to_s.camelize}".constantize
             rescue NameError
               Simple::DefaultMessage
             end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: database_consistency
 version: !ruby/object:Gem::Version
-  version: 3.1.0
+  version: 3.1.1
 platform: ruby
 authors:
 - Evgeniy Demin
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-10-20 00:00:00.000000000 Z
+date: 2026-10-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord