database_consistency 3.0.5 → 3.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f88fd56f01f639d5614fa82f5e76f6d4a4dfb05c04c246f5baeedf93fd01fe24
-  data.tar.gz: 0bb41479e542c995569b54a6cfc188ea39103c30a074560f0bae15f8223c1128
+  metadata.gz: d1a3f79e718dbab025a1077436d34a99f96441d4c38ea6eeab44b48a9d47017b
+  data.tar.gz: 3d923752051575203683bf72e4fa91d538e668d0f3259be1a3c85f078bd35fc8
 SHA512:
-  metadata.gz: 54baea922639aec00a1c1edb9aaef5e0d70ec91a2ce63552fcb2ab502b93c1a2779c3227fdb55c7cb03afd17a346624cfc192d84c07480583b44bba00554eea5
-  data.tar.gz: 69a60f5b359e2bfc89765756115e510646d6167fd2819da7f25451302c52f1f54c2c590e1a487eb2291c9e747a54e80bf4e193b9db506bc13f8cc7a580b0be8c
+  metadata.gz: 483695e3e1bfb73d833f71832f770e6783bab926c785bb54e097a0f527adc66a33112e7c83f3e7f1f849d5f0015d8f16e01bcff135d55933c683f76dbb58626d
+  data.tar.gz: f0686a44bb3fe3e842ad8b9f72a4b11801cad4745c389665d015bc0255529709b4b4f843d4a97a5064e5ede8643c3f5d36b800c2c4f63ad7b0f4bf6119544f4b

data/lib/database_consistency/checkers/association_checkers/polymorphic_association_nullability_checker.rb

@@ -0,0 +1,47 @@
+# frozen_string_literal: true
+
+module DatabaseConsistency
+  module Checkers
+    # This class checks that polymorphic association columns have matching null constraints
+    class PolymorphicAssociationNullabilityChecker < AssociationChecker
+      Report = ReportBuilder.define(
+        DatabaseConsistency::Report,
+        :foreign_key,
+        :foreign_type
+      )
+
+      private
+
+      def preconditions
+        association.belongs_to? && association.polymorphic? && foreign_key_column && foreign_type_column
+      end
+
+      def check
+        if foreign_key_column.null == foreign_type_column.null
+          report_template(:ok)
+        else
+          report_template(:fail, error_slug: :polymorphic_association_nullability_mismatch)
+        end
+      end
+
+      def report_template(status, error_slug: nil)
+        Report.new(
+          status: status,
+          error_slug: error_slug,
+          error_message: nil,
+          foreign_key: association.foreign_key.to_s,
+          foreign_type: association.foreign_type.to_s,
+          **report_attributes
+        )
+      end
+
+      def foreign_key_column
+        @foreign_key_column ||= model.columns_hash[association.foreign_key.to_s]
+      end
+
+      def foreign_type_column
+        @foreign_type_column ||= model.columns_hash[association.foreign_type.to_s]
+      end
+    end
+  end
+end

data/lib/database_consistency/checkers/index_checkers/redundant_unique_index_checker.rb

@@ -60,7 +60,7 @@ module DatabaseConsistency
 
       def contain_index?(another_index)
         another_index_columns = Helper.extract_index_columns(another_index.columns)
-        index_columns & another_index_columns == another_index_columns
+        (another_index_columns - index_columns).empty?
       end
 
       def index_columns

data/lib/database_consistency/checkers/validators_fraction_checkers/numericality_constraint_checker.rb

@@ -0,0 +1,71 @@
+# frozen_string_literal: true
+
+module DatabaseConsistency
+  module Checkers
+    # This class checks if numericality validator has check constraint in the database
+    class NumericalityConstraintChecker < ValidatorsFractionChecker
+      SQL_KEYWORDS = %w[
+        and or not null is true false in like between case when then else end check
+        exists select where having order group limit offset distinct all any some
+        from join on using as by union into values set update delete insert with
+      ].freeze
+      PLAIN_IDENTIFIER_PATTERN =
+        /\b([a-zA-Z_][a-zA-Z0-9_]*(?:\.[a-zA-Z_][a-zA-Z0-9_]*)?)\b(?!\s*\()/.freeze
+
+      private
+
+      def filter(validator)
+        validator.kind == :numericality
+      end
+
+      def preconditions
+        model.connection.respond_to?(:check_constraints) &&
+          model.connection.table_exists?(model.table_name) &&
+          column &&
+          validators.any?
+      end
+
+      def check
+        if check_constraint_for_column?
+          report_template(:ok)
+        else
+          report_template(:fail, error_slug: :numericality_check_constraint_missing)
+        end
+      end
+
+      def check_constraint_for_column?
+        check_constraints.any? do |constraint|
+          constraint_columns(constraint.expression).include?(column.name.downcase)
+        end
+      end
+
+      def check_constraints
+        @check_constraints ||= model.connection.check_constraints(model.table_name)
+      rescue StandardError
+        []
+      end
+
+      def constraint_columns(expression)
+        expression_sql = expression.to_s
+        # Captures identifiers in three forms:
+        # 1) "double quoted", 2) `backtick quoted`, 3) plain SQL identifiers.
+        # Plain identifiers followed by `(` are excluded to skip SQL function names.
+        quoted_identifiers = expression_sql.scan(/"([^"]+)"|`([^`]+)`/).flatten.compact
+        # Only the column part is needed for comparison, so `table.column` is
+        # reduced to `column`.
+        # `(?!\s*\()` excludes function names such as `ABS(`.
+        plain_identifiers = expression_sql.scan(PLAIN_IDENTIFIER_PATTERN)
+                                          .flatten
+                                          .map { |identifier| identifier.split('.').last }
+
+        (quoted_identifiers + plain_identifiers).map(&:downcase).reject do |identifier|
+          SQL_KEYWORDS.include?(identifier)
+        end
+      end
+
+      def column
+        @column ||= model.columns.find { |field| field.name == attribute.to_s }
+      end
+    end
+  end
+end

data/lib/database_consistency/helper.rb

@@ -156,12 +156,18 @@ module DatabaseConsistency
       nil
     end
 
-    # Builds the effective uniqueness constraint enforced by a validator by
-    # combining its explicit `conditions` proc with implicit guards such as
-    # `allow_nil` / `allow_blank`.
+    # Builds the effective uniqueness constraint enforced by a validator.
+    #
+    # When the validator carries an explicit `conditions` proc, that proc is the
+    # authoritative partial predicate. The implicit `allow_nil` / `allow_blank`
+    # guard on the validated attribute is redundant against a unique index (which
+    # already treats NULLs as distinct), so it is only used as a fallback when no
+    # explicit conditions are present. Otherwise gems that always set `allow_nil`
+    # (e.g. database_validations) would append a duplicate or extra
+    # `attribute IS NOT NULL` clause and never match the partial index.
     def uniqueness_validator_where_sql(model, attribute, validator)
       conditions_sql = conditions_where_sql(model, validator.options[:conditions])
-      guard_sql = uniqueness_validator_guard_sql(model, attribute, validator)
+      guard_sql = conditions_sql ? nil : uniqueness_validator_guard_sql(model, attribute, validator)
 
       sql_parts = [conditions_sql, guard_sql].reject { |part| part.nil? || part == '' }
       return nil if sql_parts.empty?

data/lib/database_consistency/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DatabaseConsistency
-  VERSION = '3.0.5'
+  VERSION = '3.0.8'
 end

data/lib/database_consistency/writers/simple/numericality_check_constraint_missing.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+module DatabaseConsistency
+  module Writers
+    module Simple
+      class NumericalityCheckConstraintMissing < Base # :nodoc:
+        private
+
+        def template
+          'column has a numericality validator but does not have a CHECK constraint'
+        end
+
+        def unique_attributes
+          {
+            table_or_model_name: report.table_or_model_name,
+            column_or_attribute_name: report.column_or_attribute_name
+          }
+        end
+      end
+    end
+  end
+end

data/lib/database_consistency/writers/simple/polymorphic_association_nullability_mismatch.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+module DatabaseConsistency
+  module Writers
+    module Simple
+      class PolymorphicAssociationNullabilityMismatch < Base # :nodoc:
+        private
+
+        def template
+          'polymorphic association columns (%<foreign_key>s and %<foreign_type>s) should have matching null constraints'
+        end
+
+        def attributes
+          {
+            foreign_key: report.foreign_key,
+            foreign_type: report.foreign_type
+          }
+        end
+
+        def unique_attributes
+          {
+            table_or_model_name: report.table_or_model_name,
+            column_or_attribute_name: report.column_or_attribute_name,
+            foreign_key: report.foreign_key,
+            foreign_type: report.foreign_type
+          }
+        end
+      end
+    end
+  end
+end

data/lib/database_consistency.rb

@@ -36,6 +36,7 @@ require 'database_consistency/writers/simple/missing_uniqueness_validation'
 require 'database_consistency/writers/simple/null_constraint_misses_validator'
 require 'database_consistency/writers/simple/null_constraint_missing'
 require 'database_consistency/writers/simple/possible_null'
+require 'database_consistency/writers/simple/numericality_check_constraint_missing'
 require 'database_consistency/writers/simple/small_primary_key'
 require 'database_consistency/writers/simple/inconsistent_enum_type'
 require 'database_consistency/writers/simple/enum_values_inconsistent_with_ar_enum'
@@ -46,6 +47,7 @@ require 'database_consistency/writers/simple/missing_association_class'
 require 'database_consistency/writers/simple/missing_table'
 require 'database_consistency/writers/simple/implicit_order_column_missing'
 require 'database_consistency/writers/simple/missing_dependent_destroy'
+require 'database_consistency/writers/simple/polymorphic_association_nullability_mismatch'
 require 'database_consistency/writers/simple/missing_index_find_by'
 require 'database_consistency/writers/simple/view_missing_primary_key'
 require 'database_consistency/writers/simple/view_primary_key_column_missing'
@@ -91,6 +93,7 @@ require 'database_consistency/checkers/association_checkers/foreign_key_type_che
 require 'database_consistency/checkers/association_checkers/foreign_key_cascade_checker'
 require 'database_consistency/checkers/association_checkers/missing_association_class_checker'
 require 'database_consistency/checkers/association_checkers/missing_dependent_destroy_checker'
+require 'database_consistency/checkers/association_checkers/polymorphic_association_nullability_checker'
 
 require 'database_consistency/checkers/column_checkers/column_checker'
 require 'database_consistency/checkers/column_checkers/null_constraint_checker'
@@ -107,6 +110,7 @@ require 'database_consistency/checkers/validator_checkers/case_sensitive_unique_
 
 require 'database_consistency/checkers/validators_fraction_checkers/validators_fraction_checker'
 require 'database_consistency/checkers/validators_fraction_checkers/column_presence_checker'
+require 'database_consistency/checkers/validators_fraction_checkers/numericality_constraint_checker'
 
 require 'database_consistency/checkers/index_checkers/index_checker'
 require 'database_consistency/checkers/index_checkers/unique_index_checker'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: database_consistency
 version: !ruby/object:Gem::Version
-  version: 3.0.5
+  version: 3.0.8
 platform: ruby
 authors:
 - Evgeniy Demin
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-05-23 00:00:00.000000000 Z
+date: 2026-07-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -153,6 +153,7 @@ files:
 - lib/database_consistency/checkers/association_checkers/missing_association_class_checker.rb
 - lib/database_consistency/checkers/association_checkers/missing_dependent_destroy_checker.rb
 - lib/database_consistency/checkers/association_checkers/missing_index_checker.rb
+- lib/database_consistency/checkers/association_checkers/polymorphic_association_nullability_checker.rb
 - lib/database_consistency/checkers/base_checker.rb
 - lib/database_consistency/checkers/column_checkers/column_checker.rb
 - lib/database_consistency/checkers/column_checkers/enum_value_checker.rb
@@ -175,6 +176,7 @@ files:
 - lib/database_consistency/checkers/validator_checkers/missing_unique_index_checker.rb
 - lib/database_consistency/checkers/validator_checkers/validator_checker.rb
 - lib/database_consistency/checkers/validators_fraction_checkers/column_presence_checker.rb
+- lib/database_consistency/checkers/validators_fraction_checkers/numericality_constraint_checker.rb
 - lib/database_consistency/checkers/validators_fraction_checkers/validators_fraction_checker.rb
 - lib/database_consistency/configuration.rb
 - lib/database_consistency/databases/factory.rb
@@ -240,6 +242,8 @@ files:
 - lib/database_consistency/writers/simple/null_constraint_association_misses_validator.rb
 - lib/database_consistency/writers/simple/null_constraint_misses_validator.rb
 - lib/database_consistency/writers/simple/null_constraint_missing.rb
+- lib/database_consistency/writers/simple/numericality_check_constraint_missing.rb
+- lib/database_consistency/writers/simple/polymorphic_association_nullability_mismatch.rb
 - lib/database_consistency/writers/simple/possible_null.rb
 - lib/database_consistency/writers/simple/redundant_case_insensitive_option.rb
 - lib/database_consistency/writers/simple/redundant_index.rb