database_consistency 3.0.5 → 3.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f88fd56f01f639d5614fa82f5e76f6d4a4dfb05c04c246f5baeedf93fd01fe24
-  data.tar.gz: 0bb41479e542c995569b54a6cfc188ea39103c30a074560f0bae15f8223c1128
+  metadata.gz: 41244c7508ff0579de421a22e770767de915176ef2e43ed9371daadf6cdd9243
+  data.tar.gz: bb38bf3073e135b1e6c039a451237a5bcd71a4c03484e4926ddc00cc41faa7b3
 SHA512:
-  metadata.gz: 54baea922639aec00a1c1edb9aaef5e0d70ec91a2ce63552fcb2ab502b93c1a2779c3227fdb55c7cb03afd17a346624cfc192d84c07480583b44bba00554eea5
-  data.tar.gz: 69a60f5b359e2bfc89765756115e510646d6167fd2819da7f25451302c52f1f54c2c590e1a487eb2291c9e747a54e80bf4e193b9db506bc13f8cc7a580b0be8c
+  metadata.gz: 5b26db588fda6d08012fd845ad04141d6a03bb26c058c6cf9042c344c6a6cf6304c98efc89d9ae89c0ee58d8eb4a918e2d1a725578aa60782df036b665f2d638
+  data.tar.gz: c1b6d1abd2eab007e48ad83e157feaee26ea2b2485c243c8bde0e44685f862b01386d9ef5295693883ae3decc85274f27c6a33b9392c799108ee80e8f0bd5f1b

data/lib/database_consistency/checkers/association_checkers/polymorphic_association_nullability_checker.rb

@@ -0,0 +1,47 @@
+# frozen_string_literal: true
+
+module DatabaseConsistency
+  module Checkers
+    # This class checks that polymorphic association columns have matching null constraints
+    class PolymorphicAssociationNullabilityChecker < AssociationChecker
+      Report = ReportBuilder.define(
+        DatabaseConsistency::Report,
+        :foreign_key,
+        :foreign_type
+      )
+
+      private
+
+      def preconditions
+        association.belongs_to? && association.polymorphic? && foreign_key_column && foreign_type_column
+      end
+
+      def check
+        if foreign_key_column.null == foreign_type_column.null
+          report_template(:ok)
+        else
+          report_template(:fail, error_slug: :polymorphic_association_nullability_mismatch)
+        end
+      end
+
+      def report_template(status, error_slug: nil)
+        Report.new(
+          status: status,
+          error_slug: error_slug,
+          error_message: nil,
+          foreign_key: association.foreign_key.to_s,
+          foreign_type: association.foreign_type.to_s,
+          **report_attributes
+        )
+      end
+
+      def foreign_key_column
+        @foreign_key_column ||= model.columns_hash[association.foreign_key.to_s]
+      end
+
+      def foreign_type_column
+        @foreign_type_column ||= model.columns_hash[association.foreign_type.to_s]
+      end
+    end
+  end
+end

data/lib/database_consistency/checkers/index_checkers/redundant_unique_index_checker.rb

@@ -60,7 +60,7 @@ module DatabaseConsistency
 
       def contain_index?(another_index)
         another_index_columns = Helper.extract_index_columns(another_index.columns)
-        index_columns & another_index_columns == another_index_columns
+        (another_index_columns - index_columns).empty?
       end
 
       def index_columns

data/lib/database_consistency/helper.rb

@@ -156,12 +156,18 @@ module DatabaseConsistency
       nil
     end
 
-    # Builds the effective uniqueness constraint enforced by a validator by
-    # combining its explicit `conditions` proc with implicit guards such as
-    # `allow_nil` / `allow_blank`.
+    # Builds the effective uniqueness constraint enforced by a validator.
+    #
+    # When the validator carries an explicit `conditions` proc, that proc is the
+    # authoritative partial predicate. The implicit `allow_nil` / `allow_blank`
+    # guard on the validated attribute is redundant against a unique index (which
+    # already treats NULLs as distinct), so it is only used as a fallback when no
+    # explicit conditions are present. Otherwise gems that always set `allow_nil`
+    # (e.g. database_validations) would append a duplicate or extra
+    # `attribute IS NOT NULL` clause and never match the partial index.
     def uniqueness_validator_where_sql(model, attribute, validator)
       conditions_sql = conditions_where_sql(model, validator.options[:conditions])
-      guard_sql = uniqueness_validator_guard_sql(model, attribute, validator)
+      guard_sql = conditions_sql ? nil : uniqueness_validator_guard_sql(model, attribute, validator)
 
       sql_parts = [conditions_sql, guard_sql].reject { |part| part.nil? || part == '' }
       return nil if sql_parts.empty?

data/lib/database_consistency/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DatabaseConsistency
-  VERSION = '3.0.5'
+  VERSION = '3.0.6'
 end

data/lib/database_consistency/writers/simple/polymorphic_association_nullability_mismatch.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+module DatabaseConsistency
+  module Writers
+    module Simple
+      class PolymorphicAssociationNullabilityMismatch < Base # :nodoc:
+        private
+
+        def template
+          'polymorphic association columns (%<foreign_key>s and %<foreign_type>s) should have matching null constraints'
+        end
+
+        def attributes
+          {
+            foreign_key: report.foreign_key,
+            foreign_type: report.foreign_type
+          }
+        end
+
+        def unique_attributes
+          {
+            table_or_model_name: report.table_or_model_name,
+            column_or_attribute_name: report.column_or_attribute_name,
+            foreign_key: report.foreign_key,
+            foreign_type: report.foreign_type
+          }
+        end
+      end
+    end
+  end
+end

data/lib/database_consistency.rb

@@ -46,6 +46,7 @@ require 'database_consistency/writers/simple/missing_association_class'
 require 'database_consistency/writers/simple/missing_table'
 require 'database_consistency/writers/simple/implicit_order_column_missing'
 require 'database_consistency/writers/simple/missing_dependent_destroy'
+require 'database_consistency/writers/simple/polymorphic_association_nullability_mismatch'
 require 'database_consistency/writers/simple/missing_index_find_by'
 require 'database_consistency/writers/simple/view_missing_primary_key'
 require 'database_consistency/writers/simple/view_primary_key_column_missing'
@@ -91,6 +92,7 @@ require 'database_consistency/checkers/association_checkers/foreign_key_type_che
 require 'database_consistency/checkers/association_checkers/foreign_key_cascade_checker'
 require 'database_consistency/checkers/association_checkers/missing_association_class_checker'
 require 'database_consistency/checkers/association_checkers/missing_dependent_destroy_checker'
+require 'database_consistency/checkers/association_checkers/polymorphic_association_nullability_checker'
 
 require 'database_consistency/checkers/column_checkers/column_checker'
 require 'database_consistency/checkers/column_checkers/null_constraint_checker'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: database_consistency
 version: !ruby/object:Gem::Version
-  version: 3.0.5
+  version: 3.0.6
 platform: ruby
 authors:
 - Evgeniy Demin
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-05-23 00:00:00.000000000 Z
+date: 2026-07-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -153,6 +153,7 @@ files:
 - lib/database_consistency/checkers/association_checkers/missing_association_class_checker.rb
 - lib/database_consistency/checkers/association_checkers/missing_dependent_destroy_checker.rb
 - lib/database_consistency/checkers/association_checkers/missing_index_checker.rb
+- lib/database_consistency/checkers/association_checkers/polymorphic_association_nullability_checker.rb
 - lib/database_consistency/checkers/base_checker.rb
 - lib/database_consistency/checkers/column_checkers/column_checker.rb
 - lib/database_consistency/checkers/column_checkers/enum_value_checker.rb
@@ -240,6 +241,7 @@ files:
 - lib/database_consistency/writers/simple/null_constraint_association_misses_validator.rb
 - lib/database_consistency/writers/simple/null_constraint_misses_validator.rb
 - lib/database_consistency/writers/simple/null_constraint_missing.rb
+- lib/database_consistency/writers/simple/polymorphic_association_nullability_mismatch.rb
 - lib/database_consistency/writers/simple/possible_null.rb
 - lib/database_consistency/writers/simple/redundant_case_insensitive_option.rb
 - lib/database_consistency/writers/simple/redundant_index.rb