database_consistency 2.0.4 → 3.0.5

data/lib/database_consistency/writers/simple/missing_foreign_key_cascade.rb

@@ -7,7 +7,7 @@ module DatabaseConsistency
         private
 
         def template
-          'should have foreign key with on_delete: :%<cascade_option>s in the database'
+          'should have a foreign key with on_delete: :%<cascade_option>s in the database'
         end
 
         def attributes

data/lib/database_consistency/writers/simple/missing_index_find_by.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+
+module DatabaseConsistency
+  module Writers
+    module Simple
+      class MissingIndexFindBy < Base # :nodoc:
+        private
+
+        def template
+          'column is used in find_by but is missing an index%<source_location>s'
+        end
+
+        def attributes
+          if report.source_location
+            count = report.total_findings_count || 1
+            count_str = count > 1 ? ", and #{count - 1} more" : ''
+            { source_location: " (found at #{report.source_location}#{count_str})" }
+          else
+            { source_location: '' }
+          end
+        end
+
+        def unique_attributes
+          {
+            table_or_model_name: report.table_or_model_name,
+            column_or_attribute_name: report.column_or_attribute_name
+          }
+        end
+      end
+    end
+  end
+end

data/lib/database_consistency/writers/simple/missing_table.rb

@@ -7,7 +7,7 @@ module DatabaseConsistency
         private
 
         def template
-          'should have a table in the database'
+          'should have a corresponding table in the database'
         end
 
         def unique_attributes

data/lib/database_consistency/writers/simple/missing_unique_index.rb

@@ -7,7 +7,7 @@ module DatabaseConsistency
         private
 
         def template
-          'model should have proper unique index in the database'
+          'model should have a unique index in the database'
         end
 
         def unique_attributes

data/lib/database_consistency/writers/simple/missing_uniqueness_validation.rb

@@ -7,7 +7,7 @@ module DatabaseConsistency
         private
 
         def template
-          'index is unique in the database but do not have uniqueness validator'
+          'index is unique in the database but does not have a uniqueness validator'
         end
 
         def unique_attributes

data/lib/database_consistency/writers/simple/null_constraint_association_misses_validator.rb

@@ -7,7 +7,7 @@ module DatabaseConsistency
         private
 
         def template
-          'column is required in the database but do not have presence validator for association %<association_name>s'
+          'column is NOT NULL but does not have a presence validator for association %<association_name>s'
         end
 
         def attributes

data/lib/database_consistency/writers/simple/null_constraint_misses_validator.rb

@@ -7,7 +7,7 @@ module DatabaseConsistency
         private
 
         def template
-          'column is required in the database but does not have a validator disallowing nil values'
+          'column is NOT NULL but does not have a validator disallowing nil values'
         end
 
         def unique_attributes

data/lib/database_consistency/writers/simple/null_constraint_missing.rb

@@ -7,7 +7,7 @@ module DatabaseConsistency
         private
 
         def template
-          'column should be required in the database'
+          'column should be NOT NULL'
         end
 
         def unique_attributes

data/lib/database_consistency/writers/simple/possible_null.rb

@@ -7,7 +7,7 @@ module DatabaseConsistency
         private
 
         def template
-          'column is required but there is possible null value insert'
+          'column is NOT NULL but may receive a NULL value'
         end
 
         def unique_attributes

data/lib/database_consistency/writers/simple/redundant_case_insensitive_option.rb

@@ -7,7 +7,7 @@ module DatabaseConsistency
         private
 
         def template
-          "has case insensitive type and doesn't require case_sensitive: false option"
+          'column has a case-insensitive type and does not need the case_sensitive: false option'
         end
 
         def unique_attributes

data/lib/database_consistency/writers/simple/redundant_index.rb

@@ -7,7 +7,7 @@ module DatabaseConsistency
         private
 
         def template
-          'index is redundant as %<covered_index_name>s covers it'
+          'index is redundant because %<covered_index_name>s covers it'
         end
 
         def attributes

data/lib/database_consistency/writers/simple/redundant_unique_index.rb

@@ -7,7 +7,7 @@ module DatabaseConsistency
         private
 
         def template
-          'index uniqueness is redundant as %<covered_index_name>s covers it'
+          'index uniqueness is redundant because %<covered_index_name>s covers it'
         end
 
         def attributes

data/lib/database_consistency/writers/simple/small_primary_key.rb

@@ -7,7 +7,7 @@ module DatabaseConsistency
         private
 
         def template
-          'column has int/serial type but recommended to have bigint/bigserial/uuid'
+          'column has int/serial type but it is recommended to use bigint/bigserial/uuid'
         end
 
         def unique_attributes

data/lib/database_consistency/writers/simple/three_state_boolean.rb

@@ -7,7 +7,7 @@ module DatabaseConsistency
         private
 
         def template
-          'boolean column should have NOT NULL constraint'
+          'boolean column should be NOT NULL'
         end
 
         def unique_attributes

data/lib/database_consistency/writers/simple/view_missing_primary_key.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+module DatabaseConsistency
+  module Writers
+    module Simple
+      class ViewMissingPrimaryKey < Base # :nodoc:
+        private
+
+        def template
+          'model backed by a database view should have primary_key set'
+        end
+
+        def unique_attributes
+          {
+            table_or_model_name: report.table_or_model_name
+          }
+        end
+      end
+    end
+  end
+end

data/lib/database_consistency/writers/simple/view_primary_key_column_missing.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+module DatabaseConsistency
+  module Writers
+    module Simple
+      class ViewPrimaryKeyColumnMissing < Base # :nodoc:
+        private
+
+        def template
+          'model backed by a database view has primary_key set to a non-existent column'
+        end
+
+        def unique_attributes
+          {
+            table_or_model_name: report.table_or_model_name
+          }
+        end
+      end
+    end
+  end
+end

data/lib/database_consistency.rb

@@ -1,14 +1,11 @@
 # frozen_string_literal: true
 
 require 'active_record'
-require 'active_support/inflector'
-
-ActiveSupport::Inflector.inflections do |inflect|
-  inflect.irregular 'index', 'indexes'
-end
 
 require 'database_consistency/version'
 require 'database_consistency/helper'
+require 'database_consistency/files_helper'
+require 'database_consistency/prism_helper'
 require 'database_consistency/configuration'
 require 'database_consistency/rescue_error'
 require 'database_consistency/errors'
@@ -48,6 +45,10 @@ require 'database_consistency/writers/simple/three_state_boolean'
 require 'database_consistency/writers/simple/missing_association_class'
 require 'database_consistency/writers/simple/missing_table'
 require 'database_consistency/writers/simple/implicit_order_column_missing'
+require 'database_consistency/writers/simple/missing_dependent_destroy'
+require 'database_consistency/writers/simple/missing_index_find_by'
+require 'database_consistency/writers/simple/view_missing_primary_key'
+require 'database_consistency/writers/simple/view_primary_key_column_missing'
 require 'database_consistency/writers/simple_writer'
 
 require 'database_consistency/writers/autofix/helpers/migration'
@@ -81,6 +82,7 @@ require 'database_consistency/checkers/enum_checkers/enum_type_checker'
 
 require 'database_consistency/checkers/model_checkers/model_checker'
 require 'database_consistency/checkers/model_checkers/missing_table_checker'
+require 'database_consistency/checkers/model_checkers/view_primary_key_checker'
 
 require 'database_consistency/checkers/association_checkers/association_checker'
 require 'database_consistency/checkers/association_checkers/missing_index_checker'
@@ -88,6 +90,7 @@ require 'database_consistency/checkers/association_checkers/foreign_key_checker'
 require 'database_consistency/checkers/association_checkers/foreign_key_type_checker'
 require 'database_consistency/checkers/association_checkers/foreign_key_cascade_checker'
 require 'database_consistency/checkers/association_checkers/missing_association_class_checker'
+require 'database_consistency/checkers/association_checkers/missing_dependent_destroy_checker'
 
 require 'database_consistency/checkers/column_checkers/column_checker'
 require 'database_consistency/checkers/column_checkers/null_constraint_checker'
@@ -96,6 +99,7 @@ require 'database_consistency/checkers/column_checkers/primary_key_type_checker'
 require 'database_consistency/checkers/column_checkers/enum_value_checker'
 require 'database_consistency/checkers/column_checkers/three_state_boolean_checker'
 require 'database_consistency/checkers/column_checkers/implicit_ordering_checker'
+require 'database_consistency/checkers/column_checkers/missing_index_find_by_checker'
 
 require 'database_consistency/checkers/validator_checkers/validator_checker'
 require 'database_consistency/checkers/validator_checkers/missing_unique_index_checker'
@@ -112,12 +116,15 @@ require 'database_consistency/checkers/index_checkers/redundant_unique_index_che
 # The root module
 module DatabaseConsistency
   class << self
-    def run(*args, **opts) # rubocop:disable Metrics/MethodLength
+    def run(*args, **opts) # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
       configuration = Configuration.new(*args)
+
+      Writers::AutofixWriter.validate_scope!(opts[:only_checkers]) if opts[:autofix]
+
       reports = Processors.reports(configuration)
 
       if opts[:autofix]
-        Writers::AutofixWriter.write(reports, config: configuration)
+        Writers::AutofixWriter.write(reports, config: configuration, opts: opts[:only_checkers])
 
         0
       elsif opts[:todo]

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: database_consistency
 version: !ruby/object:Gem::Version
-  version: 2.0.4
+  version: 3.0.5
 platform: ruby
 authors:
 - Evgeniy Demin
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-02-07 00:00:00.000000000 Z
+date: 2026-05-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -151,12 +151,14 @@ files:
 - lib/database_consistency/checkers/association_checkers/foreign_key_checker.rb
 - lib/database_consistency/checkers/association_checkers/foreign_key_type_checker.rb
 - lib/database_consistency/checkers/association_checkers/missing_association_class_checker.rb
+- lib/database_consistency/checkers/association_checkers/missing_dependent_destroy_checker.rb
 - lib/database_consistency/checkers/association_checkers/missing_index_checker.rb
 - lib/database_consistency/checkers/base_checker.rb
 - lib/database_consistency/checkers/column_checkers/column_checker.rb
 - lib/database_consistency/checkers/column_checkers/enum_value_checker.rb
 - lib/database_consistency/checkers/column_checkers/implicit_ordering_checker.rb
 - lib/database_consistency/checkers/column_checkers/length_constraint_checker.rb
+- lib/database_consistency/checkers/column_checkers/missing_index_find_by_checker.rb
 - lib/database_consistency/checkers/column_checkers/null_constraint_checker.rb
 - lib/database_consistency/checkers/column_checkers/primary_key_type_checker.rb
 - lib/database_consistency/checkers/column_checkers/three_state_boolean_checker.rb
@@ -168,6 +170,7 @@ files:
 - lib/database_consistency/checkers/index_checkers/unique_index_checker.rb
 - lib/database_consistency/checkers/model_checkers/missing_table_checker.rb
 - lib/database_consistency/checkers/model_checkers/model_checker.rb
+- lib/database_consistency/checkers/model_checkers/view_primary_key_checker.rb
 - lib/database_consistency/checkers/validator_checkers/case_sensitive_unique_validation_checker.rb
 - lib/database_consistency/checkers/validator_checkers/missing_unique_index_checker.rb
 - lib/database_consistency/checkers/validator_checkers/validator_checker.rb
@@ -179,7 +182,9 @@ files:
 - lib/database_consistency/databases/types/sqlite.rb
 - lib/database_consistency/debug_context.rb
 - lib/database_consistency/errors.rb
+- lib/database_consistency/files_helper.rb
 - lib/database_consistency/helper.rb
+- lib/database_consistency/prism_helper.rb
 - lib/database_consistency/processors/associations_processor.rb
 - lib/database_consistency/processors/base_processor.rb
 - lib/database_consistency/processors/columns_processor.rb
@@ -225,8 +230,10 @@ files:
 - lib/database_consistency/writers/simple/length_validator_lower_limit.rb
 - lib/database_consistency/writers/simple/length_validator_missing.rb
 - lib/database_consistency/writers/simple/missing_association_class.rb
+- lib/database_consistency/writers/simple/missing_dependent_destroy.rb
 - lib/database_consistency/writers/simple/missing_foreign_key.rb
 - lib/database_consistency/writers/simple/missing_foreign_key_cascade.rb
+- lib/database_consistency/writers/simple/missing_index_find_by.rb
 - lib/database_consistency/writers/simple/missing_table.rb
 - lib/database_consistency/writers/simple/missing_unique_index.rb
 - lib/database_consistency/writers/simple/missing_uniqueness_validation.rb
@@ -239,6 +246,8 @@ files:
 - lib/database_consistency/writers/simple/redundant_unique_index.rb
 - lib/database_consistency/writers/simple/small_primary_key.rb
 - lib/database_consistency/writers/simple/three_state_boolean.rb
+- lib/database_consistency/writers/simple/view_missing_primary_key.rb
+- lib/database_consistency/writers/simple/view_primary_key_column_missing.rb
 - lib/database_consistency/writers/simple_writer.rb
 - lib/database_consistency/writers/todo_writer.rb
 homepage: https://github.com/djezzzl/database_consistency
@@ -266,14 +275,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.4.0
+      version: 2.6.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.33
+rubygems_version: 3.4.19
 signing_key:
 specification_version: 4
 summary: Provide an easy way to check the consistency of the database constraints