database_consistency 2.0.0 → 2.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 52986b5b93512eecd5adc0b4d37f873664a2ef35eea9b42359a0870f5ecf1c6d
-  data.tar.gz: fa614ae4aa5e6f1b08fadd0d252e898745e1300aae1e5a65466727a80a41ec38
+  metadata.gz: 00b035e08de638007e2b5c13042544597dcdf30a4ea55b1a97dd4e55e16e7a1a
+  data.tar.gz: 9c6db1c345e64d271680c0e6effa6c84d72e2a6d4bde388a123f8ca109d157c3
 SHA512:
-  metadata.gz: 3d7309cf8351e0a7aac9009a4aac0d299a905f09a8d2238b629c880d9810d959f59ef3f5e0d8ce09e72a30d575c60cd792821acb3b2f51c09f023588a704f5a4
-  data.tar.gz: 97cb23bf0541dbb7a95fdbbe78e836c5e9f8c52ae99fe25392c378a9b7acc22e9dd7d3020944aa97e17a1679c02a35bbacaf6067b29be5f3f65ce05bc6856c77
+  metadata.gz: 9b322ecb69172489a441031d971c5fcdea5e68d6ed6a31486dfe36cbab349f4ffb184970f35b1cf55585398b281b82db0916fb956bc276534f42907f62ae6e32
+  data.tar.gz: 22e56221e6711045aaeecedfc305914d8363817c19d376d4a46e89eb3e7d17ad379213e7e07a080ee2f8734679688e9b3d8690f16f5d5097809fae466072472f

data/lib/database_consistency/checkers/association_checkers/foreign_key_checker.rb

@@ -21,7 +21,8 @@ module DatabaseConsistency
       def preconditions
         supported? &&
           association.belongs_to? && !association.polymorphic? &&
-          same_database?
+          same_database? &&
+          model.connection.table_exists?(model.table_name)
       rescue NameError
         false
       end

data/lib/database_consistency/checkers/column_checkers/three_state_boolean_checker.rb

@@ -12,8 +12,9 @@ module DatabaseConsistency
 
       private
 
+      # column should be a boolean and table shouldn't be a view
       def preconditions
-        column.type == :boolean
+        column.type == :boolean && model.connection.table_exists?(model.table_name)
       end
 
       def check

data/lib/database_consistency/checkers/index_checkers/redundant_index_checker.rb

@@ -7,6 +7,7 @@ module DatabaseConsistency
       Report = ReportBuilder.define(
         DatabaseConsistency::Report,
         :covered_index_name,
+        :table_name,
         :index_name
       )
 
@@ -39,6 +40,7 @@ module DatabaseConsistency
           error_message: nil,
           covered_index_name: covered_by_index&.name,
           index_name: index.name,
+          table_name: model.table_name,
           **report_attributes
         )
       end

data/lib/database_consistency/checkers/index_checkers/redundant_unique_index_checker.rb

@@ -7,7 +7,8 @@ module DatabaseConsistency
       Report = ReportBuilder.define(
         DatabaseConsistency::Report,
         :index_name,
-        :covered_index_name
+        :covered_index_name,
+        :table_name
       )
 
       private
@@ -39,6 +40,7 @@ module DatabaseConsistency
           error_message: nil,
           index_name: index.name,
           covered_index_name: covered_by_index&.name,
+          table_name: model.table_name,
           **report_attributes
         )
       end

data/lib/database_consistency/checkers/model_checkers/model_checker.rb

@@ -12,7 +12,7 @@ module DatabaseConsistency
       end
 
       def column_or_attribute_name
-        nil
+        'self'
       end
 
       def table_or_model_name

data/lib/database_consistency/checkers/validators_fraction_checkers/column_presence_checker.rb

@@ -19,7 +19,7 @@ module DatabaseConsistency
       end
 
       def preconditions
-        (regular_column || association) && validators.any?
+        (regular_column || association) && model.connection.table_exists?(model.table_name) && validators.any?
       end
 
       def report_template(status, column_name:, error_slug: nil)

data/lib/database_consistency/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DatabaseConsistency
-  VERSION = '2.0.0'
+  VERSION = '2.0.2'
 end

data/lib/database_consistency/writers/autofix/redundant_index.rb

@@ -6,7 +6,8 @@ module DatabaseConsistency
       class RedundantIndex < MigrationBase # :nodoc:
         def attributes
           {
-            index_name: report.index_name
+            index_name: report.index_name,
+            table_name: report.table_name
           }
         end
 

data/lib/database_consistency/writers/autofix/templates/redundant_index.tt

@@ -1,5 +1,5 @@
 class %<migration_name>s < ActiveRecord::Migration[%<migration_version>s]
   def change
-    remove_index nil, name: '%<index_name>s'
+    remove_index '%<table_name>s', name: '%<index_name>s'
   end
 end

data/lib/database_consistency/writers/simple_writer.rb

@@ -28,11 +28,16 @@ module DatabaseConsistency
       end
 
       def writer(report)
-        klass = begin
-                  "DatabaseConsistency::Writers::Simple::#{report.error_slug.to_s.classify}".constantize
-                rescue NameError
-                  Simple::DefaultMessage
-                end
+        klass =
+          if report.error_slug
+            begin
+              "DatabaseConsistency::Writers::Simple::#{report.error_slug.to_s.classify}".constantize
+            rescue NameError
+              Simple::DefaultMessage
+            end
+          else
+            Simple::DefaultMessage
+          end
 
         klass.new(report, config: config)
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: database_consistency
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.2
 platform: ruby
 authors:
 - Evgeniy Demin
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-12-25 00:00:00.000000000 Z
+date: 2024-12-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord