database_consistency 1.7.4 → 1.7.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b620d27a76af3af281a6d433f5d8383ad7b9ba33811785b55a80d33bd6fb8ce6
-  data.tar.gz: 378a82e286fea3e482c07e30aa02900441f47e44f7a4402b19ed7c0a6edbf6f1
+  metadata.gz: 905028bf5f85ba32f99076b621821a83f8b1bbd5b7662ebba0eb84bee85ce5f2
+  data.tar.gz: 763574e25561f0eebb64922bc2b1ab2841c3bb791b570b2a62a5d0ee56758742
 SHA512:
-  metadata.gz: c756fa1d604909c62a56c51eef6d3f5140debcd5edff683dea4e5fd9f7e1f1ca421d984912b8efb5c7eacc1056bbc87fb1c5a084dda0b4a8c808e32c8df7398d
-  data.tar.gz: 11d4f560939e6e82f30cab8a479dfbd14e34b80ec67d62f7cc43788466bf7549d3c6841b0367745b257012975f6a89a32c7e3972ed4aff9ef47a4c260ca8bd8b
+  metadata.gz: a4ca99f196d02deb4286f3468c46e2a724b585f79fce48b8768c206c72ee9cd07da42f930edbfe457ab64083a118810de19bdf7149f617d0cda8dea490f82e65
+  data.tar.gz: df2c8f4c0d7b4a2e7adf1b6a142f37bcc4b6864d8ae216e33848a5a1adec0723698f841b342080f0a2cefde1e98bd9fd21dfe85bf4721d93500c68bbcb2ba455

data/lib/database_consistency/checkers/association_checkers/foreign_key_cascade_checker.rb

@@ -2,7 +2,7 @@
 
 module DatabaseConsistency
   module Checkers
-    # This class checks if non polymorphic +belongs_to+ association has foreign key constraint
+    # This class checks that foreign key has a cascade option matching dependent option
     class ForeignKeyCascadeChecker < AssociationChecker
       Report = ReportBuilder.define(
         DatabaseConsistency::Report,
@@ -14,11 +14,11 @@ module DatabaseConsistency
       )
 
       OPTION_TO_CASCADE = {
-        delete: :cascade,
-        delete_all: :cascade,
-        nullify: :nullify,
-        restrict_with_exception: :restrict,
-        restrict_with_error: :restrict
+        delete: [:cascade],
+        delete_all: [:cascade],
+        nullify: [:nullify],
+        restrict_with_exception: [nil, :restrict],
+        restrict_with_error: [nil, :restrict]
       }.freeze
 
       DEPENDENT_OPTIONS = OPTION_TO_CASCADE.keys.freeze
@@ -52,7 +52,7 @@ module DatabaseConsistency
       end
 
       def correlated_cascade_constraint?
-        required_foreign_key_cascade == foreign_key_on_delete_option
+        required_foreign_key_cascade.include?(foreign_key_on_delete_option)
       end
 
       def dependent_option

data/lib/database_consistency/checkers/column_checkers/column_checker.rb

@@ -2,7 +2,7 @@
 
 module DatabaseConsistency
   module Checkers
-    # The base class for table checkers
+    # The base class for column checkers
     class ColumnChecker < BaseChecker
       attr_reader :model, :column
 

data/lib/database_consistency/checkers/column_checkers/enum_value_checker.rb

@@ -2,7 +2,7 @@
 
 module DatabaseConsistency
   module Checkers
-    # This class checks missing presence validator
+    # This class checks the database enum values and ActiveRecord's enum values/inclusion validations are aligned
     class EnumValueChecker < ColumnChecker
       Report = ReportBuilder.define(
         DatabaseConsistency::Report,

data/lib/database_consistency/checkers/column_checkers/length_constraint_checker.rb

@@ -2,7 +2,7 @@
 
 module DatabaseConsistency
   module Checkers
-    # This class checks missing presence validator
+    # This checker checks that column has a length constraint if there is a length validation
     class LengthConstraintChecker < ColumnChecker
       VALIDATOR_CLASS =
         if defined?(ActiveRecord::Validations::LengthValidator)

data/lib/database_consistency/checkers/column_checkers/primary_key_type_checker.rb

@@ -2,7 +2,7 @@
 
 module DatabaseConsistency
   module Checkers
-    # This class checks missing presence validator
+    # This class checks that primary key is bigserial, bigint, or uuid
     class PrimaryKeyTypeChecker < ColumnChecker
       Report = ReportBuilder.define(
         DatabaseConsistency::Report,

data/lib/database_consistency/checkers/column_checkers/three_state_boolean_checker.rb

@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+
+module DatabaseConsistency
+  module Checkers
+    # This class checks missing NOT NULL constraint for boolean columns
+    class ThreeStateBooleanChecker < ColumnChecker
+      Report = ReportBuilder.define(
+        DatabaseConsistency::Report,
+        :table_name,
+        :column_name
+      )
+
+      private
+
+      def preconditions
+        column.type == :boolean
+      end
+
+      def check
+        if valid?
+          report_template(:ok)
+        else
+          report_template(:fail, error_slug: :three_state_boolean)
+        end
+      end
+
+      def report_template(status, error_slug: nil)
+        Report.new(
+          status: status,
+          error_slug: error_slug,
+          error_message: nil,
+          table_name: model.table_name,
+          column_name: column.name,
+          **report_attributes
+        )
+      end
+
+      # @return [Boolean]
+      def valid?
+        !column.null
+      end
+    end
+  end
+end

data/lib/database_consistency/checkers/index_checkers/index_checker.rb

@@ -2,7 +2,7 @@
 
 module DatabaseConsistency
   module Checkers
-    # The base class for table checkers
+    # The base class for index checkers
     class IndexChecker < BaseChecker
       attr_reader :model, :index
 

data/lib/database_consistency/checkers/index_checkers/redundant_unique_index_checker.rb

@@ -2,7 +2,7 @@
 
 module DatabaseConsistency
   module Checkers
-    # This class checks redundant database indexes
+    # This class checks redundant database unique indexes
     class RedundantUniqueIndexChecker < IndexChecker
       Report = ReportBuilder.define(
         DatabaseConsistency::Report,

data/lib/database_consistency/checkers/validator_checkers/case_sensitive_unique_validation_checker.rb

@@ -2,7 +2,7 @@
 
 module DatabaseConsistency
   module Checkers
-    # This class checks if uniqueness validator has unique index in the database
+    # This class checks redundant case_sensitive option for uniqueness validation
     class CaseSensitiveUniqueValidationChecker < ValidatorChecker
       private
 

data/lib/database_consistency/checkers/validators_fraction_checkers/validators_fraction_checker.rb

@@ -2,7 +2,7 @@
 
 module DatabaseConsistency
   module Checkers
-    # The base class for validator checker
+    # The base class for validator fraction checkers
     class ValidatorsFractionChecker < BaseChecker
       attr_reader :model, :attribute, :validators
 

data/lib/database_consistency/helper.rb

@@ -36,8 +36,8 @@ module DatabaseConsistency
 
     # Return list of not inherited models
     def parent_models
-      models.group_by(&:table_name).each_value.map do |models|
-        models.min_by { |model| models.include?(model.superclass) ? 1 : 0 }
+      models.group_by(&:table_name).each_value.flat_map do |models|
+        models.reject { |model| models.include?(model.superclass) }
       end
     end
 

data/lib/database_consistency/processors/columns_processor.rb

@@ -8,7 +8,8 @@ module DatabaseConsistency
         Checkers::NullConstraintChecker,
         Checkers::LengthConstraintChecker,
         Checkers::PrimaryKeyTypeChecker,
-        Checkers::EnumValueChecker
+        Checkers::EnumValueChecker,
+        Checkers::ThreeStateBooleanChecker
       ].freeze
 
       private

data/lib/database_consistency/rescue_error.rb

@@ -16,7 +16,7 @@ module DatabaseConsistency
     end
 
     def initialize
-      puts 'Hey, some of checks fail with an error, please open an issue on github at https://github.com/djezzzl/database_consistency.'
+      puts 'Hey, some checks fail with an error, please open an issue on github at https://github.com/djezzzl/database_consistency.'
       puts "Attach the created file: #{filename}"
       puts 'Thank you, for your contribution!'
       puts '(c) Evgeniy Demin <lawliet.djez@gmail.com>'

data/lib/database_consistency/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DatabaseConsistency
-  VERSION = '1.7.4'
+  VERSION = '1.7.6'
 end

data/lib/database_consistency/writers/autofix_writer.rb

@@ -16,7 +16,8 @@ module DatabaseConsistency
         null_constraint_missing: Autofix::NullConstraintMissing,
         redundant_index: Autofix::RedundantIndex,
         redundant_unique_index: Autofix::RedundantIndex,
-        small_primary_key: Autofix::InconsistentTypes
+        small_primary_key: Autofix::InconsistentTypes,
+        three_state_boolean: Autofix::NullConstraintMissing
       }.freeze
 
       def write

data/lib/database_consistency/writers/simple/three_state_boolean.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+module DatabaseConsistency
+  module Writers
+    module Simple
+      class ThreeStateBoolean < Base # :nodoc:
+        private
+
+        def template
+          'boolean column should have NOT NULL constraint'
+        end
+
+        def unique_attributes
+          {
+            table_name: report.table_name,
+            column_name: report.column_name
+          }
+        end
+      end
+    end
+  end
+end

data/lib/database_consistency/writers/simple_writer.rb

@@ -28,7 +28,8 @@ module DatabaseConsistency
         missing_foreign_key_cascade: Simple::MissingForeignKeyCascade,
         enum_values_inconsistent_with_ar_enum: Simple::EnumValuesInconsistentWithArEnum,
         enum_values_inconsistent_with_inclusion: Simple::EnumValuesInconsistentWithInclusion,
-        redundant_case_insensitive_option: Simple::RedundantCaseInsensitiveOption
+        redundant_case_insensitive_option: Simple::RedundantCaseInsensitiveOption,
+        three_state_boolean: Simple::ThreeStateBoolean
       }.freeze
 
       def write

data/lib/database_consistency.rb

@@ -38,6 +38,7 @@ require 'database_consistency/writers/simple/inconsistent_enum_type'
 require 'database_consistency/writers/simple/enum_values_inconsistent_with_ar_enum'
 require 'database_consistency/writers/simple/enum_values_inconsistent_with_inclusion'
 require 'database_consistency/writers/simple/redundant_case_insensitive_option'
+require 'database_consistency/writers/simple/three_state_boolean'
 require 'database_consistency/writers/simple_writer'
 
 require 'database_consistency/writers/autofix/helpers/migration'
@@ -71,6 +72,7 @@ require 'database_consistency/checkers/column_checkers/null_constraint_checker'
 require 'database_consistency/checkers/column_checkers/length_constraint_checker'
 require 'database_consistency/checkers/column_checkers/primary_key_type_checker'
 require 'database_consistency/checkers/column_checkers/enum_value_checker'
+require 'database_consistency/checkers/column_checkers/three_state_boolean_checker'
 
 require 'database_consistency/checkers/validator_checkers/validator_checker'
 require 'database_consistency/checkers/validator_checkers/missing_unique_index_checker'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: database_consistency
 version: !ruby/object:Gem::Version
-  version: 1.7.4
+  version: 1.7.6
 platform: ruby
 authors:
 - Evgeniy Demin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-01-20 00:00:00.000000000 Z
+date: 2023-04-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -157,6 +157,7 @@ files:
 - lib/database_consistency/checkers/column_checkers/length_constraint_checker.rb
 - lib/database_consistency/checkers/column_checkers/null_constraint_checker.rb
 - lib/database_consistency/checkers/column_checkers/primary_key_type_checker.rb
+- lib/database_consistency/checkers/column_checkers/three_state_boolean_checker.rb
 - lib/database_consistency/checkers/enum_checkers/enum_checker.rb
 - lib/database_consistency/checkers/enum_checkers/enum_type_checker.rb
 - lib/database_consistency/checkers/index_checkers/index_checker.rb
@@ -228,6 +229,7 @@ files:
 - lib/database_consistency/writers/simple/redundant_index.rb
 - lib/database_consistency/writers/simple/redundant_unique_index.rb
 - lib/database_consistency/writers/simple/small_primary_key.rb
+- lib/database_consistency/writers/simple/three_state_boolean.rb
 - lib/database_consistency/writers/simple_writer.rb
 - lib/database_consistency/writers/todo_writer.rb
 homepage: https://github.com/djezzzl/database_consistency
@@ -262,7 +264,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.33
+rubygems_version: 3.1.6
 signing_key: 
 specification_version: 4
 summary: Provide an easy way to check the consistency of the database constraints