database_consistency 1.7.26 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f10f22151f5ddbb4c219ebb0efbb2af17e6d73bbd0153ad861cb748c6d202829
-  data.tar.gz: be376924b1db3b17b61eeb8cd0154f855c4b9b1a458cfacaae70c7019c1707ab
+  metadata.gz: 52986b5b93512eecd5adc0b4d37f873664a2ef35eea9b42359a0870f5ecf1c6d
+  data.tar.gz: fa614ae4aa5e6f1b08fadd0d252e898745e1300aae1e5a65466727a80a41ec38
 SHA512:
-  metadata.gz: 7dde326fd325136cd5972b9d89886cd6f3a39cddda39091ba6ece85f2261f50a9c71d2efdd0ed20c634c974d0604e21fb7b8f28130444d8f237bcdc6ea046a8e
-  data.tar.gz: 69e0304fb9b2aad06cd3efc4a152dd5b51f616f29e3dab9c8252e717393b724de84a8a051ca50700a417954ba96fcead5b2fa121bdd50dfada88c91d0ee96d27
+  metadata.gz: 3d7309cf8351e0a7aac9009a4aac0d299a905f09a8d2238b629c880d9810d959f59ef3f5e0d8ce09e72a30d575c60cd792821acb3b2f51c09f023588a704f5a4
+  data.tar.gz: 97cb23bf0541dbb7a95fdbbe78e836c5e9f8c52ae99fe25392c378a9b7acc22e9dd7d3020944aa97e17a1679c02a35bbacaf6067b29be5f3f65ce05bc6856c77

data/lib/database_consistency/checkers/base_checker.rb

@@ -11,9 +11,19 @@ module DatabaseConsistency
         configuration.enabled?('DatabaseConsistencyCheckers', checker_name)
       end
 
+      def self.inherited(subclass)
+        super
+
+        return if subclass.superclass.name == 'DatabaseConsistency::Checkers::BaseChecker'
+
+        processor_prefix = subclass.superclass.name.demodulize.delete_suffix('Checker').pluralize
+        processor = "DatabaseConsistency::Processors::#{processor_prefix}Processor".constantize
+        processor.checkers << subclass
+      end
+
       # @return [String]
       def self.checker_name
-        @checker_name ||= name.split('::').last
+        @checker_name ||= name.demodulize
       end
 
       # @param [Boolean] catch_errors

data/lib/database_consistency/configuration.rb

@@ -16,6 +16,8 @@ module DatabaseConsistency
         end
         extract_configurations(existing_paths)
       end
+
+      load_custom_checkers
     end
 
     def debug?
@@ -123,5 +125,13 @@ module DatabaseConsistency
           settings && settings['log_level']
         end
     end
+
+    def load_custom_checkers
+      return unless configuration.key?('require') && configuration['require'].is_a?(Array)
+
+      configuration['require'].each do |path|
+        require path
+      end
+    end
   end
 end

data/lib/database_consistency/processors/associations_processor.rb

@@ -4,14 +4,6 @@ module DatabaseConsistency
   module Processors
     # The class to process associations
     class AssociationsProcessor < BaseProcessor
-      CHECKERS = [
-        Checkers::MissingIndexChecker,
-        Checkers::ForeignKeyChecker,
-        Checkers::ForeignKeyTypeChecker,
-        Checkers::ForeignKeyCascadeChecker,
-        Checkers::MissingAssociationClassChecker
-      ].freeze
-
       private
 
       def check # rubocop:disable Metrics/MethodLength

data/lib/database_consistency/processors/base_processor.rb

@@ -4,21 +4,17 @@ module DatabaseConsistency
   # The module for processors
   module Processors
     def self.reports(configuration)
-      [
-        ColumnsProcessor,
-        ValidatorsProcessor,
-        AssociationsProcessor,
-        ValidatorsFractionsProcessor,
-        IndexesProcessor,
-        EnumsProcessor,
-        ModelsProcessor
-      ].flat_map do |processor|
+      BaseProcessor.descendants.flat_map do |processor|
         processor.new(configuration).reports
       end
     end
 
     # The base class for processors
     class BaseProcessor
+      def self.checkers
+        @checkers ||= Set.new
+      end
+
       attr_reader :configuration
 
       # @param [DatabaseConsistency::Configuration] configuration
@@ -38,7 +34,7 @@ module DatabaseConsistency
 
       # @return [Array<Class>]
       def enabled_checkers
-        self.class::CHECKERS.select { |checker| checker.enabled?(configuration) }
+        self.class.checkers.select { |checker| checker.enabled?(configuration) }
       end
 
       private

data/lib/database_consistency/processors/columns_processor.rb

@@ -4,15 +4,6 @@ module DatabaseConsistency
   module Processors
     # The class to process columns
     class ColumnsProcessor < BaseProcessor
-      CHECKERS = [
-        Checkers::NullConstraintChecker,
-        Checkers::LengthConstraintChecker,
-        Checkers::PrimaryKeyTypeChecker,
-        Checkers::EnumValueChecker,
-        Checkers::ThreeStateBooleanChecker,
-        Checkers::ImplicitOrderingChecker
-      ].freeze
-
       private
 
       def check # rubocop:disable Metrics/MethodLength

data/lib/database_consistency/processors/enums_processor.rb

@@ -4,10 +4,6 @@ module DatabaseConsistency
   module Processors
     # The class to process enums
     class EnumsProcessor < BaseProcessor
-      CHECKERS = [
-        Checkers::EnumTypeChecker
-      ].freeze
-
       private
 
       def check # rubocop:disable Metrics/MethodLength

data/lib/database_consistency/processors/indexes_processor.rb

@@ -4,12 +4,6 @@ module DatabaseConsistency
   module Processors
     # The class to process indexes
     class IndexesProcessor < BaseProcessor
-      CHECKERS = [
-        Checkers::UniqueIndexChecker,
-        Checkers::RedundantIndexChecker,
-        Checkers::RedundantUniqueIndexChecker
-      ].freeze
-
       private
 
       def check # rubocop:disable Metrics/AbcSize, Metrics/MethodLength

data/lib/database_consistency/processors/models_processor.rb

@@ -4,10 +4,6 @@ module DatabaseConsistency
   module Processors
     # The class to process models
     class ModelsProcessor < BaseProcessor
-      CHECKERS = [
-        Checkers::MissingTableChecker
-      ].freeze
-
       private
 
       def check

data/lib/database_consistency/processors/validators_fractions_processor.rb

@@ -4,10 +4,6 @@ module DatabaseConsistency
   module Processors
     # The class to process validators
     class ValidatorsFractionsProcessor < BaseProcessor
-      CHECKERS = [
-        Checkers::ColumnPresenceChecker
-      ].freeze
-
       private
 
       # @return [Array<Hash>]

data/lib/database_consistency/processors/validators_processor.rb

@@ -4,11 +4,6 @@ module DatabaseConsistency
   module Processors
     # The class to process validators
     class ValidatorsProcessor < BaseProcessor
-      CHECKERS = [
-        Checkers::MissingUniqueIndexChecker,
-        Checkers::CaseSensitiveUniqueValidationChecker
-      ].freeze
-
       private
 
       # @return [Array<Hash>]

data/lib/database_consistency/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DatabaseConsistency
-  VERSION = '1.7.26'
+  VERSION = '2.0.0'
 end

data/lib/database_consistency/writers/autofix/helpers/migration.rb

@@ -6,8 +6,6 @@ module DatabaseConsistency
       module Helpers
         module Migration # :nodoc:
           def migration_path(name)
-            migration_context = ActiveRecord::Base.connection.migration_context
-
             last = migration_context.migrations.last
             version = ActiveRecord::Migration.next_migration_number(last&.version.to_i + 1)
 
@@ -24,6 +22,21 @@ module DatabaseConsistency
               migration_version: ActiveRecord::Migration.current_version
             }
           end
+
+          def migration_context
+            if ActiveRecord::MigrationContext.instance_method(:initialize).arity == 1
+              return ActiveRecord::MigrationContext.new(ActiveRecord::Migrator.migrations_paths)
+            end
+
+            if ActiveRecord::Base.connection.respond_to?(:schema_migration)
+              return ActiveRecord::MigrationContext.new(
+                ActiveRecord::Migrator.migrations_paths,
+                ActiveRecord::Base.connection.schema_migration
+              )
+            end
+
+            ActiveRecord::MigrationContext.new(ActiveRecord::Migrator.migrations_paths)
+          end
         end
       end
     end

data/lib/database_consistency/writers/simple_writer.rb

@@ -5,36 +5,6 @@ module DatabaseConsistency
   module Writers
     # The simplest formatter
     class SimpleWriter < BaseWriter
-      SLUG_TO_WRITER = {
-        association_foreign_type_missing_null_constraint: Simple::AssociationForeignTypeMissingNullConstraint,
-        association_missing_index: Simple::AssociationMissingIndex,
-        association_missing_null_constraint: Simple::AssociationMissingNullConstraint,
-        enum_values_inconsistent_with_ar_enum: Simple::EnumValuesInconsistentWithArEnum,
-        enum_values_inconsistent_with_inclusion: Simple::EnumValuesInconsistentWithInclusion,
-        has_one_missing_unique_index: Simple::HasOneMissingUniqueIndex,
-        implicit_order_column_missing: Simple::ImplicitOrderColumnMissing,
-        inconsistent_enum_type: Simple::InconsistentEnumType,
-        inconsistent_types: Simple::InconsistentTypes,
-        length_validator_greater_limit: Simple::LengthValidatorGreaterLimit,
-        length_validator_lower_limit: Simple::LengthValidatorLowerLimit,
-        length_validator_missing: Simple::LengthValidatorMissing,
-        missing_association_class: Simple::MissingAssociationClass,
-        missing_foreign_key: Simple::MissingForeignKey,
-        missing_foreign_key_cascade: Simple::MissingForeignKeyCascade,
-        missing_table: Simple::MissingTable,
-        missing_unique_index: Simple::MissingUniqueIndex,
-        missing_uniqueness_validation: Simple::MissingUniquenessValidation,
-        null_constraint_association_misses_validator: Simple::NullConstraintAssociationMissesValidator,
-        null_constraint_misses_validator: Simple::NullConstraintMissesValidator,
-        null_constraint_missing: Simple::NullConstraintMissing,
-        possible_null: Simple::PossibleNull,
-        redundant_case_insensitive_option: Simple::RedundantCaseInsensitiveOption,
-        redundant_index: Simple::RedundantIndex,
-        redundant_unique_index: Simple::RedundantUniqueIndex,
-        small_primary_key: Simple::SmallPrimaryKey,
-        three_state_boolean: Simple::ThreeStateBoolean
-      }.freeze
-
       def write
         results.select(&method(:write?))
                .map(&method(:writer))
@@ -58,7 +28,12 @@ module DatabaseConsistency
       end
 
       def writer(report)
-        klass = SLUG_TO_WRITER[report.error_slug] || Simple::DefaultMessage
+        klass = begin
+                  "DatabaseConsistency::Writers::Simple::#{report.error_slug.to_s.classify}".constantize
+                rescue NameError
+                  Simple::DefaultMessage
+                end
+
         klass.new(report, config: config)
       end
     end

data/lib/database_consistency.rb

@@ -1,6 +1,11 @@
 # frozen_string_literal: true
 
 require 'active_record'
+require 'active_support/inflector'
+
+ActiveSupport::Inflector.inflections do |inflect|
+  inflect.irregular 'index', 'indexes'
+end
 
 require 'database_consistency/version'
 require 'database_consistency/helper'
@@ -60,6 +65,15 @@ require 'database_consistency/databases/factory'
 require 'database_consistency/databases/types/base'
 require 'database_consistency/databases/types/sqlite'
 
+require 'database_consistency/processors/base_processor'
+require 'database_consistency/processors/enums_processor'
+require 'database_consistency/processors/associations_processor'
+require 'database_consistency/processors/validators_processor'
+require 'database_consistency/processors/columns_processor'
+require 'database_consistency/processors/validators_fractions_processor'
+require 'database_consistency/processors/indexes_processor'
+require 'database_consistency/processors/models_processor'
+
 require 'database_consistency/checkers/base_checker'
 
 require 'database_consistency/checkers/enum_checkers/enum_checker'
@@ -95,15 +109,6 @@ require 'database_consistency/checkers/index_checkers/unique_index_checker'
 require 'database_consistency/checkers/index_checkers/redundant_index_checker'
 require 'database_consistency/checkers/index_checkers/redundant_unique_index_checker'
 
-require 'database_consistency/processors/base_processor'
-require 'database_consistency/processors/enums_processor'
-require 'database_consistency/processors/associations_processor'
-require 'database_consistency/processors/validators_processor'
-require 'database_consistency/processors/columns_processor'
-require 'database_consistency/processors/validators_fractions_processor'
-require 'database_consistency/processors/indexes_processor'
-require 'database_consistency/processors/models_processor'
-
 # The root module
 module DatabaseConsistency
   class << self

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: database_consistency
 version: !ruby/object:Gem::Version
-  version: 1.7.26
+  version: 2.0.0
 platform: ruby
 authors:
 - Evgeniy Demin
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-10-09 00:00:00.000000000 Z
+date: 2024-12-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -136,7 +136,7 @@ dependencies:
     - - ">"
       - !ruby/object:Gem::Version
         version: '1.3'
-description: 
+description:
 email:
 - lawliet.djez@gmail.com
 executables:
@@ -273,9 +273,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.1
-signing_key: 
+rubygems_version: 3.2.33
+signing_key:
 specification_version: 4
 summary: Provide an easy way to check the consistency of the database constraints
   with the application validations.
 test_files: []
+...