database_consistency 1.7.23 → 1.7.25

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fa19d97c8acb835f248d400cf2083c32e8aa409c65155d997710d9bc2cda0c59
-  data.tar.gz: a598e7238e279205af65c4101b0f8773bb90b6b816bed18850892a8d9cca4a0f
+  metadata.gz: 6a60adb5b04de89499434019dd7ae4d0281799fc457122de1d01ad825d9d74e1
+  data.tar.gz: 3cfe216adacba3de2df73bf8cc353ce56bbdae93c0b4ada74b860cd89422f173
 SHA512:
-  metadata.gz: fb372c25d9da1c239739fbc4688f98f853ae8e17fd7ac238f8eeb4b359bbd5314d0a74eadeb38e783cf3ab383f38fb0762adfd956cc392879d03b1db5d68ac8a
-  data.tar.gz: 0af3245696790d32ac16cf805038b110e8788390c3162646fcc4fb9f2e85bc343aab8db801decbcaa209bf6cf3a2db0f1f968c99bc0a016f8582e67752b56dfc
+  metadata.gz: d522414bc1680d596f9207c95615265befd75535e145c43bd7056c823a160a3620e4a9f5ce28b04b0d00878349e8a21d5b58fda669b6510bd714a355791aa8c6
+  data.tar.gz: be1853d66bf896d3ab6eae46684e8533177d90394de2d7360e2e613a3b61e050578fdd0b48a1b357c26171b4c14fedf54f74f064ba0854bdb17026730e2b58a9

data/lib/database_consistency/checkers/column_checkers/length_constraint_checker.rb

@@ -45,8 +45,14 @@ module DatabaseConsistency
       end
 
       def valid?(sign)
-        %i[maximum is].each do |option|
-          return validator.options[option].public_send(sign, column.limit) if validator.options[option]
+        %i[maximum is].each do |key|
+          option = validator.options[key]
+          next unless option
+
+          # skipping runtime-calculated limits
+          return true if option.is_a?(Proc) || option.is_a?(Symbol)
+
+          return option.public_send(sign, column.limit)
         end
 
         false

data/lib/database_consistency/configuration.rb

@@ -48,6 +48,16 @@ module DatabaseConsistency
       value
     end
 
+    def model_enabled?(model)
+      database_enabled?(Helper.database_name(model)) && enabled?(model.name.to_s)
+    end
+
+    def database_enabled?(name)
+      value = configuration.dig('DatabaseConsistencyDatabases', name, 'enabled')
+
+      value.nil? ? true : value
+    end
+
     private
 
     attr_reader :configuration

data/lib/database_consistency/helper.rb

@@ -29,17 +29,19 @@ module DatabaseConsistency
       end
     end
 
-    def project_models
+    def project_models(configuration)
       ActiveRecord::Base.descendants.select do |klass|
+        next unless configuration.model_enabled?(klass)
+
         project_klass?(klass) && connected?(klass)
       end
     end
 
     # Returns list of models to check
-    def models
-      project_models.select do |klass|
+    def models(configuration)
+      project_models(configuration).select do |klass|
         !klass.abstract_class? &&
-          klass.connection.table_exists?(klass.table_name) &&
+          klass.table_exists? &&
           !klass.name.include?('HABTM_')
       end
     end
@@ -52,8 +54,8 @@ module DatabaseConsistency
     end
 
     # Return list of not inherited models
-    def parent_models
-      models.group_by(&:table_name).each_value.flat_map do |models|
+    def parent_models(configuration)
+      models(configuration).group_by(&:table_name).each_value.flat_map do |models|
         models.reject { |model| models.include?(model.superclass) }
       end
     end
@@ -65,6 +67,8 @@ module DatabaseConsistency
       return true unless Module.respond_to?(:const_source_location) && defined?(Bundler)
 
       !Module.const_source_location(klass.to_s).first.to_s.include?(Bundler.bundle_path.to_s)
+    rescue NameError
+      false
     end
 
     # @return [Boolean]

data/lib/database_consistency/processors/associations_processor.rb

@@ -14,12 +14,9 @@ module DatabaseConsistency
 
       private
 
-      def check # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
-        Helper.models.flat_map do |model|
+      def check # rubocop:disable Metrics/MethodLength
+        Helper.models(configuration).flat_map do |model|
           DebugContext.with(model: model.name) do
-            next unless configuration.enabled?('DatabaseConsistencyDatabases', Helper.database_name(model)) &&
-                        configuration.enabled?(model.name.to_s)
-
             Helper.first_level_associations(model).flat_map do |association|
               DebugContext.with(association: association.name) do
                 enabled_checkers.flat_map do |checker_class|

data/lib/database_consistency/processors/columns_processor.rb

@@ -15,12 +15,9 @@ module DatabaseConsistency
 
       private
 
-      def check # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
-        Helper.parent_models.flat_map do |model|
+      def check # rubocop:disable Metrics/MethodLength
+        Helper.parent_models(configuration).flat_map do |model|
           DebugContext.with(model: model.name) do
-            next unless configuration.enabled?('DatabaseConsistencyDatabases', Helper.database_name(model)) &&
-                        configuration.enabled?(model.name.to_s)
-
             model.columns.flat_map do |column|
               DebugContext.with(column: column.name) do
                 enabled_checkers.flat_map do |checker_class|

data/lib/database_consistency/processors/enums_processor.rb

@@ -10,12 +10,9 @@ module DatabaseConsistency
 
       private
 
-      def check # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
-        Helper.models.flat_map do |model|
+      def check # rubocop:disable Metrics/MethodLength
+        Helper.models(configuration).flat_map do |model|
           DebugContext.with(model: model.name) do
-            next unless configuration.enabled?('DatabaseConsistencyDatabases', Helper.database_name(model)) &&
-                        configuration.enabled?(model.name.to_s)
-
             model.defined_enums.keys.flat_map do |enum|
               DebugContext.with(enum: enum) do
                 enabled_checkers.flat_map do |checker_class|

data/lib/database_consistency/processors/indexes_processor.rb

@@ -13,11 +13,8 @@ module DatabaseConsistency
       private
 
       def check # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
-        Helper.parent_models.flat_map do |model|
+        Helper.parent_models(configuration).flat_map do |model|
           DebugContext.with(model: model.name) do
-            next unless configuration.enabled?('DatabaseConsistencyDatabases', Helper.database_name(model)) &&
-                        configuration.enabled?(model.name.to_s)
-
             indexes = model.connection.indexes(model.table_name)
 
             indexes.flat_map do |index|

data/lib/database_consistency/processors/models_processor.rb

@@ -10,12 +10,9 @@ module DatabaseConsistency
 
       private
 
-      def check # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
-        Helper.project_models.flat_map do |model|
+      def check
+        Helper.project_models(configuration).flat_map do |model|
           DebugContext.with(model: model.name) do
-            next unless configuration.enabled?('DatabaseConsistencyDatabases', Helper.database_name(model)) &&
-                        configuration.enabled?(model.name.to_s)
-
             enabled_checkers.flat_map do |checker_class|
               DebugContext.with(checker: checker_class) do
                 checker = checker_class.new(model)

data/lib/database_consistency/processors/validators_fractions_processor.rb

@@ -11,12 +11,9 @@ module DatabaseConsistency
       private
 
       # @return [Array<Hash>]
-      def check # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
-        Helper.parent_models.flat_map do |model|
+      def check # rubocop:disable Metrics/MethodLength
+        Helper.parent_models(configuration).flat_map do |model|
           DebugContext.with(model: model.name) do
-            next unless configuration.enabled?('DatabaseConsistencyDatabases', Helper.database_name(model)) &&
-                        configuration.enabled?(model.name.to_s)
-
             model._validators.flat_map do |attribute, validators|
               DebugContext.with(attribute: attribute) do
                 next unless attribute

data/lib/database_consistency/processors/validators_processor.rb

@@ -12,12 +12,9 @@ module DatabaseConsistency
       private
 
       # @return [Array<Hash>]
-      def check # rubocop:disable Metrics/AbcSize, Metrics/MethodLength, Metrics/CyclomaticComplexity
-        Helper.parent_models.flat_map do |model|
+      def check # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
+        Helper.parent_models(configuration).flat_map do |model|
           DebugContext.with(model: model.name) do
-            next unless configuration.enabled?('DatabaseConsistencyDatabases', Helper.database_name(model)) &&
-                        configuration.enabled?(model.name.to_s)
-
             model.validators.flat_map do |validator|
               next unless validator.respond_to?(:attributes)
 

data/lib/database_consistency/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DatabaseConsistency
-  VERSION = '1.7.23'
+  VERSION = '1.7.25'
 end

data/lib/database_consistency/writers/autofix/association_missing_index.rb

@@ -23,7 +23,13 @@ module DatabaseConsistency
         end
 
         def columns
-          "%w[#{report.columns.join(' ')}]"
+          if report.columns.size > 1
+            "%w[#{report.columns.join(' ')}]"
+          elsif report.columns.first =~ /[()]/
+            "'#{report.columns.first}'"
+          else
+            ":#{report.columns.first}"
+          end
         end
 
         def columns_key

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: database_consistency
 version: !ruby/object:Gem::Version
-  version: 1.7.23
+  version: 1.7.25
 platform: ruby
 authors:
 - Evgeniy Demin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-12-18 00:00:00.000000000 Z
+date: 2024-08-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -126,14 +126,14 @@ dependencies:
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">"
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">"
       - !ruby/object:Gem::Version
         version: '1.3'
 description: