database_consistency 1.7.22 → 1.7.24

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f824e179d3bff9cb27c82f046c549fc1cbe89a5d31c6553be49658d45d088816
-  data.tar.gz: c3f147843c216b3dc4672c47819a960839c7d4966b3c42e249b37f38de89d4ee
+  metadata.gz: b29d0d23f3eda8be6c71719df374c21bf7c69f749bdd5d9e71b658b7194e0a7a
+  data.tar.gz: 4dc387034661a53ce80a65513696da3bb5264b4097d1928268ca2cced6a2b082
 SHA512:
-  metadata.gz: d7ce83332d2487b9b284daaad05ba34d3f98415ef163a93f9e19c808432b247116440379c712d73ca4da05c5cfbd64496453175b69ea41e682f15e4e5cbc9d44
-  data.tar.gz: 74506e33950ee7a9c768880f744e87719d4418392e41a7993bfeb507f7a15039654eec4eb55ab5ab9f18f0dfb1eca29d16cd8765069d495b1b1baa35c2414e58
+  metadata.gz: 55f5c65ea75f3384bac11404204522c850d4637c884a6d08cc2b00201e874f74b246410527f6d619e41e35ef078bcca1f7dfce34709621a0a9d4c463b46d727f
+  data.tar.gz: 6bf767f48dfb95cbfce02f9a0fe49718adff8c2afc2e7ae7d74b9496b7991f11bc9f4da10c682cb36dbab310b92c7afc01f9b0b0073c03adaa51000f3f4d216d

data/lib/database_consistency/checkers/column_checkers/enum_value_checker.rb

@@ -44,7 +44,7 @@ module DatabaseConsistency
       def verify_enum
         values = enum.values.uniq
 
-        if enum_column_values == values
+        if enum_column_values.sort == values.sort
           report_template(:ok, values)
         else
           report_template(:fail, values, error_slug: :enum_values_inconsistent_with_ar_enum)
@@ -54,7 +54,7 @@ module DatabaseConsistency
       def verify_inclusion_validator
         values = validator_values(inclusion_validator).uniq
 
-        if enum_column_values == values
+        if enum_column_values.sort == values.sort
           report_template(:ok, values)
         else
           report_template(:fail, values, error_slug: :enum_values_inconsistent_with_inclusion)

data/lib/database_consistency/checkers/column_checkers/length_constraint_checker.rb

@@ -45,8 +45,14 @@ module DatabaseConsistency
       end
 
       def valid?(sign)
-        %i[maximum is].each do |option|
-          return validator.options[option].public_send(sign, column.limit) if validator.options[option]
+        %i[maximum is].each do |key|
+          option = validator.options[key]
+          next unless option
+
+          # skipping runtime-calculated limits
+          return true if option.is_a?(Proc) || option.is_a?(Symbol)
+
+          return option.public_send(sign, column.limit)
         end
 
         false

data/lib/database_consistency/configuration.rb

@@ -48,6 +48,12 @@ module DatabaseConsistency
       value
     end
 
+    def database_enabled?(name)
+      value = configuration.dig('DatabaseConsistencyDatabases', name, 'enabled')
+
+      value.nil? ? true : value
+    end
+
     private
 
     attr_reader :configuration

data/lib/database_consistency/processors/associations_processor.rb

@@ -14,11 +14,10 @@ module DatabaseConsistency
 
       private
 
-      def check # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
+      def check # rubocop:disable Metrics/MethodLength
         Helper.models.flat_map do |model|
           DebugContext.with(model: model.name) do
-            next unless configuration.enabled?('DatabaseConsistencyDatabases', Helper.database_name(model)) &&
-                        configuration.enabled?(model.name.to_s)
+            next unless model_enabled?(model)
 
             Helper.first_level_associations(model).flat_map do |association|
               DebugContext.with(association: association.name) do

data/lib/database_consistency/processors/base_processor.rb

@@ -43,6 +43,11 @@ module DatabaseConsistency
 
       private
 
+      def model_enabled?(model)
+        configuration.database_enabled?(Helper.database_name(model)) &&
+          configuration.enabled?(model.name.to_s)
+      end
+
       def check
         raise NotImplementedError
       end

data/lib/database_consistency/processors/columns_processor.rb

@@ -15,11 +15,10 @@ module DatabaseConsistency
 
       private
 
-      def check # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
+      def check # rubocop:disable Metrics/MethodLength
         Helper.parent_models.flat_map do |model|
           DebugContext.with(model: model.name) do
-            next unless configuration.enabled?('DatabaseConsistencyDatabases', Helper.database_name(model)) &&
-                        configuration.enabled?(model.name.to_s)
+            next unless model_enabled?(model)
 
             model.columns.flat_map do |column|
               DebugContext.with(column: column.name) do

data/lib/database_consistency/processors/enums_processor.rb

@@ -10,11 +10,10 @@ module DatabaseConsistency
 
       private
 
-      def check # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
+      def check # rubocop:disable Metrics/MethodLength
         Helper.models.flat_map do |model|
           DebugContext.with(model: model.name) do
-            next unless configuration.enabled?('DatabaseConsistencyDatabases', Helper.database_name(model)) &&
-                        configuration.enabled?(model.name.to_s)
+            next unless model_enabled?(model)
 
             model.defined_enums.keys.flat_map do |enum|
               DebugContext.with(enum: enum) do

data/lib/database_consistency/processors/indexes_processor.rb

@@ -15,8 +15,7 @@ module DatabaseConsistency
       def check # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
         Helper.parent_models.flat_map do |model|
           DebugContext.with(model: model.name) do
-            next unless configuration.enabled?('DatabaseConsistencyDatabases', Helper.database_name(model)) &&
-                        configuration.enabled?(model.name.to_s)
+            next unless model_enabled?(model)
 
             indexes = model.connection.indexes(model.table_name)
 

data/lib/database_consistency/processors/models_processor.rb

@@ -10,11 +10,10 @@ module DatabaseConsistency
 
       private
 
-      def check # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
+      def check
         Helper.project_models.flat_map do |model|
           DebugContext.with(model: model.name) do
-            next unless configuration.enabled?('DatabaseConsistencyDatabases', Helper.database_name(model)) &&
-                        configuration.enabled?(model.name.to_s)
+            next unless model_enabled?(model)
 
             enabled_checkers.flat_map do |checker_class|
               DebugContext.with(checker: checker_class) do

data/lib/database_consistency/processors/validators_fractions_processor.rb

@@ -11,11 +11,10 @@ module DatabaseConsistency
       private
 
       # @return [Array<Hash>]
-      def check # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
+      def check # rubocop:disable Metrics/MethodLength
         Helper.parent_models.flat_map do |model|
           DebugContext.with(model: model.name) do
-            next unless configuration.enabled?('DatabaseConsistencyDatabases', Helper.database_name(model)) &&
-                        configuration.enabled?(model.name.to_s)
+            next unless model_enabled?(model)
 
             model._validators.flat_map do |attribute, validators|
               DebugContext.with(attribute: attribute) do

data/lib/database_consistency/processors/validators_processor.rb

@@ -12,11 +12,10 @@ module DatabaseConsistency
       private
 
       # @return [Array<Hash>]
-      def check # rubocop:disable Metrics/AbcSize, Metrics/MethodLength, Metrics/CyclomaticComplexity
+      def check # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
         Helper.parent_models.flat_map do |model|
           DebugContext.with(model: model.name) do
-            next unless configuration.enabled?('DatabaseConsistencyDatabases', Helper.database_name(model)) &&
-                        configuration.enabled?(model.name.to_s)
+            next unless model_enabled?(model)
 
             model.validators.flat_map do |validator|
               next unless validator.respond_to?(:attributes)

data/lib/database_consistency/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DatabaseConsistency
-  VERSION = '1.7.22'
+  VERSION = '1.7.24'
 end

data/lib/database_consistency/writers/autofix/association_missing_index.rb

@@ -23,7 +23,13 @@ module DatabaseConsistency
         end
 
         def columns
-          "%w[#{report.columns.join(' ')}]"
+          if report.columns.size > 1
+            "%w[#{report.columns.join(' ')}]"
+          elsif report.columns.first =~ /[()]/
+            "'#{report.columns.first}'"
+          else
+            ":#{report.columns.first}"
+          end
         end
 
         def columns_key

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: database_consistency
 version: !ruby/object:Gem::Version
-  version: 1.7.22
+  version: 1.7.24
 platform: ruby
 authors:
 - Evgeniy Demin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-11-08 00:00:00.000000000 Z
+date: 2024-08-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord