database_consistency 1.7.13 → 1.7.15

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 814c6b14aa1b2b510fc2451b0ccc53c22eddcb2954bfe4b870bfbd1788fee2b2
-  data.tar.gz: cf6bf9b77bd42a0b149609a36ecb9b0b91f6378353bcb58553dbffd1fccb9a07
+  metadata.gz: 3621ad7d1790987ba3867541950d611af17e26be2da7bbc1a33914db25292872
+  data.tar.gz: 8d26e698a1c2ca1f8ba37e2ca899b3486730a025e7b4377645603eda312c0d59
 SHA512:
-  metadata.gz: f4f002828a20fa7376346ed94bd63908a01f572aa2fa20ea452918f391baf2ad4ac7c0e72d98d784fab0003cfd4b3de36589ca29d01c9ae34951c55740fb2372
-  data.tar.gz: 68fabfbd7d75b68b8a404e57dc490d7c2e0ef30a70a76f84f08c28130a58975ad80c1ba2dd59cc1589cd7c3090a21e62ad1a6f29dd15ff013e36676be6faa42f
+  metadata.gz: aedb071d671ca0a4b92a060c58aced55e4e49039d80fbb8d0fc6aa2062070763d5ae4d08333c32cdc3c65fcdb4bf7798875076b47d342c541d1e73ce7c3e57d3
+  data.tar.gz: 82c070e44a36db48e84f17f701168d2fc02f019bd61dcdc9fa43d2cd79039eb865f8466215a75940a66b0cc782417a5adfe47394e4ed1b046164a6e43ce89092

data/lib/database_consistency/checkers/association_checkers/foreign_key_type_checker.rb

@@ -25,7 +25,8 @@ module DatabaseConsistency
         !association.polymorphic? &&
           association.through_reflection.nil? &&
           association.klass.present? &&
-          association.macro != :has_and_belongs_to_many
+          association.macro != :has_and_belongs_to_many &&
+          association.klass.table_exists?
       rescue NameError
         false
       end

data/lib/database_consistency/checkers/model_checkers/missing_table_checker.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+module DatabaseConsistency
+  module Checkers
+    # This class checks that a model has a corresponding table
+    class MissingTableChecker < ModelChecker
+      private
+
+      def preconditions
+        !model.abstract_class?
+      end
+
+      def check
+        if model.table_exists?
+          report_template(:ok)
+        else
+          report_template(:fail, error_slug: :missing_table)
+        end
+      end
+    end
+  end
+end

data/lib/database_consistency/checkers/model_checkers/model_checker.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+module DatabaseConsistency
+  module Checkers
+    # The base class for model checkers
+    class ModelChecker < BaseChecker
+      attr_reader :model
+
+      def initialize(model)
+        super()
+        @model = model
+      end
+
+      def column_or_attribute_name
+        nil
+      end
+
+      def table_or_model_name
+        @table_or_model_name ||= model.name.to_s
+      end
+    end
+  end
+end

data/lib/database_consistency/helper.rb

@@ -29,13 +29,18 @@ module DatabaseConsistency
       end
     end
 
+    def project_models
+      ActiveRecord::Base.descendants.select do |klass|
+        project_klass?(klass)
+      end
+    end
+
     # Returns list of models to check
     def models
-      ActiveRecord::Base.descendants.select do |klass|
+      project_models.select do |klass|
         !klass.abstract_class? &&
           klass.connection.table_exists?(klass.table_name) &&
-          !klass.name.include?('HABTM_') &&
-          project_klass?(klass)
+          !klass.name.include?('HABTM_')
       end
     end
 

data/lib/database_consistency/processors/base_processor.rb

@@ -10,7 +10,8 @@ module DatabaseConsistency
         AssociationsProcessor,
         ValidatorsFractionsProcessor,
         IndexesProcessor,
-        EnumsProcessor
+        EnumsProcessor,
+        ModelsProcessor
       ].flat_map do |processor|
         processor.new(configuration).reports
       end

data/lib/database_consistency/processors/models_processor.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+module DatabaseConsistency
+  module Processors
+    # The class to process models
+    class ModelsProcessor < BaseProcessor
+      CHECKERS = [
+        Checkers::MissingTableChecker
+      ].freeze
+
+      private
+
+      def check
+        Helper.project_models.flat_map do |model|
+          next unless configuration.enabled?('DatabaseConsistencyDatabases', Helper.database_name(model)) &&
+                      configuration.enabled?(model.name.to_s)
+
+          enabled_checkers.flat_map do |checker_class|
+            checker = checker_class.new(model)
+            checker.report_if_enabled?(configuration)
+          end
+        end.compact
+      end
+    end
+  end
+end

data/lib/database_consistency/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DatabaseConsistency
-  VERSION = '1.7.13'
+  VERSION = '1.7.15'
 end

data/lib/database_consistency/writers/simple/base.rb

@@ -33,7 +33,7 @@ module DatabaseConsistency
         end
 
         def msg
-          "#{report.checker_name} #{status_text} #{key_text} #{message_text}".strip
+          [report.checker_name, status_text, key_text, message_text].compact.join(' ').strip
         end
 
         def unique_key
@@ -57,11 +57,14 @@ module DatabaseConsistency
         end
 
         def key_text
-          "#{colorize(report.table_or_model_name, :blue)} #{colorize(report.column_or_attribute_name, :yellow)}"
+          [
+            colorize(report.table_or_model_name, :blue),
+            colorize(report.column_or_attribute_name, :yellow)
+          ].compact.join(' ')
         end
 
         def colorize(text, color)
-          return text unless config.colored? && color
+          return text unless text && config.colored? && color
 
           "#{COLORS[color]}#{text}\e[0m"
         end

data/lib/database_consistency/writers/simple/missing_table.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+module DatabaseConsistency
+  module Writers
+    module Simple
+      class MissingTable < Base # :nodoc:
+        private
+
+        def template
+          'should have a table in the database'
+        end
+
+        def unique_attributes
+          {
+            table_or_model_name: report.table_or_model_name
+          }
+        end
+      end
+    end
+  end
+end

data/lib/database_consistency/writers/simple_writer.rb

@@ -20,6 +20,7 @@ module DatabaseConsistency
         missing_association_class: Simple::MissingAssociationClass,
         missing_foreign_key: Simple::MissingForeignKey,
         missing_foreign_key_cascade: Simple::MissingForeignKeyCascade,
+        missing_table: Simple::MissingTable,
         missing_unique_index: Simple::MissingUniqueIndex,
         missing_uniqueness_validation: Simple::MissingUniquenessValidation,
         null_constraint_association_misses_validator: Simple::NullConstraintAssociationMissesValidator,

data/lib/database_consistency.rb

@@ -40,6 +40,7 @@ require 'database_consistency/writers/simple/enum_values_inconsistent_with_inclu
 require 'database_consistency/writers/simple/redundant_case_insensitive_option'
 require 'database_consistency/writers/simple/three_state_boolean'
 require 'database_consistency/writers/simple/missing_association_class'
+require 'database_consistency/writers/simple/missing_table'
 require 'database_consistency/writers/simple_writer'
 
 require 'database_consistency/writers/autofix/helpers/migration'
@@ -62,6 +63,9 @@ require 'database_consistency/checkers/base_checker'
 require 'database_consistency/checkers/enum_checkers/enum_checker'
 require 'database_consistency/checkers/enum_checkers/enum_type_checker'
 
+require 'database_consistency/checkers/model_checkers/model_checker'
+require 'database_consistency/checkers/model_checkers/missing_table_checker'
+
 require 'database_consistency/checkers/association_checkers/association_checker'
 require 'database_consistency/checkers/association_checkers/missing_index_checker'
 require 'database_consistency/checkers/association_checkers/foreign_key_checker'
@@ -95,6 +99,7 @@ require 'database_consistency/processors/validators_processor'
 require 'database_consistency/processors/columns_processor'
 require 'database_consistency/processors/validators_fractions_processor'
 require 'database_consistency/processors/indexes_processor'
+require 'database_consistency/processors/models_processor'
 
 # The root module
 module DatabaseConsistency

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: database_consistency
 version: !ruby/object:Gem::Version
-  version: 1.7.13
+  version: 1.7.15
 platform: ruby
 authors:
 - Evgeniy Demin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-07-09 00:00:00.000000000 Z
+date: 2023-07-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -165,6 +165,8 @@ files:
 - lib/database_consistency/checkers/index_checkers/redundant_index_checker.rb
 - lib/database_consistency/checkers/index_checkers/redundant_unique_index_checker.rb
 - lib/database_consistency/checkers/index_checkers/unique_index_checker.rb
+- lib/database_consistency/checkers/model_checkers/missing_table_checker.rb
+- lib/database_consistency/checkers/model_checkers/model_checker.rb
 - lib/database_consistency/checkers/validator_checkers/case_sensitive_unique_validation_checker.rb
 - lib/database_consistency/checkers/validator_checkers/missing_unique_index_checker.rb
 - lib/database_consistency/checkers/validator_checkers/validator_checker.rb
@@ -181,6 +183,7 @@ files:
 - lib/database_consistency/processors/columns_processor.rb
 - lib/database_consistency/processors/enums_processor.rb
 - lib/database_consistency/processors/indexes_processor.rb
+- lib/database_consistency/processors/models_processor.rb
 - lib/database_consistency/processors/validators_fractions_processor.rb
 - lib/database_consistency/processors/validators_processor.rb
 - lib/database_consistency/report.rb
@@ -221,6 +224,7 @@ files:
 - lib/database_consistency/writers/simple/missing_association_class.rb
 - lib/database_consistency/writers/simple/missing_foreign_key.rb
 - lib/database_consistency/writers/simple/missing_foreign_key_cascade.rb
+- lib/database_consistency/writers/simple/missing_table.rb
 - lib/database_consistency/writers/simple/missing_unique_index.rb
 - lib/database_consistency/writers/simple/missing_uniqueness_validation.rb
 - lib/database_consistency/writers/simple/null_constraint_association_misses_validator.rb
@@ -266,7 +270,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.33
+rubygems_version: 3.4.1
 signing_key: 
 specification_version: 4
 summary: Provide an easy way to check the consistency of the database constraints