database_consistency 1.7.11 → 1.7.13

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bf8618ba8f3e8311f6cfe28281eb840f72fb389267d23c7df8dacceb81466856
-  data.tar.gz: 14b60dbacd605899a0f1e5c95147b1f879d36ff70bcf761f867412697093d552
+  metadata.gz: 814c6b14aa1b2b510fc2451b0ccc53c22eddcb2954bfe4b870bfbd1788fee2b2
+  data.tar.gz: cf6bf9b77bd42a0b149609a36ecb9b0b91f6378353bcb58553dbffd1fccb9a07
 SHA512:
-  metadata.gz: 368509ce28357a3817a1f8c05233db99b9baa451b70e28fc484d2ea87e1745de08a65c0aff88dfc71d730b8fcd5932565b685b97d1a32b224faf9f494413055c
-  data.tar.gz: d8f1272dfabd6d7531efe1d37fd13924bedf734bf4def4274c24c8bc0d85e616a6b2c391e8594f32051e3a5cba15cb19d3aab2c6a8b682d48b1d928f21c95c00
+  metadata.gz: f4f002828a20fa7376346ed94bd63908a01f572aa2fa20ea452918f391baf2ad4ac7c0e72d98d784fab0003cfd4b3de36589ca29d01c9ae34951c55740fb2372
+  data.tar.gz: 68fabfbd7d75b68b8a404e57dc490d7c2e0ef30a70a76f84f08c28130a58975ad80c1ba2dd59cc1589cd7c3090a21e62ad1a6f29dd15ff013e36676be6faa42f

data/lib/database_consistency/checkers/association_checkers/foreign_key_checker.rb

@@ -22,6 +22,8 @@ module DatabaseConsistency
         supported? &&
           association.belongs_to? && !association.polymorphic? &&
           same_database?
+      rescue NameError
+        false
       end
 
       def same_database?

data/lib/database_consistency/checkers/association_checkers/missing_association_class_checker.rb

@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+module DatabaseConsistency
+  module Checkers
+    # This class checks if an association has existing class defined
+    class MissingAssociationClassChecker < AssociationChecker
+      Report = ReportBuilder.define(
+        DatabaseConsistency::Report,
+        :class_name
+      )
+
+      private
+
+      def preconditions
+        !association.polymorphic?
+      end
+
+      def check
+        association.klass
+        report_template(:ok)
+      rescue NameError
+        report_template(:fail, error_slug: :missing_association_class)
+      end
+
+      def report_template(status, error_slug: nil)
+        Report.new(
+          status: status,
+          error_message: nil,
+          error_slug: error_slug,
+          class_name: association.class_name,
+          **report_attributes
+        )
+      end
+    end
+  end
+end

data/lib/database_consistency/configuration.rb

@@ -9,7 +9,11 @@ module DatabaseConsistency
 
     def initialize(file_paths = DEFAULT_PATH)
       @configuration = existing_configurations(file_paths).then do |existing_paths|
-        puts "Loaded configurations: #{existing_paths.join(', ')}"
+        if existing_paths.any?
+          puts "Loaded configurations: #{existing_paths.join(', ')}"
+        else
+          puts 'No configurations were provided'
+        end
         extract_configurations(existing_paths)
       end
     end

data/lib/database_consistency/helper.rb

@@ -13,6 +13,10 @@ module DatabaseConsistency
       end
     end
 
+    def database_name(model)
+      model.connection_db_config.name.to_s if model.respond_to?(:connection_db_config)
+    end
+
     def postgresql?
       adapter == 'postgresql'
     end

data/lib/database_consistency/processors/associations_processor.rb

@@ -8,14 +8,16 @@ module DatabaseConsistency
         Checkers::MissingIndexChecker,
         Checkers::ForeignKeyChecker,
         Checkers::ForeignKeyTypeChecker,
-        Checkers::ForeignKeyCascadeChecker
+        Checkers::ForeignKeyCascadeChecker,
+        Checkers::MissingAssociationClassChecker
       ].freeze
 
       private
 
-      def check
+      def check # rubocop:disable Metrics/AbcSize
         Helper.models.flat_map do |model|
-          next unless configuration.enabled?(model.name.to_s)
+          next unless configuration.enabled?('DatabaseConsistencyDatabases', Helper.database_name(model)) &&
+                      configuration.enabled?(model.name.to_s)
 
           Helper.first_level_associations(model).flat_map do |association|
             enabled_checkers.flat_map do |checker_class|

data/lib/database_consistency/processors/columns_processor.rb

@@ -14,9 +14,10 @@ module DatabaseConsistency
 
       private
 
-      def check
+      def check # rubocop:disable Metrics/AbcSize
         Helper.parent_models.flat_map do |model|
-          next unless configuration.enabled?(model.name.to_s)
+          next unless configuration.enabled?('DatabaseConsistencyDatabases', Helper.database_name(model)) &&
+                      configuration.enabled?(model.name.to_s)
 
           model.columns.flat_map do |column|
             enabled_checkers.flat_map do |checker_class|

data/lib/database_consistency/processors/enums_processor.rb

@@ -10,9 +10,10 @@ module DatabaseConsistency
 
       private
 
-      def check
+      def check # rubocop:disable Metrics/AbcSize
         Helper.models.flat_map do |model|
-          next unless configuration.enabled?(model.name.to_s)
+          next unless configuration.enabled?('DatabaseConsistencyDatabases', Helper.database_name(model)) &&
+                      configuration.enabled?(model.name.to_s)
 
           model.defined_enums.keys.flat_map do |enum|
             enabled_checkers.flat_map do |checker_class|

data/lib/database_consistency/processors/indexes_processor.rb

@@ -14,7 +14,8 @@ module DatabaseConsistency
 
       def check # rubocop:disable Metrics/AbcSize
         Helper.parent_models.flat_map do |model|
-          next unless configuration.enabled?(model.name.to_s)
+          next unless configuration.enabled?('DatabaseConsistencyDatabases', Helper.database_name(model)) &&
+                      configuration.enabled?(model.name.to_s)
 
           indexes = model.connection.indexes(model.table_name)
 

data/lib/database_consistency/processors/validators_fractions_processor.rb

@@ -11,9 +11,10 @@ module DatabaseConsistency
       private
 
       # @return [Array<Hash>]
-      def check
+      def check # rubocop:disable Metrics/AbcSize
         Helper.parent_models.flat_map do |model|
-          next unless configuration.enabled?(model.name.to_s)
+          next unless configuration.enabled?('DatabaseConsistencyDatabases', Helper.database_name(model)) &&
+                      configuration.enabled?(model.name.to_s)
 
           model._validators.flat_map do |attribute, validators|
             next unless attribute

data/lib/database_consistency/processors/validators_processor.rb

@@ -12,9 +12,10 @@ module DatabaseConsistency
       private
 
       # @return [Array<Hash>]
-      def check # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
+      def check # rubocop:disable Metrics/AbcSize, Metrics/MethodLength, Metrics/CyclomaticComplexity
         Helper.parent_models.flat_map do |model|
-          next unless configuration.enabled?(model.name.to_s)
+          next unless configuration.enabled?('DatabaseConsistencyDatabases', Helper.database_name(model)) &&
+                      configuration.enabled?(model.name.to_s)
 
           model.validators.flat_map do |validator|
             next unless validator.respond_to?(:attributes)

data/lib/database_consistency/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DatabaseConsistency
-  VERSION = '1.7.11'
+  VERSION = '1.7.13'
 end

data/lib/database_consistency/writers/simple/missing_association_class.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+module DatabaseConsistency
+  module Writers
+    module Simple
+      class MissingAssociationClass < Base # :nodoc:
+        private
+
+        def template
+          'refers to undefined model "%<class_name>s"'
+        end
+
+        def unique_attributes
+          {
+            class_name: report.class_name
+          }
+        end
+
+        def attributes
+          {
+            class_name: report.class_name
+          }
+        end
+      end
+    end
+  end
+end

data/lib/database_consistency/writers/simple_writer.rb

@@ -6,29 +6,30 @@ module DatabaseConsistency
     # The simplest formatter
     class SimpleWriter < BaseWriter
       SLUG_TO_WRITER = {
+        association_foreign_type_missing_null_constraint: Simple::AssociationForeignTypeMissingNullConstraint,
         association_missing_index: Simple::AssociationMissingIndex,
         association_missing_null_constraint: Simple::AssociationMissingNullConstraint,
-        association_foreign_type_missing_null_constraint: Simple::AssociationForeignTypeMissingNullConstraint,
+        enum_values_inconsistent_with_ar_enum: Simple::EnumValuesInconsistentWithArEnum,
+        enum_values_inconsistent_with_inclusion: Simple::EnumValuesInconsistentWithInclusion,
         has_one_missing_unique_index: Simple::HasOneMissingUniqueIndex,
+        inconsistent_enum_type: Simple::InconsistentEnumType,
         inconsistent_types: Simple::InconsistentTypes,
         length_validator_greater_limit: Simple::LengthValidatorGreaterLimit,
         length_validator_lower_limit: Simple::LengthValidatorLowerLimit,
         length_validator_missing: Simple::LengthValidatorMissing,
+        missing_association_class: Simple::MissingAssociationClass,
         missing_foreign_key: Simple::MissingForeignKey,
+        missing_foreign_key_cascade: Simple::MissingForeignKeyCascade,
         missing_unique_index: Simple::MissingUniqueIndex,
         missing_uniqueness_validation: Simple::MissingUniquenessValidation,
         null_constraint_association_misses_validator: Simple::NullConstraintAssociationMissesValidator,
         null_constraint_misses_validator: Simple::NullConstraintMissesValidator,
         null_constraint_missing: Simple::NullConstraintMissing,
         possible_null: Simple::PossibleNull,
+        redundant_case_insensitive_option: Simple::RedundantCaseInsensitiveOption,
         redundant_index: Simple::RedundantIndex,
         redundant_unique_index: Simple::RedundantUniqueIndex,
         small_primary_key: Simple::SmallPrimaryKey,
-        inconsistent_enum_type: Simple::InconsistentEnumType,
-        missing_foreign_key_cascade: Simple::MissingForeignKeyCascade,
-        enum_values_inconsistent_with_ar_enum: Simple::EnumValuesInconsistentWithArEnum,
-        enum_values_inconsistent_with_inclusion: Simple::EnumValuesInconsistentWithInclusion,
-        redundant_case_insensitive_option: Simple::RedundantCaseInsensitiveOption,
         three_state_boolean: Simple::ThreeStateBoolean
       }.freeze
 

data/lib/database_consistency.rb

@@ -39,6 +39,7 @@ require 'database_consistency/writers/simple/enum_values_inconsistent_with_ar_en
 require 'database_consistency/writers/simple/enum_values_inconsistent_with_inclusion'
 require 'database_consistency/writers/simple/redundant_case_insensitive_option'
 require 'database_consistency/writers/simple/three_state_boolean'
+require 'database_consistency/writers/simple/missing_association_class'
 require 'database_consistency/writers/simple_writer'
 
 require 'database_consistency/writers/autofix/helpers/migration'
@@ -66,6 +67,7 @@ require 'database_consistency/checkers/association_checkers/missing_index_checke
 require 'database_consistency/checkers/association_checkers/foreign_key_checker'
 require 'database_consistency/checkers/association_checkers/foreign_key_type_checker'
 require 'database_consistency/checkers/association_checkers/foreign_key_cascade_checker'
+require 'database_consistency/checkers/association_checkers/missing_association_class_checker'
 
 require 'database_consistency/checkers/column_checkers/column_checker'
 require 'database_consistency/checkers/column_checkers/null_constraint_checker'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: database_consistency
 version: !ruby/object:Gem::Version
-  version: 1.7.11
+  version: 1.7.13
 platform: ruby
 authors:
 - Evgeniy Demin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-07-01 00:00:00.000000000 Z
+date: 2023-07-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -150,6 +150,7 @@ files:
 - lib/database_consistency/checkers/association_checkers/foreign_key_cascade_checker.rb
 - lib/database_consistency/checkers/association_checkers/foreign_key_checker.rb
 - lib/database_consistency/checkers/association_checkers/foreign_key_type_checker.rb
+- lib/database_consistency/checkers/association_checkers/missing_association_class_checker.rb
 - lib/database_consistency/checkers/association_checkers/missing_index_checker.rb
 - lib/database_consistency/checkers/base_checker.rb
 - lib/database_consistency/checkers/column_checkers/column_checker.rb
@@ -217,6 +218,7 @@ files:
 - lib/database_consistency/writers/simple/length_validator_greater_limit.rb
 - lib/database_consistency/writers/simple/length_validator_lower_limit.rb
 - lib/database_consistency/writers/simple/length_validator_missing.rb
+- lib/database_consistency/writers/simple/missing_association_class.rb
 - lib/database_consistency/writers/simple/missing_foreign_key.rb
 - lib/database_consistency/writers/simple/missing_foreign_key_cascade.rb
 - lib/database_consistency/writers/simple/missing_unique_index.rb
@@ -264,7 +266,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
+rubygems_version: 3.2.33
 signing_key: 
 specification_version: 4
 summary: Provide an easy way to check the consistency of the database constraints