database_consistency 1.6.0 → 1.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: de35bff4be332ceca4a982d5cde674db49db44a53d3fce22e177cc561cfe6253
-  data.tar.gz: 9f519c9b7aef026da3033790b47690c513871b725b5271e77afa55f29014480f
+  metadata.gz: 8049cc73c646f8be58c7f7b3491a0dc02f55f3c75eac32803b850f8c272d11fa
+  data.tar.gz: fdf3df62bb8df2995889a5c717e22fb437260ebfd77d0bd80bdb5d7b9f90494a
 SHA512:
-  metadata.gz: bdbd9750c5a9f8470a0c73fbae78a50193b423367b934f244fe0132e0dc9af29011cf55b8ef67a6dbe22f7fee3b4bbc012069dac2ae329ccad6f43452f83c80d
-  data.tar.gz: 133abb119e8a80c25b6c4fe0936273dd328adbd6df7bc290ea16f97e695b6468f99a0b9c10bea0420dbc1788de88c73948ea429981b30812002a7b103b2f9ddf
+  metadata.gz: e05dcd8d5f1dc062e482a7028f2e10c3232377f1fb7c44609ea41fffb9f14fb3a331db407a693fe5ffe1c0f69d0105e3c39b65166210a6ded5365a1e239ebb50
+  data.tar.gz: 4dba6ecf15c4f3b6ae3553c28873e23ef77b930a4275124f14b9dfae8b84cb8bfee53033fc4f84a573064c1ebd9b702bb32dddf0fa66c8838e373bb0a372f8ee

data/lib/database_consistency/checkers/column_checkers/enum_value_checker.rb

@@ -24,11 +24,7 @@ module DatabaseConsistency
       end
 
       def preconditions
-        postgresql? && column.type == :enum && (enum || inclusion_validator)
-      end
-
-      def postgresql?
-        Helper.adapter == 'postgresql'
+        Helper.postgresql? && column.type == :enum && (enum || inclusion_validator)
       end
 
       def check

data/lib/database_consistency/checkers/validator_checkers/case_sensitive_unique_validation_checker.rb

@@ -0,0 +1,34 @@
+# frozen_string_literal: true
+
+module DatabaseConsistency
+  module Checkers
+    # This class checks if uniqueness validator has unique index in the database
+    class CaseSensitiveUniqueValidationChecker < ValidatorChecker
+      private
+
+      def preconditions
+        validator.kind == :uniqueness && Helper.postgresql? && citext?
+      end
+
+      def check
+        if validator.options[:case_sensitive].nil? || validator.options[:case_sensitive]
+          report_template(:ok)
+        else
+          report_template(:fail, error_slug: :redundant_case_insensitive_option)
+        end
+      end
+
+      def citext?
+        field_name = Helper.foreign_key_or_attribute(model, attribute)
+
+        field = model.columns.find { |column| column.name.to_s == field_name.to_s }
+
+        field&.type == :citext
+      end
+
+      def sorted_uniqueness_validator_columns
+        @sorted_uniqueness_validator_columns ||= Helper.sorted_uniqueness_validator_columns(attribute, validator, model)
+      end
+    end
+  end
+end

data/lib/database_consistency/helper.rb

@@ -13,6 +13,10 @@ module DatabaseConsistency
       end
     end
 
+    def postgresql?
+      adapter == 'postgresql'
+    end
+
     def connection_config(klass)
       if klass.respond_to?(:connection_config)
         klass.connection_config

data/lib/database_consistency/processors/validators_processor.rb

@@ -5,7 +5,8 @@ module DatabaseConsistency
     # The class to process validators
     class ValidatorsProcessor < BaseProcessor
       CHECKERS = [
-        Checkers::MissingUniqueIndexChecker
+        Checkers::MissingUniqueIndexChecker,
+        Checkers::CaseSensitiveUniqueValidationChecker
       ].freeze
 
       private

data/lib/database_consistency/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DatabaseConsistency
-  VERSION = '1.6.0'
+  VERSION = '1.7.0'
 end

data/lib/database_consistency/writers/simple/redundant_case_insensitive_option.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+module DatabaseConsistency
+  module Writers
+    module Simple
+      class RedundantCaseInsensitiveOption < Base # :nodoc:
+        private
+
+        def template
+          "has case insensitive type and doesn't require case_sensitive: false option"
+        end
+
+        def unique_attributes
+          {
+            table_or_model_name: report.table_or_model_name,
+            column_or_attribute_name: report.column_or_attribute_name
+          }
+        end
+      end
+    end
+  end
+end

data/lib/database_consistency/writers/simple_writer.rb

@@ -27,7 +27,8 @@ module DatabaseConsistency
         inconsistent_enum_type: Simple::InconsistentEnumType,
         missing_foreign_key_cascade: Simple::MissingForeignKeyCascade,
         enum_values_inconsistent_with_ar_enum: Simple::EnumValuesInconsistentWithArEnum,
-        enum_values_inconsistent_with_inclusion: Simple::EnumValuesInconsistentWithInclusion
+        enum_values_inconsistent_with_inclusion: Simple::EnumValuesInconsistentWithInclusion,
+        redundant_case_insensitive_option: Simple::RedundantCaseInsensitiveOption
       }.freeze
 
       def write

data/lib/database_consistency.rb

@@ -37,6 +37,7 @@ require 'database_consistency/writers/simple/small_primary_key'
 require 'database_consistency/writers/simple/inconsistent_enum_type'
 require 'database_consistency/writers/simple/enum_values_inconsistent_with_ar_enum'
 require 'database_consistency/writers/simple/enum_values_inconsistent_with_inclusion'
+require 'database_consistency/writers/simple/redundant_case_insensitive_option'
 require 'database_consistency/writers/simple_writer'
 
 require 'database_consistency/writers/autofix/helpers/migration'
@@ -73,6 +74,7 @@ require 'database_consistency/checkers/column_checkers/enum_value_checker'
 
 require 'database_consistency/checkers/validator_checkers/validator_checker'
 require 'database_consistency/checkers/validator_checkers/missing_unique_index_checker'
+require 'database_consistency/checkers/validator_checkers/case_sensitive_unique_validation_checker'
 
 require 'database_consistency/checkers/validators_fraction_checkers/validators_fraction_checker'
 require 'database_consistency/checkers/validators_fraction_checkers/column_presence_checker'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: database_consistency
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 1.7.0
 platform: ruby
 authors:
 - Evgeniy Demin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-12-03 00:00:00.000000000 Z
+date: 2022-12-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -163,6 +163,7 @@ files:
 - lib/database_consistency/checkers/index_checkers/redundant_index_checker.rb
 - lib/database_consistency/checkers/index_checkers/redundant_unique_index_checker.rb
 - lib/database_consistency/checkers/index_checkers/unique_index_checker.rb
+- lib/database_consistency/checkers/validator_checkers/case_sensitive_unique_validation_checker.rb
 - lib/database_consistency/checkers/validator_checkers/missing_unique_index_checker.rb
 - lib/database_consistency/checkers/validator_checkers/validator_checker.rb
 - lib/database_consistency/checkers/validators_fraction_checkers/column_presence_checker.rb
@@ -223,6 +224,7 @@ files:
 - lib/database_consistency/writers/simple/null_constraint_misses_validator.rb
 - lib/database_consistency/writers/simple/null_constraint_missing.rb
 - lib/database_consistency/writers/simple/possible_null.rb
+- lib/database_consistency/writers/simple/redundant_case_insensitive_option.rb
 - lib/database_consistency/writers/simple/redundant_index.rb
 - lib/database_consistency/writers/simple/redundant_unique_index.rb
 - lib/database_consistency/writers/simple/small_primary_key.rb