database_consistency 1.1.4 → 1.1.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 33bfe05b79b4c641cfa784c2e60894004910bfcbf594d3045ce51b586eec5812
-  data.tar.gz: 20355a79ba3aa941f85764203474e8a16b5c91397ce008940f4ecb9a2e45d71a
+  metadata.gz: 32663c35384c7ebc62f0c15f382eb130392e0d58b57b32627f348a42f0f52d42
+  data.tar.gz: dc8ef9b74fe351b3186a9ea8a4d68cd7049626d06f00a5cc072825f6dbef03a0
 SHA512:
-  metadata.gz: 57e588223f73d55f10d00e47c7492de68849f3487a272293beb8eba3547bea679f4c2322a93fc2ac625177426252ba1d97650197515493a17218face6149b493
-  data.tar.gz: d21a4eab903327f8fd7ea775828c45c72674f6edf58b1f8fb0889cd986a79adaf514a160bb30497b9b46003b180888b97ddfe94c25b68a106ed4e15a97d8d25b
+  metadata.gz: '082d4d5c3a24d3af7d561c6f58fd7a0c3b4156aa59abe100620d4a8d559759ea306e90f10044dcfcf13457935ce81558141f12a9d0e9899b96b3b56332ac0831'
+  data.tar.gz: 82005f6670dd8a92c88002842be6e38874ce5b1373369168e64bef961ad7444ee1098392fc93a5638f05e90d8b34e2a99db2f855990044c0a178a329a35fb631

data/bin/database_consistency

@@ -1,27 +1,52 @@
 #!/usr/bin/env ruby
 
+require_relative '../lib/database_consistency/configuration'
+
+default_config = DatabaseConsistency::Configuration::DEFAULT_PATH
+
 if ARGV.include?('install')
-  require_relative '../lib/database_consistency/configuration'
-  config_filename = DatabaseConsistency::Configuration::CONFIGURATION_PATH
-  file_exists = File.exists?(config_filename)
+  require 'pathname'
+
+  file_exists = File.exists?(default_config)
   rules = Pathname.new(__FILE__).dirname.join('..', 'lib', 'database_consistency', 'templates', 'rails_defaults.yml').read
-  if file_exists && File.foreach(config_filename).grep(Regexp.new(rules.lines.first.chomp)).any?
-    puts "#{config_filename} is already present"
+  if file_exists && File.foreach(default_config).grep(Regexp.new(rules.lines.first.chomp)).any?
+    puts "#{default_config} is already present"
   else
-    File.open(config_filename, 'a') do |file|
+    File.open(default_config, 'a') do |file|
       file << "\n" * 2 if file_exists
       file << rules
     end
-    puts "#{config_filename} #{file_exists ? 'updated' : 'added'}"
+    puts "#{default_config} #{file_exists ? 'updated' : 'added'}"
   end
   exit 0
-else
-  base_dir = File.join(Dir.pwd, ARGV.first.to_s)
-  unless File.realpath(base_dir).start_with?(Dir.pwd)
-    puts "\nWarning! You are going out of current directory, ruby version may be wrong and some gems may be missing.\n"
+end
+
+require 'optparse'
+
+config = [default_config]
+opt_parser = OptionParser.new do |opts|
+  opts.banner = <<-DESC
+  Usage: database_consistency install - run installation
+         database_consistency [options]
+  DESC
+
+  opts.on('-cFILE', '--config=FILE', 'Use additional configuration file') do |f|
+    config << f
+  end
+
+  opts.on('-h', '--help', 'Prints this help') do
+    puts opts
+    exit
   end
 end
 
+opt_parser.parse!
+
+base_dir = File.join(Dir.pwd, ARGV.first.to_s)
+unless File.realpath(base_dir).start_with?(Dir.pwd)
+  puts "\nWarning! You are going out of current directory, ruby version may be wrong and some gems may be missing.\n"
+end
+
 # Load Rails project
 begin
   require File.join(base_dir, 'config', 'boot')
@@ -41,5 +66,5 @@ $LOAD_PATH.unshift(File.expand_path('lib', __dir__))
 require 'database_consistency'
 
 # Process checks
-code = DatabaseConsistency.run
+code = DatabaseConsistency.run(config)
 exit code

data/lib/database_consistency/checkers/association_checkers/foreign_key_checker.rb

@@ -16,7 +16,7 @@ module DatabaseConsistency
       end
 
       def supported?
-        return false if ActiveRecord::VERSION::MAJOR < 5 && ActiveRecord::Base.connection_config[:adapter] == 'sqlite3'
+        return false if ActiveRecord::VERSION::MAJOR < 5 && Helper.adapter == 'sqlite3'
 
         true
       end

data/lib/database_consistency/checkers/association_checkers/foreign_key_type_checker.rb

@@ -2,18 +2,9 @@
 
 module DatabaseConsistency
   module Checkers
-    # This class checks if association's foreign key type is the same as associated model's primary key
+    # This class checks if association's foreign key type covers associated model's primary key (same or bigger)
     class ForeignKeyTypeChecker < AssociationChecker
-      INCONSISTENT_TYPE = 'associated model key (%a_f) with type (%a_t) mismatches key (%b_f) with type (%b_t)'
-
-      TYPES = {
-        'serial' => 'integer',
-        'integer' => 'integer',
-        'int' => 'integer',
-        'bigserial' => 'bigint',
-        'bigint' => 'bigint',
-        'bigint unsigned' => 'bigint unsigned'
-      }.freeze
+      INCONSISTENT_TYPE = "foreign key (%a_f) with type (%a_t) doesn't cover primary key (%b_f) with type (%b_t)"
 
       private
 
@@ -32,16 +23,18 @@ module DatabaseConsistency
       end
 
       # Table of possible statuses
-      # | type         | status |
-      # | ------------ | ------ |
-      # | consistent   | ok     |
-      # | inconsistent | fail   |
+      # | type          | status |
+      # | ------------- | ------ |
+      # | covers        | ok     |
+      # | doesn't cover | fail   |
       def check
-        if converted_type(base_column) == converted_type(associated_column)
+        if converted_type(associated_column).cover?(converted_type(primary_column))
           report_template(:ok)
         else
           report_template(:fail, render_text)
         end
+      rescue Errors::MissingField => e
+        report_template(:fail, e.message)
       end
 
       # @return [String]
@@ -49,40 +42,40 @@ module DatabaseConsistency
         INCONSISTENT_TYPE
           .gsub('%a_t', type(associated_column))
           .gsub('%a_f', associated_key)
-          .gsub('%b_t', type(base_column))
-          .gsub('%b_f', base_key)
+          .gsub('%b_t', type(primary_column))
+          .gsub('%b_f', primary_key)
       end
 
       # @return [String]
-      def base_key
-        @base_key ||= (
-          if belongs_to_association?
-            association.foreign_key
-          else
-            association.active_record_primary_key
-          end
-        ).to_s
+      def primary_key
+        @primary_key ||= if belongs_to_association?
+                           association.association_primary_key
+                         else
+                           association.active_record_primary_key
+                         end.to_s
       end
 
       # @return [String]
       def associated_key
-        @associated_key ||= (
-          if belongs_to_association?
-            association.association_primary_key
-          else
-            association.foreign_key
-          end
-        ).to_s
+        @associated_key ||= association.foreign_key.to_s
       end
 
       # @return [ActiveRecord::ConnectionAdapters::Column]
-      def base_column
-        @base_column ||= column(association.active_record, base_key)
+      def primary_column
+        @primary_column ||= if belongs_to_association?
+                              column(association.klass, primary_key)
+                            else
+                              column(association.active_record, primary_key)
+                            end
       end
 
       # @return [ActiveRecord::ConnectionAdapters::Column]
       def associated_column
-        @associated_column ||= column(association.klass, associated_key)
+        @associated_column ||= if belongs_to_association?
+                                 column(association.active_record, associated_key)
+                               else
+                                 column(association.klass, associated_key)
+                               end
       end
 
       # @return [DatabaseConsistency::Databases::Factory]
@@ -101,8 +94,8 @@ module DatabaseConsistency
 
       # @return [String]
       def missing_field_error(table_name, column_name)
-        "Association (#{association.name}) of class (#{association.active_record}) relies on "\
-          "field (#{column_name}) of table (#{table_name}) but it is missing."
+        "association (#{association.name}) of class (#{association.active_record}) relies on "\
+          "field (#{column_name}) of table (#{table_name}) but it is missing"
       end
 
       # @param [ActiveRecord::ConnectionAdapters::Column] column
@@ -114,9 +107,9 @@ module DatabaseConsistency
 
       # @param [ActiveRecord::ConnectionAdapters::Column]
       #
-      # @return [String]
+      # @return [DatabaseConsistency::Databases::Types::Base]
       def converted_type(column)
-        database_factory.type(type(column)).convert
+        database_factory.type(type(column))
       end
 
       # @return [Boolean]

data/lib/database_consistency/checkers/column_checkers/null_constraint_checker.rb

@@ -6,6 +6,8 @@ module DatabaseConsistency
     class NullConstraintChecker < ColumnChecker
       # Message templates
       VALIDATOR_MISSING = 'column is required in the database but do not have presence validator'
+      ASSOCIATION_VALIDATOR_MISSING = 'column is required in the database but do '\
+                                      'not have presence validator for association (%a_n)'
 
       private
 
@@ -26,21 +28,23 @@ module DatabaseConsistency
       # | missing    | fail   |
       #
       # We consider PresenceValidation, InclusionValidation, ExclusionValidation, NumericalityValidator with nil,
-      # or BelongsTo association using this column
+      # or required BelongsTo association using this column
       def check
         if valid?
           report_template(:ok)
+        elsif belongs_to_association
+          report_template(:fail, ASSOCIATION_VALIDATOR_MISSING.gsub('%a_n', belongs_to_association.name.to_s))
         else
           report_template(:fail, VALIDATOR_MISSING)
         end
       end
 
       def valid?
-        validator?(ActiveModel::Validations::PresenceValidator) ||
-          validator?(ActiveModel::Validations::InclusionValidator) ||
+        validator?(:presence, column.name) ||
+          validator?(:inclusion, column.name) ||
           numericality_validator_without_allow_nil? ||
           nil_exclusion_validator? ||
-          belongs_to_association?
+          (belongs_to_association && validator?(:presence, belongs_to_association.name))
       end
 
       def primary_field?
@@ -52,28 +56,30 @@ module DatabaseConsistency
       end
 
       def nil_exclusion_validator?
-        model.validators.grep(ActiveModel::Validations::ExclusionValidator).any? do |validator|
-          Helper.check_inclusion?(validator.attributes, column.name) &&
+        model.validators.any? do |validator|
+          validator.kind == :exclusion &&
+            Helper.check_inclusion?(validator.attributes, column.name) &&
             validator.options[:in].include?(nil)
         end
       end
 
       def numericality_validator_without_allow_nil?
-        model.validators.grep(ActiveModel::Validations::NumericalityValidator).any? do |validator|
-          Helper.check_inclusion?(validator.attributes, column.name) &&
+        model.validators.any? do |validator|
+          validator.kind == :numericality &&
+            Helper.check_inclusion?(validator.attributes, column.name) &&
             !validator.options[:allow_nil]
         end
       end
 
-      def validator?(validator_class)
-        model.validators.grep(validator_class).any? do |validator|
-          Helper.check_inclusion?(validator.attributes, column.name)
+      def validator?(kind, attribute)
+        model.validators.any? do |validator|
+          validator.kind == kind && Helper.check_inclusion?(validator.attributes, attribute)
         end
       end
 
-      def belongs_to_association?
-        model.reflect_on_all_associations.grep(ActiveRecord::Reflection::BelongsToReflection).any? do |r|
-          Helper.check_inclusion?([r.foreign_key, r.foreign_type], column.name)
+      def belongs_to_association
+        @belongs_to_association ||= model.reflect_on_all_associations.find do |r|
+          r.belongs_to? && Helper.check_inclusion?([r.foreign_key, r.foreign_type], column.name)
         end
       end
     end

data/lib/database_consistency/checkers/validators_fraction_checkers/column_presence_checker.rb

@@ -29,8 +29,18 @@ module DatabaseConsistency
       # | all missing                     | required | ok     |
       # | all missing                     | optional | fail   |
       def check
+        report_message
+      rescue Errors::MissingField => e
+        report_template(:fail, e.message)
+      end
+
+      def weak_option?
+        validators.all? { |validator| validator.options.slice(*WEAK_OPTIONS).any? }
+      end
+
+      def report_message
         can_be_null = column.null
-        has_weak_option = validators.all? { |validator| validator.options.slice(*WEAK_OPTIONS).any? }
+        has_weak_option = weak_option?
 
         return report_template(:ok) if can_be_null == has_weak_option
         return report_template(:fail, POSSIBLE_NULL) unless can_be_null
@@ -43,8 +53,9 @@ module DatabaseConsistency
       end
 
       def column
-        @column ||= regular_column || association_reference_column ||
-                    (raise Errors::MissingField, "Missing column in #{model.table_name} for #{attribute}")
+        @column ||= regular_column ||
+                    association_reference_column ||
+                    (raise Errors::MissingField, "column (#{attribute}) is missing in table (#{model.table_name}) but used for presence validation") # rubocop:disable Layout/LineLength
       end
 
       def regular_column

data/lib/database_consistency/configuration.rb

@@ -5,15 +5,20 @@ require 'yaml'
 module DatabaseConsistency
   # The class to access configuration options
   class Configuration
-    CONFIGURATION_PATH = '.database_consistency.yml'
-
-    def initialize(filepath = CONFIGURATION_PATH)
-      @configuration = if filepath && File.exist?(filepath)
-                         data = YAML.load_file(filepath)
-                         data.is_a?(Hash) ? data : {}
-                       else
-                         {}
-                       end
+    DEFAULT_PATH = '.database_consistency.yml'
+
+    def initialize(filepaths = DEFAULT_PATH)
+      @configuration = Array(filepaths).each_with_object({}) do |filepath, result|
+        content =
+          if filepath && File.exist?(filepath)
+            data = YAML.load_file(filepath)
+            data.is_a?(Hash) ? data : {}
+          else
+            {}
+          end
+
+        combine_configs!(result, content)
+      end
     end
 
     def debug?
@@ -48,6 +53,16 @@ module DatabaseConsistency
 
     attr_reader :configuration
 
+    def combine_configs!(config, new_config)
+      config.merge!(new_config) do |_key, val, new_val|
+        if val.is_a?(Hash) && new_val.is_a?(Hash)
+          combine_configs!(val, new_val)
+        else
+          new_val
+        end
+      end
+    end
+
     def settings
       @settings ||= configuration['DatabaseConsistencySettings']
     end

data/lib/database_consistency/databases/types/base.rb

@@ -7,6 +7,11 @@ module DatabaseConsistency
       class Base
         attr_reader :type
 
+        COVERED_TYPES = {
+          'bigint' => %w[integer bigint],
+          'integer' => %w[integer smallint]
+        }.freeze
+
         # @param [String] type
         def initialize(type)
           @type = type
@@ -16,6 +21,13 @@ module DatabaseConsistency
         def convert
           type
         end
+
+        # @param [DatabaseConsistency::Databases::Types::Base]
+        #
+        # @return [Boolean]
+        def cover?(other_type)
+          (COVERED_TYPES[convert] || [convert]).include?(other_type.convert)
+        end
       end
     end
   end

data/lib/database_consistency/databases/types/sqlite.rb

@@ -7,9 +7,10 @@ module DatabaseConsistency
       class Sqlite < Base
         TYPES = {
           'bigserial' => 'bigint',
-          'bigint' => 'bigint',
           'serial' => 'integer',
-          'integer' => 'integer'
+          'integer(8)' => 'bigint',
+          'integer(4)' => 'integer',
+          'integer(2)' => 'smallint'
         }.freeze
 
         # @return [String]

data/lib/database_consistency/helper.rb

@@ -5,6 +5,14 @@ module DatabaseConsistency
   module Helper
     module_function
 
+    def adapter
+      if ActiveRecord::Base.respond_to?(:connection_config)
+        ActiveRecord::Base.connection_config[:adapter]
+      else
+        ActiveRecord::Base.connection_db_config.configuration_hash[:adapter]
+      end
+    end
+
     # Returns list of models to check
     def models
       ActiveRecord::Base.descendants.delete_if(&:abstract_class?).delete_if do |klass|

data/lib/database_consistency/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DatabaseConsistency
-  VERSION = '1.1.4'
+  VERSION = '1.1.9'
 end

data/lib/database_consistency.rb

@@ -48,8 +48,8 @@ require 'database_consistency/processors/indexes_processor'
 # The root module
 module DatabaseConsistency
   class << self
-    def run
-      configuration = Configuration.new
+    def run(*args)
+      configuration = Configuration.new(*args)
       reports = Processors.reports(configuration)
 
       Writers::SimpleWriter.write(

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: database_consistency
 version: !ruby/object:Gem::Version
-  version: 1.1.4
+  version: 1.1.9
 platform: ruby
 authors:
 - Evgeniy Demin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-10-26 00:00:00.000000000 Z
+date: 2021-12-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -56,14 +56,14 @@ dependencies:
   name: pg
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.2'
 - !ruby/object:Gem::Dependency
@@ -94,6 +94,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: rspec_junit_formatter
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.4'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.4'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
@@ -185,7 +199,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.8
+rubygems_version: 3.2.22
 signing_key: 
 specification_version: 4
 summary: Provide an easy way to check the consistency of the database constraints